Hello Ben,
sorry I was away for some time and could not follow up -
Testing the 2.5 branch I'm still getting one fail:
## ------------- ##
## Test results. ##
## ------------- ##
ERROR: 1735 tests were run,
1 failed unexpectedly.
1 test was skipped.
## -------------------------- ##
## testsuite.log was created. ##
## -------------------------- ##
Please send `tests/testsuite.log' and all information you think might help:
To: <b...@openvswitch.org>
Subject: [openvswitch 2.5.1] testsuite: 954 failed
From the testsuite.log file I gather that this might be a missing
testcase fix.
+++ /root/DH/ovs-branch-2.5/tests/testsuite.dir/at-groups/954/stdout
2016-06-29 15:50:50.106250194 +0200
@@ -1,3 +1,3 @@
recirc_id(0),in_port(1),eth_type(0x1234), packets:8, bytes:480,
used:0.0s, actions:100
-recirc_id(0),in_port(1),eth_type(0x8100),vlan(vid=99/0x0,pcp=7/0x0),encap(eth_type(0x1234)),
packets:2, bytes:120, used:0.0s, actions:drop
+recirc_id(0),in_port(1),eth_type(0x8100),vlan(vid=99/0x1,pcp=7/0x0),encap(eth_type(0x1234)),
packets:2, bytes:120, used:0.0s, actions:drop
Do you want me to send you the entire log ?
Cheers,
Dirk
On 05/30/2016 01:21 PM, Gerhard Stenzel wrote:
On 05/27/2016 02:18 AM, Ben Pfaff wrote:
On Tue, May 24, 2016 at 12:24:31PM +0200, Gerhard Stenzel wrote:
On 05/02/2016 10:36 PM, Ben Pfaff wrote:
What if we just make ofp_port_t 32 bits? That has to be the long-term
trend anyway because OpenFlow 1.1+ uses a 32-bit port number. The
following passes all the unit tests on i386 (though I haven't
carefully
looked at all the uses of ofp_port_t), what about big-endian systems?
diff --git a/include/openvswitch/flow.h b/include/openvswitch/flow.h
...
Hi Ben, which patch do you plan to take? For master, your patch
might be
better, but for 2.5 Dirk's proposal seems less invasive.
I posted a series of fixes:
http://openvswitch.org/pipermail/dev/2016-May/071791.html
I applied all five patch to master and "make check":
(the skipped ones are Python3 tests)
...
## ------------- ##
## Test results. ##
## ------------- ##
1765 tests were successful.
286 tests were skipped.
Thank you.
_______________________________________________
discuss mailing list
discuss@openvswitch.org
http://openvswitch.org/mailman/listinfo/discuss
