Hi all,
Is there any comment on this patch? Thanks.
Regards,
Yi
-Original Message-
From: devel@edk2.groups.io On Behalf Of yi1 li
Sent: Wednesday, September 7, 2022 4:29 PM
To: devel@edk2.groups.io
Cc: Li, Yi1 ; Yao, Jiewen ; Wang, Jian
J ; Xiaoyu Lu ; Jiang, Guomin
Subject: [edk2
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3828
Review PR: https://github.com/tianocore/edk2/pull/3309
This patch sequence is used to add CryptBn library, which are wrapped
over OpenSSL. The implementation provides library functions for EFI
BaseCrypt protocol and EFI BaseCrypt Configurati
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3828
This patch is used to add CryptBn library, which is wrapped
over OpenSSL.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Xiaoyu Lu
Cc: Guomin Jiang
Signed-off-by: Yi Li
---
CryptoPkg/Include/Library/BaseCryptLib.h | 418 +
.../Li
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3828
The implementation provides CryptBn library functions
for EFI Driver and EFI BaseCrypt Protocol.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Xiaoyu Lu
Cc: Guomin Jiang
Signed-off-by: Yi Li
---
CryptoPkg/CryptoPkg.dsc |
Add unit test for CryptoBn.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Xiaoyu Lu
Cc: Guomin Jiang
Signed-off-by: Yi Li
---
.../BaseCryptLib/UnitTestHostBaseCryptLib.inf | 1 +
.../BaseCryptLib/BaseCryptLibUnitTests.c | 1 +
.../UnitTest/Library/BaseCryptLib/BnTests.c | 266 +++
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3828
This patch is used to add CryptEc library, which is wrapped
over OpenSSL.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Xiaoyu Lu
Cc: Guomin Jiang
Signed-off-by: Yi Li
---
CryptoPkg/Include/Library/BaseCryptLib.h | 424 ++
.../Libr
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3828
The implementation provides CryptEc library functions
for EFI Driveer and EFI BaseCrypt Protocol.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Xiaoyu Lu
Cc: Guomin Jiang
Signed-off-by: Yi Li
---
CryptoPkg/CryptoPkg.dsc |
Add unit test for CryptoEc.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Xiaoyu Lu
Cc: Guomin Jiang
Signed-off-by: Yi Li
---
.../BaseCryptLib/UnitTestHostBaseCryptLib.inf | 2 +
CryptoPkg/Test/CryptoPkgHostUnitTest.dsc | 3 +
.../BaseCryptLib/BaseCryptLibUnitTests.c | 1 +
.../UnitTest
Hi Jiewen,
Thanks for review, changes done.
Since both BN and EC extend many structures, splitting them will cause git
conflicts,
I've adjusted the order of patches: Ec commits are based on Bn commits. Just
convenient for merge.
Thanks,
Yi
-Original Message-
From: Yao, Jiewen
Sent: Wed
Resend patch sets because of typos in comment message.
-Original Message-
From: Li, Yi1
Sent: Wednesday, September 21, 2022 1:27 PM
To: devel@edk2.groups.io
Cc: Li, Yi1 ; Yao, Jiewen ; Wang, Jian
J ; Lu, Xiaoyu1 ; Jiang, Guomin
Subject: [PATCH V3 0/3] CryptoPkg: Add EC support
REF: h
2.groups.io; Li, Yi1 ; Kinney, Michael D
Cc: Yao, Jiewen ; Wang, Jian J ;
Lu, Xiaoyu1 ; Jiang, Guomin
Subject: RE: [edk2-devel] [PATCH V2 1/3] CryptoPkg: Add EC support
Comments embedded below.
Mike
> -Original Message-----
> From: devel@edk2.groups.io On Behalf Of yi1 li
> Sent: Tue
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4075
Fake BIO_snprintf() need to return error status -1. 0 will be
considered a correct return value, this may cause crash, please
refer to bugzilla link for details.
Signed-off-by: Yi Li
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Xiaoyu Lu
Cc: Guo
o: devel@edk2.groups.io; Li, Yi1 ; Kinney, Michael D
>
> Cc: Yao, Jiewen ; Wang, Jian J ;
> Lu, Xiaoyu1 ; Jiang,
> Guomin
> Subject: RE: [edk2-devel] [PATCH V2 1/3] CryptoPkg: Add EC support
>
> Comments embedded below.
>
> Mike
>
> > -Original Message-
; welcome.
> >
> > Thanks,
> > Yi
> >
> > -Original Message-
> > From: Kinney, Michael D
> > Sent: Thursday, September 22, 2022 12:22 AM
> > To: devel@edk2.groups.io; Li, Yi1 ; Kinney, Michael D
> >
> > Cc: Yao, Jiewen ; Wang, Jian J
ot cause is that we have enabled conditional ec in
> > > OpensslLib.inf before by PcdOpensslEcEnabled,
> > >
> >
> https://github.com/tianocore/edk2/blob/2c17d676e402d75a3a674499342f7ddaccf387bd/CryptoPkg/Library/OpensslLib/OpensslLib.inf#L2
> > > 02-L238
> > >
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3828
Review PR: https://github.com/tianocore/edk2/pull/3398
This patch sequence is used to add CryptEc library, which are wrapped
over OpenSSL. The implementation provides library functions for EFI
BaseCrypt protocol and EFI BaseCrypt Configurati
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3828
This patch is used to add CryptEc library, which is wrapped
over OpenSSL.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Xiaoyu Lu
Cc: Guomin Jiang
Signed-off-by: Yi Li
---
CryptoPkg/Include/Library/BaseCryptLib.h | 424 ++
.../Libr
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3828
The implementation provides CryptEc library functions
for EFI Driveer and EFI BaseCrypt Protocol.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Xiaoyu Lu
Cc: Guomin Jiang
Signed-off-by: Yi Li
---
CryptoPkg/CryptoPkg.dsc |
Describes the use cases under which ECC needs to be enabled,
and provides the impact on memory size for developers' reference.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Xiaoyu Lu
Cc: Guomin Jiang
Cc: Michael D Kinney
Signed-off-by: Yi Li
---
CryptoPkg/CryptoPkg.dec | 28 ++
Add unit test for CryptoEc.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Xiaoyu Lu
Cc: Guomin Jiang
Signed-off-by: Yi Li
---
.../BaseCryptLib/UnitTestHostBaseCryptLib.inf | 2 +
CryptoPkg/Test/CryptoPkgHostUnitTest.dsc | 3 +
.../BaseCryptLib/BaseCryptLibUnitTests.c | 1 +
.../UnitTest
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3828
Review PR: https://github.com/tianocore/edk2/pull/3398
This patch sequence is used to add CryptEc library, which are wrapped
over OpenSSL. The implementation provides library functions for EFI
BaseCrypt protocol and EFI BaseCrypt Configurati
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3828
The implementation provides CryptEc library functions
for EFI Driveer and EFI BaseCrypt Protocol.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Xiaoyu Lu
Cc: Guomin Jiang
Signed-off-by: Yi Li
---
CryptoPkg/CryptoPkg.dsc |
Describes the use cases under which ECC needs to be enabled,
and provides the impact on memory size for developers' reference.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Xiaoyu Lu
Cc: Guomin Jiang
Cc: Michael D Kinney
Signed-off-by: Yi Li
---
CryptoPkg/CryptoPkg.dec | 29 ++
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3828
This patch is used to add CryptEc library, which is wrapped
over OpenSSL.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Xiaoyu Lu
Cc: Guomin Jiang
Signed-off-by: Yi Li
---
CryptoPkg/Include/Library/BaseCryptLib.h | 424 ++
.../Libr
Add unit test for CryptoEc.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Xiaoyu Lu
Cc: Guomin Jiang
Signed-off-by: Yi Li
---
.../BaseCryptLib/UnitTestHostBaseCryptLib.inf | 2 +
CryptoPkg/Test/CryptoPkgHostUnitTest.dsc | 3 +
.../BaseCryptLib/BaseCryptLibUnitTests.c | 1 +
.../UnitTest
Hi Jiewen,
Can you take a look at this patch?
WPA3 Tls API fuzzing is blocked because of same pem API.
Thanks,
Yi
-Original Message-
From: devel@edk2.groups.io On Behalf Of yi1 li
Sent: Thursday, September 22, 2022 8:53 PM
To: devel@edk2.groups.io
Cc: Li, Yi1 ; Yao, Jiewen ; Wang, Jian
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4075
Fake BIO_snprintf() does not actually print anything to buf,
it should return -1 as error.
0 will be considered a correct return value, the consumer may think that
the buf is valid and parse the buffer.
please refer to bugzilla link for deta
This patch series is used to add CryptBn library, which is wrapped
over OpenSSL. The implementation provides CryptBn library functions
for EFI BaseCrypt protocol and EFI BaseCrypt Configuration Protocol.
yi1 li (2):
CryptoPkg: Add BigNum support
CryptoPkg: Add BigNum NullLib
CryptoPkg
This patch is used to add CryptBn library, which is wrapped
over OpenSSL. The implementation provides CryptBn library functions
for EFI BaseCrypt protocol and EFI BaseCrypt Configuration Protocol.
Signed-off-by: yi1 li
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Xiaoyu Lu
Cc: Guomin Jiang
This patch is used to add CryptBnNull library, which is used to
optimize code size.
Signed-off-by: yi1 li
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Xiaoyu Lu
Cc: Guomin Jiang
---
.../Library/BaseCryptLib/Bn/CryptBnNull.c | 525 ++
.../Library/BaseCryptLib/PeiCryptLib.inf
y, which is used to
> optimize code size.
>
> Signed-off-by: yi1 li
>
> Cc: Jiewen Yao
> Cc: Jian J Wang
> Cc: Xiaoyu Lu
> Cc: Guomin Jiang
> ---
> .../Library/BaseCryptLib/Bn/CryptBnNull.c | 525 ++
> .../Library/BaseCryptLib/PeiC
午6:10，Li, Yi1 写道：
>>
>> This patch is used to add CryptBnNull library, which is used to
>> optimize code size.
>>
>> Signed-off-by: yi1 li
>>
>> Cc: Jiewen Yao
>> Cc: Jian J Wang
>> Cc: Xiaoyu Lu
>> Cc: Guomin Jiang
>
Hi Vineel,
Are you still working on this issue? I'm glad to see that edk2 will enable EC
and other crypto features and would like some advice.
I found from the previous discussion that there are only some issues with Ovmf
binary size left,
Have you tried enlarging the size of DXEFV in OvmfPkgIa
for providing the inputs here. Really appreciated.
I will try to resume the work(had to put it aside due to other priorities).
Please expect the patch by EOW.
Thanks,
Vineel
From: devel@edk2.groups.io On Behalf Of yi1 li via
groups.io
Sent: Tuesday, February 22, 2022 6:33 PM
To: Vineel Kovvuri
Hi Vineel,
Code is good to me, just some BKM for edk2 upstream:
1. It's a little strange that there are submodule changes in the patch 0004,
maybe you forget to run git submodule update:
diff --git a/BaseTools/Source/C/BrotliCompress/brotli
b/BaseTools/Source/C/BrotliCompress/brotli
index
Well done! And Edk2 has code style tools internal, use this cmd to fix it:
pip install -r pip-requirements.txt
git ls-files CryptoPkg*.c CryptoPkg*.h |
.\.pytool\Plugin\UncrustifyCheck\mu-uncrustify-release_extdep\Windows-x86\uncrustify.exe
-c .\.pytool\Plugin\UncrustifyCheck\uncrustify.cfg -F
Hi Vineel,
I noticed that there are some CI errors still in PR,
1. The VsIntrinscicLib is only used in OpenSSL related lib, putting it only
in the CryptoPkg would make more sense and simplify the review process.
1. A BKM: NULL LibraryClass means that its internal API will not be called
Thanks for your information,
1.See also https://edk2.groups.io/g/devel/message/87130 & followups.
git branch here: https://github.com/kraxel/edk2/commits/intrinsics
It's good to me, make code more clear.
2. Jiewen (Cc'ed) suggested to look into using CryptoPkg/Driver instead of
linking openssl
Agree with that and I think the first issue is OPENSSL_NO_* be not cover every
file related to some feature in openssl (like ec).
Once those macro defines can cover everything, we can put all files in
OpensslLib.inf [Source],
and control macro defines in opensslconf.h by PCDs to do customization.
is valid. If the expression evaluates
to FALSE, then the EDK II build tools must ignore the entry.
This patch is going to add this feature.
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: yi1 li
Signed-off-by: Zhiju.Fan
yi1 li (2):
BaseTools:Add the FeatureFlagExpression usage to the InfBuildData
. If the expression evaluates to FALSE,
then the EDK II build tools must ignore the entry.
This patch is going to add this feature.
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: yi1 li
Signed-off-by: Zhiju.Fan
---
BaseTools/Source/Python/Common/Expression.py | 2 +-
BaseTools/Source/Python
to FALSE,
then the EDK II build tools must ignore the entry.
This patch is going to add this feature.
Cc: Bob Feng
Cc: Liming Gao
Cc: Heng Luo
Signed-off-by: yi1 li
---
.../Source/Python/Workspace/InfBuildData.py | 16 +++-
.../Source/Python/Workspace/MetaFileParser.py
is valid. If the expression evaluates
to FALSE, then the EDK II build tools must ignore the entry.
This patch is going to add this feature.
Cc: Bob Feng
Cc: Liming Gao
Cc: Heng Luo
Signed-off-by: yi1 li
Signed-off-by: Zhiju.Fan
yi1 li (2):
BaseTools:Add the FeatureFlagExpression usage to
to FALSE,
then the EDK II build tools must ignore the entry.
This patch is going to add this feature.
Cc: Bob Feng
Cc: Liming Gao
Cc: Heng Luo
Signed-off-by: yi1 li
---
BaseTools/Source/Python/Workspace/InfBuildData.py | 14 ++
.../Source/Python/Workspace/MetaFileParser.py
. If the expression evaluates to FALSE,
then the EDK II build tools must ignore the entry.
This patch is going to add this feature.
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: yi1 li
Signed-off-by: Zhiju.Fan
---
BaseTools/Source/Python/Common/Expression.py | 2 +-
BaseTools/Source/Python
TRUE,then the entry is valid. If the expression evaluates to FALSE, then the
EDK II build tools must ignore the entry.
This patch is going to add this feature.
Cc: Bob Feng
Cc: Liming Gao
Cc: Heng Luo
Signed-off-by: yi1 li
---
BaseTools/Source/Python/Workspace/InfBuildData.py | 14
is valid. If the expression evaluates
to FALSE, then the EDK II build tools must ignore the entry.
This patch is going to add this feature.
Signed-off-by: yi1 li
yi1 li (2):
BaseTools:Add the FeatureFlagExpression usage to the InfBuildData
BaseTools:Add the FeatureFlagExpression usage to the
to FALSE,
then the EDK II build tools must ignore the entry.
This patch is going to add this feature.
Signed-off-by: yi1 li
---
BaseTools/Source/Python/Workspace/InfBuildData.py | 14 ++
.../Source/Python/Workspace/MetaFileParser.py | 4
2 files changed, 14 insertions
. If the expression evaluates to FALSE,
then the EDK II build tools must ignore the entry.
This patch is going to add this feature.
Signed-off-by: yi1 li
---
BaseTools/Source/Python/Common/Expression.py | 2 +-
BaseTools/Source/Python/Common/GlobalData.py | 1 +
.../Source/Python/Workspace
From: Yi Li
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3828
FeatureFlagExpression Support in Source section of INF file. The Pcd
value in the expression is from INF or DEC.
When a FeatureFlagExpression is present,if the expression evaluates
to TRUE,then the entry is valid. If the express
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3828
FeatureFlagExpression Support in Source section of INF file. The Pcd
value in the expression is from INF or DEC.
When a FeatureFlagExpression is present,if the expression evaluates
to TRUE,then the entry is valid. If the expression evaluates
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3881
LibraryClass MmServicesTableLib SynchronizationLib in SmmCryptLib.inf should be
listed in CryptoPkg.dsc.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Zhihao Li
Signed-off-by: yi1 li
---
CryptoPkg/CryptoPkg.dsc | 2 ++
1 file changed, 2
This patch is a bug fix about FeatureFlagExpression in INF file:
INF [Source] section now unconditionally use Pcd default value in DEC
when handling FeatureFlagExpression, it is wrong.
If a Pcd value has been set in the DSC file, we should use latest
value in DSC instead of default value.
Cc:
Details:
1. Some APIs need more detail comment.
2. Correct BnRShift() param order.
3. Remove unsecure ECC curve from GroupToNid().
4. Add full public key validating procedures to EcDhDeriveSecret().
Cc: Ming Tan
Cc: Heng Luo
Signed-off-by: Yi Li
---
CryptoPkg/Driver/Crypto.c
1. Origenal code mixes up the input/output parameters for the BN_rshift()
function - the output is actually the first parameter and not the second
one. Now we correct BnRShift() param order.
2. NID_X9_62_prime192v1() and NID_secp224r1 prohibited by Intel Crypto/TLS
Guidelines (due to being insuffi
-
> From: devel@edk2.groups.io On Behalf Of yi1 li
> Sent: Monday, July 11, 2022 1:48 PM
> To: devel@edk2.groups.io
> Cc: Li, Yi1 ; Feng, Bob C ;
> Gao, Liming
> Subject: [edk2-devel] [PATCH 1/1] BaseTools: INF should use latest Pcd
> value instead of default value
>
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3828
Review PR: https://github.com/tianocore/edk2/pull/3309
This patch sequence is used to add CryptBn and CryptEc library, which
are wrapped over OpenSSL. The implementation provides library functions
for EFI BaseCrypt protocol and EFI BaseCrypt
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3828
This patch is used to add CryptBn library, which is wrapped
over OpenSSL.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Xiaoyu Lu
Cc: Guomin Jiang
Signed-off-by: Yi Li
---
CryptoPkg/Include/Library/BaseCryptLib.h | 418 +
.../Li
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3828
The implementation provides CryptBn library functions
for EFI CryptoDxe and EFI BaseCrypt Protocol.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Xiaoyu Lu
Cc: Guomin Jiang
Signed-off-by: Yi Li
---
CryptoPkg/CryptoPkg.dsc
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3828
This patch is used to add CryptEc library, which is wrapped
over OpenSSL.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Xiaoyu Lu
Cc: Guomin Jiang
Signed-off-by: Yi Li
---
CryptoPkg/Include/Library/BaseCryptLib.h | 424 ++
.../Libr
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3828
The implementation provides CryptEc library functions
for EFI Driveer and EFI BaseCrypt Protocol.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Xiaoyu Lu
Cc: Guomin Jiang
Signed-off-by: Yi Li
---
CryptoPkg/CryptoPkg.dsc |
Add unit test for CryptoBn.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Xiaoyu Lu
Cc: Guomin Jiang
Signed-off-by: Yi Li
---
.../BaseCryptLib/UnitTestHostBaseCryptLib.inf | 1 +
.../BaseCryptLib/BaseCryptLibUnitTests.c | 1 +
.../UnitTest/Library/BaseCryptLib/BnTests.c | 257 +++
Add unit test for CryptoEc.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Xiaoyu Lu
Cc: Guomin Jiang
Signed-off-by: Yi Li
---
.../BaseCryptLib/UnitTestHostBaseCryptLib.inf | 2 +
CryptoPkg/Test/CryptoPkgHostUnitTest.dsc | 3 +
.../BaseCryptLib/BaseCryptLibUnitTests.c | 1 +
.../UnitTest
Run uncrustify tools on EC and BN change to meet UEFI code style.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Xiaoyu Lu
Cc: Guomin Jiang
Signed-off-by: Yi Li
---
CryptoPkg/Driver/Crypto.c | 2 +-
CryptoPkg/Include/Library/BaseCryptLib.h | 8 +-
CryptoPkg/Library/BaseCryp
| 1,008,352 | 721,408| 744,832|
Cc: Jiewen Yao
Cc: Jian J Wang
Signed-off-by: yi1 li
yi1 li (3):
CryptoPkg: Add instrinsics to support building ECC on IA32 windows
CryptoPkg: Reconfigure OpensslLib to add EC algorithms
CryptoPkg: Make EC source file config-able
CryptoPkg
Signed-off-by: yi1 li
---
.../Library/IntrinsicLib/Ia32/MathLlmul.asm | 98 +++
.../Library/IntrinsicLib/Ia32/MathLlshr.asm | 78 +++
.../Library/IntrinsicLib/IntrinsicLib.inf | 2 +
3 files changed, 178 insertions(+)
create mode 100644 CryptoPkg/Library
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3679
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3828
Reconfigure OpensslLib to add elliptic curve cipher algorithms.
Cc: Jiewen Yao
Cc: Jian J Wang
Signed-off-by: yi1 li
---
.../Library/Include/openssl/opensslconf.h | 3
compiled.
Cc: Jiewen Yao
Cc: Jian J Wang
Signed-off-by: yi1 li
---
CryptoPkg/CryptoPkg.dec | 4 +
.../Library/Include/openssl/opensslconf.h | 7 +-
CryptoPkg/Library/OpensslLib/OpensslLib.inf | 96 ++-
.../Library/OpensslLib/OpensslLibCrypto.inf | 96
Signed-off-by: yi1 li
---
.../Library/IntrinsicLib/Ia32/MathLlmul.asm | 98 +++
.../Library/IntrinsicLib/Ia32/MathLlshr.asm | 78 +++
.../Library/IntrinsicLib/IntrinsicLib.inf | 2 +
3 files changed, 178 insertions(+)
create mode 100644 CryptoPkg/Library
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3679
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3828
Reconfigure OpensslLib to add elliptic curve cipher algorithms.
Cc: Jiewen Yao
Cc: Jian J Wang
Signed-off-by: yi1 li
---
.../Library/Include/openssl/opensslconf.h | 3
compiled.
Cc: Jiewen Yao
Cc: Jian J Wang
Signed-off-by: yi1 li
---
CryptoPkg/CryptoPkg.dec | 4 +
.../Library/Include/openssl/opensslconf.h | 7 +-
CryptoPkg/Library/OpensslLib/OpensslLib.inf | 95 ++-
.../Library/OpensslLib/OpensslLibCrypto.inf | 95
| CryptPei.efi | CryptSmm.efi |
> Before | 815,616| 540,544| 563,712|
> Diabled | 815,616| 540,544| 563,712|
> Enabled | 1,008,352 | 721,408 | 744,832 |
>
> Cc: Jiewen Yao
> Cc: Jian J Wang
>
> Signed-off-by
gPlatformFinalPcd into datapipe and modifies the
assignment logicto fix this.
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: yi1 li
---
BaseTools/Source/Python/AutoGen/AutoGenWorker.py | 1 +
BaseTools/Source/Python/AutoGen/DataPipe.py | 2 ++
BaseTools/Source/Python/Workspace/DscBuildData.py | 1
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3679
This dependency is needed to build openssl lib with ECC ciphers
under IA32 Windows and adds implementation for _allmul and _allshr
instrinsics.
It is taken from Project Mu:
microsoft/mu_basecore@b55b341
Signed-off-by: yi1 li
As subject.
yi1 li (4):
CryptoPkg: Add instrinsics to support building ECC on IA32 windows
CryptoPkg: Reconfigure OpensslLib to add EC algorithms
CryptoPkg: Make EC source file config-able
CryptoPkg: Add PcdEcEnabled to Base/Pei/SmmCryptLib.inf
CryptoPkg/CryptoPkg.dec
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3679
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3828
Reconfigure OpensslLib to add elliptic curve cipher algorithms.
Signed-off-by: yi1 li
---
.../Library/Include/openssl/opensslconf.h | 3 --
CryptoPkg/Library/OpensslLib
compilers
Signed-off-by: yi1 li
---
CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf | 3 +++
CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf| 3 +++
CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf| 3 +++
CryptoPkg/Library/OpensslLib/OpensslLib.inf | 3 +--
CryptoPkg/Library/OpensslLib
compiled.
Signed-off-by: yi1 li
---
CryptoPkg/CryptoPkg.dec | 4 +
.../Library/Include/openssl/opensslconf.h | 7 +-
CryptoPkg/Library/OpensslLib/OpensslLib.inf | 95 ++-
.../Library/OpensslLib/OpensslLibCrypto.inf | 95 ++-
4 files
io On Behalf Of yi1 li
> Sent: Monday, April 18, 2022 6:03 AM
> To: devel@edk2.groups.io
> Cc: Li, Yi1
> Subject: [edk2-devel] [PATCH 1/4] CryptoPkg: Add instrinsics to
> support building ECC on IA32 windows
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3679
>
From: Yi Li
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3679
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3828
Tls/Base/Pei/Smm/RuntimeCryptLib.inf will use OpensslLib,
and the opensslconf.h in openssllib will use PcdEcEnabled,
but it is not declared in the inf file now,
it will cau
value is not handled yet.
The edk2 CI doesn't seem to build modules relying on OpenSSL due to the
CONTINUOUS_INTEGRATION flag, explaining why the patch passed the CI I think.
I added Bob as I think he knows more about BaseTools.
Regards,
Pierre
On 4/18/22 15:03, yi1 li vi
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3892
Which are needed for SUITE-B and SUITE-B-192.
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by: yi1 li
---
MdePkg/Include/IndustryStandard/Tls1.h | 133 ++---
1 file changed, 97 insertions(+), 36 deletions(-)
diff
Thank you
Yao, Jiewen
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of yi1 li
> Sent: Wednesday, May 4, 2022 5:31 PM
> To: devel@edk2.groups.io
> Cc: Li, Yi1 ; Kinney, Michael D
> ; Gao, Liming
> Subject: [edk2-devel] [PATCH 1/1] MdePkg: Add WPA3 relat
out consumer, it is hard for me to understand why they are needed, or if we
miss something else.
Thank you
Yao, Jiewen
> -Original Message-
> From: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
> mailto:devel@edk2.groups.io>> On Behalf Of yi1 li
> Sent
Recommend for Gerd:
(2) Keep the EC config option, but update process_files.pl to
automatically add the PcdEcEnabled config option handling
to the files it generates.
This patch set does (2).
When remove 'no-ec' from openssl configure list, will automatically remove
'OPENSSL_NO_EC', 'OPENSSL_
Recommend from Gerd:
(2) Keep the EC config option, but update process_files.pl to
automatically add the PcdEcEnabled config option handling
to the files it generates.
When remove 'no-ec' from openssl configure list, will automatically remove
'OPENSSL_NO_EC', 'OPENSSL_NO_ECDH', 'OPENSSL_NO_ECD
Files generated by process_files.pl from openssl sources should not be checked
for edk2 code style.
Signed-off-by: Gerd Hoffmann
Signed-off-by: Yi Li
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Xiaoyu Lu
Cc: Guomin Jiang
---
CryptoPkg/CryptoPkg.ci.yaml | 10 ++
1 file changed, 10 insertions
Run process_files.pl with the current openssl submodule version.
Signed-off-by: Yi Li
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Xiaoyu Lu
Cc: Guomin Jiang
Cc: Gerd Hoffmann
---
CryptoPkg/Library/Include/crypto/dso_conf.h | 7 +-
.../Library/Include/openssl/opensslconf.h | 266 +
Hi, Changes to this file are automatically generated by perl script. Modified
them before to follow edk2 code style.
Gerd thinks files generated by process_files.pl from openssl sources should not
be checked for edk2 code style, I agree with him.
So the changes are back.
-Original Message--
Sounds good, I like this idea which make openssl generated part and edk2
conditional part more clear.
Thank you,
Yi
-Original Message-
From: devel@edk2.groups.io On Behalf Of Gerd Hoffmann
Sent: Monday, May 9, 2022 5:34 PM
To: Li, Yi1
Cc: devel@edk2.groups.io; Yao, Jiewen ; Wang, Jian
Yes it does come from running the generated files though uncrustify once last
year when uncrustify was introduced:
https://github.com/tianocore/edk2/commit/7c342378317039e632d9a1a5d4cf7c21aec8cb7a
I can remove those change next patch to avoid confusion.
Thank you,
Yi
-Original Message
Recommend from Gerd:
(2) Keep the EC config option, but update process_files.pl to
automatically add the PcdEcEnabled config option handling
to the files it generates.
This patch set does (2).
When remove 'no-ec' from openssl configure list, will automatically remove
'OPENSSL_NO_EC', 'OPENSSL
PcdOpensslXXXEnabled is a more appropriate choice.
Signed-off-by: Yi Li
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Xiaoyu Lu
Cc: Guomin Jiang
---
CryptoPkg/CryptoPkg.dec | 2 +-
.../Library/BaseCryptLib/BaseCryptLib.inf | 2 +-
.../Library/BaseCryptLib/PeiCryptLib.inf
Move auto-generated openssl config to opensslconf_generated.h,
And opensslconf.h will contain both edk2 conditional openssl
feature and opensslconf_generated.h.
Will make two part more clear.
New conditional feture code in opensslconf.h will look like:
/* Autogenerated conditional openssl featur
Recommend from Gerd:
(2) Keep the EC config option, but update process_files.pl to
automatically add the PcdEcEnabled config option handling
to the files it generates.
When remove 'no-ec' from openssl configure list, will automatically remove
'OPENSSL_NO_EC', 'OPENSSL_NO_ECDH', 'OPENSSL_NO_ECD
Run process_files.pl with the current openssl submodule version.
Signed-off-by: Yi Li
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Xiaoyu Lu
Cc: Guomin Jiang
Cc: Gerd Hoffmann
---
CryptoPkg/Library/Include/crypto/dso_conf.h | 7 +-
.../Library/Include/openssl/opensslconf.h | 17 ++
.../Inclu
Files generated by process_files.pl from openssl sources should not be checked
for edk2 code style.
Signed-off-by: Gerd Hoffmann
Signed-off-by: Yi Li
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Xiaoyu Lu
Cc: Guomin Jiang
---
CryptoPkg/CryptoPkg.ci.yaml | 11 +++
1 file changed, 11 insertion
Files generated by process_files.pl from openssl sources should not be checked
for edk2 code style.
Signed-off-by: Gerd Hoffmann
Signed-off-by: Yi Li
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Xiaoyu Lu
Cc: Guomin Jiang
---
CryptoPkg/CryptoPkg.ci.yaml | 14 +-
1 file changed, 13 insert
Recommend from Gerd:
(2) Keep the EC config option, but update process_files.pl to
automatically add the PcdEcEnabled config option handling
to the files it generates.
This patch set does (2).
When remove 'no-ec' from openssl configure list, will automatically remove
'OPENSSL_NO_EC', 'OPENSS
PcdOpensslXXXEnabled is a more appropriate choice.
Signed-off-by: Yi Li
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Xiaoyu Lu
Cc: Guomin Jiang
---
CryptoPkg/CryptoPkg.dec | 2 +-
.../Library/BaseCryptLib/BaseCryptLib.inf | 2 +-
.../Library/BaseCryptLib/PeiCryptLib.inf
1 - 100 of 113 matches
Mail list logo
