Thanks for review and have re-sent patch series. -----Original Message----- From: Yao, Jiewen <jiewen....@intel.com> Sent: Wednesday, April 13, 2022 2:42 PM To: Li, Yi1 <yi1...@intel.com>; devel@edk2.groups.io Cc: Wang, Jian J <jian.j.w...@intel.com> Subject: RE: [PATCH 0/3] CryptoPkg: Enable ECC in openssllib by a customize-able way
Thanks for the contribution. Great progress on adding ECC. With PcdLib removed and "no-ec" removed, the series is reviewed-by: Jiewen Yao <jiewen....@intel.com> > -----Original Message----- > From: Li, Yi1 <yi1...@intel.com> > Sent: Wednesday, April 13, 2022 2:24 PM > To: devel@edk2.groups.io > Cc: Li, Yi1 <yi1...@intel.com>; Yao, Jiewen <jiewen....@intel.com>; > Wang, Jian J <jian.j.w...@intel.com> > Subject: [PATCH 0/3] CryptoPkg: Enable ECC in openssllib by a > customize-able way > > EDK2 has Enabled a feature which allow SOURCE section in INF files to > use Pcd to customize source files list. If Pcd equal to FALSE, this > file will not be compiled. > https://github.com/tianocore/edk2/commit/ > bf9230a9f3dde065c3c8b4175ccd32e44e8f0362 > The patches add a customizable EC feature to CryptoPkg by this feature. > > If Pcd equal to FALSE(Diabled), the binary size will not be changed. > > Size diff(Bytes): > | CryptDxe.efi | CryptPei.efi | CryptSmm.efi | > Before | 815,616 | 540,544 | 563,712 | > Diabled | 815,616 | 540,544 | 563,712 | > Enabled | 1,008,352 | 721,408 | 744,832 | > > Cc: Jiewen Yao <jiewen....@intel.com> > Cc: Jian J Wang <jian.j.w...@intel.com> > > Signed-off-by: yi1 li <yi1...@intel.com> > yi1 li (3): > CryptoPkg: Add instrinsics to support building ECC on IA32 windows > CryptoPkg: Reconfigure OpensslLib to add EC algorithms > CryptoPkg: Make EC source file config-able > > CryptoPkg/CryptoPkg.dec | 4 + > .../Library/Include/openssl/opensslconf.h | 10 +- > .../Library/IntrinsicLib/Ia32/MathLlmul.asm | 98 +++++++++++++++++++ > .../Library/IntrinsicLib/Ia32/MathLlshr.asm | 78 +++++++++++++++ > .../Library/IntrinsicLib/IntrinsicLib.inf | 2 + > CryptoPkg/Library/OpensslLib/OpensslLib.inf | 50 ++++++++++ > .../Library/OpensslLib/OpensslLibCrypto.inf | 50 ++++++++++ > CryptoPkg/Library/OpensslLib/process_files.pl | 2 +- > 8 files changed, 289 insertions(+), 5 deletions(-) create mode > 100644 CryptoPkg/Library/IntrinsicLib/Ia32/MathLlmul.asm > create mode 100644 CryptoPkg/Library/IntrinsicLib/Ia32/MathLlshr.asm > > -- > 2.33.0.windows.2 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#88856): https://edk2.groups.io/g/devel/message/88856 Mute This Topic: https://groups.io/mt/90435462/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
