Sounds good, I like this idea which make openssl generated part and edk2 conditional part more clear.
Thank you, Yi -----Original Message----- From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Gerd Hoffmann Sent: Monday, May 9, 2022 5:34 PM To: Li, Yi1 <yi1...@intel.com> Cc: devel@edk2.groups.io; Yao, Jiewen <jiewen....@intel.com>; Wang, Jian J <jian.j.w...@intel.com>; Lu, Xiaoyu1 <xiaoyu1...@intel.com>; Jiang, Guomin <guomin.ji...@intel.com> Subject: Re: [edk2-devel] [PATCH 1/3] CryptoPkg: Update process_files.pl to automatically add PCD config option Hi, > +# > +# Add conditional feature to opensslconf.h # I'd suggest to write the opensslconf.h created by openssl unmodified to opensslconf-generated.h, then have a opensslconf.h like this: #include <Library/PcdLib.h> #include "opensslconf-generated.h" #if !FixedPcdGetBool(PcdEcEnable) # define OPENSSL_NO_EC # [ ... ] #endif take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#89604): https://edk2.groups.io/g/devel/message/89604 Mute This Topic: https://groups.io/mt/90982453/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
