Well done! And Edk2 has code style tools internal, use this cmd to fix it:
pip install -r pip-requirements.txt git ls-files CryptoPkg*.c CryptoPkg*.h | .\.pytool\Plugin\UncrustifyCheck\mu-uncrustify-release_extdep\Windows-x86\uncrustify.exe -c .\.pytool\Plugin\UncrustifyCheck\uncrustify.cfg -F - --replace --no-backup --if-changed Thank you! Yi Li From: vineelko via groups.io <vineelko=microsoft....@groups.io> Sent: Saturday, February 26, 2022 1:52 AM To: Li, Yi1 <yi1...@intel.com>; devel@edk2.groups.io Subject: Re: [edk2-devel] [PATCH 1/2] Reconfigure OpensslLib to add elliptic curve chipher algorithms Huge Thanks for "You can submit PR to edk2 mater branch directly to check for CI bugs(will not be reviewed or merged)." I am fixing them. Regarding the style(extra spaces and tabs), It is actually coming from openssl when we run CryptoPkg/Library/OpensslLib/process_files.pl Not sure if there a way to exclude some of the files from checking the style? Sample PR against EDK2 master: https://github.com/tianocore/edk2/pull/2546/files Thanks, Vineel -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#87032): https://edk2.groups.io/g/devel/message/87032 Mute This Topic: https://groups.io/mt/86257810/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
