Yes it does come from running the generated files though uncrustify once last year when uncrustify was introduced: https://github.com/tianocore/edk2/commit/7c342378317039e632d9a1a5d4cf7c21aec8cb7a I can remove those change next patch to avoid confusion.
Thank you, Yi -----Original Message----- From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Gerd Hoffmann Sent: Monday, May 9, 2022 5:38 PM To: Yao, Jiewen <jiewen....@intel.com> Cc: Li, Yi1 <yi1...@intel.com>; devel@edk2.groups.io; Wang, Jian J <jian.j.w...@intel.com>; Lu, Xiaoyu1 <xiaoyu1...@intel.com>; Jiang, Guomin <guomin.ji...@intel.com> Subject: Re: [edk2-devel] [PATCH 3/3] CryptoPkg/openssl: update generated files On Mon, May 09, 2022 at 03:25:24AM +0000, Yao, Jiewen wrote: > Thanks for the update. > > think some changes are unnecessary. > > > -#define OSSL_CRYPTO_DSO_CONF_H > > -#define DSO_NONE > > -#define DSO_EXTENSION ".so" > > +# define OSSL_CRYPTO_DSO_CONF_H > > +# define DSO_NONE > > +# define DSO_EXTENSION ".so" > > Why you add a space ' ' ? > > Can we make it unchanged? Not sure where this comes from, either it's a upstream openssl change, or it comes from running the generated files though uncrustify once last year when uncrustify was introduced. take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#89606): https://edk2.groups.io/g/devel/message/89606 Mute This Topic: https://groups.io/mt/90982455/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
