On 10/10/19 09:38, Laszlo Ersek wrote:
> On 10/10/19 04:52, Ni, Ray wrote:
>> Laszlo,
>> Can you add comments in the code you changed to describe the two different
>> behaviors?
>
> It's described in the DEC file, near the PCD:
>
> + # nonzero
Before adding another AP enumeration mode, clarify the documentation on
the current logic. No functional changes.
Cc: Eric Dong
Cc: Ray Ni
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1515
Signed-off-by: Laszlo Ersek
---
Notes:
v2:
- new patch
UefiCpuPkg/Library/MpInitLib
avior when
the exact boot CPU count is known in advance. (A hung boot is better than
an AP checking-in after timeout, and executing code from released
storage.)
Cc: Eric Dong
Cc: Ray Ni
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1515
Signed-off-by: Laszlo Ersek
---
Notes:
v2:
- u
ensively than the existent comment). Then the new mode is introduced
(with additional documentation).
Cc: Eric Dong
Cc: Ray Ni
Thanks,
Laszlo
Laszlo Ersek (2):
UefiCpuPkg/MpInitLib: expand comment on initial AP enumeration
UefiCpuPkg/MpInitLib: honor the platform's boot CPU count in AP
On 10/10/19 11:29, Fu, Siyuan wrote:
>> -Original Message-
>> From: Laszlo Ersek
>> Sent: 2019年10月10日 16:06
>> To: Fu, Siyuan ; devel@edk2.groups.io; Rabeda,
>> Maciej
>> Cc: Wu, Jiaxin
>> Subject: Re: [edk2-devel] [PATCH v1 1/1] NetworkPk
Hi Liming, Andrew,
On 10/10/19 14:32, Liming Gao wrote:
> Laszlo:
>
>> -Original Message-----
>> From: Laszlo Ersek
>> Sent: Wednesday, October 9, 2019 4:22 AM
>> To: Gao, Liming ; devel@edk2.groups.io; af...@apple.com
>> Subject: Re: [edk2-devel] [Pa
Hi Liming,
On 10/10/19 14:18, Liming Gao wrote:
>> -Original Message-
>> From: devel@edk2.groups.io On Behalf Of Laszlo Ersek
>> Sent: Thursday, October 10, 2019 3:35 PM
>> To: Andrew Fish ; Gao, Liming
>> Cc: devel@edk2.groups.io
>> Subject: Re
Hi Liming,
On 10/10/19 16:08, Liming Gao wrote:
> Laszlo:
> Option (a) works. Jordan patch can fix this issue.
> Option (b) doesn't work. Even if disable optimization, CLANG doesn't
> generate the code with push rbp & pop rbp.
>
> So, Jordan patch becomes only option. We can discuss thi
On 10/10/19 17:45, David Woodhouse wrote:
> On Thu, 2019-10-10 at 10:00 +0200, Laszlo Ersek wrote:
>>> Subject: C=HU, ST=Pest, L=Budapest, O=Laszlo Ersek Home Office,
>>> OU=IPv6 cert, CN=fd33:eb1b:9b36::2
>
> Yeah, you're not actually testing the case
On 10/10/19 16:37, Junhao Gao wrote:
> Hi edk2 members
>
>I have a question for your help.
>I want to enable qemu+kvm+ovmf to boot up windows xp,
>then ovmf support winxp starting-up?
To my understanding, the first Windows "family" with any kind of U
On 10/11/19 01:17, Lendacky, Thomas wrote:
> On 10/3/19 10:12 AM, Tom Lendacky wrote:
>>
>>
>> On 10/3/19 5:32 AM, Laszlo Ersek wrote:
>>> On 10/03/19 12:12, Laszlo Ersek wrote:
>>>
>>>> UINT32 ApEntryPoint;
>>>> EFI_GUID SevEsFo
Hi Liming,
On 10/09/19 16:44, Gao, Liming wrote:
> The difference between XCODE/CLANG and GCCXX is the linker. Current
> patches are introduced for the different linker. Clang supports most
> usage of GCC compiler. So, CLANG and XCODE uses GCC family. When I
> enable XCODE or CLANG tool chain in
On 10/11/19 02:14, Fu, Siyuan wrote:
>> -Original Message-
>> From: Laszlo Ersek
>> Sent: 2019年10月11日 0:06
>> To: Fu, Siyuan ; devel@edk2.groups.io; Rabeda,
>> Maciej
>> Cc: Wu, Jiaxin
>> Subject: Re: [edk2-devel] [PATCH v1 1/1] NetworkPk
On 10/11/19 03:30, Liming Gao wrote:
> Laszlo:
>
>> -Original Message-----
>> From: Laszlo Ersek [mailto:ler...@redhat.com]
>> Sent: Friday, October 11, 2019 1:35 AM
>> To: devel@edk2.groups.io; Gao, Liming ; Justen,
>> Jordan L
>> Subject: Re: [edk2
On 10/11/19 03:47, Liming Gao wrote:
> Laszlo:
>
>> -Original Message-----
>> From: Laszlo Ersek [mailto:ler...@redhat.com]
>> Sent: Friday, October 11, 2019 12:43 AM
>> To: devel@edk2.groups.io; Gao, Liming ; Andrew Fish
>>
>> Cc: Justen, Jordan L
dress), if
> you do need such feature that verify the IP in X509_check_ip &
> X509_check_ip_asc , please report new Bugzilla (need TLS Spec update the
> expose the setting interface), don't mix up the HTTPS hostname verification
> here.
(To clarify my stance.)
Given the ab
Hi,
On 10/11/19 03:19, Liming Gao wrote:
> Andrew:
> I verify the change (2de1f611be06ded3a59726a4052a9039be7d459b
> MdeModulePkg/BdsDxe: Also call PlatformBootManagerWaitCallback on 0)
> in Emulator.
> It works, because PCD value is set to 10 in Emulator.
>
> Before this change, if Time
On 10/11/19 06:59, Andrew Fish via Groups.Io wrote:
> Liming,
>
> Thanks for looking into this!
>
> Can someone also answer my question about the expected behavior of taking an
> exception in OVMF? Is the CpuDeadloop() expected?
Yes, it is.
The exception handler dumps the register file and t
and check out the <https://www.kraxel.org/repos/>
> continuous
> integration repository, which provides CSM-enabled OVMF builds.
>
> Could you help me to choose which branch supporting CSM, and more
> details, thanks very much.
>
> Thanks,
> Junhao
&
On 10/11/19 13:16, David Woodhouse wrote:
> On Fri, 2019-10-11 at 12:55 +0200, Laszlo Ersek wrote:
>> On 10/11/19 04:24, Wu, Jiaxin wrote:
>>> Hi Laszlo & David,
>>>
>>> I think I have *repeated* several times that we are targeting to fix the
>>&g
Hi Andrew,
On 10/11/19 15:13, Andrew Fish wrote:
> I'm with Pete on this as my expectation would be the progress bar
> completes when you are done. I'd also point out that a common progress
> bar UI implementation is to show the area that is going to be updated.
> I don't think our UI does that,
On 10/11/19 10:22, Ni, Ray wrote:
> Laszlo, the comments couldn't be better! Thanks!!
>
> Reviewed-by: Ray Ni
Thanks, Ray :)
Series pushed as commit range a7e2d20193e8..778832bcad33.
Cheers!
Laszlo
>
>> -Original Message-
>> From: Laszlo Ersek
>>
On 10/11/19 16:35, David Woodhouse wrote:
> On Fri, 2019-10-11 at 16:27 +0200, Laszlo Ersek wrote:
>> On 10/11/19 09:44, Gao, Junhao wrote:
>>> Hi David
>>>
>>>I have found this compiled OVMF-with-csm.fd can support winxp
>>> booting up.
On 10/12/19 08:42, Andrew Fish wrote:
> Laszlo,
>
> For 2) this is very unfortunate. I think the root cause is for those
> of us who work on x86 hardware day to day we get programed that
> SEC/PEI is IA32 and DXE is X64, and this can lead to some unfortunate
> coding outcomes.
First I was confuse
; +(TimeoutInitial - TimeoutRemain) * 100 / TimeoutInitial,
> 0
> );
> }
>
(2) Can you please post the same patch for
"ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c" as well?
That would be mean two patches, in a v2 series.
With both (1) and (2) cover
at.com; Gao, Liming
>> Subject: [PATCH 1/1] MdeModulePkg/BdsDxe: Fix calling
>> PlatformBootManagerWaitCallback on 0
>>
>> From: Laszlo Ersek
>>
>> Commit 2de1f611be06ded3a59726a4052a9039be7d459b introduced a
>> regression
>> whereas
On 10/11/19 18:01, David Woodhouse wrote:
> On Fri, 2019-10-11 at 17:36 +0200, Laszlo Ersek wrote:
>> On 10/11/19 13:16, David Woodhouse wrote:
>>> I first started looking at this when it was
>>> reported as such, on the list.
>>
>> I believe you. Can you s
On 10/14/19 18:15, Laszlo Ersek wrote:
> David: another way to prevent the regression is to commit the current
> patches, but disable them with a BOOLEAN PCD, by default. (This need not
> be a feature PCD; it could even be dynamic.) Then platforms accepting
> the SAN/GEN_IP regression
On 10/14/19 17:03, Pete Batard wrote:
> Changes from previous version:
> - Additional empty comment lines above and below, to keep with existing
> comment
> style
> - Similar logic is applied to ArmVirtPkg/PlatformBootManagerLib, since the
> same
> issue may manifest itself here.
>
> Pete Ba
SMM
> timing and stability differences on the BSP (e.g. CPU#0) vs an
> AP (e.g. CPU#1).
> # taskset -c 0 efibootmgr
> # taskset -c 1 efibootmgr
>
> Cc: Ard Biesheuvel
> Cc: Laszlo Ersek
> Cc: Liming Gao
> Cc: Jordan Justen
> Cc: Hao A Wu
> Signed-off-by: Michael K
ming and stability differences on the BSP (e.g. CPU#0) vs an
> AP (e.g. CPU#1).
> # taskset -c 0 efibootmgr
> # taskset -c 1 efibootmgr
>
> Cc: Ard Biesheuvel
> Cc: Laszlo Ersek
> Cc: Liming Gao
> Cc: Jordan Justen
> Cc: Hao A Wu
> Signed-off-by: Michael K
On 10/15/19 01:30, Michael Kubacki wrote:
> This change enables the variable runtime cache by default by setting
> gEfiMdeModulePkgTokenSpaceGuid.PcdEnableVariableRuntimeCache in
> MdeModulePkg.dec to TRUE.
>
> Cc: Dandan Bi
> Cc: Ard Biesheuvel
> Cc: Eric Dong
> Cc: La
On 10/15/19 02:26, Liming Gao wrote:
> In v2, drop patch 12, and update commit message for 5 & 11.
Thank you, Liming.
In patch 11, there is a small typo in the commit message, "crush" vs.
"crash". If you get the chance, please correct that just before pushing.
Thanks!
Laszlo
-=-=-=-=-=-=-=-=-=-
for both ARM and AARCH64 (which may
> start relying on intrinsics due to future changes)
>
> Link: https://bugzilla.tianocore.org/show_bug.cgi?id=2269
> Reported-by: Laszlo Ersek
> Signed-off-by: Ard Biesheuvel
> ---
> DynamicTablesPkg/DynamicTablesPkg.dsc | 1 +
> 1 fi
On 10/15/19 13:03, David Woodhouse wrote:
> On Mon, 2019-10-14 at 18:15 +0200, Laszlo Ersek wrote:
>> My understanding is that a fix purely in edk2 -- that is, without
>> advancing our openssl submodule reference at once -- is possible, based
>> on your
On 10/15/19 15:54, Laszlo Ersek wrote:
> On 10/15/19 13:03, David Woodhouse wrote:
>> The "app callback" in my OpenConnect example is set on the SSL_CTX not
>> the SSL object, and is called from the top-level
>> ssl_verify_cert_chain() function *instead* of
On 10/15/19 17:57, David Woodhouse wrote:
> On Thu, 2019-10-10 at 20:03 +0200, Laszlo Ersek wrote:
>> (I can't test it easily myself, as I don't even know how to create a
>> server certificate with a SAN -- any kind of SAN, let alone GEN_IP.)
>
> I had to
On 10/15/19 18:56, Laszlo Ersek wrote:
> On 10/15/19 15:54, Laszlo Ersek wrote:
>> On 10/15/19 13:03, David Woodhouse wrote:
>
>>> The "app callback" in my OpenConnect example is set on the SSL_CTX not
>>> the SSL object, and is called from the top-le
On 01/14/20 11:34, Vitaly Cheptsov via Groups.Io wrote:
> - ConnectControllers
> ShellPkg/Library/UefiShellDriver1CommandsLib/Connect.c
>
> This one is more complex, as it supports explicitly connecting specified
> controllers, however, for connecting all controllers it locates handles with
> g
Hi Dandan, Brian,
On 01/14/20 09:56, Dandan Bi wrote:
> From: Brian R Haug
>
> Update data type of variables which save the opcode numbers
> to UINTN, in case some configuration module has lots of
> configuration items.
>
> Cc: Liming Gao
> Cc: Eric Dong
> Signed-off-by: Brian R Haug
> Reviewe
On 01/14/20 14:08, Laszlo Ersek wrote:
> Hi Dandan, Brian,
>
> On 01/14/20 09:56, Dandan Bi wrote:
>> From: Brian R Haug
>>
>> Update data type of variables which save the opcode numbers
>> to UINTN, in case some configuration module has lots of
>> co
CC Phil
On 01/14/20 17:32, Leif Lindholm wrote:
> Leif now works at NUVIA Inc, update email address accordingly.
>
> Cc: Andrew Fish
> Cc: Ard Biesheuvel
> Cc: Laszlo Ersek
> Cc: Michael D Kinney
> Cc: Ray Ni
> Cc: Zhichao Gao
> Cc: Leif Lindholm
>
> Cc: Ray Ni
> Cc: Laszlo Ersek
> Signed-off-by: Eric Dong
> ---
> UefiCpuPkg/Library/MpInitLib/MpLib.c | 10 ++
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.c
> b/UefiCpuPkg/Library/MpInitLib/MpLib.c
Hi Ray, Eric,
any comments about the patch below?
It hasn't been a week yet (I usually don't ping before a full week), but
the patch is not large, so I figure maybe you've missed it. (Traffic on
has been quite high recently.)
Thanks!
Laszlo
On 01/10/20 00:25, Laszlo Ersek wro
On 01/15/20 12:08, Philippe Mathieu-Daudé wrote:
> On 1/10/20 12:25 AM, Laszlo Ersek wrote:
>> In commit 4eee0cc7cc0d ("UefiCpuPkg/PiSmmCpu: Enable 5 level paging when
>> CPU supports", 2019-07-12), the Page Directory Entry setting was
>> regressed
>> (corrup
Hi Ard,
On 01/15/20 11:22, Ard Biesheuvel wrote:
> Currently, ArmPkg's implementation of PlatformBootManagerBeforeConsole()
> iterates over all PCI I/O handles in the database and connects the ones
> that may produce an instance of the Graphics Output Protocol (GOP) once
> connected. After that, i
On 01/15/20 14:02, Ard Biesheuvel wrote:
> On Wed, 15 Jan 2020 at 13:50, Laszlo Ersek wrote:
>> (3) So how about the following approach:
>>
>> (3a) factor the following sequence:
>>
>> FilterAndProcess (&gEfiPciIoProtocolGuid, IsPciDis
On 01/16/20 04:15, Dong, Eric wrote:
> Hi Laszlo,
>
>> -Original Message-----
>> From: Laszlo Ersek [mailto:ler...@redhat.com]
>> Sent: Wednesday, January 15, 2020 6:05 PM
>> To: Dong, Eric ; devel@edk2.groups.io
>> Cc: Ni, Ray
>> Subject: Re: [PATCH
tialization works. The
> user can still get HMAC context via HmacXxxNew interface, which hides the
> details about the context.
>
> Cc: Xiaoyu Lu
> Cc: Laszlo Ersek
> Signed-off-by: Jian J Wang
> ---
> CryptoPkg/Include/Library/BaseCryptLib.h | 94 ++
ion and release,
> use HmacXxxNew() and HmacXxxFree() instead.
>
> Cc: Xiaoyu Lu
> Cc: Laszlo Ersek
> Signed-off-by: Jian J Wang
> ---
> CryptoPkg/Include/Library/BaseCryptLib.h | 17 --
> .../Library/BaseCryptLib/Hmac/CryptHmacMd5.c | 31
* cpp suitable for source code in the C and C++
>languages.
The key statement is the one in parentheses.
Thus, mark our *.h and *.c files as belonging to the "cpp" git-diff
driver.
This change has a dramatic effect on the following command, for example:
$ git
wen Yao
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2129
Signed-off-by: Laszlo Ersek
---
SecurityPkg/Library/DxeImageVerificationLib/DxeImageVerificationLib.c | 34
+---
1 file changed, 16 insertions(+), 18 deletions(-)
diff --git
a/SecurityPkg/Library/DxeImag
patible error codes to
EFI_ACCESS_DENIED, under some circumstances.
Cc: Chao Zhang
Cc: Jian J Wang
Cc: Jiewen Yao
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2129
Fixes: 570b3d1a7278df29878da87990e8366bd42d0ec5
Signed-off-by: Laszlo Ersek
---
SecurityPkg/Library/DxeImageVerificationLib/
git show -b -W
for reviewing it more easily.
Cc: Chao Zhang
Cc: Jian J Wang
Cc: Jiewen Yao
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2129
Signed-off-by: Laszlo Ersek
---
SecurityPkg/Library/DxeImageVerificationLib/DxeImageVerificationLib.c | 41
++--
1 file changed,
e "Status" outcome from API-incompatible error codes to
EFI_ACCESS_DENIED, under some circumstances.
Cc: Chao Zhang
Cc: Jian J Wang
Cc: Jiewen Yao
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2129
Signed-off-by: Laszlo Ersek
---
SecurityPkg/Library/DxeImageVerificationLib/DxeI
://bugzilla.tianocore.org/show_bug.cgi?id=2129
Fixes: 5db28a6753d307cdfb1cfdeb2f63739a9f959837
Signed-off-by: Laszlo Ersek
---
SecurityPkg/Library/DxeImageVerificationLib/DxeImageVerificationLib.c | 11
---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git
a/SecurityPkg/Library/DxeImageVeri
J Wang
Cc: Jiewen Yao
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2129
Signed-off-by: Laszlo Ersek
---
SecurityPkg/Library/DxeImageVerificationLib/DxeImageVerificationLib.c | 20
++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git
a/SecurityPkg/Library/DxeImageVerificat
c: Jian J Wang
Cc: Jiewen Yao
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2129
Signed-off-by: Laszlo Ersek
---
SecurityPkg/Library/DxeImageVerificationLib/DxeImageVerificationLib.c | 1 -
1 file changed, 1 deletion(-)
diff --git
a/SecurityPkg/Library/DxeImageVerificationLib/DxeImageVe
AUTH_SIG_FAILED or EFI_IMAGE_EXECUTION_AUTH_SIG_FOUND.
For now, the EFI_IMAGE_EXECUTION_INFO addition logic is not changed; we
only make sure that the record we add is not malformed.)
Cc: Chao Zhang
Cc: Jian J Wang
Cc: Jiewen Yao
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2129
NIED, under some circumstances.
Cc: Chao Zhang
Cc: Jian J Wang
Cc: Jiewen Yao
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2129
Fixes: 570b3d1a7278df29878da87990e8366bd42d0ec5
Signed-off-by: Laszlo Ersek
---
SecurityPkg/Library/DxeImageVerificationLib/DxeImageVerificationLib.c | 2 +-
quot; in
DxeImageVerificationHandler(). Remove the variable, and simply return
EFI_SECURITY_VIOLATION in the end.
This patch is a no-op, regarding behavior.
Cc: Chao Zhang
Cc: Jian J Wang
Cc: Jiewen Yao
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2129
Signed-off-by: Laszlo Ersek
function-context", for easier review.
Cc: Chao Zhang
Cc: Jian J Wang
Cc: Jiewen Yao
Thanks,
Laszlo
Laszlo Ersek (11):
SecurityPkg/DxeImageVerificationHandler: simplify "VerifyStatus"
SecurityPkg/DxeImageVerificationHandler: remove "else" aft
l for the immediate
HashPeImageByType() retval check, introduce a specific helper variable,
called "HashStatus".
This patch is a no-op, functionally.
Cc: Chao Zhang
Cc: Jian J Wang
Cc: Jiewen Yao
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2129
Signed-off-by: Laszlo Ersek
---
onflict.
Ah, that makes total sense. I didn't expect this reason!
> Reviewed-by: Ray Ni
Thanks!
Laszlo
>
>> -----Original Message-
>> From: Laszlo Ersek
>> Sent: Friday, January 10, 2020 7:25 AM
>> To: edk2-devel-groups-io
>> Cc: Dong, Eric ; Ni, Ra
On 01/16/20 22:34, Leif Lindholm wrote:
> On Thu, Jan 16, 2020 at 19:54:43 +0100, Philippe Mathieu-Daudé wrote:
>>> Phil, would it make sense for us to ask Leif to post an update to
>>> ".mailmap"?
>>>
>>> For example, what happens if we run "git shortlog" over a period that
>>> contains patches au
On 01/17/20 01:22, Gao, Liming wrote:
> Leif:
> Vfr is not C style source file. It can't be regarded as C source
> file.
>
> Laszlo:
>Is there such support for the assembly file, such as .nasm?
According to the gitattributes(5) manual, there doesn't seem to be a
git-diff driver for assembl
On 01/17/20 01:56, Gao, Liming wrote:
> Leif:
> .act is same to .aslc. There are no cases in open source.
How about this then:
*.[Aa][Cc][Tt] diff=cpp
*.[Aa][Ss][Ll][Cc] diff=cpp
*.[CcHh] diff=cpp
*.[Cc][Cc] diff=cpp
*.[Cc][Pp][Pp] diff=cpp
Thanks,
Laszlo
-=-=-=-=-
(CpuMpData);
> SaveLocalApicTimerSetting (CpuMpData);
> }
>
> This commit will address the above-mentioned issue.
>
> Test done:
> * OS boot on a real platform with multi processors
>
> Cc: Eric Dong
> Cc: Ray Ni
> Cc: Laszlo Ersek
> Cc: Michael D
On 01/10/20 00:25, Laszlo Ersek wrote:
> In commit 4eee0cc7cc0d ("UefiCpuPkg/PiSmmCpu: Enable 5 level paging when
> CPU supports", 2019-07-12), the Page Directory Entry setting was regressed
> (corrupted) when splitting a 2MB page to 512 4KB pages, in the
> InitPaging() funct
ired = TRUE;
> AllocateResetVector (CpuMpData);
> FillExchangeInfoData (CpuMpData);
> SaveLocalApicTimerSetting (CpuMpData);
> }
>
> This commit will address the above-mentioned issue.
>
> Test done:
> * OS boot on a real platform with multi processors
>
On 01/17/20 14:05, Leif Lindholm wrote:
> On Fri, Jan 17, 2020 at 09:30:49 +0100, Laszlo Ersek wrote:
>> On 01/17/20 01:56, Gao, Liming wrote:
>>> Leif:
>>> .act is same to .aslc. There are no cases in open source.
>>
>> How about this then:
>>
&g
On 01/19/20 08:03, Gao, Zhichao wrote:
> Hi Laszlo,
>
> Sorry for misunderstanding the logic in read key function. That makes the
> incorrect analysis.
> The read key function is waiting for "specific" key press not a key press. We
> should drop all the other pressing-key.
> That means we should
those as belonging to the "cpp" git-diff driver.
This change has a dramatic effect on the following command, for example:
$ git show -W 2ef0c27cb84c
Cc: Bob Feng
Cc: Leif Lindholm
Cc: Liming Gao
Signed-off-by: Laszlo Ersek
---
Notes:
v2:
- take suffixes from "B
On 01/20/20 10:11, Philippe Mathieu-Daudé wrote:
> Hi Liming,
>
> On 1/9/20 6:35 AM, Feng, Bob C wrote:
>> Reviewed-by: Bob Feng
>
> Is the Review-by tag from Bob enough to get this patch merged?
Yes, see the "M" role:
BaseTools
F: BaseTools/
W: https://github.com/tianocore/tianocore.github.io
On 01/20/20 11:12, Leif Lindholm wrote:
> On Mon, Jan 20, 2020 at 10:42:45 +0100, Laszlo Ersek wrote:
>> The "--function-context" ("-W") option of git-diff displays the entire
>> body of a modified function, not just small modified hunks within the
>> func
On 01/20/20 17:58, Leif Lindholm wrote:
> This is a proposal for a process by which new features can be added to UEFI
> forum specifications after first having been designed and prototyped in the
> open.
>
> This process lets changes and the development of new features happen in the
> open, withou
Hi Ken,
On 01/23/20 02:37, Ken Taylor wrote:
> If I try to get the size of a DynamicEx PCD in the context of a BIOS
> build for which that PCD is undefined, the call locks up. I expected
> to just get a size of 0, since the PCD is not defined in the build
> context of the PCD DXE service. Is th
Mike,
can you please ACK this patch while Liming and Bob are away? It's very
simple.
Thanks!
Laszlo
On 01/20/20 10:42, Laszlo Ersek wrote:
> The "--function-context" ("-W") option of git-diff displays the entire
> body of a modified function, not just small modif
On 01/23/20 22:08, Andrew Fish wrote:
>
>> On Jan 23, 2020, at 3:21 AM, Laszlo Ersek wrote:
>>
>> Hi Ken,
>>
>> On 01/23/20 02:37, Ken Taylor wrote:
>>
>>> If I try to get the size of a DynamicEx PCD in the context of a BIOS
>>> bui
On 01/24/20 03:10, Michael D Kinney wrote:
> Add maintainers and reviewers for UnitTestFrameworkPkg
>
> Cc: Sean Brogan
> Cc: Bret Barkelew
> Cc: Andrew Fish
> Cc: Laszlo Ersek
> Cc: Leif Lindholm
> Signed-off-by: Michael D Kinney
> ---
> Maintainers.txt |
bmodule directory is
> added as a new file with attributes 16 that can be detected
> by looking for the pattern "new file mode 16".
>
> Cc: Bob Feng
> Cc: Liming Gao
> Cc: Laszlo Ersek
> Signed-off-by: Michael D Kinney
> ---
> BaseTools/Scripts/Patch
Hi Phil,
On 10/24/19 17:12, Philippe Mathieu-Daudé wrote:
> On 10/24/19 12:29 PM, Laszlo Ersek wrote:
>> On 10/23/19 14:05, Philippe Mathieu-Daudé wrote:
>>> Hi Laszlo,
>>>
>>> On 10/23/19 12:15 AM, Laszlo Ersek wrote:
>>>> In v1.5.0, QEMU&#x
On 01/29/20 13:12, Anthony PERARD wrote:
> To avoid nasm generating a warning, replace the macro by the value
> expected to be stored in eax.
> Ia32/XenPVHMain.asm:76: warning: dword data exceeds bounds
>
> Reported-by: Laszlo Ersek
> Signed-off-by: Anthony PERARD
to configure X86 Processor FSB clock.
> + # @Prompt FSB Clock.
> + gEfiMdePkgTokenSpaceGuid.PcdFSBClock|2|UINT32|0x000c
> +
> [UserExtensions.TianoCore."ExtraFiles"]
>MdePkgExtra.uni
>
Looks good to me:
Reviewed-by: Laszlo Ersek
Mike or Liming will ha
};
> #ifndef __XEN__
> typedef struct shared_info shared_info_t;
> +typedef struct shared_info XEN_SHARED_INFO;
> #endif
>
> /* Turn a plain number into a C UINTN constant. */
>
Assuming the OVMF platforms continue to build at this stage into the
series, and provided that
On 01/29/20 13:12, Anthony PERARD wrote:
> Calculate the frequency of the APIC timer that Xen provides.
>
> Even though the frequency is currently hard-coded, it isn't part of
> the public ABI that Xen provides and thus may change at any time. OVMF
> needs to determine the frequency by an other me
.PcdCName|Value
-
I'm not sure if the "build" utility accepts this intentionally, or by
mistake.
Can you simply keep the "|1" part too?
Otherwise, I'm OK with the argument laid out in the commit message.
(Thank you for the detailed commit message!)
W
On 01/29/20 15:43, Philippe Mathieu-Daudé wrote:
> Hi Laszlo,
>
> On 1/24/20 12:40 PM, Laszlo Ersek wrote:
>> On 10/24/19 17:12, Philippe Mathieu-Daudé wrote:
>>> This patch is fine then.
>>>
>>> Since the QEMU spec is RFC and not merged, I'm worr
S Protocol however.
For their sake, introduce a new feature PCD that simply reflects the
CSM_ENABLE build flag.
Cc: Anthony Perard
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Julien Grall
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1512
Signed-off-by: Laszlo Ersek
---
Not
is R-b.
Cc: Anthony Perard
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Julien Grall
Thanks,
Laszlo
Laszlo Ersek (11):
OvmfPkg: introduce PcdQ35SmramAtDefaultSmbase
OvmfPkg/IndustryStandard: increase vertical whitespace in Q35 macro
defs
OvmfPkg/IndustryStandard: a
https://bugzilla.tianocore.org/show_bug.cgi?id=1512
Signed-off-by: Laszlo Ersek
Reviewed-by: Jiewen Yao
---
Notes:
v2:
- trim Cc list
- pick up Jiewen's R-b <https://edk2.groups.io/g/devel/message/48166>
OvmfPkg/PlatformPei/MemDetect.c | 37 ++--
1 file change
.
Cc: Ard Biesheuvel
Cc: Jordan Justen
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1512
Signed-off-by: Laszlo Ersek
Reviewed-by: Jiewen Yao
---
Notes:
v2:
- trim Cc list
- pick up Jiewen's R-b <https://edk2.groups.io/g/devel/message/48166>
OvmfPkg/OvmfPkg.dec
-by: Laszlo Ersek
Reviewed-by: Jiewen Yao
---
Notes:
v2:
- trim Cc list
- pick up Jiewen's R-b <https://edk2.groups.io/g/devel/message/48166>
OvmfPkg/PlatformPei/MemDetect.c | 13 +--
OvmfPkg/PlatformPei/Platform.c | 23
2 files changed, 24
.
Cc: Ard Biesheuvel
Cc: Jordan Justen
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1512
Signed-off-by: Laszlo Ersek
Reviewed-by: Jiewen Yao
---
Notes:
v2:
- trim Cc list
- pick up Jiewen's R-b <https://edk2.groups.io/g/devel/message/48166>
OvmfPkg/Include
ater patch.
Cc: Ard Biesheuvel
Cc: Jordan Justen
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1512
Signed-off-by: Laszlo Ersek
Reviewed-by: Jiewen Yao
---
Notes:
v2:
- trim Cc list
- pick up Jiewen's R-b <https://edk2.groups.io/g/devel/message/48166>
OvmfPkg/Platfo
to "Q35MchIch9.h".
(There are some other unused offsets in Table 5-1; for example we had
scavenged 0x50 for implementing the extended TSEG feature. 0x9C is the
first byte-wide register standing in isolation after 0x50.)
Cc: Ard Biesheuvel
Cc: Jordan Justen
Ref: https://bugzilla.tianocore.o
SmmAccess2Dxe (for locking
at normal boot), and an EDKII_S3_SMM_INIT_DONE_GUID PPI notify in
SmmAccessPei (for locking at S3 resume).
Cc: Ard Biesheuvel
Cc: Jordan Justen
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1512
Signed-off-by: Laszlo Ersek
Reviewed-by: Jiewen Yao
---
Notes:
https://edk2.groups.io/g/devel/message/48348
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Justen
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1512
Signed-off-by: Laszlo Ersek
---
Notes:
v2:
- In CSM_ENABLE builds, pretend that SMRAM never exists at the default
SMBA
Justen
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1512
Signed-off-by: Laszlo Ersek
Reviewed-by: Jiewen Yao
---
Notes:
v2:
- trim Cc list
- pick up Jiewen's R-b <https://edk2.groups.io/g/devel/message/48166>
OvmfPkg/PlatformPei/MemDetect.c | 10 ++
1 file
(the UEFI memory map is
untouched during S3 resume).
Cc: Ard Biesheuvel
Cc: Jordan Justen
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1512
Signed-off-by: Laszlo Ersek
Reviewed-by: Jiewen Yao
---
Notes:
v2:
- trim Cc list
- pick up Jiewen's R-b <https://edk2.groups.io
901 - 1000 of 4419 matches
Mail list logo
