On 01/29/20 15:43, Philippe Mathieu-Daudé wrote:
> Hi Laszlo,
>
> On 1/24/20 12:40 PM, Laszlo Ersek wrote:
>> On 10/24/19 17:12, Philippe Mathieu-Daudé wrote:
>>> This patch is fine then.
>>>
>>> Since the QEMU spec is RFC and not merged, I'm worried it might
>>> change. I'd rather review this patch again once the QEMU spec
>>> update is accepted/merged.
>>
>> Igor's QEMU work is now upstream: 3e08b2b9cb64..3a61c8db9d25
>>
>> Can you please re-check this patch? No changes should be necessary.
>>
>> In particular,
>>
>> - QEMU commit e6d0c3ce6895 ("acpi: cpuhp: introduce 'Command data 2'
>> field", 2020-01-22) covers the definition of QEMU_CPUHP_R_CMD_DATA2, in
>> this patch,
>>
>> - QEMU commit ae340aa3d256 ("acpi: cpuhp: spec: add typical usecases",
>> 2020-01-22), section "detect and enable modern CPU hotplug interface",
>> matches the QEMU_CPUHP_R_CMD_DATA2 usage in the next patch of this
>> series.
>
> Re-checked correctly. Thanks for waiting/tracking it get merged.
>
> My Reviewed-by stands.
>
>>> Reviewed-by: Philippe Mathieu-Daude <[email protected]>
Thank you. I've also retested it now; it works.
Merged via <https://github.com/tianocore/edk2/pull/319>; commit range
c8b8157e126a..83357313dd67.
Thanks!
Laszlo
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#53531): https://edk2.groups.io/g/devel/message/53531
Mute This Topic: https://groups.io/mt/36465006/21656
Group Owner: [email protected]
Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
