On 01/24/20 03:10, Michael D Kinney wrote: > Add maintainers and reviewers for UnitTestFrameworkPkg > > Cc: Sean Brogan <sean.bro...@microsoft.com> > Cc: Bret Barkelew <bret.barke...@microsoft.com> > Cc: Andrew Fish <af...@apple.com> > Cc: Laszlo Ersek <ler...@redhat.com> > Cc: Leif Lindholm <l...@nuviainc.com> > Signed-off-by: Michael D Kinney <michael.d.kin...@intel.com> > --- > Maintainers.txt | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Maintainers.txt b/Maintainers.txt > index ca9da28925..91059db937 100644 > --- a/Maintainers.txt > +++ b/Maintainers.txt > @@ -479,6 +479,13 @@ M: Guo Dong <guo.d...@intel.com> > M: Benjamin You <benjamin....@intel.com> > S: Maintained > > +UnitTestFrameworkPkg > +F: UnitTestFrameworkPkg/ > +M: Michael D Kinney <michael.d.kin...@intel.com> > +R: Sean Brogan <sean.bro...@microsoft.com> > +R: Bret Barkelew <bret.barke...@microsoft.com> > +S: Maintained > + > StandaloneMmPkg > F: StandaloneMmPkg/ > M: Ard Biesheuvel <ard.biesheu...@linaro.org> >
The additions look good, but they seem to be added in the (alphabetically) wrong place. Hmm wait, the disorder is already there, from earlier: StandaloneMmPkg shouldn't have been introduced at the end of the file, in commit 2b85beae0b2e, but inserted between "SourceLevelDebugPkg" and "StdLib". At this moment (master @ 9a1f14ad721b), we should move the StandaloneMmPkg section between SourceLevelDebugPkg and UefiCpuPkg. For this patch: Reviewed-by: Laszlo Ersek <ler...@redhat.com> and I'll file a BZ about fixing the order of StandaloneMmPkg. Thanks, Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#53471): https://edk2.groups.io/g/devel/message/53471 Mute This Topic: https://groups.io/mt/70061171/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
