On 01/20/20 10:11, Philippe Mathieu-Daudé wrote: > Hi Liming, > > On 1/9/20 6:35 AM, Feng, Bob C wrote: >> Reviewed-by: Bob Feng <bob.c.f...@intel.com> > > Is the Review-by tag from Bob enough to get this patch merged?
Yes, see the "M" role: BaseTools F: BaseTools/ W: https://github.com/tianocore/tianocore.github.io/wiki/BaseTools M: Bob Feng <bob.c.f...@intel.com> M: Liming Gao <liming....@intel.com> ... In fact, the patch has been committed as 2649a735b249e. Unfortunately: - your name has been messed up in the "Author" meta-datum :( - we don't directly know who committed the patch, becaus "Committer" only says "mergify[bot]" Now, based on the subject and the commit date of the patch, I can find some related notification emails in my "github.com email notifications" folder. From those, the revelant (merged) GitHub PR seems to be: https://github.com/tianocore/edk2/pull/283 I agree it's annoying to not have confirmation on the mailing list, directly in your patch's thread. The only thing I can recommend is, check the git history periodically, for recently committed patches, authored by yourself. Personally, on the maintainer side, I always make sure to confirm a merge on-list, separately. Thanks Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#53401): https://edk2.groups.io/g/devel/message/53401 Mute This Topic: https://groups.io/mt/69378760/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
