Re: [edk2-devel] [PATCH v2] UefiCpuPkg/PiSmmCpuDxeSmm: Use NonSmm BSP as default SMM BSP.

On 11/20/23 04:10, Zhiguang Liu wrote: > Currently, if BSP election is not enabled, will use Core0 as SMM BSP. > However, Core0 does not always have the highest performance. > So, we can used NonSmm BSP as default BSP. > This will take effect in normal SMM init flow and S3 boot flow > > Cc: Ray Ni

Re: [edk2-discuss] [edk2-devel] Soft Feature Freeze starts now for edk2-stable202311

Hi Leif, Please see my response inline marked [SAMI]. Regards, Sami Mujawar On 09/11/2023, 13:12, "disc...@edk2.groups.io on behalf of Leif Lindholm via groups.io" mailto:disc...@edk2.groups.io> on behalf of quic_llindhol=quicinc@groups.io

Re: [edk2-devel] [PATCH 1/1] StandaloneMmPkg/Core: Restart dispatcher once MmEntryPoint is registered

On 11/20/23 09:30, Xu, Wei6 wrote: > Defer the dispatch of the remaining MM drivers once the CPU driver has > been dispatched. > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4599 > > In MmDispatcher, return immediately if the MM Entry Point was registered. > Then the MM IPL will reinvoke t

Re: [edk2-discuss] [edk2-devel] Soft Feature Freeze starts now for edk2-stable202311

On 2023-11-22 11:11, Sami Mujawar wrote: Hi Leif, Please see my response inline marked [SAMI]. On the whole, tagging edk2-platforms at the same time as we tag the main repo is unlikely to be beneficial. We'll need to introduce a freeze of the platforms tree once the main repo stable tag is mad

[edk2-devel] [PATCH 1/1] BaseTools/Scripts/PatchCheck.py: Check for Change-id

Code review tools like gerrit might use a 'Change-id' tag to track the evolution of patches. This tag should be removed before submitting a patch to the mailing-list. It has been observed that contributors sometimes forget to remove this tag. Add a check in PatchCheck.py to automate this. Also add

Re: [edk2-discuss] [edk2-devel] Soft Feature Freeze starts now for edk2-stable202311

W dniu 22.11.2023 o 13:26, Leif Lindholm pisze: On 2023-11-22 11:11, Sami Mujawar wrote: [SAMI] The proposal above looks good to me. This may be slightly off topic, but can we also enable edk2-platform upstream CI as well, please? This would be helpful to catch issues much earlier. [/SAMI]

Re: [edk2-discuss] [edk2-devel] Soft Feature Freeze starts now for edk2-stable202311

On 2023-11-22 13:21, Marcin Juszkiewicz wrote: W dniu 22.11.2023 o 13:26, Leif Lindholm pisze: On 2023-11-22 11:11, Sami Mujawar wrote: [SAMI] The proposal above looks good to me. This may be slightly off topic, but can we also enable edk2-platform upstream CI as well, please? This would be

Re: [edk2-devel] [PATCH 1/1] StandaloneMmPkg/Core: Restart dispatcher once MmEntryPoint is registered

On Wed, 22 Nov 2023 at 12:45, Laszlo Ersek wrote: > ... > (3) Most importantly, speaking to a larger context, I don't understand > how this patch can work *at all*. > > Namely, I can find no MM IPL inside edk2! > > The DXE and MM dispatcher are supposed to work together in the following > way: > >

Re: [edk2-devel] [PATCH edk2-platforms 1/1] set WritePolicyValid for all cache types

On Wed, Nov 15, 2023 at 13:46:08 +0100, Marcin Juszkiewicz wrote: > acpiview complains: > > ERROR: On Arm based systems, all cache properties must be provided in > the cache type structure. Missing 'Write Policy Valid' flag. > > ACPI specification says: > > > Set to 1 if the write policy attribu

Re: [edk2-devel] [PATCH v3 1/5] DesignWare/DwEmmcDxe: Enabled Internal IDMAC interrupt RX/TX register

On Fri, 3 Nov 2023 at 03:52, John Chew wrote: > > From: mindachen1987 > > Remove DMA enable in CTRL register > Added DMA polling handling for RX/TX > This describes what the patch does, but not why. Please elaborate on what the problem is and why the changes in the patch are a suitable solution.

Re: [edk2-devel] [PATCH v3 2/5] DesignWare/DwEmmcDxe: Add CPU little endian option

On Fri, 3 Nov 2023 at 03:52, John Chew wrote: > > From: mindachen1987 > > Add PCD for little endian CPU. During RX, the endianess of data receive > via DMA will be swap. > I take it this means that the IP can be synthesized in both little and big endian versions, right? Is there no ID register i

Re: [edk2-devel] [PATCH v3 3/5] DesignWare/DwEmmcDxe: Remove ARM dependency library

On Fri, 3 Nov 2023 at 03:52, John Chew wrote: > > From: mindachen1987 > > This driver do not have dependency on ArmLib. It will cause compilation > error when compile with risv architecture. > > Cc: Sunil V L > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Cc: Michael D Kinney > Cc: Li Yong > Sig

Re: [edk2-devel] [PATCH v3 4/5] DesignWare/DwEmmcDxe: Add handling for SDMMC

On Fri, 3 Nov 2023 at 03:53, John Chew wrote: > > From: mindachen1987 > > Add base address PCD for eMMC and SDMMC > Add application command for SDMMC > Add PCD for Ultra High Speed (UHS) option > Why is this a single patch? If your commit log contains an enumeration of the changes, it is usually

Re: [edk2-devel] [PATCH v3 5/5] DesignWare/DwEmmcDxe: Force DMA buffer to allocate below 4GB

On Fri, 3 Nov 2023 at 03:53, John Chew wrote: > > The buffer address passed into the read/write block function sometimes > larger than 4GB. This driver only support 32-bit DMA addressing. > MMC timeout will occur if DMA buffer is allocated in 64-bit address. > > Cc: Sunil V L > Cc: Leif Lindholm

Re: [edk2-devel] [PATCH v3 11/39] UefiCpuPkg: Add LoongArch64 CPU Timer library

On 11/17/23 11:00, Chao Li wrote: > Add the LoongArch64 CPU Timer library, using CPUCFG 0x4 and 0x5 for > Stable Counter frequency. > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4584 > > Cc: Eric Dong > Cc: Ray Ni > Cc: Rahul Kumar > Cc: Gerd Hoffmann > Signed-off-by: Chao Li > ---

Re: [edk2-devel] [PATCH v3 11/39] UefiCpuPkg: Add LoongArch64 CPU Timer library

On 11/22/23 17:12, Laszlo Ersek wrote: > On 11/17/23 11:00, Chao Li wrote: >> + >> + if (!BaseFreq || !ClockMultiplier || !ClockDivide) { > > (13) The edk2 coding style does not like scalar types *other* than > BOOLEAN to be used in logical context. Please rewrite as: > > (BaseFreq == 0) || (

Re: [edk2-devel] [Patch V7 2/2] UefiCpuPkg/MpInitLib: Update the comments of _CPU_MP_DATA.

On 11/21/23 03:35, Yuanhao Xie wrote: > No functional changes in this patch. > > Updates the comments of _CPU_MP_DATA to delcared that duplications in > CpuMpData are present to avoid to be direct accessed and comprehended > in assembly code. CpuMpData: Intended for use in C code while > Exchang

Re: [edk2-devel] [PATCH v6 1/6] MdePkg: Add macro definitions for CET feature for NASM files.

On 11/21/23 08:53, Ni, Ray wrote: > You might need to drop Reviewed-by from Laszlo as the patch content is so > different than the reviewed version. > > Reviewed-by: Ray Ni > > > > Thanks, > Ray >> -Original Message- >> From: Sheng, W >> Sent: Tuesday, November 21, 2023 3:03 PM >> To

Re: [edk2-devel] [Patch V2 1/3] UefiCpuPkg/MpInitLib:Repeat WakeUpAp of loading microcode,Syncing MTRR.

On 11/21/23 08:39, Yuanhao Xie wrote: > This patch replicates the WakeUpAp operation, encompassing both > microcode loading and MTRR synchronization, regardless of whether > MpHandOff is NULL. > > The purpose of this patch is to enhance the review process. > The separation in this patch is aimed a

Re: [edk2-devel] [Patch V2 2/3] UefiCpuPkg/MpInitLib: Detect microcode and store MTRR when CpuCount > 1

On 11/21/23 08:39, Yuanhao Xie wrote: > Detect and apply Microcode on BSP, store BSP's MTRR setting only when > CpuCount > 1. > > The purpose of this patch is to enhance the review process. > The separation in this patch is aimed at facilitating a more > straightforward review, with the ultimate g

Re: [edk2-devel] [Patch V2 2/3] UefiCpuPkg/MpInitLib: Detect microcode and store MTRR when CpuCount > 1

On 11/22/23 18:03, Laszlo Ersek wrote: > On 11/21/23 08:39, Yuanhao Xie wrote: >> Detect and apply Microcode on BSP, store BSP's MTRR setting only when >> CpuCount > 1. >> >> The purpose of this patch is to enhance the review process. >> The separation in this patch is aimed at facilitating a more

Re: [edk2-devel] [Patch V2 2/3] UefiCpuPkg/MpInitLib: Detect microcode and store MTRR when CpuCount > 1

On 11/22/23 18:06, Laszlo Ersek wrote: > On 11/22/23 18:03, Laszlo Ersek wrote: >> On 11/21/23 08:39, Yuanhao Xie wrote: >>> Detect and apply Microcode on BSP, store BSP's MTRR setting only when >>> CpuCount > 1. >>> >>> The purpose of this patch is to enhance the review process. >>> The separation

Re: [edk2-devel] [Patch V2 3/3] UefiCpuPkg/MpInitLib: Eliminate redundant microcode loading in DXE.

On 11/21/23 08:39, Yuanhao Xie wrote: > The DXE stage's Microcode loading process has been elimincated by: > > 1. Microcode HOB consumption in MP initialization within the DXE phase. > 2. Restricting MicrocodeDetect to the PEI phase instead of DXE for BSP. > 3. BSP now WakeUpAp only for synchroniz

Re: [edk2-discuss] [edk2-devel] Soft Feature Freeze starts now for edk2-stable202311

On Wed, Nov 22, 2023 at 1:49 PM Leif Lindholm wrote: > > On 2023-11-22 13:21, Marcin Juszkiewicz wrote: > > W dniu 22.11.2023 o 13:26, Leif Lindholm pisze: > >> On 2023-11-22 11:11, Sami Mujawar wrote: > > > >>> [SAMI] The proposal above looks good to me. This may be slightly off > >>> topic, but

[edk2-devel] [PATCH 0/3] RedfishPkg: refine HiiUtilityLib and fix USB NIC discovering

This patch series involves the following changes: 1. fix memory leak and add explicit variable initialization in HiiUtilityLib 2. fix MAC address comparison during USB NIC discovering. Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin

[edk2-devel] [PATCH 1/3] RedfishPkg: fix memory leak in HiiUtilityLib

Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin --- RedfishPkg/Library/HiiUtilityLib/HiiUtilityLib.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/RedfishPkg/Library/HiiUtilityLib/HiiUtilityLib.c b/RedfishPkg/Library/HiiUtilityLib/HiiUtilityLib.c ind

[edk2-devel] [PATCH 2/3] RedfishPkg: add explicit variable initialization

Ancient GCC 4.8.5 warned about variable may be unitialied. And it doesn't look like false alarm. The warning is: edk2/RedfishPkg/Library/HiiUtilityLib/HiiUtilityInternal.c: In function 'GetQuestionDefault': edk2/RedfishPkg/Library/HiiUtilityLib/HiiUtilityInternal.c:5519:6: error: 'ConfigAccess'

[edk2-devel] [PATCH 3/3] RedfishPkg: fix searching for the BMC-exposed USB NIC

According to RedfishPkg/Readme.md document: "The last byte of host-end USB NIC MAC address is the last byte of BMC-end USB NIC MAC address minus 1." It is necessary to subtract 1 from IpmiLanChannelMacAddress. Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin

[edk2-devel] [PATCH v2 0/3] RedfishPkg: refine HiiUtilityLib and fix USB NIC discovering

v2: removed --transfer-encoding=base64 from `git send-email` command line as it has broken patch format as I can see from the mailing list. v1: This patch series involves the following changes: 1. fix memory leak and add explicit variable initialization in HiiUtilityLib 2. fix MAC addres

[edk2-devel] [PATCH v2 1/3] RedfishPkg: fix memory leak in HiiUtilityLib

Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin --- RedfishPkg/Library/HiiUtilityLib/HiiUtilityLib.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/RedfishPkg/Library/HiiUtilityLib/HiiUtilityLib.c b/RedfishPkg/Library/HiiUtilityLib/HiiUtilityLib.c ind

[edk2-devel] [PATCH v2 2/3] RedfishPkg: add explicit variable initialization

Ancient GCC 4.8.5 warned about variable may be unitialied. And it doesn't look like false alarm. The warning is: edk2/RedfishPkg/Library/HiiUtilityLib/HiiUtilityInternal.c: In function 'GetQuestionDefault': edk2/RedfishPkg/Library/HiiUtilityLib/HiiUtilityInternal.c:5519:6: error: 'ConfigAccess'

[edk2-devel] [PATCH v2 3/3] RedfishPkg: fix searching for the BMC-exposed USB NIC

According to RedfishPkg/Readme.md document: "The last byte of host-end USB NIC MAC address is the last byte of BMC-end USB NIC MAC address minus 1." It is necessary to subtract 1 from IpmiLanChannelMacAddress. Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin

Re: [edk2-devel] [PATCH v2 1/3] RedfishPkg: fix memory leak in HiiUtilityLib

Thanks for fixing memory leak issue. Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: Mike Maslenkin > Sent: Thursday, November 23, 2023 8:01 AM > To: devel@edk2.groups.io > Cc: abner.ch...@amd.com; Nickle Wang ; > ig...@ami.com > Subject: [PATCH v2 1/3] RedfishPkg

Re: [edk2-devel] [PATCH v2 2/3] RedfishPkg: add explicit variable initialization

Yes, it is an issue. Thanks! Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: Mike Maslenkin > Sent: Thursday, November 23, 2023 8:01 AM > To: devel@edk2.groups.io > Cc: abner.ch...@amd.com; Nickle Wang ; > ig...@ami.com > Subject: [PATCH v2 2/3] RedfishPkg: add ex

Re: [edk2-devel] [PATCH v2 3/3] RedfishPkg: fix searching for the BMC-exposed USB NIC

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: Mike Maslenkin > Sent: Thursday, November 23, 2023 8:01 AM > To: devel@edk2.groups.io > Cc: abner.ch...@amd.com; Nickle Wang ; > ig...@ami.com > Subject: [PATCH v2 3/3] RedfishPkg: fix searching for the BMC-exposed

Re: [edk2-devel] [Patch V3 1/3] UefiCpuPkg/MpInitLib: Eliminate redundant microcode loading in DXE.

> - MicrocodeDetect (CpuMpData, ProcessorNumber); > - // > - // Sync BSP's MTRR table to AP > + // Synchronizing the MTRR table to the AP is always essential. > + // During the DXE phase, it cannot be omitted like loading microcode, > + // as the PEI and DXE may be in different bit modes.

Re: [edk2-devel] [Patch V3 1/3] UefiCpuPkg/MpInitLib: Eliminate redundant microcode loading in DXE.

> > - if (!GetMicrocodePatchInfoFromHob ( > - &CpuMpData->MicrocodePatchAddress, > - &CpuMpData->MicrocodePatchRegionSize > - )) > - { Can you delete the GetMicrocodePathInfoFromHob() in this patch instead of the 3rd patch? -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You

Re: [edk2-devel] [PATCH v2 3/3] RedfishPkg: fix searching for the BMC-exposed USB NIC

[AMD Official Use Only - General] HI Nickle and Mike, I also have some fixes and revised BMC USB NIC library for searching BMC exposed NIC. Please don't not merge this patch set just for now. I will review this and compare with the changes I have. Thanks Abner > -Original Message- > Fr

Re: [edk2-devel] [Patch V3 2/3] UefiCpuPkg/MpInitLib: Store MTRRs settings only when CpuCount>1

Reviewed-by: Ray Ni Thanks, Ray > -Original Message- > From: Xie, Yuanhao > Sent: Wednesday, November 22, 2023 2:09 PM > To: devel@edk2.groups.io > Cc: Xie, Yuanhao ; Ni, Ray ; > Dong, Eric ; Kumar, Rahul R > ; Tom Lendacky ; > Laszlo Ersek > Subject: [Patch V3 2/3] UefiCpuPkg/MpInitLib

Re: [edk2-devel] [Patch V3 3/3] UefiCpuPkg/MpInitLib: Extract Dump Microcode Revision as function.

> VOID > -ShadowMicrocodeUpdatePatch ( > - IN OUT CPU_MP_DATA *CpuMpData > +DumpMicrocodeRevision ( > + IN CPU_MP_DATA *CpuMpData >) > { > - EFI_STATUS Status; > + UINT32 ThreadId; > + UINT32 ExpectedMicrocodeRevision; > + CPU_INFO_IN_HOB *CpuInfoInHob; > + UINT

Re: [edk2-devel] edk2 uncrustify update (73.0.8)?

On Fri, Nov 17, 2023 at 9:08 AM Laszlo Ersek wrote: > > On 11/16/23 09:29, Pedro Falcato wrote: > > On Tue, Nov 14, 2023 at 3:01 PM Laszlo Ersek wrote: > >> > >> On 11/13/23 22:33, Pedro Falcato wrote: > >>> On Mon, Nov 13, 2023 at 8:37 PM Rebecca Cran wrote: > > On 11/13/2023 1:08 PM,

Re: [edk2-devel] [PATCH 1/1] StandaloneMmPkg/Core: Restart dispatcher once MmEntryPoint is registered

> + gRequestDispatch = TRUE; > + gDispatcherRunning = FALSE; 1. It's good to set RequestDispatch to TRUE as it exits unconditionally and very likely more drivers can be dispatched later. 2. Since StandaloneMmCore registers a SMI handler, it's possible that some SMM driver ent

Re: [edk2-devel] edk2 uncrustify update (73.0.8)?

On Thu, Nov 16, 2023 at 5:36 PM Michael Kubacki wrote: > This is the first time Uncrustify has been updated in edk2 since Dec 7, > 2021. > > https://github.com/tianocore/edk2/commits/master/.pytool/Plugin/UncrustifyCheck/uncrustify_ext_dep.yaml > > Its configuration has also not changed during tha

Re: [edk2-devel] [PATCH 1/1] BaseTools/Scripts/PatchCheck.py: Check for Change-id

On Wed, Nov 22, 2023 at 1:15 PM PierreGondois wrote: > > Code review tools like gerrit might use a 'Change-id' tag to track > the evolution of patches. This tag should be removed before > submitting a patch to the mailing-list. > It has been observed that contributors sometimes forget to remove >

Re: [edk2-devel] [PATCH v2 3/3] RedfishPkg: fix searching for the BMC-exposed USB NIC

[AMD Official Use Only - General] Reviewed-by: Abner Chang Mike, could you please create a PR for this patch set? Thanks Abner > -Original Message- > From: Mike Maslenkin > Sent: Thursday, November 23, 2023 8:01 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; nick...@nvidia.com; >

Re: [edk2-devel] [PATCH v2 3/3] RedfishPkg: fix searching for the BMC-exposed USB NIC

[AMD Official Use Only - General] Good to go. We can merge this after code freeze. Abner > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chang, > Abner via groups.io > Sent: Thursday, November 23, 2023 9:20 AM > To: Nickle Wang ; Mike Maslenkin > ; devel@edk2.groups.io >

[edk2-devel] [PATCH v3] UefiCpuPkg/PiSmmCpuDxeSmm: Use NonSmm BSP as default SMM BSP.

Currently, if BSP election is not enabled, will use Core0 as SMM BSP. However, Core0 does not always have the highest performance. So, we can used NonSmm BSP as default BSP. This will take effect in normal SMM init flow and S3 boot flow. In normal SMM flow, the code is executed in Non-SMM mode. In

[edk2-devel] [PATCH v2] CloudHv: Add CI for CloudHv on AArch64

Add the long lost CI for CloudHv on AArch64. As CloudHv CI works nearly the same way with other VMMs like KvmTool, thus we can easily create its CI configuration based on KvmTool. Reviewed-by: Laszlo Ersek Signed-off-by: Jianyong Wu --- .../PlatformCI/.azurepipelines/Ubuntu-GCC5.yml | 13 +

[edk2-devel] [Proposed Fix][PATCH v1 1/1] MdeModulePkg/DxeCapsuleLibFmp: Fix crash with VirtualAddressMap omitted

If the SetVirtualAddressMap() is not called, mIsVirtualAddrConverted is FALSE and the kernel crash occurs in IsNestedFmpCapsule() when executing gBS->LocateProtocol () in the else case. To serve the omitted SetVirtualAddressMap() call, we could just check mEsrtTable presence instead of relying on

[edk2-devel] [PATCH 0/6] Refine BMC USB NIC discovery and Redfish service enablement

From: Abner Chang This patch set updates the algorithm of BMC USB NIC discovery and fixes some bugs. - Add a new protocol to trigger the notification of Redfish Host Interface readiness. This fixes the issue Redfish config handler driver acquires Redfish service before Redfish Host Inter

[edk2-devel] [PATCH 2/6] RedfishPkg/RedfishHostInterfaceDxe: Add Redfish HI readiness notification

From: Abner Chang Introduce gEdkIIRedfishHostInterfaceReadyProtocolGuid and produce it when Redfish Host Interface is installed on system. Signed-off-by: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Cc: Mike Maslenkin --- RedfishPkg/RedfishPkg.dec| 3 +++ .../Re

[edk2-devel] [PATCH 3/6] RedfishPkg/RedfishConfigHandler: Use Redfish HI readiness notification

From: Abner Chang Wait until Redfish Host Interface is installed on the system then acquire Redfish service. Signed-off-by: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Cc: Mike Maslenkin --- .../RedfishConfigHandlerDriver.inf| 9 +- .../RedfishConfigHandlerDriver.c

[edk2-devel] [PATCH 1/6] RedfishPkg/BmcUsbNicLib: Update BMC USB NIC searching algorithm

From: Abner Chang Update BMC USB NIC searching algorithm for IPv4 only. Signed-off-by: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Cc: Mike Maslenkin --- .../PlatformHostInterfaceBmcUsbNicLib.c | 188 -- 1 file changed, 128 insertions(+), 60 deletions(-) diff --g

[edk2-devel] [PATCH 4/6] RedfishPkg/RedfishConfigHandler: Correct the prototype of callback function

From: Abner Chang Signed-off-by: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Cc: Mike Maslenkin --- RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerDriver.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerDr

[edk2-devel] [PATCH 5/6] RedfishPkg/RedfishDiscovery: Add more debug message

From: Abner Chang Signed-off-by: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Cc: Mike Maslenkin --- .../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c b/RedfishPkg/Red

[edk2-devel] [PATCH 6/6] RedfishPkg/RedfishDiscovery: Refine SMBIOS 42h code

From: Abner Chang Refine SMBIOS 42h code add mode debug message for the error conditions. Signed-off-by: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Cc: Mike Maslenkin --- .../RedfishDiscoverInternal.h | 2 ++ .../RedfishSmbiosHostInterface.c | 20

[edk2-devel] [PATCH V2 0/8] Refine BMC USB NIC discovery and Redfish service enablement

From: Abner Chang In V2: Send additional two patches those are missed in V1. This patch set updates the algorithm of BMC USB NIC discovery and fixes some bugs. - Add a new protocol to trigger the notification of Redfish Host Interface readiness. This fixes the issue Redfish config ha

[edk2-devel] [PATCH V2 1/8] RedfishPkg/BmcUsbNicLib: Update BMC USB NIC searching algorithm

From: Abner Chang Update BMC USB NIC searching algorithm for IPv4 only. Signed-off-by: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Cc: Mike Maslenkin --- .../PlatformHostInterfaceBmcUsbNicLib.c | 188 -- 1 file changed, 128 insertions(+), 60 deletions(-) diff --g

[edk2-devel] [PATCH V2 2/8] RedfishPkg/RedfishHostInterfaceDxe: Add Redfish HI readiness notification

From: Abner Chang Introduce gEdkIIRedfishHostInterfaceReadyProtocolGuid and produce it when Redfish Host Interface is installed on system. Signed-off-by: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Cc: Mike Maslenkin --- RedfishPkg/RedfishPkg.dec| 3 +++ .../Re

[edk2-devel] [PATCH V2 4/8] RedfishPkg/RedfishConfigHandler: Correct the prototype of callback function

From: Abner Chang Signed-off-by: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Cc: Mike Maslenkin --- RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerDriver.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerDr

[edk2-devel] [PATCH V2 5/8] RedfishPkg/RedfishDiscovery: Add more debug message

From: Abner Chang Signed-off-by: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Cc: Mike Maslenkin --- .../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c b/RedfishPkg/Red

[edk2-devel] [PATCH V2 7/8] RedfishPkg/HostInterfaceBmcUsbNic: Fix incorrect reference of MAC address pointer

From: Abner Chang MAC address reference is incorrect when it is copied to Host Interface DeviceDescriptor. Signed-off-by: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Cc: Mike Maslenkin --- .../PlatformHostInterfaceBmcUsbNicLib.c | 2 +- 1 file changed, 1 inserti

[edk2-devel] [PATCH V2 8/8] RedfishPkg/HostInterfaceBmcUsbNic: Fix incorrect HI protocol record size

From: Abner Chang The size of structure must be minus with byte that is occupied by the initial array. Signed-off-by: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Cc: Mike Maslenkin --- .../PlatformHostInterfaceBmcUsbNicLib.c | 4 ++-- 1 file changed, 2 insertions(

[edk2-devel] [PATCH V2 6/8] RedfishPkg/RedfishDiscovery: Refine SMBIOS 42h code

From: Abner Chang Refine SMBIOS 42h code add mode debug message for the error conditions. Signed-off-by: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Cc: Mike Maslenkin --- .../RedfishDiscoverInternal.h | 2 ++ .../RedfishSmbiosHostInterface.c | 20

[edk2-devel] [PATCH V2 3/8] RedfishPkg/RedfishConfigHandler: Use Redfish HI readiness notification

From: Abner Chang Wait until Redfish Host Interface is installed on the system then acquire Redfish service. Signed-off-by: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Cc: Mike Maslenkin --- .../RedfishConfigHandlerDriver.inf| 9 +- .../RedfishConfigHandlerDriver.c