On Wed, Nov 15, 2023 at 13:46:08 +0100, Marcin Juszkiewicz wrote:
> acpiview complains:
>
> ERROR: On Arm based systems, all cache properties must be provided in
> the cache type structure. Missing 'Write Policy Valid' flag.
>
> ACPI specification says:
>
> > Set to 1 if the write policy attribute described is valid. A value
> > of 0 indicates that, where possible, processor architecture specific
> > discovery mechanisms should be used to ascertain the value of this
> > attribute.
>
> Signed-off-by: Marcin Juszkiewicz <marcin.juszkiew...@linaro.org>
Reviewed-by: Leif Lindholm <quic_llind...@quicinc.com>
Pushed as 10e2eb030de3.
Thanks!
> ---
> Silicon/Qemu/SbsaQemu/Include/IndustryStandard/SbsaQemuAcpi.h | 2 +-
> Platform/RaspberryPi/AcpiTables/Pptt.aslc | 2 +-
> Silicon/Marvell/Armada7k8k/AcpiTables/Pptt.aslc | 2 +-
> Silicon/Marvell/OcteonTx/AcpiTables/T91/Pptt.aslc | 2 +-
> Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Pptt.aslc | 2 +-
> Silicon/Socionext/SynQuacer/AcpiTables/Pptt.aslc | 2 +-
> 6 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/Silicon/Qemu/SbsaQemu/Include/IndustryStandard/SbsaQemuAcpi.h
> b/Silicon/Qemu/SbsaQemu/Include/IndustryStandard/SbsaQemuAcpi.h
> index 983d17f6fa50..61d8bce8c959 100644
> --- a/Silicon/Qemu/SbsaQemu/Include/IndustryStandard/SbsaQemuAcpi.h
> +++ b/Silicon/Qemu/SbsaQemu/Include/IndustryStandard/SbsaQemuAcpi.h
> @@ -126,7 +126,7 @@ typedef struct {
> 1, /* AssociativityValid */
> \
> 1, /* AllocationTypeValid */
> \
> 1, /* CacheTypeValid */
> \
> - 0, /* WritePolicyValid */
> \
> + 1, /* WritePolicyValid */
> \
> 1, /* LineSizeValid */
> \
> },
> \
> 0, /* NextLevelOfCache */
> \
> diff --git a/Platform/RaspberryPi/AcpiTables/Pptt.aslc
> b/Platform/RaspberryPi/AcpiTables/Pptt.aslc
> index a52bc5a31adf..b80f5ff1e057 100644
> --- a/Platform/RaspberryPi/AcpiTables/Pptt.aslc
> +++ b/Platform/RaspberryPi/AcpiTables/Pptt.aslc
> @@ -114,7 +114,7 @@ typedef struct {
> 1, /* AssociativityValid */
> \
> 1, /* AllocationTypeValid */
> \
> 1, /* CacheTypeValid */
> \
> - 0, /* WritePolicyValid */
> \
> + 1, /* WritePolicyValid */
> \
> 1, /* LineSizeValid */
> \
> },
> \
> 0, /* NextLevelOfCache */
> \
> diff --git a/Silicon/Marvell/Armada7k8k/AcpiTables/Pptt.aslc
> b/Silicon/Marvell/Armada7k8k/AcpiTables/Pptt.aslc
> index e03bfcd6211d..f3a9b90fb564 100644
> --- a/Silicon/Marvell/Armada7k8k/AcpiTables/Pptt.aslc
> +++ b/Silicon/Marvell/Armada7k8k/AcpiTables/Pptt.aslc
> @@ -94,7 +94,7 @@ typedef struct {
> 1, /* AssociativityValid */
> \
> 1, /* AllocationTypeValid */
> \
> 1, /* CacheTypeValid */
> \
> - 0, /* WritePolicyValid */
> \
> + 1, /* WritePolicyValid */
> \
> 1, /* LineSizeValid */
> \
> },
> \
> 0, /* NextLevelOfCache */
> \
> diff --git a/Silicon/Marvell/OcteonTx/AcpiTables/T91/Pptt.aslc
> b/Silicon/Marvell/OcteonTx/AcpiTables/T91/Pptt.aslc
> index f37c7511134d..3793cbbca0b5 100644
> --- a/Silicon/Marvell/OcteonTx/AcpiTables/T91/Pptt.aslc
> +++ b/Silicon/Marvell/OcteonTx/AcpiTables/T91/Pptt.aslc
> @@ -94,7 +94,7 @@ typedef struct {
> 1, /* AssociativityValid */
> \
> 1, /* AllocationTypeValid */
> \
> 1, /* CacheTypeValid */
> \
> - 0, /* WritePolicyValid */
> \
> + 1, /* WritePolicyValid */
> \
> 1, /* LineSizeValid */
> \
> },
> \
> 0, /* NextLevelOfCache */
> \
> diff --git a/Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Pptt.aslc
> b/Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Pptt.aslc
> index ae1a21df23b9..04652653563e 100644
> --- a/Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Pptt.aslc
> +++ b/Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Pptt.aslc
> @@ -92,7 +92,7 @@ typedef struct {
> 1, /* AssociativityValid */
> \
> 1, /* AllocationTypeValid */
> \
> 1, /* CacheTypeValid */
> \
> - 0, /* WritePolicyValid */
> \
> + 1, /* WritePolicyValid */
> \
> 1, /* LineSizeValid */
> \
> },
> \
> 0, /* NextLevelOfCache */
> \
> diff --git a/Silicon/Socionext/SynQuacer/AcpiTables/Pptt.aslc
> b/Silicon/Socionext/SynQuacer/AcpiTables/Pptt.aslc
> index e351d82b9763..f3e9149769ea 100644
> --- a/Silicon/Socionext/SynQuacer/AcpiTables/Pptt.aslc
> +++ b/Silicon/Socionext/SynQuacer/AcpiTables/Pptt.aslc
> @@ -91,7 +91,7 @@ typedef struct {
> 1, /* AssociativityValid */
> \
> 1, /* AllocationTypeValid */
> \
> 1, /* CacheTypeValid */
> \
> - 0, /* WritePolicyValid */
> \
> + 1, /* WritePolicyValid */
> \
> 1, /* LineSizeValid */
> \
> },
> \
> 0, /* NextLevelOfCache */
> \
> --
> 2.41.0
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111607): https://edk2.groups.io/g/devel/message/111607
Mute This Topic: https://groups.io/mt/102603819/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe:
https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
