Yes, it is an issue. Thanks!
Reviewed-by: Nickle Wang <nick...@nvidia.com>
Regards,
Nickle
> -----Original Message-----
> From: Mike Maslenkin <mike.maslen...@gmail.com>
> Sent: Thursday, November 23, 2023 8:01 AM
> To: devel@edk2.groups.io
> Cc: abner.ch...@amd.com; Nickle Wang <nick...@nvidia.com>;
> ig...@ami.com
> Subject: [PATCH v2 2/3] RedfishPkg: add explicit variable initialization
>
> External email: Use caution opening links or attachments
>
>
> Ancient GCC 4.8.5 warned about variable may be unitialied.
> And it doesn't look like false alarm.
>
> The warning is:
> edk2/RedfishPkg/Library/HiiUtilityLib/HiiUtilityInternal.c: In function
> 'GetQuestionDefault':
> edk2/RedfishPkg/Library/HiiUtilityLib/HiiUtilityInternal.c:5519:6: error:
> 'ConfigAccess' may be used uninitialized in this function [-Werror=maybe-
> uninitialized]
> if (ConfigAccess != NULL) {
>
> Cc: Abner Chang <abner.ch...@amd.com>
> Cc: Nickle Wang <nick...@nvidia.com>
> Cc: Igor Kulchytskyy <ig...@ami.com>
> Signed-off-by: Mike Maslenkin <mike.maslen...@gmail.com>
> ---
> RedfishPkg/Library/HiiUtilityLib/HiiUtilityInternal.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/RedfishPkg/Library/HiiUtilityLib/HiiUtilityInternal.c
> b/RedfishPkg/Library/HiiUtilityLib/HiiUtilityInternal.c
> index 80b93beae999..b61b7f5fcdcc 100644
> --- a/RedfishPkg/Library/HiiUtilityLib/HiiUtilityInternal.c
> +++ b/RedfishPkg/Library/HiiUtilityLib/HiiUtilityInternal.c
> @@ -5451,6 +5451,7 @@ GetQuestionDefault (
>
>
> Status = EFI_NOT_FOUND;
>
> StrValue = NULL;
>
> + ConfigAccess = NULL;
>
> OriginalDefaultId = DefaultId;
>
> DefaultLink = GetFirstNode (&FormSet->DefaultStoreListHead);
>
>
>
> --
> 2.32.0 (Apple Git-132)
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111632): https://edk2.groups.io/g/devel/message/111632
Mute This Topic: https://groups.io/mt/102759079/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
