On 11/22/23 17:12, Laszlo Ersek wrote:
> On 11/17/23 11:00, Chao Li wrote:
>> +
>> + if (!BaseFreq || !ClockMultiplier || !ClockDivide) {
>
> (13) The edk2 coding style does not like scalar types *other* than
> BOOLEAN to be used in logical context. Please rewrite as:
>
> (BaseFreq == 0) || (ClockMultiplier == 0) || (ClockDivide == 0)
>
>> + DEBUG ((DEBUG_ERROR, "LoongArch Stable Timer is not available in the
>> CPU, hence this library cannot be used.\n"));
>
> (13) I think this line is a bit too long (117 chars). I think the
> currently accepted limit (?) is 100 characters (but I'm unsure).
>
> Recommend to break this up to multiple lines.
>
>> + StableTimerFreq = 0;
>
Sorry, this was a complex and long review; I messed up the comment
numbering -- it seems I made two points (13). :)
Laszlo
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111614): https://edk2.groups.io/g/devel/message/111614
Mute This Topic: https://groups.io/mt/102644766/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe:
https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
