Re: [edk2-devel] [PATCH v9 02/32] UefiCpuPkg/MpInitLib: move SEV specific routines in AmdSev.c

On Wed, Oct 13, 2021 at 11:56:43AM -0500, Brijesh Singh wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 > > Move all the SEV specific function in AmdSev.c. > > No functional change intended. Acked-by: Gerd Hoffmann -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all mes

Re: [edk2-devel] [PATCH v9 03/32] OvmfPkg/ResetVector: move clearing GHCB in SecMain

On Wed, Oct 13, 2021 at 11:56:44AM -0500, Brijesh Singh wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 > > In preparation for SEV-SNP support move clearing of the GHCB memory from > the ResetVector/AmdSev.asm to SecMain/AmdSev.c. The GHCB page is not > accessed until SevEsProtoco

Re: [edk2-devel] [PATCH v9 04/32] OvmfPkg/ResetVector: introduce SEV metadata descriptor for VMM use

On Wed, Oct 13, 2021 at 11:56:45AM -0500, Brijesh Singh wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 > > The OvmfPkgX86 build reserves memory regions in MEMFD. The memory regions > get accessed in the SEC phase. AMD SEV-SNP require that the guest's > private memory be accepted

Re: [edk2-devel] [PATCH v9 05/32] OvmfPkg: reserve SNP secrets page

On Wed, Oct 13, 2021 at 11:56:46AM -0500, Brijesh Singh wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 > > During the SNP guest launch sequence, a special secrets page needs to be > inserted by the VMM. The PSP will populate the page; it will contain the > VM Platform Communicati

Re: [edk2-devel] [PATCH v9 06/32] OvmfPkg: reserve CPUID page

On Wed, Oct 13, 2021 at 11:56:47AM -0500, Brijesh Singh wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 > > Platform features and capabilities are traditionally discovered via the > CPUID instruction. Hypervisors typically trap and emulate the CPUID > instruction for a variety of

Re: [edk2-devel] [PATCH v9 07/32] OvmfPkg/ResetVector: pre-validate the data pages used in SEC phase

On Wed, Oct 13, 2021 at 11:56:48AM -0500, Brijesh Singh wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 > > An SEV-SNP guest requires that private memory (aka pages mapped encrypted) > must be validated before being accessed. > > The validation process consist of the following se

Re: [edk2-devel] [PATCH v9 08/32] OvmfPkg/ResetVector: use SEV-SNP-validated CPUID values

On Wed, Oct 13, 2021 at 11:56:49AM -0500, Brijesh Singh wrote: > From: Michael Roth > > CPUID instructions are issued during early boot to do things like probe > for SEV support. Currently these are handled by a minimal #VC handler > that uses the MSR-based GHCB protocol to fetch the CPUID values

[edk2-devel] [PATCH v1] ArmPkg/Smbios: Fix max cache size 2 wrong issue

As SMBIOS spec, bit-31 of maximum cache size 2 should be 1 for 64K granularity. Signed-off-by: Ming Huang --- ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/Processo

Re: [edk2-devel] [PATCH 1/1] BaseTools: add edk2-test repo to SetupGit.py

Reviewed-by: Bob Feng -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#81977): https://edk2.groups.io/g/devel/message/81977 Mute This Topic: https://groups.io/mt/78148735/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://e

Re: [edk2-devel] [PATCH v9 09/32] OvmfPkg/MemEncryptSevLib: add MemEncryptSevSnpEnabled()

On Wed, Oct 13, 2021 at 11:56:50AM -0500, Brijesh Singh wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 > > Create a function that can be used to determine if VM is running as an > SEV-SNP guest. > > Cc: Michael Roth > Cc: James Bottomley > Cc: Min Xu > Cc: Jiewen Yao > Cc: T

Re: [edk2-devel] [PATCH v9 10/32] OvmfPkg/SecMain: register GHCB gpa for the SEV-SNP guest

On Wed, Oct 13, 2021 at 11:56:51AM -0500, Brijesh Singh wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 > > The SEV-SNP guest requires that GHCB GPA must be registered before using. > See the GHCB specification section 2.3.2 for more details. Acked-by: Gerd Hoffmann -=-=-=-=-

Re: [edk2-devel] [PATCH v9 11/32] OvmfPkg/VmgExitLib: use SEV-SNP-validated CPUID values

On Wed, Oct 13, 2021 at 11:56:52AM -0500, Brijesh Singh wrote: > From: Michael Roth > > SEV-SNP firmware allows a special guest page to be populated with > guest CPUID values so that they can be validated against supported > host features before being loaded into encrypted guest memory to be > us

Re: [edk2-devel] [PATCH v9 12/32] OvmfPkg/PlatformPei: register GHCB gpa for the SEV-SNP guest

On Wed, Oct 13, 2021 at 11:56:53AM -0500, Brijesh Singh wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 > > The SEV-SNP guest requires that GHCB GPA must be registered before using. > See the GHCB specification section 2.3.2 for more details. Acked-by: Gerd Hoffmann -=-=-=-=-

Re: [edk2-devel] [PATCH v9 13/32] OvmfPkg/AmdSevDxe: do not use extended PCI config space

On Wed, Oct 13, 2021 at 11:56:54AM -0500, Brijesh Singh wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 > > Commit 85b8eac59b8c5bd9c7eb9afdb64357ce1aa2e803 added support to ensure > that MMIO is only performed against the un-encrypted memory. If MMIO > is performed against encrypt

Re: [edk2-devel] [PATCH V2 07/28] UefiCpuPkg: Support TDX in BaseXApicX2ApicLib

On October 13, 2021 1:31 PM, Ray Ni wrote: > Min, > Comments below: > > +**/ > +BOOLEAN > +EFIAPI > > 1. EFIAPI is for public lib API. Is this a public API? No, it is not a public API. The EFIAPI will be removed. Thanks for reminder. > > +BaseXApicIsTdxGuest ( > + VOID > + ) > +{ > + UINT32

Re: [edk2-devel] [PATCH v9 14/32] OvmfPkg/MemEncryptSevLib: add support to validate system RAM

On Wed, Oct 13, 2021 at 11:56:55AM -0500, Brijesh Singh wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 > > Many of the integrity guarantees of SEV-SNP are enforced through the > Reverse Map Table (RMP). Each RMP entry contains the GPA at which a > particular page of DRAM should b

Re: [edk2-devel] [PATCH v9 15/32] OvmfPkg/MemEncryptSevLib: add function to check the VMPL0

On Wed, Oct 13, 2021 at 11:56:56AM -0500, Brijesh Singh wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 > > Virtual Machine Privilege Level (VMPL) feature in the SEV-SNP > architecture allows a guest VM to divide its address space into four > levels. The level can be used to provi

Re: [edk2-devel] [PATCH v1 1/1] StandaloneMmPkg: To support CLANGPDB build

Hey Jiyang, NO! Please do not. :) Yes, this fixes build, but the AARCH64 core (I did not check ARM) depends on self-relocation as it is loaded in-place at a location unknown at compile-time. PIE helps ensure there are no relocations in .text among other things. I know CLANGPDB does not support

Re: [edk2-devel] EDK II bug 3066: please merge [PATCH 1/1] BaseTools: add edk2-test repo to SetupGit.py

Created a PR: https://github.com/tianocore/edk2/pull/2064 to merge this patch. -Original Message- From: Heinrich Schuchardt Sent: Wednesday, October 13, 2021 8:06 PM To: Feng, Bob C ; Liming Gao Cc: devel@edk2.groups.io; G Edhaya Chandran ; Chen, Christine Subject: EDK II bug 3066: pl

Re: [edk2-devel] [PATCH v9 16/32] OvmfPkg/BaseMemEncryptSevLib: skip the pre-validated system RAM

On Wed, Oct 13, 2021 at 11:56:57AM -0500, Brijesh Singh wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 > > The MemEncryptSevSnpPreValidateSystemRam() is used for pre-validating the > system RAM. As the boot progress, each phase validates a fixed region of > the RAM. In the PEI ph

Re: [edk2-devel] [PATCH V2 13/28] UefiCpuPkg: Enable Tdx support in MpInitLib

On October 13, 2021 2:01 PM, Ray Ni wrote: > Min, > The change is to provide a totally different MP service in TDX case. > It makes the MpInitLib more complicated. > > How about? > 1. Change CpuMpPei/CpuMpDxe to return directly in TDX case. > 2. Add new TdxCpuMpPei/TdxCpuMpDxe to provide a new set

Re: [edk2-devel] [PATCH v9 17/32] OvmfPkg/MemEncryptSevLib: add support to validate > 4GB memory in PEI phase

On Wed, Oct 13, 2021 at 11:56:58AM -0500, Brijesh Singh wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 > > The initial page built during the SEC phase is used by the > MemEncryptSevSnpValidateSystemRam() for the system RAM validation. The > page validation process requires using

Re: [edk2-devel] [PATCH v9 18/32] OvmfPkg/SecMain: validate the memory used for decompressing Fv

On Wed, Oct 13, 2021 at 11:56:59AM -0500, Brijesh Singh wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 > > The VMM launch sequence should have pre-validated all the data pages used > in the Reset vector. The range does not cover the data pages used during > the SEC phase (mainly

Re: [edk2-devel] [PATCH v9 19/32] OvmfPkg/PlatformPei: validate the system RAM when SNP is active

On Wed, Oct 13, 2021 at 11:57:00AM -0500, Brijesh Singh wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 > > When SEV-SNP is active, a memory region mapped encrypted in the page > table must be validated before access. There are two approaches that > can be taken to validate the sy

Re: [edk2-devel] [PATCH v9 20/32] UefiCpuPkg: Define ConfidentialComputingGuestAttr

Hi, > + ## This dynamic PCD indicates the memory encryption attribute of the guest. > + # @Prompt Memory encryption attribute > + > gUefiCpuPkgTokenSpaceGuid.PcdConfidentialComputingGuestAttr|0|UINT64|0x6017 See discussion in parallel thread. This is probably not the best place for the

Re: [edk2-devel] [PATCH v9 21/32] OvmfPkg/PlatformPei: set PcdConfidentialComputingAttr when SEV is active

On Wed, Oct 13, 2021 at 11:57:02AM -0500, Brijesh Singh wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 > > The MpInitLib uses the ConfidentialComputingAttr PCD to determine whether > AMD SEV is active so that it can use the VMGEXITs defined in the GHCB > specification to create A

Re: [edk2-devel] [PATCH v9 22/32] UefiCpuPkg/MpInitLib: use PcdConfidentialComputingAttr to check SEV status

On Wed, Oct 13, 2021 at 11:57:03AM -0500, Brijesh Singh wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 > > Previous commit introduced a generic confidential computing PCD that can > determine whether AMD SEV-ES is enabled. Update the MpInitLib to drop the > PcdSevEsIsEnabled in f

Re: [edk2-devel] [PATCH v9 23/32] UefiCpuPkg: add PcdGhcbHypervisorFeatures

On Wed, Oct 13, 2021 at 11:57:04AM -0500, Brijesh Singh wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 > > Version 2 of the GHCB specification added a new VMGEXIT that the guest > could use for querying the hypervisor features. One of the immediate > users for it will be an AP cr

Re: [edk2-devel] [PATCH v9 24/32] OvmfPkg/PlatformPei: set the Hypervisor Features PCD

On Wed, Oct 13, 2021 at 11:57:05AM -0500, Brijesh Singh wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 > > Version 2 of the GHCB specification added the support to query the > hypervisor feature bitmap. The feature bitmap provide information > such as whether to use the AP create

Re: [edk2-devel] [PATCH v9 25/32] MdePkg/GHCB: increase the GHCB protocol max version

On Wed, Oct 13, 2021 at 11:57:06AM -0500, Brijesh Singh wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 > > Now that OvmfPkg supports version 2 of the GHCB specification, bump the > protocol version. Acked-by: Gerd Hoffmann -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive

Re: [edk2-devel] [PATCH v9 26/32] UefiCpuPkg/MpLib: add support to register GHCB GPA when SEV-SNP is enabled

On Wed, Oct 13, 2021 at 11:57:07AM -0500, Brijesh Singh wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 > > An SEV-SNP guest requires that the physical address of the GHCB must > be registered with the hypervisor before using it. See the GHCB > specification section 2.3.2 for more

Re: [edk2-devel] [PATCH v9 27/32] UefiCpuPkg/MpInitLib: use BSP to do extended topology check

On Wed, Oct 13, 2021 at 11:57:08AM -0500, Brijesh Singh wrote: > From: Michael Roth > > During AP bringup, just after switching to long mode, APs will do some > cpuid calls to verify that the extended topology leaf (0xB) is available > so they can fetch their x2 APIC IDs from it. In the case of S

Re: [edk2-devel] [PATCH v9 28/32] OvmfPkg/MemEncryptSevLib: change the page state in the RMP table

On Wed, Oct 13, 2021 at 11:57:09AM -0500, Brijesh Singh wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 > > The MemEncryptSev{Set,Clear}PageEncMask() functions are used to set or > clear the memory encryption attribute in the page table. When SEV-SNP > is active, we also need to c

Re: [edk2-devel] [PATCH v9 29/32] OvmfPkg/MemEncryptSevLib: skip page state change for Mmio address

On Wed, Oct 13, 2021 at 11:57:10AM -0500, Brijesh Singh wrote: > The SetMemoryEncDec() is used by the higher level routines to set or clear > the page encryption mask for system RAM and Mmio address. When SEV-SNP is > active, in addition to set/clear page mask it also updates the RMP table. > The R

Re: [edk2-devel] [PATCH v9 30/32] OvmfPkg/PlatformPei: mark cpuid and secrets memory reserved in EFI map

On Wed, Oct 13, 2021 at 11:57:11AM -0500, Brijesh Singh wrote: > When SEV-SNP is active, the CPUID and Secrets memory range contains the > information that is used during the VM boot. The content need to be persist > across the kexec boot. Mark the memory range as Reserved in the EFI map > so that

Re: [edk2-devel] [PATCH v9 31/32] OvmfPkg/AmdSev: expose the SNP reserved pages through configuration table

On Wed, Oct 13, 2021 at 11:57:12AM -0500, Brijesh Singh wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 > > Now that both the secrets and cpuid pages are reserved in the HOB, > extract the location details through fixed PCD and make it available > to the guest OS through the confi

Re: [edk2-devel] [PATCH v9 32/32] UefiCpuPkg/MpInitLib: Use SEV-SNP AP Creation NAE event to launch APs

On Wed, Oct 13, 2021 at 11:57:13AM -0500, Brijesh Singh wrote: > From: Tom Lendacky > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 > > Use the SEV-SNP AP Creation NAE event to create and launch APs under > SEV-SNP. This capability will be advertised in the SEV Hypervisor > Feature S

Re: [edk2-devel] [PATCH v1 1/1] StandaloneMmPkg: To support CLANGPDB build

Hi Marvin, How about we limit the -fno-pie option only apply on IA32 and X64 like below? diff --git a/StandaloneMmPkg/Core/StandaloneMmCore.inf b/StandaloneMmPkg/Core/StandaloneMmCore.inf [BuildOptions] GCC:*_*_*_CC_FLAGS = -fpie GCC:*_*_*_DLINK_FLAGS = -Wl,-z,text,-Bsymbolic,-pie +

Re: [edk2-devel] [PATCH V2 06/28] MdePkg: Update BaseIoLibIntrinsicSev to support Tdx

Hi, > > Hmm, I guess we should move the pcd then so it cam be used more widely. > > Confidential computing has an impact beyond just cpu, it's also memory, io > > and > > more. > How about define ConfidentialComputingAttr PCD in MdePkg.dec? Looks sensible to me. take care, Gerd -=-=-=-=-

Re: [edk2-devel] [PATCH v1 1/1] StandaloneMmPkg: To support CLANGPDB build

Hey Steven, As I said, I prefer my patch, but this would work too of course. I talked about the PIE stuff with Ard before, so maybe he has an opinion on this? :) (Small correction for my last e-mail, of course we are not *guaranteed* there are *no* relocations in .text, but they'd all point t

Re: [edk2-devel] [PATCH v1 1/1] StandaloneMmPkg: To support CLANGPDB build

On Thu, 14 Oct 2021 at 11:08, Marvin Häuser wrote: > > Hey Steven, > > As I said, I prefer my patch, but this would work too of course. > I talked about the PIE stuff with Ard before, so maybe he has an opinion > on this? :) > > (Small correction for my last e-mail, of course we are not *guarantee

Re: [edk2-devel] [PATCH v1 1/1] StandaloneMmPkg: To support CLANGPDB build

Hey Ard, Thanks for commenting! On 14.10.21 11:09, Ard Biesheuvel wrote: On Thu, 14 Oct 2021 at 11:08, Marvin Häuser wrote: Hey Steven, As I said, I prefer my patch, but this would work too of course. I talked about the PIE stuff with Ard before, so maybe he has an opinion on this? :) (Smal

[edk2-devel] [edk2-platforms: PATCH v5 0/9] MinPlatformPkg: Support FSP 2.3 FSP_NON_VOLATILE_STORAGE_HOB2.

V5: Fix GCC build failure in LargeVariableWriteLib.c V4: . Switched to LargeVariableRead(Write)Lib in SaveMemoryConfig driver . Fixed tailing white space issue in PeiLib.c/.h . Updated function descriptions for PeiGetVariable() and PeiGetLargeVariable() . Added VariableReadLib to CorePeiLi

[edk2-devel] [edk2-platforms: PATCH v5 1/9] MinPlatformPkg: Support FSP 2.3 FSP_NON_VOLATILE_STORAGE_HOB2.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3678 Implementation should search FSP_NON_VOLATILE_STORAGE_HOB2 firstly and only search FSP_NON_VOLATILE_STORAGE_HOB when former one is not found. Also added PeiGetLargeVariable () to support the scenarios where the variable data size is bigger

[edk2-devel] [edk2-platforms: PATCH v5 2/9] CometlakeOpenBoardPkg: Use same variable name for FspNvsHob.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3678 To simplify the implementation the variable Name/GUID has been changed to "FspNvsBuffer" and gFspNvsBufferVariableGuid regardless it stores the data from FSP_NON_VOLATILE_STORAGE_HOB2 or FSP_NON_VOLATILE_STORAGE_HOB. Cc: Nate DeSimone Cc:

[edk2-devel] [edk2-platforms: PATCH v5 3/9] KabylakeOpenBoardPkg/AspireVn7Dash572G:Use same variable name for FspNvsHob

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3678 To simplify the implementation the variable Name/GUID has been changed to "FspNvsBuffer" and gFspNvsBufferVariableGuid regardless it stores the data from FSP_NON_VOLATILE_STORAGE_HOB2 or FSP_NON_VOLATILE_STORAGE_HOB. Cc: Nate DeSimone Cc:

[edk2-devel] [edk2-platforms: PATCH v5 4/9] KabylakeOpenBoardPkg/GalagoPro3: Use same variable name for FspNvsHob.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3678 To simplify the implementation the variable Name/GUID has been changed to "FspNvsBuffer" and gFspNvsBufferVariableGuid regardless it stores the data from FSP_NON_VOLATILE_STORAGE_HOB2 or FSP_NON_VOLATILE_STORAGE_HOB. Cc: Nate DeSimone Cc:

[edk2-devel] [edk2-platforms: PATCH v5 5/9] KabylakeOpenBoardPkg/KabylakeRvp3: Use same variable name for FspNvsHob.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3678 To simplify the implementation the variable Name/GUID has been changed to "FspNvsBuffer" and gFspNvsBufferVariableGuid regardless it stores the data from FSP_NON_VOLATILE_STORAGE_HOB2 or FSP_NON_VOLATILE_STORAGE_HOB. Cc: Nate DeSimone Sign

[edk2-devel] [edk2-platforms: PATCH v5 6/9] TigerlakeOpenBoardPkg: Use same variable name for FspNvsHob.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3678 To simplify the implementation the variable Name/GUID has been changed to "FspNvsBuffer" and gFspNvsBufferVariableGuid regardless it stores the data from FSP_NON_VOLATILE_STORAGE_HOB2 or FSP_NON_VOLATILE_STORAGE_HOB. Cc: Sai Chaganty Cc: N

[edk2-devel] [edk2-platforms: PATCH v5 7/9] WhiskeylakeOpenBoardPkg: Use same variable name for FspNvsHob.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3678 To simplify the implementation the variable Name/GUID has been changed to "FspNvsBuffer" and gFspNvsBufferVariableGuid regardless it stores the data from FSP_NON_VOLATILE_STORAGE_HOB2 or FSP_NON_VOLATILE_STORAGE_HOB. Cc: Nate DeSimone Sign

[edk2-devel] [edk2-platforms: PATCH v5 8/9] WhitleyOpenBoardPkg: Support FSP 2.3 FSP_NON_VOLATILE_STORAGE_HOB2.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3678 Implementation should search FSP_NON_VOLATILE_STORAGE_HOB2 firstly and only search FSP_NON_VOLATILE_STORAGE_HOB when former one is not found. Also added PeiGetLargeVariable () to support the scenarios where the variable data size is bigger

[edk2-devel] [edk2-platforms: PATCH v5 9/9] WhitleySiliconPkg: Use same variable name for FspNvsHob.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3678 To simplify the implementation the variable Name/GUID has been changed to "FspNvsBuffer" and gFspNvsBufferVariableGuid regardless it stores the data from FSP_NON_VOLATILE_STORAGE_HOB2 or FSP_NON_VOLATILE_STORAGE_HOB. Cc: Isaac Oram Cc: Nat

Re: [edk2-devel] [PATCH] OvmfPkg/BhyveBhfPkg: install bhyve's ACPI tables

Acked-by: Jiewen Yao > -Original Message- > From: devel@edk2.groups.io On Behalf Of Peter > Grehan > Sent: Thursday, October 14, 2021 1:42 PM > To: Köhne, Corvin > Cc: Ard Biesheuvel ; Yao, Jiewen > ; Justen, Jordan L ; Gerd > Hoffmann ; Rebecca Cran ; > devel@edk2.groups.io; Kinney, Mi

Re: [edk2-devel] [PATCH] OvmfPkg/Bhyve: Use QemuFwCfg over BhyveFwCtl

Acked-by: Jiewen Yao > -Original Message- > From: devel@edk2.groups.io On Behalf Of Gerd > Hoffmann > Sent: Thursday, October 14, 2021 1:12 PM > To: Köhne, Corvin > Cc: Corvin Köhne ; Ard Biesheuvel > ; Yao, Jiewen ; Justen, > Jordan L ; Rebecca Cran ; > Peter Grehan ; devel@edk2.groups

Re: [edk2-devel] [PATCH V3 00/12] Migrate ArmVirtPkg modules to OvmfPkg

On Tue, 12 Oct 2021 at 06:17, Abner Chang wrote: > > Hi package maintainers, > > The review process of this patch set is almost done and please allow me to > merge it because the corresponding changes on edk2-platform is also required > to merge. > > > > Ard and Leif, do I need the Reviewed-by o

Re: [edk2-devel] [PATCH v1] ArmPkg/Smbios: Fix max cache size 2 wrong issue

+Rebecca On Thu, Oct 14, 2021 at 15:23:14 +0800, Ming Huang wrote: > As SMBIOS spec, bit-31 of maximum cache size 2 should be 1 > for 64K granularity. > > Signed-off-by: Ming Huang > --- > ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c | 2 +- > 1 file changed, 1 insertion(+),

Re: [edk2-devel] [PATCH V3 00/12] Migrate ArmVirtPkg modules to OvmfPkg

Hi Are, I am so sorry about that I just merged it two hours ago. Any process needed if we want to change the commit messages for adding your review tag? Abner Get Outlook for Android From: Ard Biesheuvel Sent: Thursday, October 14, 2021 5

Re: [edk2-devel] [PATCH v2 1/1] SecurityPkg/Library: Add Tpm2NvUndefineSpaceSpecial to Tpm2CommandLib

Hi Bret I saw PR failure - https://github.com/tianocore/edk2/pull/2066 Thank you > -Original Message- > From: devel@edk2.groups.io On Behalf Of Bret > Barkelew > Sent: Thursday, October 14, 2021 1:33 AM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Wang, Jian J ; > Zhang, Qi1 ; Kumar, R

Re: [edk2-devel] [PATCH V3 00/12] Migrate ArmVirtPkg modules to OvmfPkg

On Thu, 14 Oct 2021 at 12:14, Chang, Abner (HPS SW/FW Technologist) wrote: > > Hi Are, I am so sorry about that I just merged it two hours ago. Any process > needed if we want to change the commit messages for adding your review tag? > Don't worry about it. > >

Re: [edk2-devel] [PATCH V2 0/3] Introduce TdProtocol into EDK2

Hi Sami I am not sure if I can understand your comment - "Some interfaces may need to use an architecture specific library, and some configuration options would need to be defined using PCDs." Would you please be more specific? Thank you Yao Jiewen > -Original Message- > From: Xu, Min

Re: [edk2-devel] [PATCH v1] ArmPkg/Smbios: Fix max cache size 2 wrong issue

Reviewed-by: Rebecca Cran On 10/14/21 1:23 AM, Ming Huang wrote: As SMBIOS spec, bit-31 of maximum cache size 2 should be 1 for 64K granularity. Signed-off-by: Ming Huang --- ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c | 2 +- 1 file changed, 1 insertion(+), 1 deletio

[edk2-devel] Cancelled Event: TianoCore Design Meeting - APAC/NAMO - Friday, October 15, 2021 #cal-cancelled

BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:CANCELLED REFRESH-INTERVAL;VALUE=DURATION:PT1H X-PUBLISHED-TTL:PT1H CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:Asia/Shanghai LAST-MODIFIED:20201011T015911Z TZURL:http://tzurl.org/zoneinfo-outlook/Asia/Shanghai X-LIC-LOC

Re: [edk2-devel] [RFC] [PATCH 0/2] Proposal to add EFI_MP_SERVICES_PROTOCOL support for AARCH64

On 9/28/21 5:14 AM, Leif Lindholm wrote: On Fri, Sep 24, 2021 at 20:17:50 -0600, Rebecca Cran wrote: I'd like to propose adding EFI_MP_SERVICES_PROTOCOL support for AARCH64 systems. I've attached two patches to implement support for it in the DXE phase, based on code in EmulatorPkg and UefiCpuP

Re: [edk2-devel] [edk2-rfc] [RFC] [PATCH 0/2] Proposal to add EFI_MP_SERVICES_PROTOCOL support for AARCH64

On Mon, Oct 11, 2021 at 21:52:13 +, Samer El-Haj-Mahmoud wrote: > For the RFC itself, I personally do not have any objection, and > welcome the addition of this protocol to AARCH64, as long as it > utilizes the PSCI services to achieve the OS boot requirements. > > It may be worth getting feed

Re: [edk2-devel] [edk2-platforms: PATCH v5 0/9] MinPlatformPkg: Support FSP 2.3 FSP_NON_VOLATILE_STORAGE_HOB2.

Series Reviewed-by: Isaac Oram -Original Message- From: Chiu, Chasel Sent: Thursday, October 14, 2021 2:16 AM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Oram, Isaac W ; Desimone, Nathaniel L ; Luo, Heng ; Jeremy Soller ; Benjamin Doron ; Chaganty, Rangasai V ; Kethi Reddy, Deepika

[edk2-devel] [PATCH 1/1] DynamicTablesPkg: Fix void pointer arithmetic

From: Pierre Gondois Building the DynamicTablesPkg with the additional -Wpointer-arith flag triggers the following error: "pointer of type ‘void *’ used in arithmetic [-Werror=pointer-arith]" Cast the void pointer to fix the error. Signed-off-by: Pierre Gondois --- .../Common/TableHelperL

[edk2-devel] [PATCH 0/5] [RfC] OvmfPkg/Microvm: second batch of microvm patches

Adds support for virtio-mmio devices to microvm. Needs patched qemu, so posting this only for review. Actual merge should wait until the host side changes are accepted to qemu. While being at it also add the README, the patch somehow disappeared from the first batch. Gerd Hoffmann (5): OvmfPkg

[edk2-devel] [PATCH 2/5] OvmfPkg/Microvm/fdt: load fdt from fw_cfg

Needed for hardware detection: virtio-mmio devices for now, later also pcie root bridge. Depends on patched qemu which actually provides an fdt: https://gitlab.com/kraxel/qemu/-/commits/sirius/microvm-device-tree https://bugzilla.tianocore.org/show_bug.cgi?id=3689 Signed-off-by: Gerd Hoffmann --

[edk2-devel] [PATCH 1/5] OvmfPkg/Microvm/fdt: add device tree support

Add fdt parser from EmbeddedPkg (FdtLib and FdtClientDxe) to MicrovmX64. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3689 Signed-off-by: Gerd Hoffmann --- OvmfPkg/Microvm/MicrovmX64.dsc | 6 ++ OvmfPkg/Microvm/MicrovmX64.fdf | 2 ++ 2 files changed, 8 insertions(+) diff --git a/Ovmf

[edk2-devel] [PATCH 3/5] OvmfPkg/Microvm/fdt: add empty fdt

FdtClient is unhappy without a device tree, so add an empty fdt which we can use in case etc/fdt is not present in fw_cfg. https://bugzilla.tianocore.org/show_bug.cgi?id=3689 Signed-off-by: Gerd Hoffmann --- OvmfPkg/PlatformPei/Platform.c | 26 ++ 1 file changed, 22 inser

[edk2-devel] [PATCH 4/5] OvmfPkg/Microvm/virtio: add virtio-mmio support

Add virtio-mmio support (VirtioMmioDeviceLib and VirtioFdtDxe). https://bugzilla.tianocore.org/show_bug.cgi?id=3689 Signed-off-by: Gerd Hoffmann --- OvmfPkg/Microvm/MicrovmX64.dsc | 2 ++ OvmfPkg/Microvm/MicrovmX64.fdf | 1 + 2 files changed, 3 insertions(+) diff --git a/OvmfPkg/Microvm/Microvm

[edk2-devel] [PATCH 5/5] OvmfPkg/Microvm: add README

Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3599 Signed-off-by: Gerd Hoffmann Acked-by: Jiewen Yao --- OvmfPkg/Microvm/README | 50 ++ 1 file changed, 50 insertions(+) create mode 100644 OvmfPkg/Microvm/README diff --git a/OvmfPkg/Microvm/README

Re: [edk2-devel] [PATCH v1 1/1] StandaloneMmPkg: To support CLANGPDB build

Marvin, It's fine to use your below patch to fix this issue. Please help to check-in it. https://edk2.groups.io/g/devel/message/78894?p=%2C%2C%2C20%2C0%2C0%2C0%3A%3Arecentpostdate%2Fsticky%2C%2CStandaloneMmPkg%3A+Support+CLANGPDB+X64+builds%2C20%2C2%2C0%2C84754068 Thanks Steven Shi > -Orig

Re: [edk2-devel] [PATCH V2 0/3] Introduce TdProtocol into EDK2

Hi Sami To clarify my description: I am OK to define it in an architecture neutral protocol, such as EFI_TEE_MEASUREMENT_PROTOCOL, or EFI_CCAM_PROTOCOL. I am happy to do that. However, at current point of time, I am not sure how other arch supports those feature, such as AMD SEV (https://www.am

Re: [edk2-devel] [PATCH v2 1/1] SecurityPkg/Library: Add Tpm2NvUndefineSpaceSpecial to Tpm2CommandLib

It looks like all errors are still related to ECC and PatchCheck, even though I'm just matching the rest of the file. Please advise if we want to update the entire file. On Thu, Oct 14, 2021 at 3:48 AM Yao, Jiewen wrote: > Hi Bret > I saw PR failure - https://github.com/tianocore/edk2/pull/2066

Re: [edk2-devel] [edk2-platforms][PATCH 05/15] Platform/ARM: Use PcdPciIoTranslation PCD from MdePkg

Hi Abner, This patch: https://edk2.groups.io/g/devel/message/81310 renames: gArmTokenSpaceGuid.PcdPciMmio32Translation to: gEfiMdePkgTokenSpaceGuid.PcdPciMmio32Translation but gArmTokenSpaceGuid.PcdPciMmio32Translation is still used in ARM platforms, e.g.: SgiPkg/SgiPlatform.dsc.inc:155:  gArm

[edk2-devel] [PATCH 0/2] work area fixes

We missed updating the AmdSev package and Ia32 buid to use new work area. Brijesh Singh (2): Ovmfpkg: update Ia32 build to use new work area OvmfPkg/AmdSev: update the fdf to use new workarea PCD OvmfPkg/AmdSev/AmdSevX64.fdf | 9 - OvmfPkg/OvmfPkgIa32X64.fdf| 3 +

[edk2-devel] [PATCH 1/2] Ovmfpkg: update Ia32 build to use new work area

The commit 80e67af9afca added support for the generic work area concept used mainly by the encrypted VMs. In the past, the work area was preliminary used by the SEV-ES VMs. The SEV-ES support is available for the X64 builds only. But now, that work area header contains fields that nonencrypted VMs

[edk2-devel] [PATCH 2/2] OvmfPkg/AmdSev: update the fdf to use new workarea PCD

The commit 80e67af9afca added support for the generic work area concept used mainly by the encrypted VMs but missed update the AmdSev package. Fixes: 80e67af9afca ("OvmfPkg: introduce a common work area") Cc: James Bottomley Cc: Min Xu Cc: Jiewen Yao Cc: Tom Lendacky Cc: Jordan Justen Cc: Ard

[edk2-devel] [PATCH v2 0/1] StandaloneMmPkg: Support CLANGPDB builds

V2: Update patch to account for ARM support Currently, the flag "-fpie" is passed for all builds with a GCC family toolchain, including CLANGPDB. CLANGPDB however does not support this flag as it generates PE/COFF files directly. As the flag is mostly required for ARM-specific self-relocation, dr

[edk2-devel] [PATCH v2 1/1] StandaloneMmPkg: Support CLANGPDB builds

Currently, the flag "-fpie" is passed for all builds with a GCC family toolchain, including CLANGPDB. CLANGPDB however does not support this flag as it generates PE/COFF files directly. As the flag is mostly required for ARM-specific self-relocation, drop it for other architectures and document th

Re: [edk2-devel] [PATCH v9 04/32] OvmfPkg/ResetVector: introduce SEV metadata descriptor for VMM use

On 10/14/21 12:08 AM, Gerd Hoffmann wrote: > On Wed, Oct 13, 2021 at 11:56:45AM -0500, Brijesh Singh wrote: >> BZ: >> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D3275&data=04%7C01%7Cbrijesh.singh%40amd.com%7Cee86130b95964399c70b0

Re: [edk2-devel] [PATCH v9 17/32] OvmfPkg/MemEncryptSevLib: add support to validate > 4GB memory in PEI phase

On 10/14/21 1:31 AM, Gerd Hoffmann wrote: > On Wed, Oct 13, 2021 at 11:56:58AM -0500, Brijesh Singh wrote: >> BZ: >> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D3275&data=04%7C01%7Cbrijesh.singh%40amd.com%7C82e310da29774221b2e908

Re: [edk2-devel] [PATCH v9 20/32] UefiCpuPkg: Define ConfidentialComputingGuestAttr

On 10/14/21 1:38 AM, Gerd Hoffmann wrote: > Hi, > >> + ## This dynamic PCD indicates the memory encryption attribute of the >> guest. >> + # @Prompt Memory encryption attribute >> + >> gUefiCpuPkgTokenSpaceGuid.PcdConfidentialComputingGuestAttr|0|UINT64|0x6017 > See discussion in paral

Re: [edk2-devel] [PATCH] Platform/RaspberryPi: Remove TypeTranslation attribute

Hi, On 10/10/21 4:10 PM, Ard Biesheuvel wrote: On Sun, 10 Oct 2021 at 21:48, Mark Kettenis wrote: The MMIO host bridge window isn't translated as both the primary and secondary side are MMIO. So remove the incorrect TypeTranslation attribute. Signed-off-by: Mark Kettenis Reviewed-by: Ard

Re: [edk2-devel] [PATCH 3/5] Platform/RaspberryPi: Update Linux quirk name

Hi, On 10/1/21 7:52 PM, Jeremy Linton wrote: During review/merge of the linux ecam quirk, some logic was added to require the quirk name to be exactly 6 characters, matching the MADT field its overriding. As such, the rpi quirk here needed to be shorted by a character to avoid confusion. I'm

Re: [edk2-devel] [PATCH v9 22/32] UefiCpuPkg/MpInitLib: use PcdConfidentialComputingAttr to check SEV status

On 10/14/21 1:41 AM, Gerd Hoffmann via groups.io wrote: > On Wed, Oct 13, 2021 at 11:57:03AM -0500, Brijesh Singh wrote: >> BZ: >> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D3275&data=04%7C01%7Cbrijesh.singh%40amd.com%7C45efbf71

Re: [edk2-devel] [PATCH v9 30/32] OvmfPkg/PlatformPei: mark cpuid and secrets memory reserved in EFI map

On 10/14/21 1:58 AM, Gerd Hoffmann wrote: > On Wed, Oct 13, 2021 at 11:57:11AM -0500, Brijesh Singh wrote: >> When SEV-SNP is active, the CPUID and Secrets memory range contains the >> information that is used during the VM boot. The content need to be persist >> across the kexec boot. Mark the m

[edk2-devel] [PATCH] [edk2-platforms] [PATCH V1] Fix for WilsonCitySMT OS boot issue & using proper ASSERT macro

Fix to resolve the OS boot issue when booting on WilsonCitySMT board. ASSERT_EFI_ERROR(StatusParameter) needs to be passed with Error Status code and not with TRUE or FALSE. Replaced ASSERT_EFI_ERROR with ASSERT. Signed-off-by: Manickavasakam Karpagavinayagam --- Platform/Intel/WhitleyOpenBoard

Re: [edk2-devel] [PATCH v3] UefiPayloadPkg: Remove SystemTableInfo GUID.

gUefiSystemTableInfoGuid is an internal implementation used between payload entry module and EDKII modules. It is fine to remove it to avoid confusion that someone might think it is the interface between bootloader and payload. Since open sourced SBL already produce the HOBs gUniversalPayload

Re: [edk2-devel] [PATCH] [edk2-platforms] [PATCH V1] Fix for WilsonCitySMT OS boot issue & using proper ASSERT macro

Reviewed-by: Isaac Oram -Original Message- From: manickavasakam karpagavinayagam Sent: Thursday, October 14, 2021 3:30 PM To: devel@edk2.groups.io Cc: Oram, Isaac W ; Desimone, Nathaniel L ; fel...@ami.com; DOPPALAPUDI, HARIKRISHNA ; Jha, Manish ; Bobroff, Zachary ; KARPAGAVINAYAGAM,

[edk2-devel] [`edk2-devel][PATCH] UefiPayloadPkg: Fix the build issue for coreboot

From: Guo Dong There is typo in previous change caused coreboot build failue. This patch fixed the build issue. Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Signed-off-by: Guo Dong --- UefiPayloadPkg/Library/CbParseLib/CbParseLib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) di

Re: [edk2-devel] [PATCH] IntelSiliconPkg/FirmwareInterfaceTable: Define FIT 4 record

Patch has been merged with Change-ID removed from commit message. From: Holland, Michael Sent: Tuesday, October 12, 2021 2:48 PM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Ni, Ray Subject: [PATCH] IntelSiliconPkg/FirmwareInterfaceTable: Define FIT 4 record -=-=-=-=-=-=-=-=-=-=-=- G

[edk2-devel] [PATCH] IntelFsp2Pkg: Add support for config editor to handle multiple UPD

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3692 In several use cases in bootloader, there are multiple instances of UPD with same signature header. As such, using previous version of config editor to edit those will result in only overriding the first found instance. This patch provides th

Re: [edk2-devel] [edk2-platforms: PATCH v5 0/9] MinPlatformPkg: Support FSP 2.3 FSP_NON_VOLATILE_STORAGE_HOB2.

For the series... Reviewed-by: Nate DeSimone > -Original Message- > From: Chiu, Chasel > Sent: Thursday, October 14, 2021 2:16 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Oram, Isaac W > ; Desimone, Nathaniel L > ; Luo, Heng ; > Jeremy Soller ; Benjamin Doron > ; Chaganty, Rangas

Re: [edk2-devel] [PATCH] [edk2-platforms] [PATCH V1] Fix for WilsonCitySMT OS boot issue & using proper ASSERT macro

Reviewed-by: Nate DeSimone > -Original Message- > From: devel@edk2.groups.io On Behalf Of > manickavasakam karpagavinayagam via groups.io > Sent: Thursday, October 14, 2021 3:30 PM > To: devel@edk2.groups.io > Cc: Oram, Isaac W ; Desimone, Nathaniel L > ; fel...@ami.com; DOPPALAPUDI, > H

Re: [edk2-devel] [PATCH] [edk2-platforms] [PATCH V1] Fix for WilsonCitySMT OS boot issue & using proper ASSERT macro

Pushed: https://github.com/tianocore/edk2-platforms/commit/86916cb > -Original Message- > From: devel@edk2.groups.io On Behalf Of > manickavasakam karpagavinayagam via groups.io > Sent: Thursday, October 14, 2021 3:30 PM > To: devel@edk2.groups.io > Cc: Oram, Isaac W ; Desimone, Nathaniel

Re: [edk2-devel] [PATCH v2 1/1] SecurityPkg/Library: Add Tpm2NvUndefineSpaceSpecial to Tpm2CommandLib

Hi Liming/Mike Do you have any suggestion here? How do we change CI to add the name to exception list ? Thank you Yao Jiewen From: Bret Barkelew Sent: Friday, October 15, 2021 1:07 AM To: Yao, Jiewen Cc: devel@edk2.groups.io; Wang, Jian J ; Zhang, Qi1 ; Kumar, Rahul1 Subject: Re: [edk2-devel

Re: [edk2-devel][edk2-platforms][PATCH V1 1/1] WhitleyOpenBoardPkg/PlatformHooksLib: Fix eSPI serial debug

Reviewed-by: Nate DeSimone > -Original Message- > From: Oram, Isaac W > Sent: Wednesday, September 22, 2021 2:35 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > > Subject: [edk2-devel][edk2-platforms][PATCH V1 1/1] > WhitleyOpenBoardPkg/PlatformHooksLib: Fix e

Re: [edk2-devel] [PATCH] Enable wildcard host name matching in EDK2 HTTPS/TLS implementation

Reviewed-by: Jiewen Yao Since this https://bugzilla.tianocore.org/show_bug.cgi?id=3691 (networkpkg) is separated from https://bugzilla.tianocore.org/show_bug.cgi?id=3679 (cryptopkg), I will handle those two separately. I will only help merge 3679, and I would expect networkpkg maintainer handle

  1   2   >