Pushed: https://github.com/tianocore/edk2-platforms/commit/86916cb
> -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of > manickavasakam karpagavinayagam via groups.io > Sent: Thursday, October 14, 2021 3:30 PM > To: devel@edk2.groups.io > Cc: Oram, Isaac W <isaac.w.o...@intel.com>; Desimone, Nathaniel L > <nathaniel.l.desim...@intel.com>; fel...@ami.com; DOPPALAPUDI, > HARIKRISHNA <harikrish...@ami.com>; Jha, Manish <mani...@ami.com>; > Bobroff, Zachary <zacha...@ami.com>; KARPAGAVINAYAGAM, > MANICKAVASAKAM <manickavasak...@ami.com> > Subject: [edk2-devel] [PATCH] [edk2-platforms] [PATCH V1] Fix for > WilsonCitySMT OS boot issue & using proper ASSERT macro > > Fix to resolve the OS boot issue when booting on WilsonCitySMT board. > ASSERT_EFI_ERROR(StatusParameter) needs to be passed with Error Status > code and not with TRUE or FALSE. > Replaced ASSERT_EFI_ERROR with ASSERT. > > Signed-off-by: Manickavasakam Karpagavinayagam > <manickavasak...@ami.com> > --- > Platform/Intel/WhitleyOpenBoardPkg/Uba/BoardInit/Dxe/BoardInitDxe.c | > 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git > a/Platform/Intel/WhitleyOpenBoardPkg/Uba/BoardInit/Dxe/BoardInitDxe.c > b/Platform/Intel/WhitleyOpenBoardPkg/Uba/BoardInit/Dxe/BoardInitDxe.c > index d8274fa7ad..212103f483 100644 > --- > a/Platform/Intel/WhitleyOpenBoardPkg/Uba/BoardInit/Dxe/BoardInitDxe.c > +++ > b/Platform/Intel/WhitleyOpenBoardPkg/Uba/BoardInit/Dxe/BoardInitDxe.c > @@ -68,6 +68,16 @@ BoardInitDxeDriverEntry ( > ASSERT_EFI_ERROR (Status); > > break; > > > > + case TypeWilsonCitySMT: > > + Status = gBS->InstallProtocolInterface( > > + &Handle, > > + &gEfiPlatformTypeWilsonCitySMTProtocolGuid, > > + EFI_NATIVE_INTERFACE, > > + NULL > > + ); > > + ASSERT_EFI_ERROR(Status); > > + break; > > + > > case TypeCooperCityRP: > > Status = gBS->InstallProtocolInterface ( > > &Handle, > > @@ -80,7 +90,7 @@ BoardInitDxeDriverEntry ( > > > default: > > // CAN'T GO TO HERE. > > - ASSERT_EFI_ERROR (FALSE); > > + ASSERT (FALSE); > > } > > > > return Status; > > -- > 2.25.0.windows.1 > > > Please consider the environment before printing this email. > > The information contained in this message may be confidential and > proprietary to American Megatrends (AMI). This communication is intended > to be read only by the individual or entity to whom it is addressed or by > their > designee. If the reader of this message is not the intended recipient, you are > on notice that any distribution of this message, in any form, is strictly > prohibited. Please promptly notify the sender by reply e-mail or by > telephone at 770-246-8600, and then delete or destroy all copies of the > transmission. > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#82065): https://edk2.groups.io/g/devel/message/82065 Mute This Topic: https://groups.io/mt/86326587/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
