Re: [edk2-devel] Retire EmbeddedPkg/Library/FdtLib

Thanks Leif for sharing that. Regards, Nhi On 9/24/2024 5:43 PM, Leif Lindholm via groups.io wrote: > On 2024-09-19 10:57, Nhi Pham via groups.io wrote: >> Hi, >> >> It appears that the EmbeddedPkg/Library/FdtLib could be replaced by >> MdePkg/Library/BaseFdtLib. Shou

Re: [edk2-devel] [PATCH edk2-non-osi v2 0/1] Emulator/X86EmulatorDxe: Replace with MultiArchUefiPkg build

I think Ard approved this patch. Is it sufficient to push? https://edk2.groups.io/g/devel/message/120565 Regards, Nhi From: devel@edk2.groups.io on behalf of Rebecca Cran via groups.io Sent: Thursday, September 19, 2024 9:45 PM To: devel@edk2.groups.io ; rebe..

[edk2-devel] Retire EmbeddedPkg/Library/FdtLib

Hi, It appears that the EmbeddedPkg/Library/FdtLib could be replaced by MdePkg/Library/BaseFdtLib. Should we remove the old one in EmbeddedPkg and transition to the new one? The type declaration in EmbeddedPkg/Include/libfdt_env.h cause some compilation errors in certain cases. Regards, Nhi

Re: [edk2-devel] [PATCH v1 0/1] ArmPkg/Smbios: Changing default uni values to ""

Hi Sami, On 9/9/2024 3:00 PM, Sami Mujawar via groups.io wrote: > Hi Nhi, Sam, > > Apologies, this slipped off the radar. > > The changes look good to me. > Is it possible to submit a pull request, please? I've integrated Sam's patch and changed the default uni values to "Not Set". https://git

Re: [edk2-devel] [PATCH v1 0/1] ArmPkg/Smbios: Changing default uni values to ""

Hi, It seems that this patch has been left unattended. The empty string "" may be ambiguous, as it could imply that the string is valid but contains no characters, or it has not been filled. On Ampere platforms, I utilize "Not Set" to avoid this confusion, which is effective for FWTS. Regards

Re: [edk2-devel] [PATCH 1/1] AmpereAltraPkg/FlashLib: Fix kernel crash if not call SetVirtualAddressMap()

; quic_llind...@quicinc.com ; Chuong Tran OS ; Rebecca Cran OS Subject: Re: [edk2-devel] [PATCH 1/1] AmpereAltraPkg/FlashLib: Fix kernel crash if not call SetVirtualAddressMap() On Thu, 29 Aug 2024 at 10:48, Nhi Pham via groups.io wrote: > > Pushed as 03d3395552c5 > Thanks for finally provid

Re: [edk2-devel] [PATCH 1/1] AmpereAltraPkg/FlashLib: Fix kernel crash if not call SetVirtualAddressMap()

Pushed as 03d3395552c5 Thanks, Nhi From: Chuong Tran OS Sent: Thursday, August 29, 2024 3:25 PM To: Nhi Pham OS ; devel@edk2.groups.io Cc: quic_llind...@quicinc.com ; Chuong Tran OS ; Rebecca Cran OS Subject: Re: [PATCH 1/1] AmpereAltraPkg/FlashLib: Fix kerne

Re: [edk2-devel] [edk2-platforms][PATCH v2 1/1] JadePkg: Add ACPI SPMI table

Pushed as 146cb5322498..c400d971093f Thanks, Nhi From: devel@edk2.groups.io on behalf of Nhi Pham via groups.io Sent: Friday, August 23, 2024 9:51 AM To: Chuong Tran OS ; devel@edk2.groups.io Cc: quic_llind...@quicinc.com ; Chuong Tran OS ; Rebecca Cran OS

Re: [edk2-devel] [PATCH 0/2] Ampere: Add BMC Configuration Screen

Pushed as 9d8eda62..146cb5322498 Thanks, Nhi From: devel@edk2.groups.io on behalf of Nhi Pham via groups.io Sent: Friday, August 23, 2024 9:51 AM To: Chuong Tran OS ; devel@edk2.groups.io Cc: quic_llind...@quicinc.com ; Chuong Tran OS ; Rebecca Cran OS

Re: [edk2-devel] [edk2-platforms][PATCH v2 0/5] Add IPMI SSIF support

Pushed as 6146fd7abcf6..9d8eda62 Thanks, Nhi From: Chuong Tran OS Sent: Thursday, August 29, 2024 12:55 PM To: Nhi Pham OS ; devel@edk2.groups.io Cc: quic_llind...@quicinc.com ; Chuong Tran OS ; Rebecca Cran OS Subject: Re: [edk2-platforms][PATCH v2 0/5]

Re: [edk2-devel] [edk2-platforms][PATCH v2 1/1] JadePkg: Add ACPI SPMI table

Thanks for the review. I will push after the IPMI SSIF support is merged. Regards, Nhi From: Chuong Tran OS Sent: Thursday, August 22, 2024 5:49 PM To: Nhi Pham OS ; devel@edk2.groups.io Cc: quic_llind...@quicinc.com ; Chuong Tran OS ; Rebecca Cran OS Subject

Re: [edk2-devel] [PATCH 0/2] Ampere: Add BMC Configuration Screen

Thanks for the review. I will push after the IPMI SSIF support is merged. -Nhi From: Chuong Tran OS Sent: Thursday, August 22, 2024 3:22 PM To: Nhi Pham OS ; devel@edk2.groups.io Cc: quic_llind...@quicinc.com ; Chuong Tran OS ; Rebecca Cran OS Subject: Re: [P

Re: [edk2-devel] [edk2-platforms][PATCH 0/3] AmpereAltraPkg: Remove Max Frequency config

Pushed as debfeb1f3052..7dad9da43942 Thanks, Nhi From: Chuong Tran OS Sent: Thursday, August 22, 2024 1:58 PM To: Nhi Pham OS ; devel@edk2.groups.io Cc: quic_llind...@quicinc.com ; Chuong Tran OS ; Rebecca Cran OS Subject: Re: [edk2-platforms][PATCH 0/3] Ampe

[edk2-devel] [edk2-platforms][PATCH 3/3] AmpereAltraPkg/SystemFirmwareInterfaceLib: Remove unused MailboxMsgTurboConfig()

Since configuring the max frequency is unnecessary, its configuration functions is unused, so remove it. Signed-off-by: Nhi Pham --- Silicon/Ampere/AmpereAltraPkg/Include/Library/SystemFirmwareInterfaceLib.h | 25 Silicon/Ampere/AmpereAltraPkg/Library/SystemFirm

[edk2-devel] [edk2-platforms][PATCH 1/3] AmpereAltraPkg/AcpiConfigDxe: Remove Max Frequency config option

Beginning with SCP version 1.08, the CPU nominal frequency is equivalient to the maximum (turbo) frequency. Hence, the max frequency config option can be eliminated from the ACPI Configuration screen. Signed-off-by: Nhi Pham --- Silicon/Ampere/AmpereAltraPkg/Include/AcpiConfigNVDataStruct.h

[edk2-devel] [edk2-platforms][PATCH 2/3] AmpereAltraPkg/PlatformInfoDxe: Correct CPU frequency info

Given that the max frequency is always active, the CPU frequency showned on the CPU Information screen should be retrieved using the CpuGetMaxFreq() function. The function will prioritize obtaining the max frequency over the CPU normal frequency. Signed-off-by: Nhi Pham --- Silicon/Ampere/Amper

[edk2-devel] [edk2-platforms][PATCH 0/3] AmpereAltraPkg: Remove Max Frequency config

This patch series aims to remove the maximum (turbo) frequency since the CPU nominal frequency is equivalient to the max frequency. Nhi Pham (3): AmpereAltraPkg/AcpiConfigDxe: Remove Max Frequency config option AmpereAltraPkg/PlatformInfoDxe: Correct CPU frequency info AmpereAltraPkg/SystemF

Re: [edk2-devel] [edk2-platforms][PATCH 1/1] JadePkg: Add ACPI SPMI table

-platforms][PATCH 1/1] JadePkg: Add ACPI SPMI table On 8/13/2024 9:33 PM, Nhi Pham via groups.io wrote: This could be a static function. > +EFI_STATUS > +EFIAPI > +AcpiInstallSpmiTable ( > + VOID > + ); > + > #endif /* ACPI_PLATFORM_H_ */ > diff --git > a/Plat

[edk2-devel] [edk2-platforms][PATCH v2 1/1] JadePkg: Add ACPI SPMI table

This implements ACPI SPMI table as defined in the IPMI specification. Signed-off-by: Nhi Pham --- v2: + Remove EFIAPI + Make the function UpdateIpmiSpecRevision() static + Change 0x0F to 0xF to be more readable. Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiPlatformDxe.inf |

[edk2-devel] [edk2-platforms][PATCH 1/1] JadePkg: Add ACPI SPMI table

This implements ACPI SPMI table as defined in the IPMI specification. Signed-off-by: Nhi Pham --- Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiPlatformDxe.inf | 4 + Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiPlatform.h | 13 +++ Platform/Ampere/JadePkg/Drivers/AcpiPlatfo

[edk2-devel] [PATCH 1/1] AmpereAltraPkg/FlashLib: Fix kernel crash if not call SetVirtualAddressMap()

From: Chuong Tran OS kernel with greater than or equal to 48-bit VA space avoids EFI's SetVirtualAddressMap() runtime service on Arm64 and simply uses the 1:1 address mapping that UEFI used at booting. However, AmpereAltraPkg's RuntimeFlashLib replies on function call SetVirtualAddressMap() to de

[edk2-devel] [PATCH 2/2] JadePkg: Add BmcConfigDxe

Signed-off-by: Nhi Pham --- Platform/Ampere/JadePkg/Jade.dsc | 1 + Platform/Ampere/JadePkg/Jade.fdf | 1 + 2 files changed, 2 insertions(+) diff --git a/Platform/Ampere/JadePkg/Jade.dsc b/Platform/Ampere/JadePkg/Jade.dsc index 1bd9f2ec1583..db3733cf5b08 100644 --- a/Platform/Ampere/JadePkg/Jade

[edk2-devel] [PATCH 1/2] AmpereSiliconPkg: Implement BMC Configuration screen

This implements the BMC configuration screen to provide basic information such as IPMI version, BMC version, and BMC IPv4. Signed-off-by: Nhi Pham --- Silicon/Ampere/AmpereSiliconPkg/AmpereSiliconPkg.dec | 8 +- Silicon/Ampere/AmpereSiliconPkg/Drivers/BmcConfigDxe/BmcConfigDxe

[edk2-devel] [PATCH 0/2] Ampere: Add BMC Configuration Screen

This implements BMC Configuration Screen and supports on Ampere Mt. Jade platform. Nhi Pham (2): AmpereSiliconPkg: Implement BMC Configuration screen JadePkg: Add BmcConfigDxe Silicon/Ampere/AmpereSiliconPkg/AmpereSiliconPkg.dec | 8 +- Platform/Ampere/JadePkg/Jade.dsc

Re: [edk2-devel] [edk2-platforms][PATCH v2 0/5] Add IPMI SSIF support

Hi Leif, Hope you're doing well. I hope you can find a few minutes on reviewing this patch set. I appreciate your time. Thanks, Nhi From: devel@edk2.groups.io on behalf of Nhi Pham via groups.io Sent: Thursday, August 8, 2024 10:06 AM To: quic_

Re: [edk2-devel] [edk2-platforms][PATCH 1/1] AmpereAltraPkg/FlashFvbDxe: Sync up NVRAM FV with NVRAM cached

Pushed as 70d5c0e3af97..debfeb1f3052 Thanks, Nhi From: Rebecca Cran OS Sent: Friday, August 9, 2024 8:00 PM To: Nhi Pham OS ; devel@edk2.groups.io Cc: quic_llind...@quicinc.com ; Chuong Tran OS ; Tam Chi Nguyen OS Subject: Re: [edk2-platforms][PATCH 1/1] Ampe

[edk2-devel] [edk2-platforms][PATCH 1/1] AmpereAltraPkg/FlashFvbDxe: Sync up NVRAM FV with NVRAM cached

From: Tam Chi Nguyen Currently, the NVRAM FV region is only updated once at FlashPei that makes the data in NVRAM FV outdated with data in NVRAM region in SPI-NOR. It causes the duplication of the valid NV variables when the Variable Reclaim process performs. Consequently, after rebooting, system

Re: [edk2-devel] [edk2-platforms][PATCH v2 0/5] Add IPMI SSIF support

through GitHub PR. Could you please send the PR against edk2-platforms? Thanks Abner -Original Message- From: devel@edk2.groups.io <mailto:devel@edk2.groups.io> <mailto:devel@edk2.groups.io>> On Behalf Of Nhi Pham via groups.io Sent: Wednesday, August 7, 2024

Re: [edk2-devel] [edk2-platforms][PATCH v2 0/5] Add IPMI SSIF support

Hi Leif, I saw a comment from you in the Pull Request and I resolved it. Do you prefer to review in the Github PR? Should I send v3 to the mailing list? Regards, Nhi On 8/7/2024 1:47 PM, Nhi Pham wrote: > This updates the I2C library and implements SMBUS PEI/DXE drivers to > support IPMI SSIF i

Re: [edk2-devel] [edk2-platforms][PATCH v2 0/5] Add IPMI SSIF support

Original Message- > From: devel@edk2.groups.io On Behalf Of Nhi Pham > via groups.io > Sent: Wednesday, August 7, 2024 2:47 PM > To: devel@edk2.groups.io > Cc: quic_llind...@quicinc.com; chu...@os.amperecomputing.com; > rebe...@os.amperecomputing.com; n...@os.amperecomputing.com >

[edk2-devel] [edk2-platforms][PATCH v2 4/5] JadePkg: Add PlatformBmcReadyLib to support BMC ready check

This adds the PlatformBmcReadyLib library instance, which provides a function to check whether the BMC is ready for transaction or not. The function checks the GPIO pin specified by the PcdBmcReadyGpio PCD and returns TRUE if the pin is set to a logic high level, indicating that the BMC is ready.

[edk2-devel] [edk2-platforms][PATCH v2 5/5] Ampere/Jade: Enable IPMI SSIF

This adds the building of IPMI SSIf and associated modules. Signed-off-by: Nhi Pham --- Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc | 23 Platform/Ampere/JadePkg/Jade.dsc | 2 ++ Platform/Ampere/JadePkg/Jade.fdf | 17

[edk2-devel] [edk2-platforms][PATCH v2 3/5] AmpereAltraPkg: Add SmbusHc PEI and DXE drivers

This adds the implementation of SMBUS PPI and Protocol to produce SMBUS interface in both PEI and DXE phases for use by IPMI SSIF. Signed-off-by: Nhi Pham --- Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcDxe.inf | 43 +++ Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcPei.inf |

[edk2-devel] [edk2-platforms][PATCH v2 2/5] AmpereSiliconPkg: Define PCDs for SMBUS and BMC

This introduces fixed PCDs for SMBUS and BMC as specified to Ampere. Signed-off-by: Nhi Pham --- Silicon/Ampere/AmpereSiliconPkg/AmpereSiliconPkg.dec | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/Silicon/Ampere/AmpereSiliconPkg/AmpereSiliconPkg.dec b/Silic

[edk2-devel] [edk2-platforms][PATCH v2 1/5] AmpereAltraPkg/DwI2cLib: Add support for SMBUS+PEC operation

This introduces two input parameters to the I2cProbe() and updates the InternalI2cRead() for the support of the SMBUS operation with optional PEC check, which will be used by the IPMI SSIF driver. Signed-off-by: Nhi Pham --- Silicon/Ampere/AmpereAltraPkg/Include/Library/I2cLib.h |

[edk2-devel] [edk2-platforms][PATCH v2 0/5] Add IPMI SSIF support

This updates the I2C library and implements SMBUS PEI/DXE drivers to support IPMI SSIF in the Mt. Jade platform. v2: - Refine the changes of the DwI2cLib per Leif's comments and update the commit message accordingly. - Remove the additional PCD PcdBmcSlaveAddr since it's is unused. NOTE: Regard

Re: [edk2-devel] [edk2-platforms][PATCH 1/5] AmpereAltraPkg/DwI2cLib: Add SmbusRead() function

On 8/1/2024 10:18 PM, Leif Lindholm via groups.io wrote: On Thu, Aug 01, 2024 at 16:36:14 +0700, Nhi Pham via groups.io wrote: This adds the SmbusRead() function designed for SMBUS transaction to support the extraction of the data lenth byte from the initial byte of the SMBUS Block Read

Re: [edk2-devel] [edk2-platforms][PATCH 1/5] AmpereAltraPkg/DwI2cLib: Add SmbusRead() function

On 8/1/2024 10:14 PM, Leif Lindholm wrote: On Thu, Aug 01, 2024 at 16:36:14 +0700, Nhi Pham via groups.io wrote: This adds the SmbusRead() function designed for SMBUS transaction to support the extraction of the data lenth byte from the initial byte of length I will fix, thanks. the

Re: [edk2-devel] [edk2-platforms][PATCH 2/5] AmpereSiliconPkg: Define PCDs for SMBUS and BMC

On 8/1/2024 10:02 PM, Leif Lindholm via groups.io wrote: On Thu, Aug 01, 2024 at 16:36:15 +0700, Nhi Pham wrote: This introduces fixed PCDs for SMBUS and BMC as specified to Ampere. Signed-off-by: Nhi Pham --- Silicon/Ampere/AmpereSiliconPkg/AmpereSiliconPkg.dec | 12 1 file ch

Re: [edk2-devel] [PATCH edk2-platforms 1/1] Platform/ ARM AARCH64: Remove ArmPlatformLib MPCore boilerplate

For Silicon/Ampere/AmpereAltraPkg, Reviewed-by: Nhi Pham Tested-by: Nhi Pham Thanks, Nhi -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120187): https://edk2.groups.io/g/devel/message/120187 Mute This Topic: https://groups.io/mt/10766

Re: [edk2-devel] [PATCH edk2-platforms 1/2] Platform AARCH64: Move PrePeiCore users to Sec.inf

For Silicon/Ampere/AmpereAltraPkg, Reviewed-by: Nhi Pham Tested-by: Nhi Pham Thanks, Nhi -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120186): https://edk2.groups.io/g/devel/message/120186 Mute This Topic: https://groups.io/mt/10764

[edk2-devel] [edk2-platforms][PATCH 4/5] JadePkg: Add PlatformBmcReadyLib to support BMC ready check

This adds the PlatformBmcReadyLib library instance, which provides a function to check whether the BMC is ready for transaction or not. The function checks the GPIO pin specified by the PcdBmcReadyGpio PCD and returns TRUE if the pin is set to a logic high level, indicating that the BMC is ready.

[edk2-devel] [edk2-platforms][PATCH 5/5] Ampere/Jade: Enable IPMI SSIF

This adds the building of IPMI SSIf and associated modules. Signed-off-by: Nhi Pham --- Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc | 23 Platform/Ampere/JadePkg/Jade.dsc | 2 ++ Platform/Ampere/JadePkg/Jade.fdf | 17

[edk2-devel] [edk2-platforms][PATCH 3/5] AmpereAltraPkg: Add SmbusHc PEI and DXE drivers

This adds the implementation of SMBUS PPI and Protocol to produce SMBUS interface in both PEI and DXE phases for use by IPMI SSIF. Signed-off-by: Nhi Pham --- Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcDxe.inf | 43 +++ Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcPei.inf |

[edk2-devel] [edk2-platforms][PATCH 2/5] AmpereSiliconPkg: Define PCDs for SMBUS and BMC

This introduces fixed PCDs for SMBUS and BMC as specified to Ampere. Signed-off-by: Nhi Pham --- Silicon/Ampere/AmpereSiliconPkg/AmpereSiliconPkg.dec | 12 1 file changed, 12 insertions(+) diff --git a/Silicon/Ampere/AmpereSiliconPkg/AmpereSiliconPkg.dec b/Silicon/Ampere/AmpereSil

[edk2-devel] [edk2-platforms][PATCH 0/5] Add IPMI SSIF support

This updates the I2C library and implements SMBUS PEI/DXE drivers to support IPMI SSIF in the Mt. Jade platform. Nhi Pham (5): AmpereAltraPkg/DwI2cLib: Add SmbusRead() function AmpereSiliconPkg: Define PCDs for SMBUS and BMC AmpereAltraPkg: Add SmbusHc PEI and DXE drivers JadePkg: Add Plat

[edk2-devel] [edk2-platforms][PATCH 1/5] AmpereAltraPkg/DwI2cLib: Add SmbusRead() function

This adds the SmbusRead() function designed for SMBUS transaction to support the extraction of the data lenth byte from the initial byte of the SMBUS Block Read, allowing the I2C master to accurately read the SMBUS response with the exact data length. This addresses the issue where the SmbusLib:SmB

Re: [edk2-devel] [edk2-platforms][PATCH 1/1] Ampere/JadePkg: Add secure boot default keys initialization

Pushed as 6c78047349e2..443eb9601190 -Nhi On 6/5/2024 11:10 AM, Rebecca Cran wrote: Reviewed-by: Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120137): https://edk2.groups.io/g/devel/message/120137 Mute This Topic: ht

Re: [edk2-devel] [PATCH RFC edk2-platforms 3/5] Platform/Ampere: Switch to unicore SEC implementation

Thanks Ard for the clean up and maintaining the platforms's updates. Reviewed-by: Nhi Pham Tested-by: Nhi Pham Regards, Nhi On 7/29/2024 7:22 PM, Ard Biesheuvel wrote: From: Ard Biesheuvel Spec adherent AArch64 systems use PSCI to manage secondary CPUs, and only enter the execution level w

Re: [edk2-devel] [PATCH edk2-platforms 0/6] JadePkg and common Ampere code fixes

Pushed as 8975c5d45ea9..6c78047349e2 Thanks, Nhi On 6/7/2024 11:49 AM, Nhi Pham wrote: For this series, Reviewed-by: Nhi Pham Thanks, Nhi On 6/6/2024 10:04 AM, Rebecca Cran wrote: These are a set of bug fixes I made to the Mt Jade and common Ampere code while working on updating and improv

Re: [edk2-devel] [PATCH edk2-platforms 07/11] Silicon/Ampere: Switch to generic ArmPsciResetSystemLib

Thanks Ard for the patch. Reviewed-by: Nhi Pham Regards, Nhi On 7/25/2024 3:24 PM, Ard Biesheuvel wrote: From: Ard Biesheuvel The PSCI reset libraries in ArmPkg are being consolidated into a single one to reduce the maintenance burden of having multiple libraries doing the same thing in a s

Re: [edk2-devel] [PATCH edk2-platforms 3/4] Platform/Ampere: Switch to generic ResetRuntime DXE driver

Thanks a lot for the patch. Reviewed-by: Nhi Pham Tested-by: Nhi Pham On 7/21/2024 9:51 PM, Ard Biesheuvel wrote: > From: Ard Biesheuvel > > The reset runtime DXE driver is deprecated and will be removed soon. It > is superseded by a generic implementation in MdeModulePkg, which is > shared b

Re: [edk2-devel] [PATCH edk2-platforms 2/2] SbsaQemu: set CPU model in SMBIOS

On 7/12/2024 5:01 PM, Ard Biesheuvel via groups.io wrote: On Fri, 12 Jul 2024 at 11:24, Marcin Juszkiewicz wrote: SbsaQemu platform have several cpu models available. Since start it reported "arm-virt" one in SMBIOS instead of real one. This change replaces it with the real cpu model like Cor

Re: [edk2-devel] [edk2-platforms][PATCH v2] ManageabilityPkg: add support for the phosphor ipmi blob transfer protocol

On 7/10/2024 10:12 PM, Nickle Wang wrote: Hi @Nhi Pham , I am sorry for taking so long to address your review comments. I updated pull request here: https://github.com/tianocore/edk2-platforms/pull/76 T

Re: [edk2-devel] [PATCH edk2-platforms 2/5] Platform,Silicon: drop redundant uses of PcdArmArchTimerFreqInHz

Thanks for the cleanup. For Ampere Altra, Reviewed-by: Nhi Pham -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119663): https://edk2.groups.io/g/devel/message/119663 Mute This Topic: https://groups.io/mt/106780877/21656 Group Owner: d

Re: [edk2-devel] [PATCH edk2-platforms 0/6] JadePkg and common Ampere code fixes

For this series, Reviewed-by: Nhi Pham Thanks, Nhi On 6/6/2024 10:04 AM, Rebecca Cran wrote: These are a set of bug fixes I made to the Mt Jade and common Ampere code while working on updating and improving ADLINK's edk2_aadp project. Rebecca Cran (6): Silicon/Ampere: Fix capitalization o

Re: [edk2-devel] [edk2-platforms][PATCH 1/1] Ampere/JadePkg: Add secure boot default keys initialization

Could you help push my patch to Tianocore/edk2-platforms once approved, while I don't have write permission? Thanks, Nhi On 6/5/2024 11:10 AM, Rebecca Cran wrote: Reviewed-by: Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Onl

[edk2-devel] [edk2-platforms][PATCH 1/1] Ampere/JadePkg: Add secure boot default keys initialization

This allows to initialize secure boot with the default factory keys embedded in firmware flash image. For example, to incorporate PK, KEK, and DB default keys, specify the corresponding key files in the Jade.dsc as follows: DEFINE DEFAULT_KEYS= TRUE DEFINE PK_DEFAULT_FILE = path/to/PK

Re: [edk2-devel] [PATCH] ASpeed/ASpeedGopBinPkg: Update X64/AArch64 Gop UEFI Driver

On 5/30/2024 8:33 AM, Tommy Huang wrote>> On 5/29/2024 8:18 PM, Leif Lindholm via groups.io wrote: +Nhi, Could you check/verify these work fine on your systems? Yes, I can. Thanks Leif for reaching out to me. Hi Tommy Huang - Could you please create a Pull Request (PR) or share a branch so I

Re: [edk2-devel] [PATCH] ASpeed/ASpeedGopBinPkg: Update X64/AArch64 Gop UEFI Driver

On 5/29/2024 8:18 PM, Leif Lindholm via groups.io wrote: > +Nhi, > > Could you check/verify these work fine on your systems? Yes, I can. Thanks Leif for reaching out to me. Hi Tommy Huang - Could you please create a Pull Request (PR) or share a branch so I can easily apply and test the AArch64 G

Re: [edk2-devel] [PATCH 0/9] Allocate and unblock variable runtime cache buffer in PEI

On 5/17/2024 4:49 PM, duntan via groups.io wrote: This patch set defines a new VARIABLE_RUNTIME_CACHE_INFO HOB. The HOB is used to store the address and size of the buffer that will be used for variable runtime service when the PcdEnableVariableRuntimeCache is TRUE. In following patches, when P

Re: [edk2-devel] [edk2-platforms][PATCH v2] ManageabilityPkg: add support for the phosphor ipmi blob transfer protocol

Hi Abner, It' hard to say actually. I don't spend full-time for open-source work. But I will try to complete it within 2 weeks or sooner. Most of Ampere Altra drivers including IPMI SSIF are living at https://github.com/AmpereComputing/edk2-platforms. The effort now is to port to be compatib

Re: [edk2-devel] [edk2-platforms][PATCH v2] ManageabilityPkg: add support for the phosphor ipmi blob transfer protocol

Hi Nickle, Please see my comments inline... P/s: I just realized that I can not test this protocol without IPMI SSIF to be compatible with ManageabilityPkg framework. On 5/15/2024 10:06 PM, Nickle Wang wrote: REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4773 This change implements the

Re: [edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg: add support for the phosphor ipmi blob transfer protocol

On 5/16/2024 3:44 PM, Chang, Abner wrote: [AMD Official Use Only - AMD Internal Distribution Only] Hi Nhi, Are you using SSIF as the transport interface based on the ManabeabilityPkg framework? If yes, will you contribute that driver? yes, we are. I will need to update the SSIF driver to be

Re: [edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg: add support for the phosphor ipmi blob transfer protocol

Thanks Nickle. I'm reviewing and testing it. Will get back to you soon. On 5/15/2024 10:14 PM, Nickle Wang via groups.io wrote: Hi Nhi, Version 2 patch files are sent for review here: https://edk2.groups.io/g/devel/message/118914 and https://edk2.groups.io/g/devel/message/118922 For your con

Re: [edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg: add support for the phosphor ipmi blob transfer protocol

Thanks Nickle. I will help review and verify your patch. On 5/14/2024 8:56 AM, Nickle Wang wrote: Hi Nhi, This task is on my list but with lower priority. I will try to provide version 2 patch for review here by the end of this week. Thanks, Nickle -Original Message- From: Nhi Pham

Re: [edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg: add support for the phosphor ipmi blob transfer protocol

On 2/9/2024 11:37 PM, Chang, Abner via groups.io wrote: [AMD Official Use Only - General] Yeah, I forget this patch set and seems we don't have any follow up conversation after below feedbacks from community. https://edk2.groups.io/g/devel/message/103116 https://edk2.groups.io/g/devel/message/

Re: [edk2-devel] [PATCH v1 1/1] StandaloneMmPkg/StandaloneMmHobLib: Remove HOB creation

On 5/2/2024 4:31 AM, Oliver Smith-Denny via groups.io wrote: Hi folks, returning to this thread because I noticed that HOB creation still exists in StandaloneMmCore for ARM: https://github.com/tianocore/edk2/blob/5d4c5253e8bbc0baa8837fcd868925212df85201/StandaloneMmPkg/Library/StandaloneMmCoreEn

Re: [edk2-devel] [PATCH 1/1] CryptoPkg: Add new API to get PKCS7 Signature

On 2/1/2024 9:09 AM, Yao, Jiewen via groups.io wrote: Hi Nhi Would you please: 1) File an issue in Bugzilla - https://bugzilla.tianocore.org/ 2) Share with us the usage of this new API. We are trying to understand why it is needed. Hi Jiewen, Sorry for late response. I've just been back from

Re: [edk2-devel] [PATCH 1/1] StandaloneMmPkg/Core: Remove optimization for depex evaluation

On 1/19/2024 6:51 PM, levi.yun wrote: Except, 8bit transfer encoding. Tested-by: levi.yun Reviewed-by: levi.yun Thanks Levi Yun for testing. -Nhi -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114131): https://edk2.groups.io/g/dev

[edk2-devel] [PATCH RESEND 1/1] StandaloneMmPkg/Core: Remove optimization for depex evaluation

From: Laszlo Ersek The current dependency evaluator violates the memory access permission when patching depex grammar directly in the read-only depex memory area. Laszlo pointed out the optimization issue in the thread (1) "Memory Attribute for depex section" and provided suggested patch to remo

Re: [edk2-devel] [PATCH 1/1] StandaloneMmPkg/Core: Remove optimization for depex evaluation

On 1/19/2024 5:39 PM, Ard Biesheuvel wrote: Thanks for the patch. This looks good to me in principle, only the patch got mangled by your MTA Please resend using 8bit transfer encoding. (You can use BaseTools/Scripts/SetupGit.py to configure Git for you) Thanks Ard, I will resend the patch wi

[edk2-devel] [PATCH 1/1] StandaloneMmPkg/Core: Remove optimization for depex evaluation

From: Laszlo Ersek The current dependency evaluator violates the memory access permission when patching depex grammar directly in the read-only depex memory area. Laszlo pointed out the optimization issue in the thread (1) "Memory Attribute for depex section" and provided suggested patch to remo

Re: [edk2-devel] Memory Attribute for depex section

On 1/18/2024 9:49 PM, Laszlo Ersek wrote: but I'd prefer to just remove this optimization from standalone MM, given that not only a) it shouldn't have to deal with a large number of protocol GUIDs, but also b) the driver dispatch is much more straight-forward. (Typically, StMM drivers can be disp

Re: [edk2-devel] Memory Attribute for depex section

Hi Laszlo, On 1/16/2024 2:00 AM, Laszlo Ersek wrote: On 1/15/24 15:04, Ard Biesheuvel wrote: On Mon, 15 Jan 2024 at 14:07, Nhi Pham wrote: On 1/12/2024 4:45 PM, Laszlo Ersek wrote: (Independently: I think that's a valid thing to do for *SMM* drivers, because the entry point functions of tho

Re: [edk2-devel] Memory Attribute for depex section

On 1/12/2024 4:45 PM, Laszlo Ersek wrote: > (Independently: I think that's a valid thing to do for *SMM* drivers, > because the entry point functions of those drivers are permitted to use > both SMM and DXE/UEFI protocols. But whether the same is valid for the > *standalone* MM drivers -- that look

Re: [edk2-devel] Memory Attribute for depex section

++ disc...@edk2.groups.io On 1/8/2024 5:11 PM, Nhi Pham wrote: > Hi Ard, all, > > Could you please help explain how the depex section in an image is > mapped in terms of memory attribute? > > As my observation, dispatcher locates[1] the depex section inside the > module image and write[2] an eva

[edk2-devel] Memory Attribute for depex section

Hi Ard, all, Could you please help explain how the depex section in an image is mapped in terms of memory attribute? As my observation, dispatcher locates[1] the depex section inside the module image and write[2] an evaluated data to the depex if necessary for scheduled boot order. The probl

Re: [edk2-devel] [PATCH v1 16/17] Silicon/Ampere/AmpereAltraPkg: Add ImagePropertiesRecordLib Instance

Thanks for update. Reviewed-by: Nhi Pham On 12/1/2023 7:34 AM, Taylor Beebe wrote: ImagePropertiesRecordLib is used by DxeMain and PiSmmCore, so it needs to be added to most platforms. Signed-off-by: Taylor Beebe Cc: Nhi Pham Cc: Chuong Tran Cc: Leif Lindholm Cc: Rebecca Cran --- Silic

Re: [edk2-devel] [PATCH v1 2/2] StandaloneMmPkg: Fix HOB space and heap space conflicted issue

On 9/7/2023 10:38 PM, Nhi Pham wrote: > On 9/6/2023 11:22 PM, Oliver Smith-Denny wrote: >> On 9/6/2023 1:50 AM, Ard Biesheuvel wrote: >>> On Wed, 6 Sept 2023 at 09:56, Nhi Pham >>> wrote: On 9/6/2023 1:33 PM, Ni, Ray wrote: > [EXTERNAL EMAIL NOTICE: This email originated from an exte

Re: [edk2-devel] [Proposed Fix][PATCH v1 1/1] MdeModulePkg/DxeCapsuleLibFmp: Fix crash with VirtualAddressMap omitted

On 11/23/2023 3:36 PM, Ard Biesheuvel wrote: On Thu, 23 Nov 2023 at 05:49, Nhi Pham wrote: If the SetVirtualAddressMap() is not called, mIsVirtualAddrConverted is FALSE and the kernel crash occurs in IsNestedFmpCapsule() when executing gBS->LocateProtocol () in the else case. To serve the omi

[edk2-devel] [Proposed Fix][PATCH v1 1/1] MdeModulePkg/DxeCapsuleLibFmp: Fix crash with VirtualAddressMap omitted

If the SetVirtualAddressMap() is not called, mIsVirtualAddrConverted is FALSE and the kernel crash occurs in IsNestedFmpCapsule() when executing gBS->LocateProtocol () in the else case. To serve the omitted SetVirtualAddressMap() call, we could just check mEsrtTable presence instead of relying on

Re: [edk2-devel] [PATCH] MdeModulePkg/RegularExpressinoDxe: Fix clang error

Hi Liming, Could you please help review and get this patch merged within the next edk2-stable tag? Thanks, Nhi On 10/23/2023 11:27 AM, Nhi Pham via groups.io wrote: > This looks good to me. I also build-tested this patch. > > Reviewed-by: Nhi Pham > Tested-by: Nhi Pham > &g

Re: [edk2-devel] [PATCH] MdeModulePkg/RegularExpressinoDxe: Fix clang error

This looks good to me. I also build-tested this patch. Reviewed-by: Nhi Pham Tested-by: Nhi Pham On 10/3/2023 10:04 PM, Jake Garver via groups.io wrote: Ignore old style declaration warnings in oniguruma/src/st.c. This was already ignored for MSFT, but newer versions of clang complain as wel

Re: [edk2-devel] RFC: SetVariable callbacks

Hi Girish, I missed your reply. Sorry if I chime in very late, and you started to develop toward option 1. There are some cases that we can leverage your work here. Please see inline... On 9/21/2023 10:58 PM, Girish Mahadevan wrote: Hello Nhi, On 9/21/2023 1:41 AM, Nhi Pham via groups.io

Re: [edk2-devel] [PATCH edk2-platforms v4 4/4] SbsaQemu: disable XHCI in DSDT if not present

Acked-by: Nhi Pham Nit: I think you want to run uncrustify for Patch 3 as well :) Regards, Nhi On 10/18/2023 5:07 PM, Marcin Juszkiewicz wrote: We need platform version to be at least 0.3 to have XHCI in virtual hardware. On older platforms there is non-working EHCI which we ignore. Set DSDT

Re: [edk2-devel] [PATCH edk2-platforms v3 4/4] SbsaQemu: disable XHCI in DSDT if not present

Hi Marcin, There is a nitpicking below. Other than, it looks good to me. Acked-by: Nhi Pham Regards, Nhi On 10/17/2023 8:23 PM, Marcin Juszkiewicz wrote: We need platform version to be at least 0.3 to have XHCI in virtual hardware. On older platforms there is non-working EHCI which we ignor

Re: [edk2-devel] [PATCH edk2-platforms v2 0/4] Provide XHCI USB controller only for newer hardware

Hi Marcin, On 10/16/2023 5:06 PM, Marcin Juszkiewicz wrote: Platform version 0.3 introduced XHCI USB controller instead of EHCI one. But we did it in a way that there is no in-EDK2 check for platform version (XHCI is always given). This behaviour works with Linux as it complains about being una

Re: [edk2-devel] [edk2-platforms PATCH 1/1] AmpereAltraPkg/Ac01PcieLib: drop useless link status register read

Thanks, Laszlo for this patch. Reviewed-by: Nhi Pham Regards, Nhi On 10/17/2023 5:05 PM, Laszlo Ersek via groups.io wrote: Nhi says that reading LINK_CONTROL_LINK_STATUS_REG is redundant; its only use was debugging (before commit 380b4b40c60d). Thus, we can go farther than commit 2e27c62ef000

Re: [edk2-devel] [edk2-platforms PATCH 12/19] AmpereAltraPkg/Ac01PcieLib: fix compilation error

HI Lazslo, I was not reviewing carefully. The MmioRead32 is redundant code. Can you help me get rid of that code? Thanks, Nhi On 10/13/2023 9:20 AM, Nhi Pham wrote: Thanks for fixing it. Reviewed-by: Nhi Pham Regards, Nhi On 10/12/2023 4:09 PM, Laszlo Ersek wrote: Commit 380b4b40c60d ("A

Re: [edk2-devel] [edk2-platforms PATCH 13/19] JadePkg/PCF85063RealTimeClockLib: hide LibRtcVirtualNotifyEvent

It looks good to me. Reviewed-by: Nhi Pham Thanks, Nhi On 10/12/2023 4:09 PM, Laszlo Ersek wrote: The RealTimeClockLib class header in edk2 mistakenly declares a function called LibRtcVirtualNotifyEvent(). No component ever calls this function crossing module boundaries; all RealTimeClockLib

Re: [edk2-devel] [edk2-platforms PATCH 12/19] AmpereAltraPkg/Ac01PcieLib: fix compilation error

Thanks for fixing it. Reviewed-by: Nhi Pham Regards, Nhi On 10/12/2023 4:09 PM, Laszlo Ersek wrote: Commit 380b4b40c60d ("AmpereAltraPkg: Update Ampere specific platform PCIe core", 2023-03-29) removed the DEBUG macro call from Ac01PcieCoreUpdateLink() that was the only reader of "Val". Since

Re: [edk2-devel] [PATCH] RedfishPkg: Use base version SortLib for the specific modules

Thanks for writing this patch. Reviewed-by: Nhi Pham Tested-by: Nhi Pham Regards, Nhi On 10/11/2023 10:49 AM, Nickle Wang wrote: Reviewed-by: Nickle Wang Regards, Nickle -Original Message- From: abner.ch...@amd.com Sent: Wednesday, October 11, 2023 11:41 AM To: devel@edk2.group

Re: [edk2-devel] [PATCH 1/1] ArmPkg: Add Pcd to disable EFI_MEMORY_ATTRIBUTE_PROTOCOL

Hi Ard, Oliver, I'm investigating the crash on grub2/shim loader due to the added EFI_MEMORY_ATTRIBUTE_PROTOCOL when rebasing. I found this interesting patch and went through on the discussion, I am still not sure the conclusion on this patch. This issue impacts many platforms, and any downs

Re: [edk2-devel] RFC: SetVariable callbacks

Can we write a DXE_RUNTIME driver to override the pointers of UEFI Runtime Get/SetVariable() services? Then, we can add platform specific or custom implementation before/after calling the original Get/SetVariable()? Regards, Nhi On 9/21/2023 3:27 AM, Girish Mahadevan via groups.io wrote: Hel

Re: [edk2-devel] [PATCH edk2-platforms 1/1] Platform/Ampere: Update Readme.md

Reviewed-by: Nhi Pham Thanks, Nhi On 9/12/2023 12:44 AM, Rebecca Cran wrote: Improve the Readme.md in Platform/Ampere: - At this point eMAG is irrelevant, and most people are likely using Altra systems. Drop mention of it. - Instead of mentioning the 'latest' versions of CentOS and Ubuntu

[edk2-devel] [edk2-platforms][PATCH 1/1] Maintainers.txt: Update maintainers for Ampere platforms

This adds Rebecca Cran as reviewer, updates myself as maintainer, and Leif as reviewer. Also, removes Vu Nguyen and Thang Nguyen due to no longer working on EDK2. Signed-off-by: Nhi Pham --- Maintainers.txt | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/Maintainers.tx

Re: [edk2-devel] [PATCH v1 2/2] StandaloneMmPkg: Fix HOB space and heap space conflicted issue

On 9/6/2023 11:22 PM, Oliver Smith-Denny wrote: On 9/6/2023 1:50 AM, Ard Biesheuvel wrote: On Wed, 6 Sept 2023 at 09:56, Nhi Pham wrote: On 9/6/2023 1:33 PM, Ni, Ray wrote: [EXTERNAL EMAIL NOTICE: This email originated from an external sender. Please be mindful of safe email handling and pro

Re: [edk2-devel] [PATCH v1 2/2] StandaloneMmPkg: Fix HOB space and heap space conflicted issue

devel] [PATCH v1 2/2] StandaloneMmPkg: Fix HOB space and heap space conflicted issue On 9/4/2023 7:20 PM, Nhi Pham wrote: On 9/2/2023 3:43 AM, Oliver Smith-Denny wrote: On 8/31/2023 1:20 AM, Nhi Pham via groups.io wrote: If I am understanding this correctly, this is only an issue when HOBs are creat

Re: [edk2-devel] [PATCH v1 2/2] StandaloneMmPkg: Fix HOB space and heap space conflicted issue

On 9/6/2023 4:29 AM, Oliver Smith-Denny wrote: On 9/4/2023 7:20 PM, Nhi Pham wrote: On 9/2/2023 3:43 AM, Oliver Smith-Denny wrote: On 8/31/2023 1:20 AM, Nhi Pham via groups.io wrote: If I am understanding this correctly, this is only an issue when HOBs are created in StMM, i.e. not from HOBs

  1   2   3   4   >