Thanks Ard for the clean up and maintaining the platforms's updates.
Reviewed-by: Nhi Pham <n...@os.amperecomputing.com> Tested-by: Nhi Pham <n...@os.amperecomputing.com> Regards, Nhi On 7/29/2024 7:22 PM, Ard Biesheuvel wrote:
From: Ard Biesheuvel <a...@kernel.org> Spec adherent AArch64 systems use PSCI to manage secondary CPUs, and only enter the execution level where UEFI and the OS live using a single CPU. This means using a SEC implementation of the MPCore variety is never needed, and in practice, those drivers don't work correctly unless an older version of the GIC is used (v2), which only supports up to 8 CPUs and is therefore rare on server silicon. So switch to the UniCore flavor, which should be functionally equivalent if only a single CPU runs the UEFI firmware. Signed-off-by: Ard Biesheuvel <a...@kernel.org> --- Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc | 6 +----- Platform/Ampere/JadePkg/Jade.fdf | 2 +- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc b/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc index 977e4c4c238d..bec743e2c453 100644 --- a/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc +++ b/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc @@ -390,12 +390,8 @@ [PcdsFixedAtBuild.common] gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x2000 gEfiMdeModulePkgTokenSpaceGuid.PcdMaxAuthVariableSize|0x2800- #- # Stacks for MPCores in Normal World - # gArmPlatformTokenSpaceGuid.PcdCPUCoresStackBase|0x91100000 gArmPlatformTokenSpaceGuid.PcdCPUCorePrimaryStackSize|0x20000 - gArmPlatformTokenSpaceGuid.PcdCPUCoreSecondaryStackSize|0x1000## Maximum memory region that fits into the 32bit address space @@ -525,7 +521,7 @@ [Components.common] # # PEI Phase modules # - ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf + ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf MdeModulePkg/Core/Pei/PeiMain.inf MdeModulePkg/Universal/PCD/Pei/Pcd.inf { <LibraryClasses> diff --git a/Platform/Ampere/JadePkg/Jade.fdf b/Platform/Ampere/JadePkg/Jade.fdf index 127e4401f69b..6d1af3570287 100644 --- a/Platform/Ampere/JadePkg/Jade.fdf +++ b/Platform/Ampere/JadePkg/Jade.fdf @@ -148,7 +148,7 @@ [FV.FVMAIN_COMPACT] INF MdeModulePkg/Universal/StatusCodeHandler/Pei/StatusCodeHandlerPei.inf }- INF ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf+ INF ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf INF MdeModulePkg/Core/Pei/PeiMain.inf INF UefiCpuPkg/CpuIoPei/CpuIoPei.inf INF ArmPlatformPkg/PlatformPei/PlatformPeim.inf
-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120136): https://edk2.groups.io/g/devel/message/120136 Mute This Topic: https://groups.io/mt/107628986/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
