Thanks Rebecca. I fixed in the next version. Regards, Nhi ________________________________ From: Rebecca Cran OS <rebe...@os.amperecomputing.com> Sent: Wednesday, August 14, 2024 8:53 PM To: devel@edk2.groups.io <devel@edk2.groups.io>; Nhi Pham OS <n...@os.amperecomputing.com> Cc: quic_llind...@quicinc.com <quic_llind...@quicinc.com>; Chuong Tran OS <chu...@os.amperecomputing.com>; Rebecca Cran OS <rebe...@os.amperecomputing.com> Subject: Re: [edk2-devel] [edk2-platforms][PATCH 1/1] JadePkg: Add ACPI SPMI table
On 8/13/2024 9:33 PM, Nhi Pham via groups.io wrote: This could be a static function. > +EFI_STATUS > +EFIAPI > +AcpiInstallSpmiTable ( > + VOID > + ); > + > #endif /* ACPI_PLATFORM_H_ */ > diff --git > a/Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiPlatformDxe.c > b/Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiPlatformDxe.c > index 28c422dff166..a82a93d23fa2 100644 > --- a/Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiPlatformDxe.c > +++ b/Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiPlatformDxe.c I believe the project now prefers the use of the C keyword "static". > + // BCD Format > + SpmiTable->SpecificationRevision = DeviceId.SpecificationVersion & 0xF0; > + SpmiTable->SpecificationRevision |= (DeviceId.SpecificationVersion & > 0x0F) << 8; It took a second to understand this. Maybe combine it into a single line, or change the '0x0F' to just '0xF'? -- Rebecca -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120346): https://edk2.groups.io/g/devel/message/120346 Mute This Topic: https://groups.io/mt/107889268/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
