[AMD Official Use Only - General]
Hi Igor,
Only one comment below,
> -Original Message-
> From: Igor Kulchytskyy
> Sent: Tuesday, November 14, 2023 1:24 AM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Nickle Wang
>
> Subject: [PATCH 2/2] RedfishPkg: RedfishDiscoverDxe: Optimize the R
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Igor Kulchytskyy
> Sent: Tuesday, November 14, 2023 1:24 AM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Nickle Wang
>
> Subject: [PATCH 1/2] RedfishPkg: RedfishDiscoverDxe: Fix issue if IPv4
> i
*Reminder: TianoCore Bug Triage - APAC / NAMO*
*When:*
Tuesday, November 14, 2023
6:30pm to 7:30pm
(UTC-08:00) America/Los Angeles
*Where:*
https://teams.microsoft.com/l/meetup-join/19%3ameeting_OTk1YzJhN2UtOGQwNi00NjY4LWEwMTktY2JiODRlYTY1NmY0%40thread.v2/0?context=%7b%22Tid%22%3a%2246c98d88-e344
Hi Laszlo,
I see, I will look into this PI SPEC and try to implement it in MdePkg
first and then to update the SPEC.
Thanks,
Chao
On 2023/11/13 19:02, Laszlo Ersek wrote:
On 11/10/23 07:44, Chao Li wrote:
Hi Laszlo,
This is a good question, same as the previous email, some ARCH don't
requi
Currently, if BSP election is not enabled, will use Core0 as SMM BSP,
however, Core0 does not always have the highest performance core.
So, we can used NonSmm BSP as default BSP.
Cc: Ray Ni
Cc: Rahul Kumar
Cc: Gerd Hoffmann
Signed-off-by: Zhiguang Liu
---
UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
Hi Andrei,
I agree with you, I will move LoongArch-specific stuff from UefiCpuPkg
to MdePkg/Include/ in V3.
And you are also saied record the idea of moving ArmMmuLib to CpuMmuLib,
I would to say, this header is referenced from ArmPkg, and I plan to
move the ArmMmuLib from ArmPkg to UefiCpuP
On 11/13/2023 3:37 PM, Rebecca Cran wrote:
On 11/13/2023 1:08 PM, Michael Kubacki wrote:
Yes. I just did it. It is relatively minor and impacts expected code
areas.
https://github.com/tianocore/edk2/pull/5043/files
Could you update .git-blame-ignore-revs please?
https://black.readthedocs.i
Hi Sami,
Ok, I will fix them in V3 and follow your suggestions, thanks for the
review.
Thanks,
Chao
On 2023/11/13 19:46, Sami Mujawar wrote:
Hi Chao,
Thank you for this patch.
I have a few suggestions marked inline as [SAMI].
Otherwise this patch looks good to me.
With those fixed,
Revi
*Tools, CI, Code base construction meeting series*
*When:*
Monday, November 13, 2023
4:30pm to 5:30pm
(UTC-08:00) America/Los Angeles
*Where:*
https://teams.microsoft.com/l/meetup-join/19%3ameeting_ZDI2ZDg4NmMtMjI1My00MzI5LWFmYjAtMGQyNjUzNTBjZGYw%40thread.v2/0?context=%7b%22Tid%22%3a%2272f988bf-8
*Reminder: Tools, CI, Code base construction meeting series*
*When:*
Monday, November 13, 2023
4:30pm to 5:30pm
(UTC-08:00) America/Los Angeles
*Where:*
https://teams.microsoft.com/l/meetup-join/19%3ameeting_ZDI2ZDg4NmMtMjI1My00MzI5LWFmYjAtMGQyNjUzNTBjZGYw%40thread.v2/0?context=%7b%22Tid%22%3a%22
On Mon, Nov 13, 2023 at 8:37 PM Rebecca Cran wrote:
>
> On 11/13/2023 1:08 PM, Michael Kubacki wrote:
> > Yes. I just did it. It is relatively minor and impacts expected code
> > areas.
> >
> > https://github.com/tianocore/edk2/pull/5043/files
>
>
> Could you update .git-blame-ignore-revs please?
Hi Michael,
Have you tried to upstream the edk2 specific elements to the
uncrustify project? That would be a path to remove the fork
and eventually all the distros would catch up.
Mike
> -Original Message-
> From: Michael Kubacki
> Sent: Monday, November 13, 2023 12:22 PM
> To: Pedro F
On 11/13/2023 2:14 PM, Rebecca Cran via groups.io wrote:
On 11/13/2023 5:29 AM, Marcin Juszkiewicz via groups.io wrote:
Still a fan of adding edk2-uncrustify to BaseTools. If we are expected
to use it then let it get installed at same moment as "build" command is.
The issue with doing this is
On 11/13/2023 1:08 PM, Michael Kubacki wrote:
Yes. I just did it. It is relatively minor and impacts expected code
areas.
https://github.com/tianocore/edk2/pull/5043/files
Could you update .git-blame-ignore-revs please?
https://black.readthedocs.io/en/stable/guides/introducing_black_to_your
On 11/13/2023 2:07 PM, Pedro Falcato wrote:
On Mon, Nov 13, 2023 at 11:58 AM Laszlo Ersek wrote:
Hi Michael,
recently I encountered an uncrustify failure on github.
The reason was that my local uncrustify was *more recent* (73.0.8) than
the one we use in edk2 CI (which is 73.0.3, per the edk
On 11/13/2023 6:58 AM, Laszlo Ersek wrote:
Hi Michael,
recently I encountered an uncrustify failure on github.
The reason was that my local uncrustify was *more recent* (73.0.8) than
the one we use in edk2 CI (which is 73.0.3, per the edk2 file
".pytool/Plugin/UncrustifyCheck/uncrustify_ext_dep
On 11/13/2023 5:29 AM, Marcin Juszkiewicz via groups.io wrote:
Still a fan of adding edk2-uncrustify to BaseTools. If we are expected
to use it then let it get installed at same moment as "build" command is.
The issue with doing this is there's a push to remove all C/C++ code
from BaseTools (
On Mon, Nov 13, 2023 at 7:07 PM Pedro Falcato via groups.io
wrote:
>
> On Mon, Nov 13, 2023 at 11:58 AM Laszlo Ersek wrote:
> >
> > Hi Michael,
> >
> > recently I encountered an uncrustify failure on github.
> >
> > The reason was that my local uncrustify was *more recent* (73.0.8) than
> > the o
On Mon, Nov 13, 2023 at 11:58 AM Laszlo Ersek wrote:
>
> Hi Michael,
>
> recently I encountered an uncrustify failure on github.
>
> The reason was that my local uncrustify was *more recent* (73.0.8) than
> the one we use in edk2 CI (which is 73.0.3, per the edk2 file
> ".pytool/Plugin/UncrustifyC
On 11/13/23 07:22, Sheng Wei wrote:
> Patch V4:
> Separate the changes to 5 patches.
> 1) Add macro definitions for CET feature for NASM files.
> 2) Use macro CR4_CET_BIT to replace hard code value in Cet.nasm.
> 3) Use CET macro definitions in Cet.inc for SmiEntry.nasm files.
> 4
On 11/13/23 06:59, Yuanhao Xie wrote:
> From: Yuanhao Xie
>
> This patch synchronizes the No-Execute bit in the IA32_EFER
> register for the APs before the RestoreVolatileRegisters operation.
>
> The commit 964a4f0, titled "Eliminate the second INIT-SIPI-SIPI
> sequence," replaces the second INIT-
Filter out the network interfaces which are not supported by
Redfish Host Interface.
Cc: Abner Chang
Cc: Nickle Wang
Signed-off-by: Igor Kulchytskyy
---
.../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 169 +-
1 file changed, 120 insertions(+), 49 deletions(-)
diff --git a/Redf
Supported function of the driver changed to wait for all network
interface to be installed.
Cc: Abner Chang
Cc: Nickle Wang
Signed-off-by: Igor Kulchytskyy
---
.../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 31 ++-
1 file changed, 16 insertions(+), 15 deletions(-)
diff --git
Igor Kulchytskyy (2):
RedfishPkg: RedfishDiscoverDxe: Fix issue if IPv4 installed after
RestEx
RedfishPkg: RedfishDiscoverDxe: Optimize the Redfish Discover flow
.../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 138 +-
1 file changed, 105 insertions(+), 33 deletions(-)
--
On 11/13/23 06:47, Yuanhao Xie wrote:
> SMM read save state requires AP must be present.
> This patch aim to avoid the AP not ready for save state check.
>
> Signed-off-by: Zhihao Li
> Cc: Ray Ni
> Cc: Rahul Kumar
> Cc: Gerd Hoffmann
> ---
> UefiCpuPkg/PiSmmCpuDxeSmm/CpuService.c | 25 +++
On 11/10/23 06:22, Ranbir Singh wrote:
> From: Ranbir Singh
>
> The functions
> XhcInitializeEndpointContext and XhcInitializeEndpointContext64 has
> a switch-case code in which the case USB_ENDPOINT_CONTROL: falls
> through to default:
>
> While this may be intentional, it may not be evident to
On 11/10/23 06:22, Ranbir Singh wrote:
> From: Ranbir Singh
>
> The functions UsbHcGetHostAddrForPciAddr, UsbHcGetPciAddrForHostAddr
> and UsbHcFreeMem do have
>
> ASSERT ((Block != NULL));
>
> statements after for loop, but these are applicable only in DEBUG mode.
> In RELEASE mode, if for
On 11/9/23 18:39, Ranbir Singh wrote:
> From: Ranbir Singh
>
> The function SubmitResources has a switch-case code in which the
> case ACPI_ADDRESS_SPACE_TYPE_MEM: which falls through to
> case ACPI_ADDRESS_SPACE_TYPE_IO: to include additional common check.
>
> While this may be intentional, it ma
On 11/10/23 05:07, Ranbir Singh wrote:
> Options before us till now -
>
> 1. Add array overrun check and Debug statement before CpuDeadLoop within
This would be useless.
Your current patch implements the following pattern:
ASSERT (X);
if (!X) {
CpuDeadLoop ();
}
Option#1 would mean
On 11/9/23 21:40, Michael D Kinney wrote:
> Hi Ranbir,
>
> A deadloop without even a debug print is not good behavior.
In DEBUG and NOOPT builds, the ASSERT() would fire, hence providing a
debug message.
In RELEASE builds, even if there were a separate DEBUG message, the
DEBUG would be compiled
On 11/13/23 16:38, Laszlo Ersek wrote:
> On 11/7/23 03:43, Wu, Jiaxin wrote:
>> Processor extended information is filled when
>> CPU_V2_EXTENDED_TOPOLOGY is set in parameter ProcessorNumber
>> from GetProcessorInfo() (See commit: 1fadd18d).
>>
>> This filed value is retrieved from CPUID leaf 1FH, w
On 11/7/23 03:43, Wu, Jiaxin wrote:
> Processor extended information is filled when
> CPU_V2_EXTENDED_TOPOLOGY is set in parameter ProcessorNumber
> from GetProcessorInfo() (See commit: 1fadd18d).
>
> This filed value is retrieved from CPUID leaf 1FH, which is
> a preferred superset to leaf 0BH.
>
Reviewed-by: Kuo, Ted
Thanks,
Ted
-Original Message-
From: S, Ashraf Ali
Sent: Monday, November 13, 2023 4:12 PM
To: Ni, Ray ; devel@edk2.groups.io
Cc: Chiu, Chasel ; Desimone, Nathaniel L
; Duggapu, Chinni B
; Ng, Ray Han Lim ; Zeng,
Star ; Kuo, Ted ; Mohapatra, Susovan
Subject:
Hello,
I would like to announce DeviceSimPkg branch creation in edk2-staging
repository.
Branch will be used to develop DeviceSimPkg, a package for developing OS
executable tests
for device focused code.
Branch owner: Maciej Czajkowski , GitHub ID:
81293748 (https://github.com/mczaj)
Signed-o
Hi Charles,
On 10/26/23 03:05, Charles Hyde wrote:
> From: Charles Hyde
>
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2861
>
> I believe the attached ConfigRouting.txt patch will resolve bug 2861, plus
> resolve an uninitialized pointer issue in HiiConfigRoutingExportConfig().
> The un
On 11/10/23 20:08, Rebecca Cran wrote:
> Fix the URL for the edk2-test repo: the uefi-sct is a directory inside
> the repo.
>
> Signed-off-by: Rebecca Cran
> Contributed-under: TianoCore Contribution Agreement 1.1
> ---
> Maintainers.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
On 11/9/23 03:51, duntan wrote:
> Move gMpInformationHobGuid from StandaloneMmPkg to UefiCpuPkg.
>
> Previously, the HOB is defined, created and consumed only in StandaloneMmPkg.
> The HOB contains the number
> of processors and EFI_PROCESSOR_INFORMATION structure. This is the same as
> the info
sorry, unfinished thought:
On 11/13/23 14:39, Laszlo Ersek wrote:
> - the "sarif emacs" output seems a bit broken, actually, so it's not usable.
> Consider the following entry from the original JSON file:
>
> }, {
> "ruleId" : "cpp/missing-null-test",
> "ruleIndex" : 0,
>
On 11/7/23 16:43, Michael Kubacki wrote:
> The series that makes it easy to run CodeQL locally and have access to
> results from any PR or push to master.
>
> Those that have access can see the results directly in "Code Scanning"
> in the "Security" tab of the edk2 repo. That may be affected in ti
On 11/9/23 06:56, Ni, Ray wrote:
> Reviewed-by: Ray Ni
>
> Thanks for providing the alternative solution that avoids impacting OVMF
> boot performance.
This approach looks good to me.
The IA32 and X64 OVMF platforms use "BaseIoLibIntrinsicSev.inf", and
that library instance is left alone.
The
On 11/9/23 11:39, Hamit Can Karaca wrote:
> Hello,
> I am a young UEFI developer and I am trying to use the functions in
> Tpm2CommandLib to write data to TPM2. I have defined the index that, I
> am going to write data to, using the DefineSpace function. But whenever
> I am trying to use the Tpm2Nv
On 11/9/23 19:08, Michael D Kinney wrote:
> +Ray
>
>
>
> Unless I missed it, I do not see review of the patch series Ray sent
> back in July.
Right, please repost.
Laszlo
>
>
>
> Mike
>
>
>
> *From:* devel@edk2.groups.io *On Behalf Of *Aaron
> Young via groups.io
> *Sent:* Thursday,
W dniu 13.11.2023 o 12:58, Laszlo Ersek pisze:
Note that 73.0.3 indents the subexpression to the "//" comment on the
previous line, while 73.0.8 ignores the comment -- which I think is
justified here.
I believe this improvement may come from uncrustify commit 239c4fad745b
("Prevent endless inde
On Mon, Nov 13, 2023 at 01:59:48PM +0800, xieyuanh wrote:
> From: Yuanhao Xie
>
> This patch synchronizes the No-Execute bit in the IA32_EFER
> register for the APs before the RestoreVolatileRegisters operation.
>
> The commit 964a4f0, titled "Eliminate the second INIT-SIPI-SIPI
> sequence," rep
Hi Michael,
recently I encountered an uncrustify failure on github.
The reason was that my local uncrustify was *more recent* (73.0.8) than
the one we use in edk2 CI (which is 73.0.3, per the edk2 file
".pytool/Plugin/UncrustifyCheck/uncrustify_ext_dep.yaml").
Updating the version number in the
Hi Chao,
Thank you for this patch.
I have a few suggestions marked inline as [SAMI].
Otherwise this patch looks good to me.
With those fixed,
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 06/11/2023 03:29 am, Chao Li wrote:
Moved PcdDeviceTreeInitialBaseAddress and PcdDeviceTreeAllo
On 11/8/23 02:06, Michael D Kinney wrote:
> Hi Jose,
>
>
>
> 1. This logic needs to move into an AARCH64 specific directory/file.
> Other architectures handle this in other ways.
> 2. There are many places throughout edk2 sources that perform PCI
> config write operations. You are o
On 11/8/23 05:11, Wu, Jiaxin wrote:
> Hi Laszlo,
>
>>>
>>> The patch looks OK to me, but:
>>>
>>> - I would like to test it with CPU hotplug (later, likely under v2), and
>>>
>
> Sure, I can wait the update from you.
>
>>> - I think this should be two patches.
>>>
>>> First, the SmmAddProcessor(
On 11/10/23 07:11, Ranbir Singh wrote:
> EFI_NOT_READY was listed as one of the error return values in the
> function header of StartPciDevices(). So, I considered it here.
>
> Maybe we can go by a dual approach, including CpuDeadLoop() in
> StartPciDevices() as well as add return value check at t
On 11/8/23 05:29, Ranbir Singh wrote:
> Hi Mike,
>
> I agree that any manual inspection is sort of a burden, more so when it
> becomes repetitive in the long run.
>
> When I was doing these Coverity checks (Nov-Dec' 2022), I was working in
> Dell and had access to the real systems to check the ex
Hi Gerd,
In v4 , InterlockedIncrement called is after RestoreVolatileRegisters to ensure
that "finished" reporting from the APs is as
later as possible.
Here is V3：
GetProcessorNumber (CpuMpData, &ProcessorNumber);
- RestoreVolatileRegisters (&CpuMpData->CpuData[0].VolatileRegisters, FALSE);
On 11/10/23 10:46, Gerd Hoffmann wrote:
> On Fri, Nov 10, 2023 at 03:09:47PM +0800, Chao Li wrote:
>> Hi Laszlo,
>>
>> Sorry, I'm not check carefully, it is really **copied**, and we not think
>> the ARM version is not good enough.
>>
>> So, can I move this library to OvmfPkg so other ARCH use it e
On 11/10/23 07:44, Chao Li wrote:
> Hi Laszlo,
>
> This is a good question, same as the previous email, some ARCH don't
> require running code on memory during PEI phase or other reason can not
> used the MdePkg version, so this pointer will be saved by some register,
> I saw the ArmPkg version al
> diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.c
> b/UefiCpuPkg/Library/MpInitLib/MpLib.c
> index 9a6ec5db5c..f29e66a14f 100644
> --- a/UefiCpuPkg/Library/MpInitLib/MpLib.c
> +++ b/UefiCpuPkg/Library/MpInitLib/MpLib.c
> @@ -910,9 +910,16 @@ DxeApEntryPoint (
>CPU_MP_DATA *CpuMpData
>)
On Fri, Nov 10, 2023 at 08:14:39PM -0600, Michael Roth wrote:
> The struct used for GHCB-based page-state change requests uses a 40-bit
> bit-field for the GFN, which is shifted by PAGE_SHIFT to generate a
> 64-bit address. However, anything beyond 40-bits simply gets shifted off
> when doing this,
On 11/10/23 05:51, Chao Li wrote:
> Hi Laszlo,
>
> Sorry, it is my fault, I should separate this this patch for two
> standalone patches, and with some detailed commit message. I will fix
> this in V3.
>
> Currently, there are two libraries are not independent, so I guess you
> are talking about
Hi,
On Sat, Nov 11, 2023 at 12:57:43AM +0100, Laszlo Ersek wrote:
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4588
> CI: https://github.com/tianocore/edk2/pull/5031 (@ 961d5add9f03)
>
> Remove the Compatibility Support Module (CSM) from OVMF (after
> edk2-stable202311).
Nice cleanup.
On 11/13/23 04:15, Ni, Ray wrote:
> I provided 4 comments in below, starting with "[Ray".
>
> Sorry for the poor new Outlook that I am not able to put ">" in the
> original email.
>
> Thanks,
> Ray
>
>
>
> (1) I agree that
On Fri, Nov 10, 2023 at 11:48:04AM +0100, Pierre Gondois wrote:
> v3:
> - Use ArmPkg's function to access register:
> - Dropped:
> - [PATCH v2 1/7] MdePkg/BaseLib: AARCH64: Add ArmReadCntPctReg()
> - [PATCH v2 2/7] MdePkg/BaseLib: AARCH64: Add ArmReadIdAA64Isar0Reg()
> - [PATCH v2 3/7
Hi Chasel,
On 11/10/23 02:13, Chiu, Chasel wrote:
>
> Hi Laszlo,
>
> I verified and encountered build failure as some files still consuming
> definitions from LegacyBiosMpTable.h, for example:
> https://github.com/tianocore/edk2-platforms/blob/899a9dc97cd54690513380ad01ee8b2609dbefd5/Platform/I
Hi,
> - GetProcessorNumber (CpuMpData, &ProcessorNumber);
> - RestoreVolatileRegisters (&CpuMpData->CpuData[0].VolatileRegisters, FALSE);
> - InterlockedIncrement ((UINT32 *)&CpuMpData->FinishedCount);
> - PlaceAPInMwaitLoopOrRunLoop (
> -CpuMpData->ApLoopMode,
> -CpuMpData->CpuData[
Reviewed-by: S, Ashraf Ali
Thanks.,
S, Ashraf Ali
-Original Message-
From: Ni, Ray
Sent: Monday, November 13, 2023 1:09 PM
To: devel@edk2.groups.io
Cc: Chiu, Chasel ; Desimone, Nathaniel L
; Duggapu, Chinni B
; Ng, Ray Han Lim ; Zeng,
Star ; Kuo, Ted ; S, Ashraf Ali
; Mohapatra, Su
62 matches
Mail list logo
