On 11/10/23 10:46, Gerd Hoffmann wrote: > On Fri, Nov 10, 2023 at 03:09:47PM +0800, Chao Li wrote: >> Hi Laszlo, >> >> Sorry, I'm not check carefully, it is really **copied**, and we not think >> the ARM version is not good enough. >> >> So, can I move this library to OvmfPkg so other ARCH use it easily? > > Moving code from ArmVirtPkg to OvmfPkg is fine. > > OvmfPkg is the home for both x86 virtual machine bits and shared code. > The later used to be mostly virtio drivers, but with the arrival of > riscv some fdt support code has already moved from ArmVirtPkg to OvmfPkg > so arm and riscv can share it. Doing the same for loongarch is > perfectly fine.
Agreed! The naming of course remains tricky. :) It's not easy to come up with good names for distinguishing various instances of the same library class. I suggest renaming "OvmfPkg/PlatformBootManagerLib" to "PlatformBootManagerLibX86", and calling ArmVirtPkg's instance (once moved) PlatformBootManagerLibGeneric or just PlatformBootManagerLib. Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111140): https://edk2.groups.io/g/devel/message/111140 Mute This Topic: https://groups.io/mt/102413902/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
