On 11/8/23 05:29, Ranbir Singh wrote: > Hi Mike, > > I agree that any manual inspection is sort of a burden, more so when it > becomes repetitive in the long run. > > When I was doing these Coverity checks (Nov-Dec' 2022), I was working in > Dell and had access to the real systems to check the execution flow as > well as the Coverity status. I could never post these patches while > being there, but happened to raise Bugzilla's and post them there > instead hoping that they would be taken up by somebody further. > > I am no longer with Dell and later on when I found that those BZ / > issues pointed out by Coverity still exist as there are no code changes > in related contexts, I thought of taking them forward in whatever > limited capacity I can. I am a bit hesitant to do any further code > changes as now I do not have any systems to check the execution flow as > well as the Coverity status. So, I do not guarantee, but will try to > make the code changes wherever it is easy to ascertain that the > functional flow would not be impacted and the same issue won't exist > anymore.
This makes me a bit sad. I was happy to see that a company seriously invested in cleaning up Coverity issue reports all over edk2. If you don't have the environment and/or the assignment to continue doing that, then I agree that further tweaking these patches is unjustifed. (Sorry, I didn't realize the background when I reviewed your patches.) New versions would effectively mean "untested" code (untested as in not tested with Coverity specifically). In particular because the purported warning fixes will require real edk2 review (and occasionally regression testing even), which doesn't look good if we can't even be sure that the change actually placates coverity. I guess we should upstream those of your patches that are fine right as they are, and drop the rest for now. (A pity!) Accordingly, if you think some of my review comments are not especially important in this light (i.e., whenever it is better to take the patch as is, than to drop an updated version due to untestability), then please do comment so explicitly! Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111142): https://edk2.groups.io/g/devel/message/111142 Mute This Topic: https://groups.io/mt/102438299/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
