Re: [edk2-devel] [PATCH v3 3/8] DynamicTablesPkg: AcpiSsdtPcieLibArm: Fix _PRT description

2022-01-29 Thread Marc Zyngier
On Sat, 29 Jan 2022 15:52:02 +, Ard Biesheuvel wrote: > > (+ Marc) > > On Fri, 28 Jan 2022 at 16:41, wrote: > > > > From: Pierre Gondois > > > > In ACPI 6.4, s6.2.13, _PRT objects describing PCI legacy interrupts > > can be defined following 2 models. > > In the first model, a _SRS object

Re: [edk2-devel] [PATCH v2 2/2] OvmfPkg/BaseCachingPciExpressLib: Update BaseCachingPciExpressLib.inf

2022-01-29 Thread Abner Chang
> -Original Message- > From: Ard Biesheuvel > Sent: Sunday, January 30, 2022 1:17 AM > To: edk2-devel-groups-io ; Chang, Abner (HPS > SW/FW Technologist) > Cc: Schaefer, Daniel (ROM Janitor) ; Sunil V L > ; Ard Biesheuvel ; > Jiewen Yao ; Jordan Justen > ; Gerd Hoffmann ; Leif > Lindhol

Re: [edk2-devel] [PATCH 2/2] NetworkPkg: Add the missing VariablePolicyHelperLib in NetworkPkg.dsc

2022-01-29 Thread Wu, Jiaxin
Reviewed-by: Jiaxin Wu > -Original Message- > From: devel@edk2.groups.io On Behalf Of > gaoliming > Sent: Friday, January 28, 2022 5:14 PM > To: devel@edk2.groups.io > Cc: Maciej Rabeda ; Wu, Jiaxin > ; Fu, Siyuan > Subject: [edk2-devel] [PATCH 2/2] NetworkPkg: Add the missing > Varia

Re: [edk2-devel] [PATCH 2/2] CryptoPkg: Add BigNum NullLib

2022-01-29 Thread Yao, Jiewen
thank you since you are talking about size optimization, would you please share the result? thank you! Yao, Jiewen > 在 2022年1月30日,上午6:10,Li, Yi1 写道: > > This patch is used to add CryptBnNull library, which is used to > optimize code size. > > Signed-off-by: yi1 li > > Cc: Jiewen Yao > Cc

[edk2-devel] [PATCH 2/2] CryptoPkg: Add BigNum NullLib

2022-01-29 Thread yi1 li
This patch is used to add CryptBnNull library, which is used to optimize code size. Signed-off-by: yi1 li Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang --- .../Library/BaseCryptLib/Bn/CryptBnNull.c | 525 ++ .../Library/BaseCryptLib/PeiCryptLib.inf |

[edk2-devel] [PATCH 1/2] CryptoPkg: Add BigNum support

2022-01-29 Thread yi1 li
This patch is used to add CryptBn library, which is wrapped over OpenSSL. The implementation provides CryptBn library functions for EFI BaseCrypt protocol and EFI BaseCrypt Configuration Protocol. Signed-off-by: yi1 li Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang --- Crypto

[edk2-devel] [PATCH 0/2] CryptoPkg: Add BigNum support

2022-01-29 Thread yi1 li
This patch series is used to add CryptBn library, which is wrapped over OpenSSL. The implementation provides CryptBn library functions for EFI BaseCrypt protocol and EFI BaseCrypt Configuration Protocol. yi1 li (2): CryptoPkg: Add BigNum support CryptoPkg: Add BigNum NullLib CryptoPkg/Crypto

Re: [edk2-devel] [PATCH v2 1/2] OvmfPkg/BaseCachingPciExpressLib: Migrate BaseCachingPciExpressLib

2022-01-29 Thread Ard Biesheuvel
On Sat, 29 Jan 2022 at 18:05, Abner Chang wrote: > > Move BaseCachingPciExpressLib library from ArmVirtPkg to under OvmfPkg. > RISC-V Virt platform can leverage the same library to access PCI Express > registers through PCI Express base address set in PcdPciExpressBaseAddress > and cached in a glo

Re: [edk2-devel] [PATCH v2 2/2] OvmfPkg/BaseCachingPciExpressLib: Update BaseCachingPciExpressLib.inf

2022-01-29 Thread Ard Biesheuvel
On Sat, 29 Jan 2022 at 18:05, Abner Chang wrote: > > Remove the dependency with ArmVirtPkg and add RISCV64 in VALID_ARCHITECTURES. > > Signed-off-by: Abner Chang > Cc: Daniel Schaefer > Cc: Sunil V L > Cc: Ard Biesheuvel > Cc: Jiewen Yao > Cc: Jordan Justen > Cc: Gerd Hoffmann > Cc: Leif Li

Re: [edk2-devel] [PATCH v2 0/5] OvmfPkg/QemuVideoDxe: pick up display resolution settings from the host

2022-01-29 Thread Ard Biesheuvel
On Mon, 17 Jan 2022 at 10:58, Gerd Hoffmann wrote: > > See last patch in the series for details. > > v2: > - rebase to latest master > - more verbose commit message explaining the >motivation for the new PCD (see patch #1). > > Gerd Hoffmann (5): > OvmfPkg: add PcdVideoResolutionSource >

[edk2-devel] [PATCH v2 2/2] OvmfPkg/BaseCachingPciExpressLib: Update BaseCachingPciExpressLib.inf

2022-01-29 Thread Abner Chang
Remove the dependency with ArmVirtPkg and add RISCV64 in VALID_ARCHITECTURES. Signed-off-by: Abner Chang Cc: Daniel Schaefer Cc: Sunil V L Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Cc: Leif Lindholm Cc: Sami Mujawar --- .../BaseCachingPciExpressLib/BaseCaching

[edk2-devel] [PATCH v2 1/2] OvmfPkg/BaseCachingPciExpressLib: Migrate BaseCachingPciExpressLib

2022-01-29 Thread Abner Chang
Move BaseCachingPciExpressLib library from ArmVirtPkg to under OvmfPkg. RISC-V Virt platform can leverage the same library to access PCI Express registers through PCI Express base address set in PcdPciExpressBaseAddress and cached in a global variable. Signed-off-by: Abner Chang Cc: Daniel Schaef

[edk2-devel] [PATCH v2 0/2] Migrate BaseCachingPciExpressLib

2022-01-29 Thread Abner Chang
Move BaseCachingPciExpressLib library from ArmVirtPkg to under OvmfPkg. RISC-V Virt platform can leverage the same library to access PCI Express registers through PCI Express base address set in PcdPciExpressBaseAddress and cached in a global variable. In V2: One patch for movement and ArmVirtPkg

Re: [edk2-devel] [PATCH 02/11] ArmVirtPkg: Remove All UGA Support

2022-01-29 Thread Ard Biesheuvel
On Fri, 14 Jan 2022 at 01:51, Guomin Jiang wrote: > > From: GuoMinJ > > REF: https//bugzilla.tianocore.org/show_bug.cgi?id=2368 > > Remove PcdConOutGopSupport, it is unnecessary any more. > Remove All UGA Support in ArmVirtPkg > > Signed-off-by: Guomin Jiang > Cc: Ard Biesheuvel > Cc: Leif Lind

Re: [edk2-devel] [PATCH 0/2] change qemu default resolution to 1280x800

2022-01-29 Thread Ard Biesheuvel
On Fri, 21 Jan 2022 at 14:01, Gerd Hoffmann wrote: > > > > Gerd Hoffmann (2): > OvmfPkg: change qemu default resolution to 1280x800 > ArmVirtPkg: change qemu default resolution to 1280x800 > Acked-by: Ard Biesheuvel Merged as #2454 Thanks, > ArmVirtPkg/ArmVirtQemu.dsc | 4 ++-- > A

Re: [edk2-devel] [PATCH v3 3/8] DynamicTablesPkg: AcpiSsdtPcieLibArm: Fix _PRT description

2022-01-29 Thread Ard Biesheuvel
(+ Marc) On Fri, 28 Jan 2022 at 16:41, wrote: > > From: Pierre Gondois > > In ACPI 6.4, s6.2.13, _PRT objects describing PCI legacy interrupts > can be defined following 2 models. > In the first model, a _SRS object must be described to modify the PCI > interrupt. The _CRS and _PRS object allows

Re: [edk2-devel] [PATCH 0/2] Migrate ArmVirtPkg BaseCachingPciExpressLib

2022-01-29 Thread Abner Chang
> -Original Message- > From: Gerd Hoffmann > Sent: Thursday, January 27, 2022 9:20 PM > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) > > Cc: Schaefer, Daniel (ROM Janitor) ; Sunil V L > ; Ard Biesheuvel ; > Jiewen Yao ; Jordan Justen > ; Leif Lindholm ; Sami > Mujawa

Re: [edk2-devel] [PATCH v3 2/8] DynamicTablesPkg: FdtHwInfoParserLib: Parse Pmu info

2022-01-29 Thread Ard Biesheuvel
On Fri, 28 Jan 2022 at 16:41, PierreGondois wrote: > > From: Pierre Gondois > > Parse the Pmu interrupts if a pmu compatible node is present, > and populate the MADT GicC structure accordingly. > > Signed-off-by: Pierre Gondois > --- > > Notes: > v3: > - New patch. [Pierre] > > .../Fdt

Re: [edk2-devel] [PATCH v1 1/1] Maintainers.txt: Add Sami Mujawar as reviewer for ArmPkg

2022-01-29 Thread Ard Biesheuvel
On Wed, 19 Jan 2022 at 11:20, Sami Mujawar wrote: > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Signed-off-by: Sami Mujawar Excellent idea! Merged as #2453 Thanks, > --- > > Notes: > v1: > - Add Sami as the reviewer for ArmPkg[SAMI] >Ref: https://edk2.groups.io/g/dev

Re: [edk2-devel] [PATCH 0/2] Migrate ArmVirtPkg BaseCachingPciExpressLib

2022-01-29 Thread Abner Chang
Thanks for the reminder. Apparently, I missed Gerd's feedback. His reply is buried with another patch set he sent in my mailbox. Abner From: Ard Biesheuvel Sent: Saturday, January 29, 2022 2:06 AM To: edk2-devel-groups-io ; Chang, Abner (HPS SW/FW Technologist)

Re: [edk2-devel] [edk2-platforms PATCH] Platform/RaspberryPi: Add 'clock-frequency' property for miniuart

2022-01-29 Thread Ard Biesheuvel
(+ Jeremy) On Fri, 28 Jan 2022 at 16:40, Adrien Thierry wrote: > > Describe the miniuart clock frequency in a _DSD property, so that it can > be read from the Linux driver. > > The miniuart clock frequency is the core clock frequency on the > Raspberry Pi. It can be modified by the user using the

[edk2-devel] [PATCH] ArmVirtPkg/ArmVirtMemoryInitPeiLib: avoid redundant cache invalidation

2022-01-29 Thread Ard Biesheuvel
Alex reports that the cache invalidation performed by ArmVirtMemoryInitPeiLib takes a non-negligible amount of time at boot. This cache invalidation used to be necessary to avoid inconsistencies between the CPU's cached and uncached views of the permanent PEI memory region, given that the PEI phase

[edk2-devel] [PATCH 33/33] BlSupportSmm: fix definition of SetSmrr()

2022-01-29 Thread Sean Rhodes
From: Matt DeVillier Signed-off-by: Matt DeVillier Change-Id: Id5b077ad6c79717a9d97d4228145791ef062962c --- UefiPayloadPkg/BlSupportSmm/BlSupportSmm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/UefiPayloadPkg/BlSupportSmm/BlSupportSmm.c b/UefiPayloadPkg/BlSupportSmm/BlSupportSmm.c ind

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Add support for logging to CBMEM console

2022-01-29 Thread Sean Rhodes
Hey Benjamin The commit has been around for a while now and is perfectly functional. Why don't we upstream it and then `FindCbTag()` and `CopyMem()` can be a follow-up patch when/if time allows? Cheers Sean Squashing that commit in: [PATCH] UefiPayloadPkg: Add support for logging to CBMEM cons

Re: [edk2-devel] [PATCH 32/32] UefiPayloadPkg: Add build option for Above 4G Memory

2022-01-29 Thread Sean Rhodes
Thanks :) I've updated the PR. Do I need to resend the new patch again? [PATCH 33/33] UefiPayloadPkg: Add build option for Above 4G Memory When build option ABOVE_4G_MEMORY is set to true, nothing will change and EDKII will use all available memory. Setting it to false will create memory type i

Re: [edk2-devel] [PATCH 32/32] UefiPayloadPkg: Add build option for Above 4G Memory

2022-01-29 Thread Sean Rhodes
When build option ABOVE_4G_MEMORY is set to true, nothing will change and EDKII will use all available memory. Setting it to false will create memory type information HOB in payload entry, so that EDKII will reserve enough memory below 4G for EDKII modules. This option is useful for bootloaders th

[edk2-devel] [PATCH 1/1] UefiPayloadPkg/PayloadLoaderPeim: Replace Delta type INTN with UINTN

2022-01-29 Thread Guomin Jiang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3818 ProcessRelocation64 use INTN Delta. However it force it to UINTN when call it. It will have some potential issue when memory larger than 2G because the high memory address will be fill with 0x if use INTN. Cc: Guo Dong Cc: Ray Ni