> -----Original Message-----
> From: Gerd Hoffmann <kra...@redhat.com>
> Sent: Thursday, January 27, 2022 9:20 PM
> To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist)
> <abner.ch...@hpe.com>
> Cc: Schaefer, Daniel (ROM Janitor) <daniel.schae...@hpe.com>; Sunil V L
> <suni...@ventanamicro.com>; Ard Biesheuvel <ardb+tianoc...@kernel.org>;
> Jiewen Yao <jiewen....@intel.com>; Jordan Justen
> <jordan.l.jus...@intel.com>; Leif Lindholm <l...@nuviainc.com>; Sami
> Mujawar <sami.muja...@arm.com>
> Subject: Re: [edk2-devel] [PATCH 0/2] Migrate ArmVirtPkg
> BaseCachingPciExpressLib
>
> On Mon, Jan 24, 2022 at 09:52:07PM +0800, Abner Chang wrote:
> > Clone BaseCachingPciExpressLib library from ArmVirtPkg to under OvmfPkg.
> > RISC-V Virt platform can leverage the same library to access PCI Express
> > registers through PCI Express base address set in
> PcdPciExpressBaseAddress
> > and cached in a global variable. Also remove the one under ArmVirtPkg.
> >
> > Signed-off-by: Abner Chang <abner.ch...@hpe.com>
> > Cc: Daniel Schaefer <daniel.schae...@hpe.com>
> > Cc: Sunil V L <suni...@ventanamicro.com>
> > Cc: Ard Biesheuvel <ardb+tianoc...@kernel.org>
> > Cc: Jiewen Yao <jiewen....@intel.com>
> > Cc: Jordan Justen <jordan.l.jus...@intel.com>
> > Cc: Gerd Hoffmann <kra...@redhat.com>
> > Cc: Leif Lindholm <l...@nuviainc.com>
> > Cc: Sami Mujawar <sami.muja...@arm.com>
>
> Given you are mostly moving code around as git noticed ...
>
> > rename {ArmVirtPkg =>
> OvmfPkg}/Library/BaseCachingPciExpressLib/BaseCachingPciExpressLib.inf
> (87%)
> > rename {ArmVirtPkg =>
> OvmfPkg}/Library/BaseCachingPciExpressLib/PciExpressLib.c (100%)
>
> ... it doesn't make sense to split that into two patches.
Hi Gerd,
I missed this message.
Because the movement impacts two packages thus I split this change into two
patches. I just realized that you are the reviewer of these two packages, I
will send the v2 that keeps the git history.
Thanks
Abner
>
> Just using "git mv" instead has the additional advantage to keep the git
> history intact (using 'git log --follow').
>
> take care,
> Gerd
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#86208): https://edk2.groups.io/g/devel/message/86208
Mute This Topic: https://groups.io/mt/88647809/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
