Thanks for the reminder. Apparently, I missed Gerd's feedback. His reply is 
buried with another patch set he sent in my mailbox.

Abner
________________________________
From: Ard Biesheuvel <[email protected]>
Sent: Saturday, January 29, 2022 2:06 AM
To: edk2-devel-groups-io <[email protected]>; Chang, Abner (HPS SW/FW 
Technologist) <[email protected]>
Cc: Schaefer, Daniel (ROM Janitor) <[email protected]>; Sunil V L 
<[email protected]>; Ard Biesheuvel <[email protected]>; Jiewen 
Yao <[email protected]>; Jordan Justen <[email protected]>; Gerd 
Hoffmann <[email protected]>; Leif Lindholm <[email protected]>; Sami Mujawar 
<[email protected]>
Subject: Re: [edk2-devel] [PATCH 0/2] Migrate ArmVirtPkg 
BaseCachingPciExpressLib

On Fri, 28 Jan 2022 at 17:14, Abner Chang <[email protected]> wrote:
>
> Hi package owners,
> Please take a look at this patch, this patch moves ArmVirtPkg 
> BaseCachingPciExpressLib to OvmfPkg for OvmfRiscV64.
>

Do you intend to incorporate Gerd's feedback?

>
> ________________________________
> From: [email protected] <[email protected]> on behalf of Abner Chang 
> <[email protected]>
> Sent: Monday, January 24, 2022 9:52 PM
> To: [email protected] <[email protected]>
> Cc: Chang, Abner (HPS SW/FW Technologist) <[email protected]>; Schaefer, 
> Daniel (ROM Janitor) <[email protected]>; Sunil V L 
> <[email protected]>; Ard Biesheuvel <[email protected]>; 
> Jiewen Yao <[email protected]>; Jordan Justen <[email protected]>; 
> Gerd Hoffmann <[email protected]>; Leif Lindholm <[email protected]>; Sami 
> Mujawar <[email protected]>
> Subject: [edk2-devel] [PATCH 0/2] Migrate ArmVirtPkg BaseCachingPciExpressLib
>
> Clone BaseCachingPciExpressLib library from ArmVirtPkg to under OvmfPkg.
> RISC-V Virt platform can leverage the same library to access PCI Express
> registers through PCI Express base address set in PcdPciExpressBaseAddress
> and cached in a global variable. Also remove the one under ArmVirtPkg.
>
> Signed-off-by: Abner Chang <[email protected]>
> Cc: Daniel Schaefer <[email protected]>
> Cc: Sunil V L <[email protected]>
> Cc: Ard Biesheuvel <[email protected]>
> Cc: Jiewen Yao <[email protected]>
> Cc: Jordan Justen <[email protected]>
> Cc: Gerd Hoffmann <[email protected]>
> Cc: Leif Lindholm <[email protected]>
> Cc: Sami Mujawar <[email protected]>
>
> Abner Chang (2):
>   OvmfPkg/BaseCachingPciExpressLib: Clone ArmVirtPkg
>     BaseCachingPciExpressLib
>   ArmVirtPkg/BaseCachingPciExpressLib: Remove BaseCachingPciExpressLib
>
>  ArmVirtPkg/ArmVirt.dsc.inc                                  | 2 +-
>  ArmVirtPkg/ArmVirtKvmTool.dsc                               | 6 +++---
>  .../BaseCachingPciExpressLib/BaseCachingPciExpressLib.inf   | 5 +++--
>  .../Library/BaseCachingPciExpressLib/PciExpressLib.c        | 0
>  4 files changed, 7 insertions(+), 6 deletions(-)
>  rename {ArmVirtPkg => 
> OvmfPkg}/Library/BaseCachingPciExpressLib/BaseCachingPciExpressLib.inf (87%)
>  rename {ArmVirtPkg => 
> OvmfPkg}/Library/BaseCachingPciExpressLib/PciExpressLib.c (100%)
>
> --
> 2.31.1
>
>
>
>
>
>
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#86205): https://edk2.groups.io/g/devel/message/86205
Mute This Topic: https://groups.io/mt/88647809/21656
Group Owner: [email protected]
Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-


Reply via email to