Re: [edk2-devel] [PATCH 07/23] MdePkg: Update BaseIoLibIntrinsicSev to support Tdx

2021-08-17 Thread Min Xu
On August 17, 2021 4:38 PM, Gerd Hoffmann wrote: > > Hi, > > > In the I/O functions of above files, if IsTdxGuest() returns TRUE, > > then Td I/O routine is called, otherwise the legacy I/O routine is called. > > Td I/O routines are declared in IoLibTdx.h and implemented in > > IoLibInternalTdx

[edk2-devel] [PATCH] Package: CryptoPkg/BaseCryptLib: fix incorrect param order

2021-08-17 Thread Stewart, Chris (SW Architect) via groups.io
[PATCH] Package: CryptoPkg/BaseCryptLib: fix incorrect param order REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3550 Function ConvertAsn1TimeToEfiTime initializes timestamp to zeroes with SetMem, but the actual parameters are out of order. The result is the SetMem operation has no effect.

[edk2-devel] [edk2-libc Patch 9/9] AppPkg/Applications/Python/Python-2.7.10: Update INF lib classes

2021-08-17 Thread Michael D Kinney
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3549 Add BsdSocketLib and EfiSocketLib to [LibraryClasses] section of Python-2.7.10.inf. Even if sockets are disabled in Python config, with the /WHOLEARCHIVE linker option, there are still references to the socket related functions. Add these

[edk2-devel] [edk2-libc Patch 8/9] AppPkg/Applications/Python: Enable HAVE_COPYSIGN define

2021-08-17 Thread Michael D Kinney
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3549 Update Python configuration to enable the HAVE_COPYSIGN define to prevent multiple defined symbols link failure for copysign(). Cc: Rebecca Cran Signed-off-by: Michael D Kinney --- AppPkg/Applications/Python/Ia32/pyconfig.h

[edk2-devel] [edk2-libc Patch 4/9] StdLib/LibC/gdtoa: Remove source file with unused ldtoa() function.

2021-08-17 Thread Michael D Kinney
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3549 Removing the ldtoa.c file from the INF removes the ldtoa() function from this library. The ldtoa() function is not used and when /WHOLEARCHIVE linker flag is enabled this unused function makes references to other functions that are not impl

[edk2-devel] [edk2-libc Patch 3/9] StdLib: Remove SocketDxe from build

2021-08-17 Thread Michael D Kinney
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3549 SocketDxe generates build failures with VS2017 and VS2019 due to use of weak references and /WHOLEARCHIVE. Disable SocketDxe until weak references can be removed. Cc: Rebecca Cran Signed-off-by: Michael D Kinney --- StdLib/StdLib.inc |

[edk2-devel] [edk2-libc Patch 6/9] StdLib/BsdSocketLib: Add /wd4706 to CC_FLAGS

2021-08-17 Thread Michael D Kinney
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3549 Disable warning 4706 to allow assignments in conditional statements. Cc: Rebecca Cran Signed-off-by: Michael D Kinney --- StdLib/BsdSocketLib/BsdSocketLib.inf | 3 +++ 1 file changed, 3 insertions(+) diff --git a/StdLib/BsdSocketLib/Bsd

[edk2-devel] [edk2-libc Patch 5/9] StdLib/BsdSocketLib: Add missing LibNetUtil dependency to INF

2021-08-17 Thread Michael D Kinney
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3549 Add LibNetUtil to BsdSocketLib INF file that fails with missing symbols for inet_ntoa(), inet_aton(), inet_ntop(), inet_network() when BsdSocketLib is linked to another component. Cc: Rebecca Cran Signed-off-by: Michael D Kinney --- StdL

[edk2-devel] [edk2-libc Patch 1/9] StdLib: Add /Wv:11 to VS2017/VS2019 CC_FLAGS

2021-08-17 Thread Michael D Kinney
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3549 Add /Wv:11 to VS2017/VS2017 CC_FLAGS to match the warning level used by VS2015. Cc: Rebecca Cran Signed-off-by: Michael D Kinney --- StdLib/StdLib.inc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/StdLib/StdLib.inc b/StdLib/StdLi

[edk2-devel] [edk2-libc Patch 7/9] AppPkg: Add MdeLibs.dsc.inc to AppPkg.dsc

2021-08-17 Thread Michael D Kinney
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3549 Fix missing RegisterFilterLib build failure by adding MdeLibs.dsc.inc after the [Defines] section of AppPkg.dsc. Cc: Rebecca Cran Signed-off-by: Michael D Kinney --- AppPkg/AppPkg.dsc | 2 ++ 1 file changed, 2 insertions(+) diff --git a

[edk2-devel] [edk2-libc Patch 0/9] Update for edk2/master and VS2017/VS2019

2021-08-17 Thread Michael D Kinney
Update AppPkg and StdLib* to build using latest edk2/master and support VS2017 and VS2019. Most of the changes are related to warning levels, missing symbols and duplicate symbols that were uncovered by the use of the /WHOLEARCHIVE flag. Cc: Rebecca Cran Signed-off-by: Michael D Kinney Michae

[edk2-devel] [edk2-libc Patch 2/9] StdLib: Add MdeLibs.dsc.inc to StdLib.dsc

2021-08-17 Thread Michael D Kinney
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3549 Fix missing RegisterFilterLib build failure by adding MdeLibs.dsc.inc after the [Defines] section of StdLib.dsc. Cc: Rebecca Cran Signed-off-by: Michael D Kinney --- StdLib/StdLib.dsc | 2 ++ 1 file changed, 2 insertions(+) diff --git a

Re: [edk2-devel] [Patch v4 0/3] Ext4Pkg: Add Ext4Pkg

2021-08-17 Thread Michael D Kinney
pushed to edk2-platforms/master 109380a7a8..c2ab6bab4b Mike > -Original Message- > From: Kinney, Michael D > Sent: Tuesday, August 17, 2021 10:16 PM > To: devel@edk2.groups.io; pedro.falc...@gmail.com; Kinney, Michael D > > Cc: Leif Lindholm ; Bret Barkelew > > Subject: RE: [edk2-d

Re: [edk2-devel] [Patch v4 0/3] Ext4Pkg: Add Ext4Pkg

2021-08-17 Thread Michael D Kinney
Series Reviewed-by: Michael D Kinney Mike > -Original Message- > From: devel@edk2.groups.io On Behalf Of Pedro Falcato > Sent: Monday, August 16, 2021 11:07 AM > To: devel@edk2.groups.io > Cc: Pedro Falcato ; Leif Lindholm > ; Kinney, Michael D > ; Bret Barkelew > Subject: [edk2-devel

回复: [edk2-devel] [PATCH 1/1] BaseTools/GenFds: Change FV Header to FileSystemGuid3, edk2-stable202108

2021-08-17 Thread gaoliming
Yuwei: This change may impact the third part tool. Customer may have their tool to parse BIOS image. They may not support FileSystemGuid3. So, I suggest to defer this patch to next stable tag so that there are enough time to collect the feedback. For this patch, I add my comments below.

Re: [edk2-devel] [PATCH v2 1/1] MdeModulePkg/Console: Improve encoding of box drawing characters

2021-08-17 Thread Gao, Zhichao
Hi Caden/Nate, This patch aims to make the terminal output character set to be expected as https://github.com/tianocore/tianocore.github.io/wiki/Tasks-Terminal-driver-improvements. It is better to add this info to the commit message. Because of the commit message length limitation, I would sugge

Re: [edk2-devel] 回复: [edk2-stable202108] Package: CryptoPkg/BaseCryptLib: fix incorrect param order

2021-08-17 Thread Yao, Jiewen
Reviewed-by: Jiewen Yao Thanks Liming. Yes. I agree to merge it for stable tag. Will you help to do that? > -Original Message- > From: devel@edk2.groups.io On Behalf Of gaoliming > Sent: Wednesday, August 18, 2021 9:18 AM > To: 'Stewart, Chris (SW Architect)' ; > devel@edk2.groups.io >

[edk2-devel] 回复: [edk2-stable202108] Package: CryptoPkg/BaseCryptLib: fix incorrect param order

2021-08-17 Thread gaoliming
Reviewed-by: Liming Gao This is a clear bug fix. I suggest to merge it for this stable tag 202108. Thanks Liming > -邮件原件- > 发件人: Stewart, Chris (SW Architect) > 发送时间: 2021年8月17日 20:48 > 收件人: devel@edk2.groups.io > 抄送: jiewen@intel.com; jian.j.w...@intel.com; xiaoyux...@intel.com; >

[edk2-devel] TianoCore Meeting Minutes - August 2021

2021-08-17 Thread Soumya Guptha
TianoCore Community Meeting August 12, 2021 EVENTS: Google Summer of Code: * 7 projects were selected, one of the projects got dropped before mid-term. All projects are listed here: https://summerofcode.withgoogle.com/organizations/6376892141142016/ * All 6 are doing well. Code rev

Re: [edk2-devel] [edk2-platforms][PATCH v1 1/2] AcpiDebugFeaturePkg: Modules are DRIVER_ACPITABLE

2021-08-17 Thread Nate DeSimone
Pushed: https://github.com/tianocore/edk2-platforms/commit/109380 -Original Message- From: devel@edk2.groups.io On Behalf Of Benjamin Doron Sent: Wednesday, August 4, 2021 1:43 PM To: devel@edk2.groups.io Cc: Dong, Eric ; Liming Gao Subject: [edk2-devel] [edk2-platforms][PATCH v1 1/2] Ac

Re: [edk2-devel] [edk2-platforms][PATCH v1 2/2] IpmiFeaturePkg: BmcAcpi is DRIVER_ACPITABLE

2021-08-17 Thread Nate DeSimone
Hi Benjamin, I’ll just push the AcpiDebugFeaturePkg change. Thanks, Nate From: devel@edk2.groups.io On Behalf Of Benjamin Doron Sent: Tuesday, August 17, 2021 11:04 AM To: Desimone, Nathaniel L Cc: devel@edk2.groups.io; Oram, Isaac W ; Liming Gao Subject: Re: [edk2-devel] [edk2-platforms][PA

Re: [edk2-devel] [edk2-libc Patch] Maintainers.txt: Update maintainers for AppPkg and StdLib*

2021-08-17 Thread Rebecca Cran
Reviewed-by: Rebecca Cran On 8/17/21 9:16 AM, Michael D Kinney wrote: Cc: Rebecca Cran Cc: Daryl McDaniel Cc: Jaben Carsey Signed-off-by: Michael D Kinney --- Maintainers.txt | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Maintainers.txt b/Maintainers.txt ind

Re: [edk2-devel] [edk2-platforms][PATCH v1 2/2] IpmiFeaturePkg: BmcAcpi is DRIVER_ACPITABLE

2021-08-17 Thread Benjamin Doron
It appears that this fix was already committed as part of commit 2333ea4. How do I drop this patch? On Tue., Aug. 17, 2021, 1:59 p.m. Desimone, Nathaniel L, < nathaniel.l.desim...@intel.com> wrote: > Reviewed-by: Nate DeSimone > > > -Original Message- > > From: Benjamin Doron > > Sent:

Re: [edk2-devel] [edk2-platforms][PATCH v1 2/2] IpmiFeaturePkg: BmcAcpi is DRIVER_ACPITABLE

2021-08-17 Thread Nate DeSimone
Reviewed-by: Nate DeSimone > -Original Message- > From: Benjamin Doron > Sent: Wednesday, August 4, 2021 1:43 PM > To: devel@edk2.groups.io > Cc: Oram, Isaac W ; Desimone, Nathaniel L > ; Liming Gao > > Subject: [edk2-platforms][PATCH v1 2/2] IpmiFeaturePkg: BmcAcpi is > DRIVER_ACPITABL

Re: [edk2-devel] [edk2-platforms][PATCH v1 1/2] AcpiDebugFeaturePkg: Modules are DRIVER_ACPITABLE

2021-08-17 Thread Nate DeSimone
Reviewed-by: Nate DeSimone > -Original Message- > From: devel@edk2.groups.io On Behalf Of > Benjamin Doron > Sent: Wednesday, August 4, 2021 1:43 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Liming Gao > > Subject: [edk2-devel] [edk2-platforms][PATCH v1 1/2] > AcpiDebugFeaturePkg: M

Re: [edk2-devel] [edk2-platforms][PATCH v1] KabylakeSiliconPkg/PchPmcLib: Add GetSleepTypeAfterWakeup()

2021-08-17 Thread Nate DeSimone
Pushed: https://github.com/tianocore/edk2-platforms/commit/d410a0a > -Original Message- > From: devel@edk2.groups.io On Behalf Of Nate > DeSimone > Sent: Wednesday, August 11, 2021 6:22 PM > To: devel@edk2.groups.io > Cc: Desimone, Nathaniel L ; Michael > Kubacki ; Chiu, Chasel > ; Chagan

Re: [edk2-devel] [edk2-libc Patch] Maintainers.txt: Update maintainers for AppPkg and StdLib*

2021-08-17 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey -Original Message- From: Kinney, Michael D Sent: Tuesday, August 17, 2021 8:17 AM To: devel@edk2.groups.io Cc: Rebecca Cran ; Daryl McDaniel ; Carsey, Jaben Subject: [edk2-libc Patch] Maintainers.txt: Update maintainers for AppPkg and StdLib* Cc: Rebecca Cr

Re: [edk2-devel] SecCore evacuation in PeiCore?

2021-08-17 Thread Michael Kubacki
Hi Marvin, It would be beneficial in the sense that it could reduce the amount of work manually needed elsewhere. PeiCore can migrate pointers in global databases it knows about such as the PPI list that point to global data areas it has knowledge of such as Temporary RAM. Prior to this chan

Re: [edk2-devel] [edk2-platforms PATCH v2 0/4] SolidRun CEx7 Evaluation Board support

2021-08-17 Thread Ard Biesheuvel
On Sat, 7 Aug 2021 at 21:37, Marcin Wojtas wrote: > > Hi, > > The second version comes with a minor improvement, which > is a result of the TF-A support update and changes around the > default IO windows configuration. > > The patches are also available on public branches: > https://github.com/sem

Re: [edk2-devel] [edk2-non-osi PATCH] SolidRun/Cn913xCEx7Eval: Add DeviceTree

2021-08-17 Thread Ard Biesheuvel
On Sat, 7 Aug 2021 at 21:37, Marcin Wojtas wrote: > > This patch introduces the top device tree for the CN913x CEx7 > Evaluation Board, based on the sources which are common for the > Cn913x SoCs. Also an .inf file is added to allow its compilation. > > Signed-off-by: Marcin Wojtas Pushed as de

[edk2-devel] [edk2-libc Patch] StdLib/PosixLib/GetPass: Update to use safe string functions

2021-08-17 Thread Michael D Kinney
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3361 Cc: Rebecca Cran Signed-off-by: Michael D Kinney --- StdLib/PosixLib/GetPass/GetPass.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/StdLib/PosixLib/GetPass/GetPass.c b/StdLib/PosixLib/GetPass/GetPass.c index 4651

Re: [edk2-devel] [PATCH] Platform/RaspberryPi: Always use non translating DMA in DT mode

2021-08-17 Thread Jeremy Linton
On 8/17/21 10:12 AM, Ard Biesheuvel wrote: On Mon, 16 Aug 2021 at 22:27, Jeremy Linton wrote: One of the many issues with the PCIe on this platform is its inbound DMA is either constrained to the lower 3G, or on later SoC's a translation can be used. That translation was problematic with some

[edk2-devel] [edk2-libc Patch] Maintainers.txt: Update maintainers for AppPkg and StdLib*

2021-08-17 Thread Michael D Kinney
Cc: Rebecca Cran Cc: Daryl McDaniel Cc: Jaben Carsey Signed-off-by: Michael D Kinney --- Maintainers.txt | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Maintainers.txt b/Maintainers.txt index 4e05e8a..d0419be 100644 --- a/Maintainers.txt +++ b/Maintainers.txt @@ -6

Re: [edk2-devel] [PATCH] Platform/RaspberryPi: Always use non translating DMA in DT mode

2021-08-17 Thread Ard Biesheuvel
On Mon, 16 Aug 2021 at 22:27, Jeremy Linton wrote: > > One of the many issues with the PCIe on this platform is > its inbound DMA is either constrained to the lower 3G, or > on later SoC's a translation can be used. That translation > was problematic with some of the OS's expected to boot > on thi

Re: [edk2-devel] [PATCH v2 0/6] RPi4: Enable ACPI PCIe conduit

2021-08-17 Thread Ard Biesheuvel
On Tue, 10 Aug 2021 at 05:36, Jeremy Linton wrote: > > A new Arm standard DEN0115A specifies how > platforms that don't have standard ECAM can > use the firmware to handle config read/write > operations. This is mostly implemented in TFA > but UEFI needs to assure that there is a > description of

Re: [edk2-devel] [2021-gsoc-llvm-gnumake]: proposal for building using llvm/gnumake

2021-08-17 Thread Steven Shi
Hi Pedro, Your suggestion is interesting. We will try to enhance the clang Linux build and remove the libgcc dependency in the future. This patch change is for a project of Google Summer of Code 2021, which is to build BaseTools with clang + gnu make in windows. We hope to focus the windows par

Re: [edk2-devel] [edk2-platforms PATCH v2] Platform/RaspberryPi: Remove unnecessary files.

2021-08-17 Thread Ard Biesheuvel
On Tue, 17 Aug 2021 at 09:26, Grzegorz Bernacki wrote: > > Commit 2f0188b56ef4 ("Revert "Platform/RaspberryPi: Setup option for...") > mistakenly introduced to files which are residues from a > conflict resolution. Fix that. > > Signed-off-by: Grzegorz Bernacki Pushed as b291607503dc..f24aa7708d

Re: [edk2-devel] [PATCH] EmbeddedPkg/NonCoherentDmaLib: Avoid dereferencing unset Map field

2021-08-17 Thread Ard Biesheuvel
On Mon, 16 Aug 2021 at 09:10, Ard Biesheuvel wrote: > > On Fri, 13 Aug 2021 at 07:05, Jeremy Linton wrote: > > > > Map->Operation is used to select whether a DMA region that > > is being bounced has the source buffer copied to it. Except > > Map->Operation isn't yet set, so the behavior is somewh

[edk2-devel] [PATCH v1] DynamicTablesPkg: Update FADT generator to ACPI 6.4

2021-08-17 Thread Chris Jones
Bugzilla: 3568 (https://bugzilla.tianocore.org/show_bug.cgi?id=3568) Update the FADT generator to use Acpi64.h. As the FADT revision tracks the ACPI revision this updates the minor revision value generated. Mantis ID for change: https://mantis.uefi.org/mantis/view.php?id=2105 Signed-off-by: Chri

[edk2-devel] [PATCH v3 1/3] OvmfPkg: introduce a common work area

2021-08-17 Thread Brijesh Singh via groups.io
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 Both the TDX and SEV support needs to reserve a page in MEMFD as a work area. The page will contain meta data specific to the guest type. Currently, the SEV-ES support reserves a page in MEMFD (PcdSevEsWorkArea) for the work area. This page c

[edk2-devel] [PATCH v3 3/3] OvmfPkg/ResetVector: move the GHCB page setup in AmdSev.asm

2021-08-17 Thread Brijesh Singh via groups.io
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 While build the initial page table, the SetCr3ForPageTables64 checks whether SEV-ES is enabled. If so, clear the page encryption mask from the GHCB page. Move the logic to clear the page encryption mask in the AmdSev.asm. Cc: James Bottomley

[edk2-devel] [PATCH v3 2/3] OvmfPkg/ResetVector: update SEV support to use new work area format

2021-08-17 Thread Brijesh Singh via groups.io
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 Update the SEV support to switch to using the newer work area format. Cc: James Bottomley Cc: Min Xu Cc: Jiewen Yao Cc: Tom Lendacky Cc: Jordan Justen Cc: Ard Biesheuvel Cc: Erdem Aktas Signed-off-by: Brijesh Singh --- OvmfPkg/Reset

[edk2-devel] [PATCH v3 0/3] reuse the SevEsWork area

2021-08-17 Thread Brijesh Singh via groups.io
Based on the discussion on the mailing list, we agreed that instead of wasting extra page in the MEMFD, we can reuse the SevEsWorkArea buffer for the TDX. To avoid any confusion, lets introduce a OvmfWorkArea that will contains 32 bytes of header followed by the actual workarea. While at it, move

[edk2-devel] [PATCH 1/1] EmbeddedPkg/AcpiLib: Add more helper functions

2021-08-17 Thread Nhi Pham via groups.io
This adds more helper functions that assist in calculating the checksum, locating an ACPI table by signature, and updating an AML integer object. Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Abner Chang Cc: Daniel Schaefer Signed-off-by: Nhi Pham --- EmbeddedPkg/Library/AcpiLib/AcpiLib.inf | 2

Re: [edk2-devel] [PATCH v3 2/4] OvmfPkg/VirtioMmioDeviceLib: Add virtio 1.0 support.

2021-08-17 Thread Philippe Mathieu-Daudé
Hi Gerd, On 8/17/21 11:23 AM, Gerd Hoffmann wrote: > Add support for virtio 1.0 to the mmio transport. virtio 0.9.5 uses > page size, page frame number and a fixed layout for the ring. virtio > 1.0 uses the physical addresses for base address, used bits and > available bits instead. > > The rin

Re: [edk2-devel] [PATCH v3 3/4] OvmfPkg/VirtioMmioDeviceLib: Add default QueueNum for virtio 1.0

2021-08-17 Thread Philippe Mathieu-Daudé
On 8/17/21 11:23 AM, Gerd Hoffmann wrote: > Use QueueNumMax as QueueNum default for drivers which do not > explicitly call VIRTIO_DEVICE_PROTOCOL->SetQueueSize(). > > Signed-off-by: Gerd Hoffmann > --- > .../Library/VirtioMmioDeviceLib/VirtioMmioDevice.h | 1 + > .../VirtioMmioDeviceLib/Virti

[edk2-devel] [PATCH v3 4/4] OvmfPkg/VirtioMmioDeviceLib: Add virtio 1.0 feature bit handling

2021-08-17 Thread Gerd Hoffmann
virtio 1.0 has 64 feature bits instead of 32. Signed-off-by: Gerd Hoffmann --- .../VirtioMmioDeviceFunctions.c | 28 +++ 1 file changed, 23 insertions(+), 5 deletions(-) diff --git a/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDeviceFunctions.c b/OvmfPkg/Library

[edk2-devel] [PATCH v3 2/4] OvmfPkg/VirtioMmioDeviceLib: Add virtio 1.0 support.

2021-08-17 Thread Gerd Hoffmann
Add support for virtio 1.0 to the mmio transport. virtio 0.9.5 uses page size, page frame number and a fixed layout for the ring. virtio 1.0 uses the physical addresses for base address, used bits and available bits instead. The ring layout is not changed, so a 0.9.5 compatible layout is used in

[edk2-devel] [PATCH v3 3/4] OvmfPkg/VirtioMmioDeviceLib: Add default QueueNum for virtio 1.0

2021-08-17 Thread Gerd Hoffmann
Use QueueNumMax as QueueNum default for drivers which do not explicitly call VIRTIO_DEVICE_PROTOCOL->SetQueueSize(). Signed-off-by: Gerd Hoffmann --- .../Library/VirtioMmioDeviceLib/VirtioMmioDevice.h | 1 + .../VirtioMmioDeviceLib/VirtioMmioDeviceFunctions.c | 12 +++- 2 files chang

[edk2-devel] [PATCH v3 1/4] OvmfPkg/Virtio10: Add virtio-mmio 1.0 defines

2021-08-17 Thread Gerd Hoffmann
Add defines for the config space offsets for virtio 1.0 mmio transport. Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daude --- OvmfPkg/Include/IndustryStandard/Virtio10.h | 12 1 file changed, 12 insertions(+) diff --git a/OvmfPkg/Include/IndustryStandard/Virtio10.h

[edk2-devel] [PATCH v3 0/4] add support for virtio-mmio 1.0

2021-08-17 Thread Gerd Hoffmann
This little series adds virtio 1.0 support for the virtio-mmio transport. For the mmio transport the difference between 0.9.5 and 1.0 is rather small (when compared to the pci transport), it is just a bunch of new registers for the changed virtio queue initialization. So the patch series is small

Re: [edk2-devel] [PATCH 05/23] MdePkg: Add TdxProbeLib to probe Intel Tdx

2021-08-17 Thread Gerd Hoffmann
Hi, > > Also: Why there are separate TdxProbeLib + TdxLib libs? > This is because TdxLib wrap the operations of TdCall and TdVmcall. While > TdxProbeLib > is a library to probe (call CPUID(0x21)) if it is td guest or not. I am open > to merge these 2 > libs into one if the community think it i

Re: [edk2-devel] [PATCH 05/23] MdePkg: Add TdxProbeLib to probe Intel Tdx

2021-08-17 Thread Min Xu
On August 17, 2021 4:21 PM, Gerd Hoffmann wrote: > On Tue, Aug 17, 2021 at 12:14:44AM +, Min Xu wrote: > > On Monday, August 16, 2021 5:43 PM, Gerd Hoffmann wrote: > > > > +++ b/MdePkg/Library/TdxProbeLib/X64/TdProbe.nasm > > > > > > Any specific reason why you code up your own instead of using

Re: [edk2-devel] [PATCH 07/23] MdePkg: Update BaseIoLibIntrinsicSev to support Tdx

2021-08-17 Thread Gerd Hoffmann
Hi, > In the I/O functions of above files, if IsTdxGuest() returns TRUE, then > Td I/O routine is called, otherwise the legacy I/O routine is called. > Td I/O routines are declared in IoLibTdx.h and implemented in > IoLibInternalTdx.c. Sorry, I'm a bit late to the party, but what is the overall

Re: [edk2-devel] [PATCH] IntelFsp2Pkg: Support Config File and Binary delta comparison

2021-08-17 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Loo, Tung Lun > Sent: Tuesday, August 17, 2021 3:43 PM > To: devel@edk2.groups.io > Cc: Loo, Tung Lun ; Ma, Maurice > ; Desimone, Nathaniel L > ; Zeng, Star ; Chiu, > Chasel > Subject: [PATCH] IntelFsp2Pkg: Support Config File and

Re: [edk2-devel] [PATCH 05/23] MdePkg: Add TdxProbeLib to probe Intel Tdx

2021-08-17 Thread Gerd Hoffmann
On Tue, Aug 17, 2021 at 12:14:44AM +, Min Xu wrote: > On Monday, August 16, 2021 5:43 PM, Gerd Hoffmann wrote: > > > +++ b/MdePkg/Library/TdxProbeLib/X64/TdProbe.nasm > > > > Any specific reason why you code up your own instead of using the existing > > cpuid functions in BaseLib ? > Actually

[edk2-devel] [PATCH] IntelFsp2Pkg: Support Config File and Binary delta comparison

2021-08-17 Thread Tung Lun
From: "Loo, Tung Lun" BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3567 This patch is to enable config editor to have a new feature that can spell out the delta between the default configuration files' data, such as YAML and BSF, against the data stored in the binary. This can help users u

[edk2-devel] [edk2-platforms PATCH v2] Platform/RaspberryPi: Remove unnecessary files.

2021-08-17 Thread Grzegorz Bernacki
Commit 2f0188b56ef4 ("Revert "Platform/RaspberryPi: Setup option for...") mistakenly introduced to files which are residues from a conflict resolution. Fix that. Signed-off-by: Grzegorz Bernacki --- Platform/RaspberryPi/Library/DualSerialPortLib/DualSerialPortLib.c.orig | 613