On August 17, 2021 4:21 PM, Gerd Hoffmann wrote: > On Tue, Aug 17, 2021 at 12:14:44AM +0000, Min Xu wrote: > > On Monday, August 16, 2021 5:43 PM, Gerd Hoffmann wrote: > > > > +++ b/MdePkg/Library/TdxProbeLib/X64/TdProbe.nasm > > > > > > Any specific reason why you code up your own instead of using the > > > existing cpuid functions in BaseLib ? > > Actually there is no specific reason. I am not sure if AsmCpuid is a > > preferred way in this situation? > > I'm pretty sure it is preferred over duplicating code. Thanks for reminder. I will use AsmCpuid in my next version. > > Early setup code (before stack setup where you can't do calls) is a different > story. > > Also: Why there are separate TdxProbeLib + TdxLib libs? This is because TdxLib wrap the operations of TdCall and TdVmcall. While TdxProbeLib is a library to probe (call CPUID(0x21)) if it is td guest or not. I am open to merge these 2 libs into one if the community think it is a right way. > > take care, > Gerd > > > > >
-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#79415): https://edk2.groups.io/g/devel/message/79415 Mute This Topic: https://groups.io/mt/84837894/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
