Based on the discussion on the mailing list, we agreed that instead of wasting extra page in the MEMFD, we can reuse the SevEsWorkArea buffer for the TDX. To avoid any confusion, lets introduce a OvmfWorkArea that will contains 32 bytes of header followed by the actual workarea.
While at it, move the code to clear the GHCB page from PageTable build to AmdSev.asm. I have used the existing TDX BZ for it because the request came during the TDX patch review. if anyone have concern please let me know and I will happily create a new BZ. Full tree is at: https://github.com/AMDESE/ovmf/tree/sev-new-work-area Brijesh Singh (3): OvmfPkg: introduce a common work area OvmfPkg/ResetVector: update SEV support to use new work area format OvmfPkg/ResetVector: move the GHCB page setup in AmdSev.asm Cc: James Bottomley <j...@linux.ibm.com> Cc: Min Xu <min.m...@intel.com> Cc: Jiewen Yao <jiewen....@intel.com> Cc: Tom Lendacky <thomas.lenda...@amd.com> Cc: Jordan Justen <jordan.l.jus...@intel.com> Cc: Ard Biesheuvel <ardb+tianoc...@kernel.org> Cc: Erdem Aktas <erdemak...@google.com> Changes since v2: - address Tom's feedback Changes since v1: - address Jiewen's feedback. Brijesh Singh (3): OvmfPkg: introduce a common work area OvmfPkg/ResetVector: update SEV support to use new work area format OvmfPkg/ResetVector: move the GHCB page setup in AmdSev.asm OvmfPkg/OvmfPkg.dec | 12 +++ OvmfPkg/OvmfPkgX64.fdf | 9 +- OvmfPkg/PlatformPei/PlatformPei.inf | 4 +- OvmfPkg/ResetVector/ResetVector.inf | 1 + OvmfPkg/Sec/SecMain.inf | 2 + OvmfPkg/Include/Library/MemEncryptSevLib.h | 21 +--- OvmfPkg/Include/WorkArea.h | 67 +++++++++++++ OvmfPkg/PlatformPei/MemDetect.c | 8 +- OvmfPkg/Sec/SecMain.c | 36 ++++++- OvmfPkg/OvmfPkgDefines.fdf.inc | 6 ++ OvmfPkg/ResetVector/Ia32/AmdSev.asm | 109 +++++++++++++++++---- OvmfPkg/ResetVector/Ia32/PageTables64.asm | 57 +++-------- OvmfPkg/ResetVector/ResetVector.nasmb | 1 + 13 files changed, 238 insertions(+), 95 deletions(-) create mode 100644 OvmfPkg/Include/WorkArea.h -- 2.17.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#79425): https://edk2.groups.io/g/devel/message/79425 Mute This Topic: https://groups.io/mt/84947963/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
