Reviewed-by: Jiewen Yao <jiewen....@intel.com> Thanks Liming. Yes. I agree to merge it for stable tag. Will you help to do that?
> -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of gaoliming > Sent: Wednesday, August 18, 2021 9:18 AM > To: 'Stewart, Chris (SW Architect)' <chris.stew...@hp.com>; > devel@edk2.groups.io > Cc: Yao, Jiewen <jiewen....@intel.com>; Wang, Jian J <jian.j.w...@intel.com>; > Lu, XiaoyuX <xiaoyux...@intel.com>; Jiang, Guomin <guomin.ji...@intel.com>; > 'Leif Lindholm' <l...@nuviainc.com>; 'Andrew Fish' <af...@apple.com>; Kinney, > Michael D <michael.d.kin...@intel.com> > Subject: [edk2-devel] 回复: [edk2-stable202108] Package: > CryptoPkg/BaseCryptLib: fix incorrect param order > > Reviewed-by: Liming Gao <gaolim...@byosoft.com.cn> > > This is a clear bug fix. I suggest to merge it for this stable tag 202108. > > Thanks > Liming > > -----邮件原件----- > > 发件人: Stewart, Chris (SW Architect) <chris.stew...@hp.com> > > 发送时间: 2021年8月17日 20:48 > > 收件人: devel@edk2.groups.io > > 抄送: jiewen....@intel.com; jian.j.w...@intel.com; xiaoyux...@intel.com; > > guomin.ji...@intel.com; gaolim...@byosoft.com.cn; Stewart, Chris (SW > > Architect) <chris.stew...@hp.com> > > 主题: [PATCH] Package: CryptoPkg/BaseCryptLib: fix incorrect param order > > > > [PATCH] Package: CryptoPkg/BaseCryptLib: fix incorrect param order > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3550 > > > > Function ConvertAsn1TimeToEfiTime initializes timestamp to zeroes with > > SetMem, but the actual parameters are out of order. > > The result is the SetMem operation has no effect. The fix is to put the > actual > > parameters in the correct order. > > > > Signed-off-by: Chris Stewart <chris.stew...@hp.com> > > Reviewed-by: Liming Gao <gaolim...@byosoft.com.cn> > > CC: Jiewen Yao <jiewen....@intel.com> > > CC: Jian J Wang <jian.j.w...@intel.com> > > CC: Xiaoyu Lu <xiaoyux...@intel.com> > > CC: Guomin Jiang <guomin.ji...@intel.com> > > --- > > CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c > > b/CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c > > index ff7f6488f2..970e9b94a0 100644 > > --- a/CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c > > +++ b/CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c > > @@ -155,7 +155,7 @@ ConvertAsn1TimeToEfiTime ( > > } > > > > Str = (CONST CHAR8*)Asn1Time->data; > > - SetMem (EfiTime, 0, sizeof (EFI_TIME)); > > + SetMem (EfiTime, sizeof (EFI_TIME), 0); > > > > Index = 0; > > if (Asn1Time->type == V_ASN1_UTCTIME) { /* two digit > > year */ > > -- > > 2.19.2.windows.1 > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#79452): https://edk2.groups.io/g/devel/message/79452 Mute This Topic: https://groups.io/mt/84963134/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
