[edk2-devel] 回复: [Patch 1/1 V2] BaseTools: fix the split output files root dir

2021-02-03 Thread gaoliming
Acked-by: Liming Gao > -邮件原件- > 发件人: Feng, Bob C > 发送时间: 2021年2月4日 13:27 > 收件人: gaoliming ; devel@edk2.groups.io > 抄送: Chen, Christine > 主题: RE: [Patch 1/1 V2] BaseTools: fix the split output files root dir > > Yes. I did the verification on the Intel platforms. It works as before. >

回复: [edk2-devel] UEFI compile error

2021-02-03 Thread gaoliming
You can change this error message, then print the error message with pcd name, next to check this PCD definition in package DEC file. EdkLogger.error("build", PCD_STRUCTURE_PCD_ERROR, "The structure Pcd %s.%s header file is not found in %s line %s \n" % (pcd.TokenSpaceGuidCName, pcd.TokenCName

回复: [edk2-devel] 回复: [PATCH v1 1/1] BaseTools: Align include guards policy

2021-02-03 Thread gaoliming
Pierre: I get Leif point. I also see clang warning https://clang.llvm.org/docs/DiagnosticsReference.html#wreserved-id-macro I agree the compiler may reserve the macro starting with _ prefix. But so far, I don't get any error report that the macro conflict with the compiler reserved macros.

回复: [edk2-devel] [PATCH v3] MdeModulePkg/Library: Add HiiGetStringEx to UefiHiiLib for EDK2 Redfish

2021-02-03 Thread gaoliming
If TryBestLanguage is FALE and Language is NULL, then ASSERT(). So, ASSERT statement should be ASSERT (TryBestLanguage || (Language != NULL)); Is this clear? Thanks Liming > -邮件原件- > 发件人: bounce+27952+71110+4905953+8761...@groups.io > 代表 Abner Chang > 发送时间: 2021年2月3日 23:21 > 收件人: devel

[edk2-devel] 回复: [Bug 3187] FaultTolerantWriteDxe defect will cause NVRAM not recovered after number of WorkSpaceRefresh().

2021-02-03 Thread gaoliming
Chuang: I see you directly use IO port 0x70, 0x71. What purpose to use them? Thanks Liming > -邮件原件- > 发件人: Chuang, Marlboro > 发送时间: 2021年2月3日 12:59 > 收件人: devel@edk2.groups.io > 抄送: gaolim...@byosoft.com.cn > 主题: RE: [Bug 3187] FaultTolerantWriteDxe defect will cause NVRAM not > recover

[edk2-devel] Does anyone meet the github SSH access issue?

2021-02-03 Thread Ni, Ray
I met the following errors when trying to pull content from github: -- E:\Work\edk2>git pull upstream master kex_exchange_identification: Connection closed by remote host Connection closed by UNKNOWN port 65535 fatal: Could not read from remote repository. Please make sure you have the

Re: [edk2-devel] [PATCH v1 1/1] IntelSiliconPkg/ShadowMicrocodePei: Add microcode header verification.

2021-02-03 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: Fu, Siyuan > Sent: Thursday, February 4, 2021 1:40 PM > To: Li, Aaron ; devel@edk2.groups.io > Cc: Ni, Ray ; Chaganty, Rangasai V > > Subject: RE: [PATCH v1 1/1] IntelSiliconPkg/ShadowMicrocodePei: Add > microcode header verification. >

Re: [edk2-devel] [PATCH v1 1/1] IntelSiliconPkg/ShadowMicrocodePei: Add microcode header verification.

2021-02-03 Thread Siyuan, Fu
Reviewed-by: Siyuan Fu > -Original Message- > From: Li, Aaron > Sent: 2021年2月3日 15:06 > To: devel@edk2.groups.io > Cc: Ni, Ray ; Chaganty, Rangasai V > ; Fu, Siyuan > Subject: [PATCH v1 1/1] IntelSiliconPkg/ShadowMicrocodePei: Add microcode > header verification. > > BZ: https://bugzil

Re: [edk2-devel] [Patch 1/1 V2] BaseTools: fix the split output files root dir

2021-02-03 Thread Bob Feng
Yes. I did the verification on the Intel platforms. It works as before. -Original Message- From: gaoliming Sent: Thursday, February 4, 2021 9:00 AM To: Feng, Bob C ; devel@edk2.groups.io Cc: Chen, Christine Subject: 回复: [Patch 1/1 V2] BaseTools: fix the split output files root dir Bob:

[edk2-devel] reg: RNG functions Usage in NetworkPkg

2021-02-03 Thread Sivaraman Nainar
Hello Maciej: Do we have any plan to use the RNG Library function in the Macro "NET_RANDOM" of NetworkPkg. NET_RANDOM can use GetRandomNumber32() which is more reliable right? Thanks Siva -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (

Re: [edk2-devel] [PATCH 03/40] TigerlakeSiliconPkg/Include: Add Pins, Register and other include headers

2021-02-03 Thread Nate DeSimone
Reviewed-by: Nate DeSimone > -Original Message- > From: Luo, Heng > Sent: Sunday, January 31, 2021 5:36 PM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Desimone, > Nathaniel L > Subject: [PATCH 03/40] TigerlakeSiliconPkg/Include: Add Pins, Register and > other include headers

[edk2-devel] [PATCH v2] IntelFsp2Pkg: Add YAML file generation support

2021-02-03 Thread Tung Lun
Add support for YAML format file generation in addition to current BSF structure. Configuration of YAML format output will be supported by an open source ConfigEditor. Reference to YAML code, test and ConfigEditor is at https://github.com/joshloo/fsp_yaml_cfg/tree/master/Tools A unit test is also

Re: [edk2-devel] [PATCH 39/40] TigerlakeSiliconPkg: Add package DSC files

2021-02-03 Thread Nate DeSimone
Hi Heng, Please see comments inline. Thanks, Nate > -Original Message- > From: Luo, Heng > Sent: Sunday, January 31, 2021 5:37 PM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Desimone, > Nathaniel L > Subject: [PATCH 39/40] TigerlakeSiliconPkg: Add package DSC files > > REF

Re: [edk2-devel] [PATCH 37/40] TigerlakeSiliconPkg/SystemAgent: Add SystemAgent modules

2021-02-03 Thread Nate DeSimone
Reviewed-by: Nate DeSimone > -Original Message- > From: Luo, Heng > Sent: Sunday, January 31, 2021 5:37 PM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Desimone, > Nathaniel L > Subject: [PATCH 37/40] TigerlakeSiliconPkg/SystemAgent: Add SystemAgent > modules > > REF: https:

Re: [edk2-devel] [PATCH 38/40] TigerlakeSiliconPkg/Fru: Add Fru DSC files

2021-02-03 Thread Nate DeSimone
Reviewed-by: Nate DeSimone > -Original Message- > From: Luo, Heng > Sent: Sunday, January 31, 2021 5:37 PM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Desimone, > Nathaniel L > Subject: [PATCH 38/40] TigerlakeSiliconPkg/Fru: Add Fru DSC files > > REF: https://bugzilla.tiano

Re: [edk2-devel] [PATCH 34/40] TigerlakeSiliconPkg/SystemAgent: Add Acpi Tables and library instances

2021-02-03 Thread Nate DeSimone
Hi Heng, Please see comments inline. Thanks, Nate > -Original Message- > From: Luo, Heng > Sent: Sunday, January 31, 2021 5:37 PM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Desimone, > Nathaniel L > Subject: [PATCH 34/40] TigerlakeSiliconPkg/SystemAgent: Add Acpi Tables >

Re: [edk2-devel] [PATCH 35/40] TigerlakeSiliconPkg/Fru/TglCpu: Add CpuPcieRp and Vtd library instances

2021-02-03 Thread Nate DeSimone
Hi Heng, Please see comments inline. Thanks, Nate > -Original Message- > From: Luo, Heng > Sent: Sunday, January 31, 2021 5:37 PM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Desimone, > Nathaniel L > Subject: [PATCH 35/40] TigerlakeSiliconPkg/Fru/TglCpu: Add CpuPcieRp and >

Re: [edk2-devel] [PATCH 33/40] TigerlakeSiliconPkg/Pch: Add Pch private library instances

2021-02-03 Thread Nate DeSimone
Reviewed-by: Nate DeSimone > -Original Message- > From: Luo, Heng > Sent: Sunday, January 31, 2021 5:37 PM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Desimone, > Nathaniel L > Subject: [PATCH 33/40] TigerlakeSiliconPkg/Pch: Add Pch private library > instances > > REF: http

Re: [edk2-devel] [PATCH 32/40] TigerlakeSiliconPkg/Pch: Add Pch common library instances

2021-02-03 Thread Nate DeSimone
Reviewed-by: Nate DeSimone > -Original Message- > From: Luo, Heng > Sent: Sunday, January 31, 2021 5:37 PM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Desimone, > Nathaniel L > Subject: [PATCH 32/40] TigerlakeSiliconPkg/Pch: Add Pch common library > instances > > REF: https

Re: [edk2-devel] [PATCH 31/40] TigerlakeSiliconPkg/Library: Add package common library instances

2021-02-03 Thread Nate DeSimone
Reviewed-by: Nate DeSimone > -Original Message- > From: Luo, Heng > Sent: Sunday, January 31, 2021 5:37 PM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Desimone, > Nathaniel L > Subject: [PATCH 31/40] TigerlakeSiliconPkg/Library: Add package common > library instances > > RE

Re: [edk2-devel] [PATCH 30/40] TigerlakeSiliconPkg/IpBlock: Add Vtd component

2021-02-03 Thread Nate DeSimone
Reviewed-by: Nate DeSimone > -Original Message- > From: Luo, Heng > Sent: Sunday, January 31, 2021 5:37 PM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Desimone, > Nathaniel L > Subject: [PATCH 30/40] TigerlakeSiliconPkg/IpBlock: Add Vtd component > > REF: https://bugzilla.t

Re: [edk2-devel] [PATCH 29/40] TigerlakeSiliconPkg/IpBlock: Add Spi component

2021-02-03 Thread Nate DeSimone
Reviewed-by: Nate DeSimone > -Original Message- > From: Luo, Heng > Sent: Sunday, January 31, 2021 5:37 PM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Desimone, > Nathaniel L > Subject: [PATCH 29/40] TigerlakeSiliconPkg/IpBlock: Add Spi component > > REF: https://bugzilla.t

Re: [edk2-devel] [PATCH 27/40] TigerlakeSiliconPkg/IpBlock: Add SerialIo component

2021-02-03 Thread Nate DeSimone
Reviewed-by: Nate DeSimone > -Original Message- > From: Luo, Heng > Sent: Sunday, January 31, 2021 5:37 PM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Desimone, > Nathaniel L > Subject: [PATCH 27/40] TigerlakeSiliconPkg/IpBlock: Add SerialIo component > > REF: https://bugzi

Re: [edk2-devel] [PATCH 28/40] TigerlakeSiliconPkg/IpBlock: Add Smbus component

2021-02-03 Thread Nate DeSimone
Reviewed-by: Nate DeSimone > -Original Message- > From: Luo, Heng > Sent: Sunday, January 31, 2021 5:37 PM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Desimone, > Nathaniel L > Subject: [PATCH 28/40] TigerlakeSiliconPkg/IpBlock: Add Smbus component > > REF: https://bugzilla

Re: [edk2-devel] [PATCH 25/40] TigerlakeSiliconPkg/IpBlock: Add Psf component

2021-02-03 Thread Nate DeSimone
Reviewed-by: Nate DeSimone > -Original Message- > From: Luo, Heng > Sent: Sunday, January 31, 2021 5:37 PM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Desimone, > Nathaniel L > Subject: [PATCH 25/40] TigerlakeSiliconPkg/IpBlock: Add Psf component > > REF: https://bugzilla.t

Re: [edk2-devel] [PATCH 26/40] TigerlakeSiliconPkg/IpBlock: Add Sata component

2021-02-03 Thread Nate DeSimone
Reviewed-by: Nate DeSimone > -Original Message- > From: Luo, Heng > Sent: Sunday, January 31, 2021 5:37 PM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Desimone, > Nathaniel L > Subject: [PATCH 26/40] TigerlakeSiliconPkg/IpBlock: Add Sata component > > REF: https://bugzilla.

Re: [edk2-devel] [PATCH 24/40] TigerlakeSiliconPkg/IpBlock: Add Pmc component

2021-02-03 Thread Nate DeSimone
Reviewed-by: Nate DeSimone > -Original Message- > From: Luo, Heng > Sent: Sunday, January 31, 2021 5:37 PM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Desimone, > Nathaniel L > Subject: [PATCH 24/40] TigerlakeSiliconPkg/IpBlock: Add Pmc component > > REF: https://bugzilla.t

[edk2-devel] [PATCH] IntelFsp2Pkg: Add YAML file generation support

2021-02-03 Thread Tung Lun
Add support for YAML format file generation in addition to current BSF structure. Configuration of YAML format output will be supported by an open source ConfigEditor. Reference to YAML code, test and ConfigEditor is at https://github.com/joshloo/fsp_yaml_cfg/tree/master/Tools A unit test is also

Re: [edk2-devel] [PATCH 22/40] TigerlakeSiliconPkg/IpBlock: Add PchDmi component

2021-02-03 Thread Nate DeSimone
Reviewed-by: Nate DeSimone > -Original Message- > From: Luo, Heng > Sent: Sunday, January 31, 2021 5:37 PM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Desimone, > Nathaniel L > Subject: [PATCH 22/40] TigerlakeSiliconPkg/IpBlock: Add PchDmi component > > REF: https://bugzill

Re: [edk2-devel] [PATCH 21/40] TigerlakeSiliconPkg/IpBlock: Add P2sb component

2021-02-03 Thread Nate DeSimone
Reviewed-by: Nate DeSimone > -Original Message- > From: Luo, Heng > Sent: Sunday, January 31, 2021 5:37 PM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Desimone, > Nathaniel L > Subject: [PATCH 21/40] TigerlakeSiliconPkg/IpBlock: Add P2sb component > > REF: https://bugzilla.

Re: [edk2-devel] [PATCH 20/40] TigerlakeSiliconPkg/IpBlock: Add HostBridge component

2021-02-03 Thread Nate DeSimone
Reviewed-by: Nate DeSimone > -Original Message- > From: Luo, Heng > Sent: Sunday, January 31, 2021 5:37 PM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Desimone, > Nathaniel L > Subject: [PATCH 20/40] TigerlakeSiliconPkg/IpBlock: Add HostBridge > component > > REF: https://b

Re: [edk2-devel] [PATCH 19/40] TigerlakeSiliconPkg/IpBlock: Add Hda component

2021-02-03 Thread Nate DeSimone
Reviewed-by: Nate DeSimone > -Original Message- > From: Luo, Heng > Sent: Sunday, January 31, 2021 5:37 PM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Desimone, > Nathaniel L > Subject: [PATCH 19/40] TigerlakeSiliconPkg/IpBlock: Add Hda component > > REF: https://bugzilla.t

Re: [edk2-devel] [PATCH 14/40] TigerlakeSiliconPkg/IpBlock: Add CpuPcieRp component

2021-02-03 Thread Nate DeSimone
Reviewed-by: Nate DeSimone > -Original Message- > From: Luo, Heng > Sent: Sunday, January 31, 2021 5:37 PM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Desimone, > Nathaniel L > Subject: [PATCH 14/40] TigerlakeSiliconPkg/IpBlock: Add CpuPcieRp > component > > REF: https://bu

Re: [edk2-devel] [PATCH 08/40] TigerlakeSiliconPkg/SystemAgent: Add IncludePrivate headers

2021-02-03 Thread Nate DeSimone
Reviewed-by: Nate DeSimone > -Original Message- > From: Luo, Heng > Sent: Sunday, January 31, 2021 5:36 PM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Desimone, > Nathaniel L > Subject: [PATCH 08/40] TigerlakeSiliconPkg/SystemAgent: Add IncludePrivate > headers > > REF: htt

Re: [edk2-devel] [PATCH 12/40] TigerlakeSiliconPkg/Fru: Add TglPch/IncludePrivate headers

2021-02-03 Thread Nate DeSimone
Reviewed-by: Nate DeSimone > -Original Message- > From: Luo, Heng > Sent: Sunday, January 31, 2021 5:36 PM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Desimone, > Nathaniel L > Subject: [PATCH 12/40] TigerlakeSiliconPkg/Fru: Add TglPch/IncludePrivate > headers > > REF: http

Re: [edk2-devel] [PATCH 16/40] TigerlakeSiliconPkg/IpBlock: Add Gbe component

2021-02-03 Thread Nate DeSimone
Reviewed-by: Nate DeSimone > -Original Message- > From: Luo, Heng > Sent: Sunday, January 31, 2021 5:37 PM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Desimone, > Nathaniel L > Subject: [PATCH 16/40] TigerlakeSiliconPkg/IpBlock: Add Gbe component > > REF: https://bugzilla.t

Re: [edk2-devel] [PATCH 07/40] TigerlakeSiliconPkg/SystemAgent: Add include headers

2021-02-03 Thread Nate DeSimone
Reviewed-by: Nate DeSimone > -Original Message- > From: Luo, Heng > Sent: Sunday, January 31, 2021 5:36 PM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Desimone, > Nathaniel L > Subject: [PATCH 07/40] TigerlakeSiliconPkg/SystemAgent: Add include > headers > > REF: https://bu

Re: [edk2-devel] [PATCH 15/40] TigerlakeSiliconPkg/IpBlock: Add Espi component

2021-02-03 Thread Nate DeSimone
Reviewed-by: Nate DeSimone > -Original Message- > From: Luo, Heng > Sent: Sunday, January 31, 2021 5:37 PM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Desimone, > Nathaniel L > Subject: [PATCH 15/40] TigerlakeSiliconPkg/IpBlock: Add Espi component > > REF: https://bugzilla.

Re: [edk2-devel] [PATCH 13/40] TigerlakeSiliconPkg/IpBlock: Add Cnvi component

2021-02-03 Thread Nate DeSimone
Reviewed-by: Nate DeSimone > -Original Message- > From: Luo, Heng > Sent: Sunday, January 31, 2021 5:37 PM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Desimone, > Nathaniel L > Subject: [PATCH 13/40] TigerlakeSiliconPkg/IpBlock: Add Cnvi component > > REF: https://bugzilla.

Re: [edk2-devel] [PATCH 09/40] TigerlakeSiliconPkg/Fru: Add TglCpu/Include headers

2021-02-03 Thread Nate DeSimone
Reviewed-by: Nate DeSimone > -Original Message- > From: Luo, Heng > Sent: Sunday, January 31, 2021 5:36 PM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Desimone, > Nathaniel L > Subject: [PATCH 09/40] TigerlakeSiliconPkg/Fru: Add TglCpu/Include headers > > REF: https://bugzi

Re: [edk2-devel] [PATCH 11/40] TigerlakeSiliconPkg/Fru: Add TglPch/Include headers

2021-02-03 Thread Nate DeSimone
Reviewed-by: Nate DeSimone > -Original Message- > From: Luo, Heng > Sent: Sunday, January 31, 2021 5:36 PM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Desimone, > Nathaniel L > Subject: [PATCH 11/40] TigerlakeSiliconPkg/Fru: Add TglPch/Include headers > > REF: https://bugzi

Re: [edk2-devel] [PATCH 10/40] TigerlakeSiliconPkg/Fru: Add TglCpu/IncludePrivate headers

2021-02-03 Thread Nate DeSimone
Reviewed-by: Nate DeSimone > -Original Message- > From: Luo, Heng > Sent: Sunday, January 31, 2021 5:36 PM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Desimone, > Nathaniel L > Subject: [PATCH 10/40] TigerlakeSiliconPkg/Fru: Add TglCpu/IncludePrivate > headers > > REF: http

Re: [edk2-devel] [PATCH 06/40] TigerlakeSiliconPkg/Pch: Add IncludePrivate headers

2021-02-03 Thread Nate DeSimone
Reviewed-by: Nate DeSimone > -Original Message- > From: Luo, Heng > Sent: Sunday, January 31, 2021 5:36 PM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Desimone, > Nathaniel L > Subject: [PATCH 06/40] TigerlakeSiliconPkg/Pch: Add IncludePrivate headers > > REF: https://bugzi

Re: [edk2-devel] [PATCH 04/40] TigerlakeSiliconPkg/Cpu: Add Include headers

2021-02-03 Thread Nate DeSimone
Reviewed-by: Nate DeSimone > -Original Message- > From: Luo, Heng > Sent: Sunday, January 31, 2021 5:36 PM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Desimone, > Nathaniel L > Subject: [PATCH 04/40] TigerlakeSiliconPkg/Cpu: Add Include headers > > REF: https://bugzilla.tia

Re: [edk2-devel] [PATCH 40/40] Maintainers.txt: Add TigerlakeSiliconPkg maintainers

2021-02-03 Thread Nate DeSimone
Hi Heng, Thank you so much for all your work on this! I have a couple of minor comments, however due to the size of this patch series I produced a summary of these comments here for your convenience: [PATCH 01/40] #1) CpuPcieConfigGen3.h is only used on Rocket Lake boards for backwards socket

Re: [edk2-devel] [PATCH v6 9/9] OvmfPkg/SmmControl2Dxe: negotiate CPU hot-unplug

2021-02-03 Thread Ankur Arora
On 2021-02-03 12:45 p.m., Laszlo Ersek wrote: On 02/03/21 06:46, Ankur Arora wrote: On 2021-02-01 9:37 a.m., Laszlo Ersek wrote: (6) Please drop this hunk. We don't try to be smarter than QEMU, in general, whenever we perform feature negotiation. Also, AFAICS, we will do the hotplug (and no

[edk2-devel] [PATCH 2/2] UefiCpuPkg/MpInitLib: Use XADD to avoid lock acquire/release

2021-02-03 Thread Ni, Ray
When AP firstly wakes up, MpFuncs.nasm contains below logic to assign an unique ApIndex to each AP according to who comes first: ---ASM--- TestLock: xchg [edi], eax cmpeax, NotVacantFlag jz TestLock movecx, esi addecx, ApIndexLocation i

[edk2-devel] [PATCH 1/2] UefiCpuPkg/MpInitLib: Use NASM struc to avoid hardcode offset

2021-02-03 Thread Ni, Ray
In Windows environment, "dumpbin /disasm" is used to verify the disassembly before and after using NASM struc doesn't change. Signed-off-by: Ray Ni Cc: Eric Dong Cc: Laszlo Ersek Cc: Rahul Kumar --- UefiCpuPkg/Library/MpInitLib/Ia32/MpEqu.inc | 52 ++ .../Library/MpInitLib/I

[edk2-devel] [PATCH 0/2] UefiCpuPkg/MpInitLib: Use XADD to avoid lock acquire/release

2021-02-03 Thread Ni, Ray
Ray Ni (2): UefiCpuPkg/MpInitLib: Use NASM struc to avoid hardcode offset UefiCpuPkg/MpInitLib: Use XADD to avoid lock acquire/release UefiCpuPkg/Library/MpInitLib/Ia32/MpEqu.inc | 54 + .../Library/MpInitLib/Ia32/MpFuncs.nasm | 52 +++- UefiCpuPkg/Library/

Re: [edk2-devel] [PATCH v6 6/9] OvmfPkg/SmmCpuFeaturesLib: init CPU ejection state

2021-02-03 Thread Ankur Arora
On 2021-02-03 12:36 p.m., Laszlo Ersek wrote: On 02/03/21 06:20, Ankur Arora wrote: Just as a sidenote, I do see two copies of the mCpuHotEjectData in the PiSmmCpuSmm and CpuHotplugSmm maps (which makes sense, given that both include SmmCpuFeaturesLib): .bss.mCpuHotEjectData 0x00017d60

Re: [edk2-devel] [PATCH v6 7/9] OvmfPkg/CpuHotplugSmm: add CpuEject()

2021-02-03 Thread Ankur Arora
On 2021-02-03 12:55 p.m., Laszlo Ersek wrote: On 02/03/21 07:13, Ankur Arora wrote: On 2021-02-02 6:00 a.m., Laszlo Ersek wrote: On 02/01/21 21:12, Ankur Arora wrote: On 2021-02-01 11:08 a.m., Laszlo Ersek wrote: (16) This function uses a data structure for communication between BSP and APs

Re: [edk2-devel] [PATCH v6 7/9] OvmfPkg/CpuHotplugSmm: add CpuEject()

2021-02-03 Thread Ankur Arora
On 2021-02-03 12:58 p.m., Laszlo Ersek wrote: On 02/03/21 07:45, Ankur Arora wrote: On 2021-02-02 6:15 a.m., Laszlo Ersek wrote: On 02/02/21 15:00, Laszlo Ersek wrote: ... I guess that volatile-qualifying both CPU_HOT_EJECT_DATA, and the array pointed-to by CPU_HOT_EJECT_DATA.ApicIdMap, shoul

[edk2-devel] 回复: [Patch 1/1 V2] BaseTools: fix the split output files root dir

2021-02-03 Thread gaoliming
Bob: Does this behavior follow original C Split tool? Thanks Liming > -邮件原件- > 发件人: Bob Feng > 发送时间: 2021年2月1日 18:29 > 收件人: devel@edk2.groups.io > 抄送: Liming Gao ; Yuwei Chen > > 主题: [Patch 1/1 V2] BaseTools: fix the split output files root dir > > If the output file path is a relativ

Re: [edk2-devel] UEFI compile error

2021-02-03 Thread Guomin Jiang
It seem that you use some PCD directly but haven't declare it in DEC file as below error. File "/home/git/sw-edkII/edkII/BaseTools/Source/Python/Workspace/DecBuildData.py", line 468, in _GetPcd EdkLogger.error("build", PCD_STRUCTURE_PCD_ERROR, "The structure Pcd %s.%s header file is not fo

Re: [edk2-devel] [PATCH] IntelFsp2Pkg: Add YAML file generation support

2021-02-03 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Loo Tung Lun > Sent: Wednesday, February 3, 2021 8:36 AM > To: devel@edk2.groups.io > Cc: Loo, Tung Lun ; Ma, Maurice > ; Desimone, Nathaniel L > ; Zeng, Star ; Chiu, > Chasel > Subject: [PATCH] IntelFsp2Pkg: Add YAML file generat

Re: [edk2-devel] 回复: [PATCH v1 1/1] BaseTools: Align include guards policy

2021-02-03 Thread PierreGondois
Hello, I was wondering if there had been an agreement on how to proceed. For reference, the first messages are at: https://edk2.groups.io/g/devel/topic/80106488 Regards, Pierre From: Leif Lindholm Sent: Tuesday, January 26, 2021 11:07 AM To: devel@edk2.groups.io ; gaolim...@byosoft.com.cn Cc:

Re: [edk2-devel] [Bug 3187] FaultTolerantWriteDxe defect will cause NVRAM not recovered after number of WorkSpaceRefresh().

2021-02-03 Thread Chuang, Marlboro
Hi All, Regarding to Bug 3187, I have the duplicated code change and fix code change as the attachment. Please help to review and refine it. Thanks and Regards, Marlboro. -Original Message- From: bugzilla-dae...@bugzilla.tianocore.org Sent: Wednesday, February 3, 2021 11:04 AM To: C

[edk2-devel] UEFI compile error

2021-02-03 Thread suche...@zoyatek.com.cn
Hi, The error information occur when I compile a new platform UEFI source, so I need some help to correct this error, please. This is the error information under: build.py... : error C0DE: Unknown fatal error when processing [/home/git/sw-edkII/edkII/SenweiPkg/SenweiPkg.dec] (Please se

[edk2-devel] How can I receive EAP packets?

2021-02-03 Thread 梁宇飞
Hello, I am Jiangbo technology R&D, using edkii to write EAP certified loader, I use EFI_ SIMPLE_ NETWORK.Transmit () to contract, want to use EFI_ SIMPLE_ NETWORK.Receive () to receive packets. It is found that ordinary IP packets can be received, but EAP packets cannot be received. How can I rece

[edk2-devel] How can I receive EAP packets?

2021-02-03 Thread 梁宇飞
Hi,everyone, I am using edkii to write EAP certified loader, I use EFI_ SIMPLE_ NETWORK.Transmit () to contract, want to use EFI_ SIMPLE_ NETWORK.Receive () to receive packets. It is found that ordinary IP packets can be received, but EAP packets cannot be received. How can I receive EAP package

[edk2-devel] [PATCH] IntelFsp2Pkg: Add YAML file generation support

2021-02-03 Thread Tung Lun
Add support for YAML format file generation in addition to current BSF structure. Configuration of YAML format output will be supported by an open source ConfigEditor. Reference to YAML code, test and ConfigEditor is at https://github.com/joshloo/fsp_yaml_cfg/tree/master/Tools A unit test is also

Re: [edk2-devel] [PATCH 2/2] Maintainers.txt: Remove Jordan Justen from OvmfPkg

2021-02-03 Thread Ard Biesheuvel
On Tue, 2 Feb 2021 at 21:35, Jordan Justen wrote: > > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Signed-off-by: Jordan Justen Acked-by: Ard Biesheuvel > --- > Maintainers.txt | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/Maintainers.txt b/Maintainers.txt > index 96e792ab66..e986a3680

Re: [edk2-devel] [PATCH v6 7/9] OvmfPkg/CpuHotplugSmm: add CpuEject()

2021-02-03 Thread Laszlo Ersek
On 02/03/21 07:45, Ankur Arora wrote: > On 2021-02-02 6:15 a.m., Laszlo Ersek wrote: >> On 02/02/21 15:00, Laszlo Ersek wrote: >> >>> ... I guess that volatile-qualifying both CPU_HOT_EJECT_DATA, and the >>> array pointed-to by CPU_HOT_EJECT_DATA.ApicIdMap, should suffice. In >>> combination with t

Re: [edk2-devel] [PATCH v6 7/9] OvmfPkg/CpuHotplugSmm: add CpuEject()

2021-02-03 Thread Laszlo Ersek
On 02/03/21 07:13, Ankur Arora wrote: > On 2021-02-02 6:00 a.m., Laszlo Ersek wrote: >> On 02/01/21 21:12, Ankur Arora wrote: >>> On 2021-02-01 11:08 a.m., Laszlo Ersek wrote: (16) This function uses a data structure for communication between BSP and APs -- mCpuHotEjectData->ApicIdMap is

Re: [edk2-devel] [PATCH v6 9/9] OvmfPkg/SmmControl2Dxe: negotiate CPU hot-unplug

2021-02-03 Thread Laszlo Ersek
On 02/03/21 06:46, Ankur Arora wrote: > On 2021-02-01 9:37 a.m., Laszlo Ersek wrote: >> (6) Please drop this hunk. We don't try to be smarter than QEMU, in >> general, whenever we perform feature negotiation. > > Also, AFAICS, we will do the hotplug (and now hot-unplug) even if it wasn't > negoti

Re: [edk2-devel] [PATCH v6 6/9] OvmfPkg/SmmCpuFeaturesLib: init CPU ejection state

2021-02-03 Thread Laszlo Ersek
On 02/03/21 06:20, Ankur Arora wrote: > Just as a sidenote, I do see two copies of the mCpuHotEjectData in > the PiSmmCpuSmm and CpuHotplugSmm maps (which makes sense, given > that both include SmmCpuFeaturesLib): > > .bss.mCpuHotEjectData > 0x00017d60    0x8 > /tmp/PiSmmCpuDxeSmm.dll

Re: [edk2-devel] [PATCH v6 4/9] OvmfPkg/CpuHotplugSmm: introduce UnplugCpus()

2021-02-03 Thread Laszlo Ersek
On 02/03/21 05:28, Ankur Arora wrote: > On 2021-01-31 7:13 p.m., Laszlo Ersek wrote: >> On 01/29/21 01:59, Ankur Arora wrote: >>> +**/ >>> +STATIC >>> +EFI_STATUS >>> +UnplugCpus ( >>> +  IN APIC_ID  *ToUnplugApicIds, >>> +  IN UINT32   ToUnplugCount >>> + 

Re: [edk2-devel] [edk2-announce] Reminder: Community meeting this week - please resync your calendar

2021-02-03 Thread Soumya Guptha
Thanks Nate -Original Message- From: Desimone, Nathaniel L Sent: Tuesday, February 2, 2021 5:23 PM To: Guptha, Soumya K ; devel@edk2.groups.io; annou...@edk2.groups.io Subject: Re: [edk2-announce] Reminder: Community meeting this week - please resync your calendar Hi All, For those o

Re: [edk2-devel] [PATCH v3] MdeModulePkg/Library: Add HiiGetStringEx to UefiHiiLib for EDK2 Redfish

2021-02-03 Thread Abner Chang
Yes Dandan, yours follow coding standard. I will handle that. Also, I will help to push the patch to upstream with your review tag. Thanks Abner > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Dandan Bi > Sent: Wednesday, February 3, 2021 7:3

Re: [edk2-devel] [PATCH v7 13/21] ArmPkg: Add Universal/Smbios/ProcessorSubClassDxe

2021-02-03 Thread Leif Lindholm
I'm afraid I have another few comments on this - but they're pretty straightforward. If you can address those and then send out a v8 of just this patch, this set is ready to merge. On Sun, Jan 31, 2021 at 16:25:03 -0700, Rebecca Cran wrote: > ProcessorSubClassDxe provides SMBIOS CPU information us

Re: [edk2-devel] [PATCH v3] MdeModulePkg/Library: Add HiiGetStringEx to UefiHiiLib for EDK2 Redfish

2021-02-03 Thread Dandan Bi
One minor comment inline below. Reviewed-by: Dandan Bi with this is handled. Thanks, Dandan > -Original Message- > From: Abner Chang > Sent: Monday, February 1, 2021 11:06 AM > To: devel@edk2.groups.io > Cc: Bi, Dandan ; Dong, Eric ; > Nickle Wang > Subject: [PATCH v3] MdeModulePkg/Libr

Re: [edk2-devel] [PATCH] UefiPayloadPkg/PlatformBootManager: Connect console after EndOfDxe

2021-02-03 Thread Patrick Rudolph
Hi Sunny, none of the other packages are doing this before EndOfDxe. And there's no point in having trusted console as earlier as possible, as nothing is displayed in PlatformBootManagerBeforeConsole(). Please explain your use case. I don't see one here. Kind Regards, Patrick Rudolph On Wed, Feb

[edk2-devel] [PATCH 2/2 v4] StMMRpmb: Add support for building StandaloneMm image for OP-TEE

2021-02-03 Thread Ilias Apalodimas
With some recent changes in OP-TEE [1] and U-Boot [2] we can compile StMM and launch it from an OP-TEE secure partition which is mimicking SPM. There's a number of advantages in this approach. In Arm world SPM, currently used for dispatching StMM, and SPD used for OP-TEE, are mutually exclusive. S

[edk2-devel] [PATCH 1/2 v4] Drivers/OpTeeRpmb: Add an OP-TEE backed RPMB driver

2021-02-03 Thread Ilias Apalodimas
A following patch is adding support for building StMM in order to run it from OP-TEE. OP-TEE in combination with a NS-world supplicant can use the RPMB partition of an eMMC to store EFI variables. The supplicant functionality is currently available in U-Boot only but can be ported into EDK2. Assumi

[edk2-devel] [PATCH 0/2 v4] Add support for running StandaloneMm as OP-TEE TA

2021-02-03 Thread Ilias Apalodimas
Hi, This is v4 of [1] Changes since V3: - Coding style fixes proposed by Sami - Fixed all reported PatchCheck errors - Added overflow checks on the base aaddress allocated for EFI variables. The size of the partition is user defined (via Pcd's) and the memory layout and allocation addr

Re: [edk2-devel] [PATCH] UefiPayloadPkg/PlatformBootManager: Connect console after EndOfDxe

2021-02-03 Thread Wang, Sunny (HPS SW)
Hi Patrick, I'm not familiar with UefiPayloadPkg. However, since we may want to enable the trusted console as earlier as possible, you may still need to keep the PlatformConsoleInit() call at the beginning of PlatformBootManagerBeforeConsole() to support the platform that has trusted/on-board

[edk2-devel] [edk2-platforms] [PATCH v2 1/3] Platform/ARM/SgiPkg: Add helper macros for HMAT table

2021-02-03 Thread Vijayenthiran Subramaniam
Add helper macros to create Memory Proximity Domain, System Locality Latency and Bandwidth Information, Memory Side Cache Information structures in the HMAT table. Signed-off-by: Vijayenthiran Subramaniam --- Platform/ARM/SgiPkg/Include/SgiAcpiHeader.h | 110 1 file changed,

[edk2-devel] [edk2-platforms] [PATCH v2 0/3] Add HMAT tables for RD multi-chip platforms

2021-02-03 Thread Vijayenthiran Subramaniam
This patch series adds HMAT tables for Arm's Neoverse reference design multi-chip fixed virtual platforms. The first patch in the series adds helper macros to create HMAT table within SgiPkg and the rest two patches adds HMAT table for RD-N1-Edge-X2 and RD-V1-MC platforms respectively. Changes sin

[edk2-devel] [edk2-platforms] [PATCH v2 2/3] Platform/ARM/SgiPkg: Add HMAT ACPI table for RdN1EdgeX2

2021-02-03 Thread Vijayenthiran Subramaniam
Add HMAT table support for RD-N1-Edge dual-chip platform. The latencies mentioned in the table are hypothetical values and represents typical latency between two chips. These values are applicable only for RD-N1-Edge dual-chip fixed virtual and should not be reused for other platforms. Signed-off-

[edk2-devel] [edk2-platforms] [PATCH v2 3/3] Platform/ARM/SgiPkg: Add HMAT ACPI table for RD-V1-MC

2021-02-03 Thread Vijayenthiran Subramaniam
Add HMAT ACPI tables that is specific for RD-V1-MC quad-chip platform. The latencies mentioned in the table are hypothetical values and represents typical latency between four chips. These values are applicable only for RD-V1-MC quad-chip fixed virtual and should not be reused for other platforms.

[edk2-devel] [Wiki V2] Add update notes for incomaptible patches that fix typos in SmBios.h

2021-02-03 Thread Zhiguang Liu
Cc: Liming Gao Signed-off-by: Zhiguang Liu --- EDK-II-Release-Planning.md | 10 ++ 1 file changed, 10 insertions(+) diff --git a/EDK-II-Release-Planning.md b/EDK-II-Release-Planning.md index 336d8d2..7d75bea 100644 --- a/EDK-II-Release-Planning.md +++ b/EDK-II-Release-Planning.md @@ -32