On 11/29/19 07:18, Liming Gao via Groups.Io wrote:
> Hi, all
>
> Today, I review all patches in edk2 mail list. There is no patches for EDK II
> Stable Tag edk2-stable201911. Based on edk2-stable201911 tag planning, it
> will be released at 2019-11-29. So, I plan to create edk2-stable201911 base
On 11/29/19 04:02, Dong, Eric wrote:
> Hi Laszlo,
>
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Laszlo
> Ersek
> Sent: Thursday, November 28, 2019 9:57 PM
> To: Dong, Eric ; devel@edk2.groups.io
> Cc: Ni, Ray ; Gao, Liming
> Subject: Re: [edk2-devel] [PATCH v2] UefiCp
On 11/29/19 02:22, Ni, Ray wrote:
>>
>> I suggest that we introduce a new PCD for "token count per chunk", and
>> set the default value to 1, in the DEC file. (And we should copy the PCD
>> into a global variable, in InitializeDataForMmMp().)
>>
>> This way, if a platform suddenly starts consuming
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Kubacki, Michael A
> Sent: Thursday, November 28, 2019 9:06 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
>
> Subject: [edk2-platforms][PATCH V2 37/47]
> WhiskeylakeOpenBoardPkg/WhiskeylakeURvp: Enable adv
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Kubacki, Michael A
> Sent: Thursday, November 28, 2019 10:19 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Gao, Liming
> Subject: [edk2-platforms][PATCH V2 39/47] MinPlatformPkg: Install advanced
> f
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Kubacki, Michael A
> Sent: Thursday, November 28, 2019 9:06 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
>
> Subject: [edk2-platforms][PATCH V2 36/47]
> KabylakeOpenBoardPkg/KabylakeRvp3: Enable advanced
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Kubacki, Michael A
> Sent: Thursday, November 28, 2019 9:06 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
>
> Subject: [edk2-platforms][PATCH V2 35/47]
> KabylakeOpenBoardPkg/GalagoPro3: Enable advanced
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Kubacki, Michael A
> Sent: Thursday, November 28, 2019 9:06 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Gao, Liming ;
> Agyeman, Prince
> Subject: [edk2-platforms][PATCH V2 33/47] Platform/Intel: A
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Kubacki, Michael A
> Sent: Thursday, November 28, 2019 9:06 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
>
> Subject: [edk2-platforms][PATCH V2 32/47]
> WhiskeylakeOpenBoardPkg/WhiskeylakeURvp: Add FvAd
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Kubacki, Michael A
> Sent: Thursday, November 28, 2019 9:06 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
>
> Subject: [edk2-platforms][PATCH V2 31/47]
> KabylakeOpenBoardPkg/GalagoPro3: Add FvAdvancedPre
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Kubacki, Michael A
> Sent: Thursday, November 28, 2019 9:06 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
>
> Subject: [edk2-platforms][PATCH V2 30/47]
> KabylakeOpenBoardPkg/KabylakeRvp3: Add FvAdvanced
Reviewed-by: Chasel Chiu
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Kubacki,
> Michael A
> Sent: Thursday, November 28, 2019 9:06 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Gao, Liming
> Subject: [edk2-devel] [edk2-platforms][PATCH
Reviewed-by: Chasel Chiu
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Kubacki,
> Michael A
> Sent: Thursday, November 28, 2019 9:06 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
>
> Subject: [edk2-devel] [edk2-platforms][PATCH V2 25/47]
> Ka
Reviewed-by: Chasel Chiu
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Kubacki,
> Michael A
> Sent: Thursday, November 28, 2019 9:06 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
>
> Subject: [edk2-devel] [edk2-platforms][PATCH V2 27/47]
>
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Kubacki, Michael A
> Sent: Thursday, November 28, 2019 9:06 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
>
> Subject: [edk2-platforms][PATCH V2 26/47]
> KabylakeOpenBoardPkg/GalagoPro3: Add PEI_ARCH and
Hi, all
Today, I review all patches in edk2 mail list. There is no patches for EDK II
Stable Tag edk2-stable201911. Based on edk2-stable201911 tag planning, it will
be released at 2019-11-29. So, I plan to create edk2-stable201911 based on
current edk2 trunk (the latest commit
https://github.c
BZ https://bugzilla.tianocore.org/show_bug.cgi?id=2393 is submitted to record
this issue.
This is the corner issue when STATIC_ASSERT and OFFSET_OF are used together.
So, I think we can fix it after stable tag 201911.
Thanks
Liming
>-Original Message-
>From: Alex James [mailto:theracer
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2304
build.py and BuildReport.py warning using python 3.8
SyntaxWarning: "is" with a literal. Did you mean "=="?
For comparison of two strings use "==" instead of "is"
The patch is going to fixed this issue.
Cc: Liming Gao
Cc: Bob Feng
Signed-o
Hi Laszlo,
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Laszlo
Ersek
Sent: Thursday, November 28, 2019 9:57 PM
To: Dong, Eric ; devel@edk2.groups.io
Cc: Ni, Ray ; Gao, Liming
Subject: Re: [edk2-devel] [PATCH v2] UefiCpuPkg/PiSmmCpuDxeSmm: Avoid allocate
Token every time
Hi Jeremiah,
I have some questions for this change.
1. Will there be a PlatformBuild.py in any platform as your design? For example
there will be a PlatformBuild.py in MdeModulePkg, EmulatorPkg and etc. And this
PlatformBuild.py can be seen as a template?
2. The original build options can be set
>
> I suggest that we introduce a new PCD for "token count per chunk", and
> set the default value to 1, in the DEC file. (And we should copy the PCD
> into a global variable, in InitializeDataForMmMp().)
>
> This way, if a platform suddenly starts consuming tokens, it will work
> (there will alw
Reviewed-by: Jiaxin Wu
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Maciej
> Rabeda
> Sent: Thursday, November 28, 2019 10:46 PM
> To: devel@edk2.groups.io
> Cc: Wu, Jiaxin ; Fu, Siyuan
> Subject: [edk2-devel] [PATCH v1 1/1] NetworkPkg: Fixes to static code
> analysis
Reviewed-by: Siyuan Fu
> -Original Message-
> From: Maciej Rabeda
> Sent: 2019年11月28日 22:46
> To: devel@edk2.groups.io
> Cc: Wu, Jiaxin ; Fu, Siyuan
> Subject: [PATCH v1 1/1] NetworkPkg: Fixes to static code analysis hits
>
> Introducing fixes to memory leak issues identified by static
Alex:
Do you find the real issue without this fix? Or is this change just an
enhancement?
As you know, now we are in hard code freeze phase. Only functional bug is
allowed.
Thanks
Liming
>-Original Message-
>From: Alex James [mailto:theracermas...@gmail.com]
>Sent: Thursday, Novem
Mike:
In this wiki, I see 1&3 and 2&4 have the same subject. How about use the
different subjects for them?
1) Azure Pipelines Configuration Steps
3) Azure Pipelines Configuration Steps
2) GitHub Configuration Steps
4) GitHub Configuration Steps
Thanks
Liming
>-Original Message-
>From
On Thu, 28 Nov 2019 at 16:19, Leif Lindholm wrote:
>
> On Thu, Nov 28, 2019 at 15:59:14 +0100, Ard Biesheuvel wrote:
> > On Thu, 28 Nov 2019 at 15:56, Leif Lindholm
> > wrote:
> > >
> > > On Thu, Nov 28, 2019 at 15:48:39 +0100, Ard Biesheuvel wrote:
> > > > We switched to cache coherent DMA for
On Wed, 27 Nov 2019 at 19:44, Ard Biesheuvel wrote:
>
> Fix some issues in the ACPI and DT descriptions of the SMMU routing,
> in particular the routing of the CCP crypto accelerator, which sits
> behind an SMMU as well on B1 silicon (but not on B0, strangely enough)
>
> Changes since v1:
> - add
On Thu, Nov 28, 2019 at 16:04:29 +0100, Ard Biesheuvel wrote:
> On Thu, 28 Nov 2019 at 16:02, Leif Lindholm wrote:
> >
> > On Thu, Nov 28, 2019 at 15:48:40 +0100, Ard Biesheuvel wrote:
> > > The variable runtime cache for SMM enabled implementations of the
> > > variable runtime DXE driver was int
On Thu, Nov 28, 2019 at 15:59:14 +0100, Ard Biesheuvel wrote:
> On Thu, 28 Nov 2019 at 15:56, Leif Lindholm wrote:
> >
> > On Thu, Nov 28, 2019 at 15:48:39 +0100, Ard Biesheuvel wrote:
> > > We switched to cache coherent DMA for the NETSEC network controller ages
> > > ago, but the platform driver
On 11/28/19 3:46 PM, Maciej Rabeda via Groups.Io wrote:
Introducing fixes to memory leak issues identified by static code analysis
tool.
Cc: Jiaxin Wu
Cc: Siyuan Fu
Signed-off-by: Maciej Rabeda
---
NetworkPkg/Dhcp6Dxe/Dhcp6Io.c | 1 +
NetworkPkg/Ip4Dxe/Ip4If.c | 6 +-
Netw
On Thu, 28 Nov 2019 at 14:40, Leif Lindholm wrote:
>
> On Thu, Nov 28, 2019 at 14:39:23 +0100, Ard Biesheuvel wrote:
> > On Thu, 28 Nov 2019 at 14:37, Leif Lindholm
> > wrote:
> > >
> > > On Wed, Nov 27, 2019 at 19:44:38 +0100, Ard Biesheuvel wrote:
> > > > Use the more precise Cortex-A57 based
On Thu, 28 Nov 2019 at 16:02, Leif Lindholm wrote:
>
> On Thu, Nov 28, 2019 at 15:48:40 +0100, Ard Biesheuvel wrote:
> > The variable runtime cache for SMM enabled implementations of the
> > variable runtime DXE driver was introduced after the standalone
> > MM based implementation was merged for
On Thu, Nov 28, 2019 at 15:48:40 +0100, Ard Biesheuvel wrote:
> The variable runtime cache for SMM enabled implementations of the
> variable runtime DXE driver was introduced after the standalone
> MM based implementation was merged for the DeveloperBox platform.
>
> This means the combined binary
On Thu, 28 Nov 2019 at 15:56, Leif Lindholm wrote:
>
> On Thu, Nov 28, 2019 at 15:48:39 +0100, Ard Biesheuvel wrote:
> > We switched to cache coherent DMA for the NETSEC network controller ages
> > ago, but the platform driver that registers the non-discoverable device
> > currently does not refle
On Thu, Nov 28, 2019 at 15:48:39 +0100, Ard Biesheuvel wrote:
> We switched to cache coherent DMA for the NETSEC network controller ages
> ago, but the platform driver that registers the non-discoverable device
> currently does not reflect this change, which we haven't noticed since
> the driver do
The variable runtime cache for SMM enabled implementations of the
variable runtime DXE driver was introduced after the standalone
MM based implementation was merged for the DeveloperBox platform.
This means the combined binary image of ARM Trusted Firmware and
the standalone MM runtime we carry in
We switched to cache coherent DMA for the NETSEC network controller ages
ago, but the platform driver that registers the non-discoverable device
currently does not reflect this change, which we haven't noticed since
the driver doesn't look at this flag.
Let's fix this nonetheless, in case it ever
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2334
Introducing fixes to memory leak issues identified by static code analysis
tool.
Maciej Rabeda (1):
NetworkPkg: Fixes to static code analysis hits
NetworkPkg/Dhcp6Dxe/Dhcp6Io.c | 1 +
NetworkPkg/Ip4Dxe/Ip4If.c | 6 +-
Net
Introducing fixes to memory leak issues identified by static code analysis
tool.
Cc: Jiaxin Wu
Cc: Siyuan Fu
Signed-off-by: Maciej Rabeda
---
NetworkPkg/Dhcp6Dxe/Dhcp6Io.c | 1 +
NetworkPkg/Ip4Dxe/Ip4If.c | 6 +-
NetworkPkg/TcpDxe/TcpDispatcher.c | 1 +
3 files changed, 7 inser
On 11/28/19 07:17, Eric Dong wrote:
> v2 changes:
> Minor update based on comments.
>
> v1 changes:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2388
>
> Current logic allocate Token every time when need to use it.
(1) Can you please clarify, in the *commit message*, what service the
to
On Thu, Nov 28, 2019 at 14:39:23 +0100, Ard Biesheuvel wrote:
> On Thu, 28 Nov 2019 at 14:37, Leif Lindholm wrote:
> >
> > On Wed, Nov 27, 2019 at 19:44:38 +0100, Ard Biesheuvel wrote:
> > > Use the more precise Cortex-A57 based compatible strings to describe
> > > the CPUs and the PMUs in the dev
On Thu, 28 Nov 2019 at 14:37, Leif Lindholm wrote:
>
> On Wed, Nov 27, 2019 at 19:44:38 +0100, Ard Biesheuvel wrote:
> > Use the more precise Cortex-A57 based compatible strings to describe
> > the CPUs and the PMUs in the device tree.
> >
> > Signed-off-by: Ard Biesheuvel
> > ---
> > Silicon/AM
On Wed, Nov 27, 2019 at 19:44:39 +0100, Ard Biesheuvel wrote:
> The linux,phandle property is a deprecated alias for the phandle property
> which was standardized long ago, so don't bother emitting it.
>
> Signed-off-by: Ard Biesheuvel
Reviewed-by: Leif Lindholm
> ---
> Silicon/AMD/Styx/Libra
On Wed, Nov 27, 2019 at 19:44:38 +0100, Ard Biesheuvel wrote:
> Use the more precise Cortex-A57 based compatible strings to describe
> the CPUs and the PMUs in the device tree.
>
> Signed-off-by: Ard Biesheuvel
> ---
> Silicon/AMD/Styx/Library/StyxDtbLoaderLib/StyxDtbLoaderLib.c | 4 ++--
> 1 fil
On Thu, 28 Nov 2019 at 13:32, Leif Lindholm wrote:
>
> On Wed, Nov 27, 2019 at 19:44:34 +0100, Ard Biesheuvel wrote:
> > DT unit addresses are hex quantities but they should not include
> > the 0x prefix.
> >
> > Signed-off-by: Ard Biesheuvel
>
> Reviewed-by: Leif Lindholm
>
> But can you clarif
On Thu, 28 Nov 2019 at 14:22, Leif Lindholm wrote:
>
> On Wed, Nov 27, 2019 at 19:44:36 +0100, Ard Biesheuvel wrote:
> > AMD Seattle uses a range of SPIs to signal PMU events, and this requires
> > a description in the DT which SPI maps to which CPU. This requires us to
> > defer the generation of
On Wed, Nov 27, 2019 at 19:44:37 +0100, Ard Biesheuvel wrote:
> Emit the cache topology into the device tree too when generating the
> CPU nodes and the cpu-map. Note that the cache geometries are all
> fixed and thus hardcoded - the only runtime variable aspect is how
> many L2 nodes to generate (
On Wed, Nov 27, 2019 at 19:44:36 +0100, Ard Biesheuvel wrote:
> AMD Seattle uses a range of SPIs to signal PMU events, and this requires
> a description in the DT which SPI maps to which CPU. This requires us to
> defer the generation of the PMU node to a point where the CPU phandles
> have been al
On 11/28/19 6:56 AM, Alex James via Groups.Io wrote:
CLANGPDB does not define __GNUC__, but it does define __clang__. Check
for the __clang__ preprocessor definition to use __builtin_offsetof to
implement the OFFSET_OF macro.
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by: Alex James
---
Hi Eric,
On 11/28/19 7:17 AM, Dong, Eric via Groups.Io wrote:
v2 changes:
Minor update based on comments.
v1 changes:
Nitpick, previous comments should not go into the commit description,
either on a cover letter, or after the '---' marker so they get stripped
out by git-am.
Another ni
On 11/27/19 8:57 PM, Kubacki, Michael A via Groups.Io wrote:
This patch clarifies wording in several PeiCore comments to improve
reading comprehension.
Cc: Dandan Bi
Cc: Liming Gao
Cc: Jian J Wang
Cc: Hao A Wu
Signed-off-by: Michael Kubacki
---
MdeModulePkg/Core/Pei/FwVol/FwVol.h
On 11/27/19 8:57 PM, Kubacki, Michael A via Groups.Io wrote:
Cc: Dandan Bi
Cc: Liming Gao
Cc: Jian J Wang
Cc: Hao A Wu
Signed-off-by: Michael Kubacki
---
MdeModulePkg/Core/Pei/PeiMain.inf | 10 ++--
MdeModulePkg/Core/Pei/FwVol/FwVol.h | 20
MdeModulePkg/Cor
On Wed, Nov 27, 2019 at 19:44:34 +0100, Ard Biesheuvel wrote:
> DT unit addresses are hex quantities but they should not include
> the 0x prefix.
>
> Signed-off-by: Ard Biesheuvel
Reviewed-by: Leif Lindholm
But can you clarify in commit message that this is a cosmetic/style
change only?
(And
On 11/27/19 20:03, Kinney, Michael D wrote:
> Hi Laszlo,
>
> Do you want to see the presence of the 'push' label
> in a notification when the PR is created, or just
> when the checks have been completed in either the
> pass or the fail state?
I'd like to see the purpose of the PR in the first not
Hi Vikash,
If I remember correctly, those BIOSes have a binary CMS choice for CSM with
regards to options ROMs. Either you permit legacy option ROMs or you permit
UEFI option ROMs and there is not way to permit both at the same time. Make
sure that these settings are configured correctly.
Al
CLANGPDB does not define __GNUC__, but it does define __clang__. Check
for the __clang__ preprocessor definition to use __builtin_offsetof to
implement the OFFSET_OF macro.
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by: Alex James
---
MdePkg/Include/Base.h | 4 +---
1 file changed, 1 inser
Hi All,
I am developing a UEFI Option Rom driver. I found that in few
motherboard (ASrock
X100 and above, motherboard with AMD processor and MSI PC) Option Rom is
not loading. In this case, inbox driver is taking control of the device.
I checked PCI trace and found Option Rom has read from Expa
57 matches
Mail list logo
