Reviewed-by: Chasel Chiu <chasel.c...@intel.com>
> -----Original Message----- > From: Kubacki, Michael A <michael.a.kuba...@intel.com> > Sent: Thursday, November 28, 2019 9:06 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel <chasel.c...@intel.com>; Desimone, Nathaniel L > <nathaniel.l.desim...@intel.com> > Subject: [edk2-platforms][PATCH V2 35/47] > KabylakeOpenBoardPkg/GalagoPro3: Enable advanced features > > This change enables advanced features to be used by the > GalagoPro3 board in KabylakeOpenBoardPkg. > > Some platform macros in OpenBoardPkg.dsc are consolidated so all values > are set at the top of the file before including advanced feature code. > > Cc: Chasel Chiu <chasel.c...@intel.com> > Cc: Nate DeSimone <nathaniel.l.desim...@intel.com> > Signed-off-by: Michael Kubacki <michael.a.kuba...@intel.com> > Reviewed-by: Nate DeSimone <nathaniel.l.desim...@intel.com> > --- > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc > | 46 +++++++++----------- > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkgPcd.dsc | > 1 + > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.fdf | > 4 ++ > 3 files changed, 25 insertions(+), 26 deletions(-) > > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc > index d4ca2daa18..a39547f41f 100644 > --- a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc > +++ b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc > @@ -16,38 +16,32 @@ > DEFINE PROJECT = > $(PLATFORM_BOARD_PACKAGE)/$(BOARD) > DEFINE PEI_ARCH = IA32 > DEFINE DXE_ARCH = X64 > - > - # > - # Include PCD configuration for this board. > - # > - !include OpenBoardPkgPcd.dsc > - > -############################################################### > ################# > -# > -# Defines Section - statements that will be processed to create a Makefile. > -# > -############################################################### > ################# > -[Defines] > - PLATFORM_NAME = $(PLATFORM_PACKAGE) > - PLATFORM_GUID = > 7324F33D-4E96-4F8B-A550-544DE6162AB7 > - PLATFORM_VERSION = 0.1 > - DSC_SPECIFICATION = 0x00010005 > - OUTPUT_DIRECTORY = Build/$(PROJECT) > - SUPPORTED_ARCHITECTURES = IA32|X64 > - BUILD_TARGETS = DEBUG|RELEASE > - SKUID_IDENTIFIER = ALL > - > - > - FLASH_DEFINITION = > $(PROJECT)/OpenBoardPkg.fdf > - > - FIX_LOAD_TOP_MEMORY_ADDRESS = 0x0 > - DEFINE TOP_MEMORY_ADDRESS = 0x0 > + DEFINE TOP_MEMORY_ADDRESS = 0x0 > > # > # Default value for OpenBoardPkg.fdf use > # > DEFINE BIOS_SIZE_OPTION = SIZE_60 > > + PLATFORM_NAME = > $(PLATFORM_PACKAGE) > + PLATFORM_GUID = > 7324F33D-4E96-4F8B-A550-544DE6162AB7 > + PLATFORM_VERSION = 0.1 > + DSC_SPECIFICATION = 0x00010005 > + OUTPUT_DIRECTORY = Build/$(PROJECT) > + SUPPORTED_ARCHITECTURES = IA32|X64 > + BUILD_TARGETS = DEBUG|RELEASE > + SKUID_IDENTIFIER = ALL > + > + FLASH_DEFINITION = > $(PROJECT)/OpenBoardPkg.fdf > + FIX_LOAD_TOP_MEMORY_ADDRESS = 0x0 > + > + # > + # Include PCD configuration for this board. > + # > + !include > + > AdvancedFeaturePkg/TemporaryBuildWorkaround/TemporaryBuildWorkaro > und.d > + sc > + !include OpenBoardPkgPcd.dsc > + !include AdvancedFeaturePkg/Include/AdvancedFeatures.dsc > + > > ################################################################ > ################ > # > # SKU Identification section - list of all SKU IDs supported by this board. > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkgPcd.dsc > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkgPcd.dsc > index c6f5ae7534..7393897249 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkgPcd.dsc > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkgPcd.dsc > @@ -24,6 +24,7 @@ > # Stage 3 - boot to shell only > # Stage 4 - boot to OS > # Stage 5 - boot to OS with security boot enabled > + # Stage 6 - boot with advanced features enabled > # > gMinPlatformPkgTokenSpaceGuid.PcdBootStage|4 > > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.fdf > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.fdf > index 0a9b933e40..da94ed0cd1 100644 > --- a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.fdf > +++ b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.fdf > @@ -631,6 +631,8 @@ READ_LOCK_CAP = TRUE > READ_LOCK_STATUS = TRUE > FvNameGuid = 6053D78A-457E-4490-A237-31D0FBE2F305 > > +!include AdvancedFeaturePkg/Include/PreMemory.fdf > + > !if gKabylakeOpenBoardPkgTokenSpaceGuid.PcdTbtEnable == TRUE INF > $(PLATFORM_BOARD_PACKAGE)/Features/Tbt/TbtInit/Pei/PeiTbtInit.inf > !endif > @@ -657,6 +659,8 @@ READ_LOCK_CAP = TRUE > READ_LOCK_STATUS = TRUE > FvNameGuid = BE3DF86F-E464-44A3-83F7-0D27E6B88C27 > > +!include AdvancedFeaturePkg/Include/PostMemory.fdf > + > !if gKabylakeOpenBoardPkgTokenSpaceGuid.PcdTbtEnable == TRUE INF > $(PLATFORM_BOARD_PACKAGE)/Features/Tbt/TbtInit/Dxe/TbtDxe.inf > INF $(PLATFORM_BOARD_PACKAGE)/Features/PciHotPlug/PciHotPlug.inf > -- > 2.16.2.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#51495): https://edk2.groups.io/g/devel/message/51495 Mute This Topic: https://groups.io/mt/63460091/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
