Reviewed-by: Chasel Chiu <chasel.c...@intel.com>


> -----Original Message-----
> From: Kubacki, Michael A <michael.a.kuba...@intel.com>
> Sent: Thursday, November 28, 2019 9:06 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.c...@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desim...@intel.com>
> Subject: [edk2-platforms][PATCH V2 26/47]
> KabylakeOpenBoardPkg/GalagoPro3: Add PEI_ARCH and DXE_ARCH
> 
> This change adds two new macros to OpenBoardPkg.dsc that identify the
> build architecture for PEI and DXE modules. The intention of this macro is to
> ensure that all DSC files that compose the package build (such as those
> included from MinPlatformPkg or an advanced feature package) build
> phase-specific drivers for the architecture defined by the board package.
> 
> This is a macro that is required in all Minimum Platform board packages.
> 
> Cc: Chasel Chiu <chasel.c...@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desim...@intel.com>
> Signed-off-by: Michael Kubacki <michael.a.kuba...@intel.com>
> Reviewed-by: Nate DeSimone <nathaniel.l.desim...@intel.com>
> ---
>  Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc | 16
> ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git
> a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc
> b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc
> index acdc31e708..d4ca2daa18 100644
> --- a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc
> +++ b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc
> @@ -14,6 +14,8 @@
>    DEFINE      PLATFORM_BOARD_PACKAGE          =
> KabylakeOpenBoardPkg
>    DEFINE      BOARD                           = GalagoPro3
>    DEFINE      PROJECT                         =
> $(PLATFORM_BOARD_PACKAGE)/$(BOARD)
> +  DEFINE      PEI_ARCH                        = IA32
> +  DEFINE      DXE_ARCH                        = X64
> 
>    #
>    # Include PCD configuration for this board.
> @@ -74,10 +76,14 @@
>  #######################################
>  # Component Includes
>  #######################################
> +# @todo: Change below line to [Components.$(PEI_ARCH)] after
> https://bugzilla.tianocore.org/show_bug.cgi?id=2308
> +#        is completed
>  [Components.IA32]
>  !include $(PLATFORM_PACKAGE)/Include/Dsc/CorePeiInclude.dsc
>  !include $(PLATFORM_SI_PACKAGE)/SiPkgPei.dsc
> 
> +# @todo: Change below line to [Components.$(DXE_ARCH)] after
> https://bugzilla.tianocore.org/show_bug.cgi?id=2308
> +#        is completed
>  [Components.X64]
>  !include $(PLATFORM_PACKAGE)/Include/Dsc/CoreDxeInclude.dsc
>  !include $(PLATFORM_SI_PACKAGE)/SiPkgDxe.dsc
> @@ -228,6 +234,11 @@
> 
> TestPointCheckLib|$(PLATFORM_PACKAGE)/Test/Library/TestPointCheckLib/S
> mmTestPointCheckLib.inf
>  !endif
> 
> +#######################################
> +# PEI Components
> +#######################################
> +# @todo: Change below line to [Components.$(PEI_ARCH)] after
> https://bugzilla.tianocore.org/show_bug.cgi?id=2308
> +#        is completed
>  [Components.IA32]
>    #######################################
>    # Edk2 Packages
> @@ -301,6 +312,11 @@
>  !endif
>    $(PLATFORM_BOARD_PACKAGE)/BiosInfo/BiosInfo.inf
> 
> +#######################################
> +# DXE Components
> +#######################################
> +# @todo: Change below line to [Components.$(DXE_ARCH)] after
> https://bugzilla.tianocore.org/show_bug.cgi?id=2308
> +#        is completed
>  [Components.X64]
>    #######################################
>    # Edk2 Packages
> --
> 2.16.2.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#51488): https://edk2.groups.io/g/devel/message/51488
Mute This Topic: https://groups.io/mt/63458822/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to