Re: Please don't abuse "No bug" in commit messages

On 03/02/2017 15:11, Ryan VanderMeulen wrote: A friendly reminder that per the MDN commit rules, the use of "No bug" in the commit message is to be used sparingly - in general for minor things like whitespace changes/comment fixes/etc where traceability isn't as important. https://developer.mo

Re: Introducing LocaleService and mozILocaleService

On 07/02/2017 19:38, zbranie...@mozilla.com wrote: JS [2]: ``` const localeService = Components.classes["@mozilla.org/intl/localeservice;1"] .getService(Components.interfaces.mozILocaleService); const appLocales = localeService.getAppLocales(); Please can you add an alias into Services.jsm

Re: Please don't add JS implemented telemetry probes to hot code paths. (eom)

Can you clarify what you mean by "JS implemented" here? I was under the impression the telemetry implementation was in C++... Separately, was there a concrete reason for you posting this warning? I don't wish to shame people, but a concrete example of a 'wrong' pattern might help in making it

Re: Intent to unship: xml:base attribute

On 16/02/2017 06:51, Xidorn Quan wrote: Tracking bug: https://bugzilla.mozilla.org/show_bug.cgi?id=903372 Summary: * It has been removed from the spec years ago. * No other browser supports it. * We pay performance penalty for it. * It makes things trickier for stylo to handle URL values. The t

Re: Please use Add*VarCache and not Get* when reading pref values in any even possibly warm code paths

Related note: add*varcache uses a pref observer behind the scenes. Pref observers always prefix-match, and the *varcache implementation doesn't bother re-checking whether the pref for which it gets a notification matches the one you requested a cache for. So if you have prefs "blah.foo" and "bl

Re: Please use Add*VarCache and not Get* when reading pref values in any even possibly warm code paths

ached pref name is a string prefix of another pref name. :-) ~ Gijs On 22/02/2017 13:23, smaug wrote: Huh, that is a horrible bug. On 02/22/2017 01:42 PM, Gijs Kruitbosch wrote: Related note: add*varcache uses a pref observer behind the scenes. Pref observers always prefix-match, and the

Re: Startup JS debugging (sometimes) possible via Browser Toolbox

On 13/03/2017 16:48, J. Ryan Stinnett wrote: On Thu, Mar 9, 2017 at 2:18 AM, Panos Astithas > wrote: You almost completely resolved the 4-year-old bug 814298, yay! I now wonder if this makes it easier to improve mochitest debugging per bug 929535. Thank

Re: unowned module: Firefox::New Tab Page, help me find an owner

On 22/03/2017 13:22, jma...@mozilla.com wrote: I have not been able to find an owner for the Firefox::New Tab Page bugzilla component (bug 1346908). There are 35 tests in the tree and without anyone to assume responsibility for them when they are intermittent (bug 1338848), I plan to delete t

Re: Intent to unship: -moz-placeholder pseudo-element and pseudo-class

On 24/05/2017 03:13, Ku(顧思捷)CJ wrote: I intend to remove "-moz-placeholder" pseudo-element and pseudo-class in bug 1300896. Which will ship in which release? 55 or 56? Esp. asking given the upcoming feature freeze for 55. ~ Gijs ___ dev-platform ma

Re: Switching to per-channel profiles

On 26/06/2017 14:03, Ben Hearsum wrote: On 2017-06-23 06:43 PM, Dave Townsend wrote: TL;DR: We should make each Firefox channel use its own profile data allowing you to run multiple channels at the same time. Running multiple channels of Firefox is currently harder than it needs to be. You can'

Re: Linting for common causes of oranges in mochitests (need ideas)

IME panels/popups/context-menus are flaky generally, and especially on Linux. I don't know how to meaningfully lint for this. The other thing is various incantations that try to do variations on the "load x in a tab" theme. It turns out that it's not trivial to not race with an expectant page

Super-review - proposal to remove given lack of super-review-specific usage

(x-post platform + governance + bmo, please followup-to governance) Today I was asked for super-review. Although I've been around a while, I am not a super-reviewer. I can't remember the last time before today that I was asked (it's quite possibly: never). The person who asked me was mostly ju

Re: Phabricator and confidential reviews

On 09/08/2017 01:30, Mark Côté wrote: If you have any thoughts on this, please reply. I'll answer any questions and summarize the feedback with a decision in a few days. Note that we can, of course, try a simple approach to start, and add in more complex functionality after an evaluation per

Re: Intent to ship version 4 of the Safe Browsing protocol

On 16/08/2017 11:11, Enrico Weigelt, metux IT consult wrote: On 16.08.2017 01:46, Francois Marier wrote: After a year's worth of development, bug fixes, and integration testing, we are now ready to enable the latest version [1] of the Safe Browsing API in Firefox 56, two releases ahead of schedu

Re: Intent to unship: :-moz-system-metric pseudo-class and media queries in content pages.

On 01/09/2017 20:06, Emilio Cobos Álvarez wrote: Hi dev-platform@, I'd like to unship access to the :-moz-system-metric pseudo-class, and the system metric media queries, from content pages. I just filed for that. They're not in any spec, a

Re: Reminder on Try usage and infrastructure resources

This only works once you have a run that failed the test you're interested in, right? There's no way to tell the test-centric UI "find me the chunk for test with name X". ~ Gijs On 14/09/2017 16:55, Cameron Dawson wrote: Marco— I don’t know of a way to do exactly that yet. But that is in th

Re: Pulsebot in #developers

I agree with Kris' points. Perhaps there's some kind of middle ground possible? Maybe if pulsebot reported landed patch author + reviewer names (to keep the mentions) on the hour every hour, with a link to pushlogs, or something. And all the merges were coalesced to "autoland and inbound were

Re: Pulsebot in #developers

On 06/11/2017 00:23, zbranie...@mozilla.com wrote: but please, be careful because #developers is also the most natural channel for any newcomers to go to in order to ask entry level questions about our codebase. No, that should be (and is and has been for a considerable amount of time, IME),

Re: Pulsebot in #developers

On 06/11/2017 12:49, Philipp Kewisch wrote: If there is a better place to ask ad-hoc questions about Gecko, I am happy to go there (and we should make sure the channel is promoted in our docs). I think different teams have ended up with different IRC channels, as Kris said. Frontend Firefox st

Re: Intent to unship: mozmm CSS unit.

On 12/11/2017 16:36, Emilio Cobos Álvarez wrote: On 11/12/2017 05:14 PM, Xidorn Quan wrote: I doubt if there is anything changed since then (except that we still haven't pushed this on csswg), so maybe we still shouldn't remove it. I'm definitely ok with adding something like that if there's a

Re: Intent to unship: mozmm CSS unit.

On 12/11/2017 16:56, Gijs Kruitbosch wrote: because layout already adjusts some (but not all!) sizes to align to device pixels For reference: https://bugzilla.mozilla.org/show_bug.cgi?id=477157 and friends. ~ Gijs ___ dev-platform mailing list

Re: Proposal: Stop using Object.freeze/Object.seal on most of our Javascript Objects

On 20/11/2017 10:01, Mark Banner wrote: Now that we don't have legacy add-ons outside of our control, I would like to propose that we stop using Object.freeze/Object.seal on most of our objects. I believe that this was originally done to provide some extra security/stability relating to add-o

Re: Intent to implement and ship: constructible EventTarget

On 19/11/2017 03:55, Boris Zbarsky wrote: Devtools bug: I don't think devtools need to do anything special here. Devtools' inspector lets you see which DOM nodes have event listeners attached to them. It would be neat if they could provide the same support in the debugger for instances of Eve

Re: Intent to implement and ship: constructible EventTarget

On 20/11/2017 17:13, Boris Zbarsky wrote: On 11/20/17 6:28 AM, Gijs Kruitbosch wrote: Devtools' inspector lets you see which DOM nodes have event listeners attached to them. It would be neat if they could provide the same support in the debugger for instances of EventTarget (o

Re: new code to help with cross-process windows/workers (and Clients API)

On 08/12/2017 20:23, Ben Kelly wrote: Please let me know if you have any question or if you think you have a feature that could integrate with the clients infrastructure. While the initial implementation is limited to Clients API needs, I've tried to design it to support other internal uses. I'

Re: All about Prefs

On 18/12/2017 03:38, Nicholas Nethercote wrote: I am working on a redesign that will fix a lot of the problems. There was a meeting about this in Austin. I hope to implement this in Q1 2018. Yay! If you have changes related to Prefs, please let me (or another Prefs peer) know about it. Thanks

Re: Password autofilling

On 01/01/2018 20:08, Jonathan Kingston wrote: We have the ability to turn off the whole login manager within Firefox preferences: "Remember logins and passwords for web sites" but no way to prevent autofill. There's an about:config pref, as [1] points out, which does this. I wonder if there's

Re: Refactoring proposal for the observer service

This is really interesting, thanks for looking at this! On 03/01/2018 22:09, Gabriele Svelto wrote: This would have quite a few coding benefits: - It would make it far easier to retire/rename a topic, since ... JS would throw. Why would it? I think it would pass undefined (as the topic wouldn

Re: Refactoring proposal for the observer service

On 03/01/2018 23:18, Nihanth Subramanya wrote: ++ from me as well, this sounds awesome. Ideally, I would like a solution where especially JS-only observer topics don't require a non-artifact build. A JS forwarder for the "real" observer service may help with that goal, by making the "new" argu

Re: Refactoring proposal for the observer service

On 04/01/2018 22:49, Gabriele Svelto wrote: On 04/01/18 00:05, Gijs Kruitbosch wrote: Unfortunately, there are quite a lot ( https://searchfox.org/mozilla-central/search?q=obs.addObserver&case=false®exp=false&path= -- sync, the add-ons manager, session store, etc. etc.). That'

Re: Refactoring proposal for the observer service

On 04/01/2018 23:47, Gijs Kruitbosch wrote: On 04/01/2018 22:49, Gabriele Svelto wrote: On 04/01/18 00:05, Gijs Kruitbosch wrote: Unfortunately, there are quite a lot ( https://searchfox.org/mozilla-central/search?q=obs.addObserver&case=false®exp=false&path= -- sync, the add-ons

Re: Announcing the next Extended Support Release of Firefox - ESR60 with policy engine

On 04/01/2018 18:06, Tom Ritter wrote: I am curious what Enterprise users are asking for. I'd like to think/hope that a primary concern of enterprise is "Security" (or the separate topic of Privacy); but I'm not certain it is. In particular, I am curious if enterprise users would be interested

Re: PSA: searchfox now indexes rust

On 08/01/2018 21:51, Mike Hommey wrote: On Mon, Jan 08, 2018 at 11:15:13AM -0500, Kartikaya Gupta wrote: Just a heads-up, thanks to a bunch of work by Emilio, searchfox.org now indexes rust code as well, so you can do things like jump to function definitions and call sites and whatnot. Please us

Re: performing cross-context instanceof checks

On 11/01/2018 05:29, Cameron McCormack wrote: For use in the meantime, I just landed bug 1428531 on inbound, which adds a new chrome-only static method "isInstance" to Web IDL defined interfaces, so you can write for example: Document.isInstance(otherWindow.document) So that we don't have

Re: performing cross-context instanceof checks

in a different compartment. On Thu, Jan 11, 2018 at 3:58 PM, Gijs Kruitbosch wrote: On 11/01/2018 05:29, Cameron McCormack wrote: For use in the meantime, I just landed bug 1428531 on inbound, which adds a new chrome-only static method "isInstance" to Web IDL defined interfaces,

Intent to unship: remote jar: protocol pref

Hello, jar: is an internal protocol that enables loading resources from inside a jar/zip file . Firefox is the only browser I'm aware of that supports it. In Firefox 55, due to security concerns, we put using jar: with remote content (ie loaded over http(s), ftp - anything apart from file://,

Re: Intent to unship: remote jar: protocol pref

On 12/01/2018 22:12, Gijs Kruitbosch wrote: As Kris already pointed out in his footnote, the most likely group of people to have enabled this (given 0 public reports on breakage so far, as far as I'm aware) are people on ESR or otherwise in enterprise environments, and our collection rat

Re: Intent to unship: remote jar: protocol pref

tell us much about enterprise users, who are probably the most likely people to make use of it. On Fri, Jan 12, 2018 at 09:47:44PM +, Gijs Kruitbosch wrote: Hello, jar: is an internal protocol that enables loading resources from inside a jar/zip file . Firefox is the only browser I'm a

Re: Intent to unship: remote jar: protocol pref

On 17/01/2018 00:01, Daniel Veditz wrote: On Fri, Jan 12, 2018 at 2:12 PM, Gijs Kruitbosch wrote: the most likely group of people to have enabled this (given 0 public reports on breakage so far, as far as I'm aware) are people on ESR or otherwise in enterprise environments ​Or those t

Re: Please stop using keypress event to handle non-printable keys

On 18/01/2018 16:56, Nicholas Alexander wrote: On Wed, Jan 17, 2018 at 6:34 PM, Masayuki Nakano mailto:masay...@d-toybox.com>> wrote: Please stop using keypress event for handling non-printable keys in new code when you write new code and new automated tests. Could someone who is know

Re: Please stop using keypress event to handle non-printable keys

On 18/01/2018 17:36, Mark Banner wrote: On 18/01/2018 16:56, Nicholas Alexander wrote: On Wed, Jan 17, 2018 at 6:34 PM, Masayuki Nakano mailto:masay...@d-toybox.com>> wrote: Hello, everyone. Please stop using keypress event for handling non-printable keys in new code when you writ

Re: PSA: HTML injection in chrome documents is now automatically sanitized

FWIW, if you're running into this with the usecase "I have a localized string that needs to have links (or other markup) in it" and were formerly using getFormattedString combined with innerHTML, we now have a utility method that can help a little bit. Rather than hand-rolling splitting the str

Re: PSA: HTML injection in chrome documents is now automatically sanitized

d it be very difficult to warn when something is sanitized and removed? I wasted a good deal of time trying to figure out why createContextualFragment wasn't working. On Fri, Feb 2, 2018 at 2:10 AM, Gijs Kruitbosch wrote: FWIW, if you're running into this with the usecase "I have a l

Re: Web-Feed subscription improvements

On 13/03/2018 15:26, gdk...@gmail.com wrote: Hello dear Firefox development community! As a fond user of the "subscribe to this page" button I sadly acknowledge to see the deprecation of navigator.registerContentHandler(). I'm not here to grouse about it, but rather inquire about any plans to

Re: Web-Feed subscription improvements

On 14/03/2018 14:16, Boris Zbarsky wrote: On 3/14/18 7:03 AM, Gijs Kruitbosch wrote: Unfortunately, our web feed implementation is pretty unused. Not least because it's not discoverable, ever since we removed the "there is a feed link on this page" icon, right? The toolb

Re: Web-Feed subscription improvements

On 14/03/2018 14:28, gdk...@gmail.com wrote: On Wednesday, March 14, 2018 at 12:03:19 PM UTC+1, Gijs Kruitbosch wrote: Unfortunately, our web feed implementation is pretty unused. This, tied together with approximately 750-odd bugs would be enough reason for me to drop the component all

Re: Intent to implement and ship: ping, rel, referrerPolicy, relList, hreflang, type and text properties on SVG elements

On 10/04/2018 03:07, Cameron McCormack wrote: On Tue, Apr 10, 2018, at 11:58 AM, Jeff Gilbert wrote: Do we have a heuristic for when to /not/ include something from HTML in SVG? If it doesn't make two features which already exist in both HTML and SVG more consistent, then I wouldn't include i

Re: Intent to implement and ship: ping, rel, referrerPolicy, relList, hreflang, type and text properties on SVG elements

On 09/04/2018 22:11, longs...@gmail.com wrote: Summary: HTML anchor elements have ping, rel, referrerPolicy, relList, hreflang, type and text properties. SVG anchor elements should support these properties too according to the SVG 2 specification and https://github.com/w3c/svgwg/issues/315. B

Re: Intent to implement and ship: ping, rel, referrerPolicy, relList, hreflang, type and text properties on SVG elements

On 10/04/2018 09:03, Gijs Kruitbosch wrote: On 09/04/2018 22:11, longs...@gmail.com wrote: Summary: HTML anchor elements have ping, rel, referrerPolicy, relList, hreflang, type and text properties. SVG anchor elements should support these properties too according to the SVG 2 specification and

Re: Intent to implement and ship: ping, rel, referrerPolicy, relList, hreflang, type and text properties on SVG elements

On 12/04/2018 00:00, da...@openweb.io wrote: On Tuesday, 10 April 2018 00:57:43 UTC-7, Gijs Kruitbosch wrote: On 10/04/2018 03:07, Cameron McCormack wrote: On Tue, Apr 10, 2018, at 11:58 AM, Jeff Gilbert wrote: Do we have a heuristic for when to /not/ include something from HTML in SVG? If

Re: XPT files shouldn't be added to package-manifest.in any more

Err, so it seems a side-effect of this (which wasn't very obvious to me when this was posted) is that it's now no longer possible to change a .idl file for a JS component in an artifact build and have it "work". Specifically, I ran into this when changing the return type of an extant idl metho

Re: Using WebIDL objects in XPIDL

Dumb question because I don't do this very often - sorry! I am intending to async-ify a sync JS-implemented idl-defined API (which currently returns an unsigned long), that has a few C++ consumers. I was thinking the simplest solution would be a separate method definition in the idl that took

Re: Is super-review still a thing?

On 20/04/2018 22:23, Kris Maglione wrote: I can't remember the last time I saw a super-review request, but it's still documented as a policy[1]. Is it still a thing? Do we want it to still be a thing? Not in the way it used to be. See https://groups.google.com/forum/#!topic/mozilla.governance

Re: Intent to move Activity Stream into its own process

Hey, This sounds really interesting. However, wouldn't this mean that we will do a process switch for the tab's browser whenever we load a URL in the same tab that has AS in it? Or would you still intend to run the actual AS new tab page in a "normal" tab process? If it *would* mean a proces

Re: I think XUL overlays should also ignore query strings.

On 16/08/2015 19:56, Neil wrote: Can we revisit this in 2015 to see if the original reason still holds? Well, we want to get rid of XUL. I'm not sure it makes much sense to revisit any of its design decisions at this point. Then why don't you object to bug 1034999? Because it solved a concr

Re: I think XUL overlays should also ignore query strings.

As others have said, XUL is going away. It is not going away tomorrow. We should be careful about if and how we invest here, so usecases are important. On 15/08/2015 20:48, Philip Chee wrote: Use case 1: chrome://foo/content/bar.xul?a=b&c=d This could be written as chrome://foo/content/bar

Re: |hg bzexport| and Bugzilla two-factor authentication

On Windows I still get "No module named Cookie!" after using ./mach mercurial-setup to update vcs-tools. ~ Gijs On 15/09/2015 22:52, Jeff Walden wrote: The Mercurial extensions to interact with Bugzilla -- bzexport and the like -- have been updated to handle 2fa details. No need to add API k

Re: |hg bzexport| and Bugzilla two-factor authentication

This includes TortoiseHg. Things have or will break unless running MozillaBuild 2.0. Please file a Developer Services product bug with the command output with --traceback added to the args so we can track failing more gracefully. On Sep 16, 2015, at 05:02, Gijs Kruitbosch wrote: On Windows I s

Re: What is the Mac bundle id of Firefox?

The source code says: https://dxr.mozilla.org/mozilla-central/search?q=MOZ_APP_DISPLAYNAME+path%3Abranding&redirect=true&case=true&limit=63&offset=0 So for the purposes of OS X, I believe the current list is: Firefox Nightly FirefoxDeveloperEdition B2G (I *think* there is a way to build b2g st

Re: NPAPI plugin use case: native chipcard reader

Are you effectively saying that you use crypto for signing financial transactions, and the PIN is used for authenticating the user but not involved in the actual signature/crypto algorithm? Therefore, if a user finds a way to invoke the same crypto without providing the PIN, they can effect fin

Re: NPAPI plugin use case: native chipcard reader

On 12/10/2015 12:34, Eric Rescorla wrote: On Mon, Oct 12, 2015 at 4:22 AM, Gijs Kruitbosch wrote: Are you effectively saying that you use crypto for signing financial transactions, and the PIN is used for authenticating the user but not involved in the actual signature/crypto algorithm

Improving quality on Nightly and Aurora

From the earlier thread about aurora uplifts on firefox-dev (I'm crossposting to m.d.platform, please follow-up on fx-dev because that's where the original thread was.): On 22/11/2015 15:41, L. David Baron wrote: Is a significant part of the instability on aurora related to things that land on

Re: Dan Stillman's concerns about Extension Signing

On 26/11/2015 16:07, Thomas Zimmermann wrote: Hi, I haven't followed the overall discussion closely, but I'm very concerned about this change and that we're driving away extension developers. I hope that some of the relevant people read this thread, as I'd like to propose a different strategy fo

Re: Dan Stillman's concerns about Extension Signing

On 27/11/2015 12:16, Gervase Markham wrote: On 26/11/15 17:13, Mike Hoye wrote: Stillman wrote some new code and put it through a process meant to catch problems in old code, and it passed. That's unfortunate, but does it really surprise anyone that security is an evolving process? That it might

Re: Dan Stillman's concerns about Extension Signing

On 27/11/2015 13:41, Frederik Braun wrote: On 27.11.2015 13:16, Gervase Markham wrote: On 26/11/15 17:13, Mike Hoye wrote: Stillman wrote some new code and put it through a process meant to catch problems in old code, and it passed. That's unfortunate, but does it really surprise anyone that se

Re: Dan Stillman's concerns about Extension Signing

On 27/11/2015 23:46, dstill...@zotero.org wrote: The issue here is that this new system -- specifically, an automated scanner sending extensions to manual review -- has been defended by Jorge's saying, from March when I first brought this up until yesterday on the hardening bug [1], that he belie

Re: ESLint is now available in the entire tree

Yes. See bug 1150859 and friends. ~ Gijs On 30/11/2015 09:05, Tim Guan-tin Chien wrote: The Gecko JavaScript is also littered with #ifdef and # is really not a token for comment in JS... is there any plan to migrate that away since there is ESLint present? On Sun, Nov 29, 2015 at 10:37 PM, Viv

Re: Dan Stillman's concerns about Extension Signing

On 29/11/2015 02:56, Dan Stillman wrote: You can block known malware signatures with the scanner if you think that's a good use of time. But that doesn't require blocking valid APIs and patterns that have legitimate uses. That's what we're discussing here. AV software doesn't result in long delay

Re: Dan Stillman's concerns about Extension Signing

ats On Sat, Nov 28, 2015 at 10:35 AM, Eric Rescorla wrote: On Sat, Nov 28, 2015 at 2:06 AM, Gijs Kruitbosch wrote: On 27/11/2015 23:46, dstill...@zotero.org wrote: The issue here is that this new system -- specifically, an automated scanner sending extensions to manual review -- has been def

Re: Dan Stillman's concerns about Extension Signing

On 28/11/2015 19:42, Dan Stillman wrote: On 11/28/15 5:06 AM, Gijs Kruitbosch wrote: On 27/11/2015 23:46, dstill...@zotero.org wrote: The issue here is that this new system -- specifically, an automated scanner sending extensions to manual review -- has been defended by Jorge's saying,

Re: Using the Taskcluster index to find builds

FWIW, I used this for "diditland" - http://www.gijsk.com/blog/2015/11/did-it-land/ and https://gijsk.github.io/diditland/ . It was a significant improvement over scraping archive.mozilla.org's HTML pages for a month, finding the right folder for a nightly, and then scraping that for the right j

Re: Intent to ship: referrerpolicy attribute

On 02/12/2015 11:16, Franziskus Kiefer wrote: > they still use |referrer| as attribute name instead of > |referrerpolicy|. I randomly ran into this today while looking at something completely different... Where was the name changed? There is browser frontend code that still uses the old name:

Re: Too many oranges!

On 22/12/2015 17:40, James Graham wrote: On 22/12/15 17:22, Andrew Halberstadt wrote: FWIW a summary of top orangefactor[1] oranges are posted regularly to dev.tree-alerts. Configuring it to also post to dev.platform is certainly possible if that's what people want. Though I have a feeling that

Re: nsIProtocolHandler in Electrolysis?

On 04/01/2016 20:03, Cameron Kaiser wrote: What's different about nsIProtocolHandler in e10s? OverbiteFF works in 45 aurora without e10s on, but fails to recognize the protocol it defines with e10s enabled. There's no explanation of this in the browser console and seemingly no error. Do I have to

Re: Dominator tree memory analysis now in Nightly

On 14/01/2016 23:01, Nick Fitzgerald wrote: On Thu, Jan 14, 2016 at 2:49 PM, Jared Wein > wrote: Also, what is the plan for making tools like the Memory view appear in a default install? In other words, without having to go to the Settings. I worry that users

Re: Just Autoland It

On 22/01/2016 20:52, Gregory Szorc wrote: I would say that pushing cherry-picked commits for review that depend on other commits not in the commit's ancestry is just wrong. If you pushed this to Try, it would fail. So why are you pushing a "bad" commit/tree for review? If your commits depend on s

Re: Touch events enabled on Windows desktop (nightly only)

On 01/02/2016 21:46, Justin Dolske wrote: On 2/1/16 9:51 AM, Kartikaya Gupta wrote: Oh, I should also mention that currently many (if not all) Windows touchscreen devices have e10s disabled by default, because a touchscreen seems to trigger the accessibility code which disables e10s. And if e10s

Re: How to remove #ifdef XP_MACOSX in xul files?

On 02/02/2016 12:36, Philip Chee wrote: On 01/02/2016 18:17, Philipp Kewisch wrote: You can use runtime checks for the OS, e.g. using Services.appinfo Philipp Dude, he's talking about XUL, not JS. Please stop giving useless advice. It's perfectly possible to runtime-change the DOM tree as n

Re: Bug Program Next Steps

On 02/02/2016 18:04, Anne van Kesteren wrote: On Tue, Feb 2, 2016 at 6:50 PM, Boris Zbarsky wrote: But it gets worse. The typical lifetime of a bug goes like this. It gets reported to somewhere like Firefox:Untriaged (I think we have a guided form that automatically dumps things there or somet

Re: To bump mochitest's timeout from 45 seconds to 90 seconds

I concur with Ryan here, and I'd add that IME 90% if not more of these timeouts (where they are really timeouts because the test is long, rather than just brokenness in the test that leaves it hanging until the timeout) happen on debug/asan builds, where "perf regressions" isn't really a meanin

Re: rr chaos mode update

On 15/02/2016 05:16, Robert O'Callahan wrote: At this point the limiting factor is getting developers to actually debug and fix recorded test failures. Well, and platform (OS) support for rr, right? And rr also doesn't effectively support debugging frontend JS tests, AIUI? Have either of thos

Re: A lot of problems with Firefox Sync...

On 18/03/2016 11:47, Tobias B. Besemer wrote: If I use my main profile in Aurora, it updates FF immediately to the Nightly Version because the update channel is saved in the profile! Is this really necessary/right this way? I mean: Why not save the update channel in the FF installation (folder

Re: A lot of problems with Firefox Sync...

On 24/03/2016 00:08, Tobias B. Besemer wrote: But what is this: user_pref("extensions.checkCompatibility.37.0a", true); user_pref("extensions.checkCompatibility.nightly", true); Preferences relating to how/whether the add-on manager checks for compatibility with a particular release. Not sure

Re: Triage Plan for Firefox Components

On 01/04/2016 16:16, Andrew McCreight wrote: On Thu, Mar 31, 2016 at 4:01 PM, Chris Peterson wrote: Anthony's Media Playback team has been using a simple and effective triage system without special tags. All open bugs in the Audio/Video Playback component are in one of four states at all tim

Re: Firefox Hello new data collection

Hi, It's very concerning to me that you have not answered the obvious question: what domains are collected? All of the ones visited while the browser is running? The ones visited while Hello is open? The ones visited while shared through Hello? What about the ones that someone shared with you

Re: Firefox Hello new data collection

On 04/04/2016 10:01, Romain Testard wrote: Implementation bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1211542 Because this bug does not link to it: where is the bug for the privacy review of this collection? Judging by the people you CC'd I assume you got one, but where is it? ~ Gijs

Re: Firefox Hello new data collection

On 04/04/2016 11:01, Romain Testard wrote: The privacy review bug is https://bugzilla.mozilla.org/show_bug.cgi?id=1261467. More details added below. See response at the bottom. On Mon, Apr 4, 2016 at 11:23 AM, Gijs Kruitbosch wrote: On 04/04/2016 10:01, Romain Testard wrote: We

Re: [Bug 1224726] High memory consumption when opening and searching a large Javascript file in debugger.

On 12/04/2016 01:16, Justin Dolske wrote: Looks like Gijs replied in https://bugzilla.mozilla.org/show_bug.cgi?id=1255526#c21, and the contributor's last comment for the day was acknowledgment that he'd stop. Yes. I got another email personally, from which it seems that they thought the commen

Re: PSA: Cancel your old Try pushes

On 15/04/2016 20:46, Mike Connor wrote: For cases where a developer needs to run multiple runs at once, we can add an override in the trychooser syntax. I think that's a corner case It isn't when you do any kind of talos "need to fix / not regress perf" work. I agree with Jim that we should

Re: PSA: Cancel your old Try pushes

On 16/04/2016 01:24, Steve Fink wrote: Doesn't everyone keep a tab open to their try page? eg I have https://treeherder.mozilla.org/#/jobs?repo=try&author=sf...@mozilla.com open all the time. No. Treeherder is too resource-intensive to keep open for long periods of time. I tend to see multi-se

Re: PSA: Cancel your old Try pushes

On 17/04/2016 22:54, Mike Conley wrote: Generally speaking, Firefox's stability has not been good for me for 2-3 months. I'd like to file a bug, > but I've already used up my quota of unactionable bugs, and if I dug into all of my idiosyncratic issues I'd never get any work done. I seem to do t

Re: Dump frame tree in real time

On 19/04/2016 14:41, Jip de Beer wrote: I followed your steps exactly and uses this code to add a canvas on a page with jQuery: var myCanvas = document.createElement('canvas'); var width = $(document).width() myCanvas.width = width; var height = $(document).height() myC

Re: PSA: Cancel your old Try pushes

On 26/04/2016 14:01, James Graham wrote: Based on a conversation yesterday, it seems that the features of |mach try| are not well known. In particular it allows running only a subset of tests in cases that you are doing an experimental push that you expect to affect mainly one area of the code. F

Re: Intent to ship: Speech synthesis API

There are still quite a number of bugs on file for this feature: https://bugzilla.mozilla.org/buglist.cgi?quicksearch=speech%20synthesis&list_id=12990930 one of which seems to suggest we want to switch to a different system API for synthesis on Windows. Are we sure none of these other bugs need

Re: What is "Process Type = content" in "mozilla crash reports"?

On 19/05/2016 16:35, Tobias B. Besemer wrote: Due to the upcoming requirement of SSE2 to run Firefox that is discussed here: https://groups.google.com/forum/#!topic/mozilla.dev.platform/v0QAe2olnH0 ...I had a look on... Bug 1271755 - [meta] Require SSE2 to run Firefox https://bugzilla.mozilla.or

Re: FF49a1: Page load of jumping points doesn't work like it should in Wikipedia

On 20/05/2016 16:11, Tobias B. Besemer wrote: Plz open e.g. this URL: https://en.wikipedia.org/wiki/Microsoft_Windows#Alternative_implementations FF49a1 loads the page, jumps to "Alternative implementations", stays there for 1-2 sec and then go ~1 screen-high (page) down. Can someone very this

Re: Readable Bug Statuses in Bugzilla

On 24/05/2016 16:54, Ted Mielczarek wrote: On Tue, May 24, 2016, at 11:45 AM, Emma Humphries wrote: Last week the bugzilla.mozilla.org team had a work week in the San Francisco office. They were finishing the work on the modal edit view in Bugzilla, and joined them to land another new feature: R

Re: Common crashes due to MOZ_CRASH and MOZ_RELEASE_ASSERT

On 31/05/2016 09:40, Nicholas Nethercote wrote: On Tue, May 31, 2016 at 5:06 PM, Chris Peterson wrote: #2 is unannotated MOZ_CRASH() calls, i.e. there is no string argument given. These are mostly OOMs, though there are a few others in there. These ones should be annotated so they show up sepa

Re: Common crashes due to MOZ_CRASH and MOZ_RELEASE_ASSERT

On 31/05/2016 07:22, Nicholas Nethercote wrote: 10 MOZ_CRASH(Using observer service off the main thread!) 223 0.02 % This looked interesting to me, but it seems almost all of them are caused by IBM Rapport which hooks into the process and calls the observer service off-main-thread. If so

Re: Dropping support for VS2013

Who is responsible for updating our build documentation about this? It seems the docs still don't believe we can even build for sure on VS2015 (though it's been the recommended compiler for a while now), and list a number of SDKs that I'm not convinced you'd actually need to manually install if

  1   2   3   >