Github user maskit commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/642#discussion_r68702215
--- Diff: proxy/InkAPI.cc ---
@@ -6249,12 +6249,12 @@ TSVConnFdCreate(int fd)
vc->action_ = &a;
vc->id = net_next_connect
Github user maskit commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/642#discussion_r68701731
--- Diff: iocore/net/UnixNetAccept.cc ---
@@ -277,14 +277,12 @@ NetAccept::do_blocking_accept(EThread *t)
vc->options.packet_mark = packet_m
Github user maskit closed the pull request at:
https://github.com/apache/trafficserver/pull/706
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user maskit commented on the issue:
https://github.com/apache/trafficserver/pull/706
ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user maskit closed the pull request at:
https://github.com/apache/trafficserver/pull/702
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user maskit opened a pull request:
https://github.com/apache/trafficserver/pull/702
TS-4517: Build tests during "make check" phase
https://issues.apache.org/jira/browse/TS-4517
You can merge this pull request into a Git repository by running:
$ git
Github user maskit closed the pull request at:
https://github.com/apache/trafficserver/pull/677
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user maskit commented on the pull request:
https://github.com/apache/trafficserver/pull/682
The change seems reasonable.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user maskit commented on the pull request:
https://github.com/apache/trafficserver/pull/678
@PSUdaemon I didn't see any conflicts but I hope this helps you backport
the commits.
---
If your project is set up for it, you can reply to this email and have your
reply appe
GitHub user maskit opened a pull request:
https://github.com/apache/trafficserver/pull/678
TS-4428: Update Japanese documentations
Cherry pick
95355d8434deed3e8a222effa86eb7c3c11082bc..6c6b6bc50f80959484e96dda8aa87f28bbf6e086
from master for 6.2.x
You can merge this pull request
Github user maskit commented on the pull request:
https://github.com/apache/trafficserver/pull/666#issuecomment-222639026
Looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user maskit closed the pull request at:
https://github.com/apache/trafficserver/pull/676
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user maskit opened a pull request:
https://github.com/apache/trafficserver/pull/677
TS-4189: Add tests for HPACK
https://issues.apache.org/jira/browse/TS-4189
The test cases come from:
https://github.com/http2jp/hpack-test-case
https://github.com/http2
Github user maskit commented on the pull request:
https://github.com/apache/trafficserver/pull/666#issuecomment-221816974
Some URLs are shorten. They should be unified?
e.g.
https://docs.trafficserver.apache.org/records.config#thread-variables
https
Github user maskit commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/666#discussion_r64710906
--- Diff: proxy/config/records.config.default.in ---
@@ -15,12 +15,11 @@ CONFIG proxy.config.ssl.number.threads INT -1
CONFIG
Github user maskit commented on the pull request:
https://github.com/apache/trafficserver/pull/661#issuecomment-221328309
Looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user maskit commented on the pull request:
https://github.com/apache/trafficserver/pull/654#issuecomment-221186963
Thank you for pointing out the issue. I found a fix for it on RTD's
repository.
https://github.com/rtfd/readthedocs.org/c
Github user maskit closed the pull request at:
https://github.com/apache/trafficserver/pull/655
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user maskit opened a pull request:
https://github.com/apache/trafficserver/pull/655
TS-4467: Fix assert conditions
https://issues.apache.org/jira/browse/TS-4467
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/maskit
Github user maskit commented on the pull request:
https://github.com/apache/trafficserver/pull/654#issuecomment-220767781
The template file could be considered as a derivative of this file. It's
licensed under MIT.
https://github.com/snide/sphinx_rtd_theme/blob/m
GitHub user maskit opened a pull request:
https://github.com/apache/trafficserver/pull/654
TS-4466: Add links to other versions of the documentation
https://issues.apache.org/jira/browse/TS-4466
 issue. Since tsqa has a
Github user maskit commented on the pull request:
https://github.com/apache/trafficserver/pull/551#issuecomment-208206647
@jpeach I added a parameter to ``http2_generate_h2_header_from_1_1()`` to
pass a ``HTTPHdr`` declared in ``send_headers_frame()`` instead of creating it
with
Github user maskit commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/551#discussion_r59147631
--- Diff: proxy/http2/HTTP2.cc ---
@@ -498,25 +498,23 @@ http2_convert_header_from_2_to_1_1(HTTPHdr *headers)
return PARSE_DONE
Github user maskit commented on the pull request:
https://github.com/apache/trafficserver/pull/551#issuecomment-206137778
I just remembered tsqa. I'll try to write a test for this with tsqa.
---
If your project is set up for it, you can reply to this email and have your
reply a
Github user maskit commented on the pull request:
https://github.com/apache/trafficserver/pull/551#issuecomment-206128731
Though I tested it with nghttp and httpbin as an origin server, I think we
can test with nghttp/curl and nc. But if you mean automated tests, I have no
idea
GitHub user maskit opened a pull request:
https://github.com/apache/trafficserver/pull/551
TS-4321: Keep response headers in FetchSM as they are
https://issues.apache.org/jira/browse/TS-4321
You can merge this pull request into a Git repository by running:
$ git pull https
Github user maskit commented on the pull request:
https://github.com/apache/trafficserver/pull/537#issuecomment-206105027
Cool! +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user maskit commented on the pull request:
https://github.com/apache/trafficserver/pull/549#issuecomment-205336202
I couldn't have a time to dig into the issue but it seems the real problem
here is that ``has_body()`` has a side effect. It initializes
``resp_content_l
Github user maskit commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/542#discussion_r58294627
--- Diff: proxy/hdrs/test_mime.cc ---
@@ -0,0 +1,80 @@
+/** @file
+
+ A brief file description
+
+ @section license License
Github user maskit commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/542#discussion_r58294561
--- Diff: proxy/hdrs/MIME.cc ---
@@ -473,7 +473,8 @@ mime_hdr_set_accelerator_slotnum(MIMEHdrImpl *mh,
int32_t slot_id, uint32_t slot
inline void
Github user maskit commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/542#discussion_r58233222
--- Diff: proxy/hdrs/MIME.cc ---
@@ -473,7 +473,8 @@ mime_hdr_set_accelerator_slotnum(MIMEHdrImpl *mh,
int32_t slot_id, uint32_t slot
inline void
Github user maskit commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/542#discussion_r58230651
--- Diff: proxy/hdrs/MIME.cc ---
@@ -473,7 +473,8 @@ mime_hdr_set_accelerator_slotnum(MIMEHdrImpl *mh,
int32_t slot_id, uint32_t slot
inline void
Github user maskit commented on the pull request:
https://github.com/apache/trafficserver/pull/542#issuecomment-204436318
I've added contains() and tests for this.
@jpeach Can you review them?
---
If your project is set up for it, you can reply to this email and have your
Github user maskit commented on the pull request:
https://github.com/apache/trafficserver/pull/537#issuecomment-203783017
Looks good except the comparator part.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user maskit commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/537#discussion_r58005122
--- Diff: lib/ts/PriorityQueue.h ---
@@ -0,0 +1,207 @@
+/** @file
+
+ Priority Queue Implementation using Min Heap.
+
+ @section
Github user maskit commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/537#discussion_r58004342
--- Diff: lib/ts/PriorityQueue.h ---
@@ -0,0 +1,207 @@
+/** @file
+
+ Priority Queue Implementation using Min Heap.
+
+ @section
Github user maskit commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/537#discussion_r57996567
--- Diff: lib/ts/PriorityQueue.h ---
@@ -0,0 +1,191 @@
+/** @file
+
+ Priority Queue Implimentation using Min Heap.
+
+ @section
Github user maskit commented on the pull request:
https://github.com/apache/trafficserver/pull/542#issuecomment-203732053
@jpeach
I added some codes for debug and got these output. The rare case is
happening.
(I built with --enable-debug and ASAN using clang on OSX
Github user maskit commented on the pull request:
https://github.com/apache/trafficserver/pull/537#issuecomment-203415277
There should be a test case for decreasing weights.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user maskit commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/537#discussion_r57880884
--- Diff: lib/ts/PriorityQueue.h ---
@@ -0,0 +1,191 @@
+/** @file
+
+ Priority Queue Implimentation using Min Heap.
+
+ @section
Github user maskit commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/537#discussion_r57860698
--- Diff: lib/ts/PriorityQueue.h ---
@@ -0,0 +1,191 @@
+/** @file
+
+ Priority Queue Implimentation using Min Heap.
--- End diff
GitHub user maskit opened a pull request:
https://github.com/apache/trafficserver/pull/542
TS-4313: Fix improper type conversion
https://issues.apache.org/jira/browse/TS-4313
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/maskit
Github user maskit commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/460#discussion_r57849578
--- Diff: proxy/http2/HPACK.h ---
@@ -90,31 +97,29 @@ class MIMEFieldWrapper
return _field;
}
+ bool
+ is_sensitive
Github user maskit commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/460#discussion_r57056410
--- Diff: proxy/http2/HPACK.cc ---
@@ -828,9 +828,111 @@ update_dynamic_table_size(const uint8_t *buf_start,
const uint8_t *buf_end, Http
if
Github user maskit commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/460#discussion_r56920295
--- Diff: proxy/http2/HPACK.cc ---
@@ -828,9 +828,111 @@ update_dynamic_table_size(const uint8_t *buf_start,
const uint8_t *buf_end, Http
if
Github user maskit commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/460#discussion_r53552779
--- Diff: proxy/http2/Http2ConnectionState.cc ---
@@ -992,43 +998,50 @@ Http2ConnectionState::send_headers_frame(FetchSM
*fetch_sm
Github user maskit commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/460#discussion_r53549624
--- Diff: proxy/http2/Http2ConnectionState.cc ---
@@ -992,43 +998,50 @@ Http2ConnectionState::send_headers_frame(FetchSM
*fetch_sm
Github user maskit commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/460#discussion_r53446831
--- Diff: proxy/http2/HTTP2.cc ---
@@ -484,246 +498,162 @@ convert_from_2_to_1_1_header(HTTPHdr *headers)
return PARSE_DONE
Github user maskit commented on the pull request:
https://github.com/apache/trafficserver/pull/460#issuecomment-185757269
Also, this fixes a bug in the HPACK decoding process. Current decoding
process stops if there is a HTTP2 violation (not HPACK violation) but it should
not. As I
Github user maskit commented on the pull request:
https://github.com/apache/trafficserver/pull/460#issuecomment-185754698
@jpeach , I changed some function names as per your comments. But some are
not exactly the same as you suggested because I think the names should
correspond to
GitHub user maskit opened a pull request:
https://github.com/apache/trafficserver/pull/460
TS-4092: Decouple HPACK from HTTP/2
I tried to decouple HPACK from HTTP2, and it partially succeeded. It's very
difficult to completely decouple HPACK unless we use MIMEField
Github user maskit commented on the pull request:
https://github.com/apache/trafficserver/pull/427#issuecomment-172394940
Looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user maskit opened a pull request:
https://github.com/apache/trafficserver/pull/426
TS-4139: Send GOAWAY if it failed to change stream state
This is a fix for CID 1347871: Unchecked return value
You can merge this pull request into a Git repository by running:
$ git
Github user maskit commented on the pull request:
https://github.com/apache/trafficserver/pull/389#issuecomment-170236549
rebased to follow the changes in master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user maskit commented on the pull request:
https://github.com/apache/trafficserver/pull/391#issuecomment-170210430
The fixes look ok to me.
@masaori335 You mean TS-4092? I'm going to refine the names and interfaces.
---
If your project is set up for it, you can
Github user maskit commented on the pull request:
https://github.com/apache/trafficserver/pull/406#issuecomment-169277091
What is the reason why we need new project? Will we need new projects for
7.x?
---
If your project is set up for it, you can reply to this email and have your
Github user maskit commented on the pull request:
https://github.com/apache/trafficserver/pull/391#issuecomment-168053932
Http2DynamicTable class is getting messy. To clarify the responsibility of
Http2DynamicTable and to make the codes maintainable, it would be better to
cleanup at
Github user maskit commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/391#discussion_r48617340
--- Diff: proxy/http2/HPACK.cc ---
@@ -263,12 +263,80 @@ Http2DynamicTable::add_header_field(const MIMEField
*field
Github user maskit commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/391#discussion_r48614287
--- Diff: proxy/http2/HPACK.cc ---
@@ -263,12 +263,80 @@ Http2DynamicTable::add_header_field(const MIMEField
*field
Github user maskit commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/391#discussion_r48613605
--- Diff: proxy/http2/HPACK.cc ---
@@ -263,12 +263,80 @@ Http2DynamicTable::add_header_field(const MIMEField
*field
Github user maskit commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/391#discussion_r48613347
--- Diff: proxy/http2/HPACK.cc ---
@@ -263,12 +263,80 @@ Http2DynamicTable::add_header_field(const MIMEField
*field
Github user maskit commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/391#discussion_r48612923
--- Diff: proxy/http2/HPACK.cc ---
@@ -263,12 +263,80 @@ Http2DynamicTable::add_header_field(const MIMEField
*field
Github user maskit commented on the pull request:
https://github.com/apache/trafficserver/pull/395#issuecomment-166931826
Fixed the ASAN error.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
GitHub user maskit opened a pull request:
https://github.com/apache/trafficserver/pull/395
TS-4097: Encode empty string properly with HPACK
https://issues.apache.org/jira/browse/TS-4097
You can merge this pull request into a Git repository by running:
$ git pull https
Github user maskit commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/389#discussion_r48120169
--- Diff: proxy/http2/HTTP2.cc ---
@@ -665,11 +666,19 @@ http2_decode_header_blocks(HTTPHdr *hdr, const
uint8_t *buf_start, const uint8_t
GitHub user maskit opened a pull request:
https://github.com/apache/trafficserver/pull/389
TS-3967: Set stream state to close after a RST_STEAM has been sent
https://issues.apache.org/jira/browse/TS-3967
The original patches are on the JIRA ticket. I updated the patches to
Github user maskit commented on the pull request:
https://github.com/apache/trafficserver/pull/379#issuecomment-165672930
I tried `AS_ESCAPE` but it doesn't work.
Because The `id` command has not been executed yet when `AS_ESCAPE` has
been processed.
---
If your project i
GitHub user maskit opened a pull request:
https://github.com/apache/trafficserver/pull/379
TS-4074: Escape backslashes in user/group/machine name
https://issues.apache.org/jira/browse/TS-4074
The patch just replace one backslash with two backslashes.
Is there more
GitHub user maskit opened a pull request:
https://github.com/apache/trafficserver/pull/372
TS-4063: Add regression tests for HPACK Huffman
https://issues.apache.org/jira/browse/TS-4063
You can merge this pull request into a Git repository by running:
$ git pull https
Github user maskit commented on the pull request:
https://github.com/apache/trafficserver/pull/362#issuecomment-162387824
I fixed the compile error, and squashed the commits.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user maskit commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/362#discussion_r46780362
--- Diff: proxy/http2/HPACK.cc ---
@@ -332,18 +332,41 @@ int64_t
encode_string(uint8_t *buf_start, const uint8_t *buf_end, const char
*value
GitHub user maskit opened a pull request:
https://github.com/apache/trafficserver/pull/362
TS-4018: Use HPACK huffman encoding always
https://issues.apache.org/jira/browse/TS-4018
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user maskit commented on the pull request:
https://github.com/apache/trafficserver/pull/334#issuecomment-156279652
Fixed. Should I squash the commits?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user maskit opened a pull request:
https://github.com/apache/trafficserver/pull/334
TS-4019: Validate header names and values before passing to FetchSM
https://issues.apache.org/jira/browse/TS-4019
You can merge this pull request into a Git repository by running:
$ git
GitHub user maskit opened a pull request:
https://github.com/apache/trafficserver/pull/333
TS-3847: Check if table size updates are at the beginning of the block
https://issues.apache.org/jira/browse/TS-3847
You can merge this pull request into a Git repository by running
GitHub user maskit opened a pull request:
https://github.com/apache/trafficserver/pull/332
TS-3843: Remove unnecessary null check
https://issues.apache.org/jira/browse/TS-3843
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user maskit commented on the pull request:
https://github.com/apache/trafficserver/pull/295#issuecomment-141335350
@masaori335 LGTM.
We should restore the check only about flags. Other part in the commit
looks reasonable.
---
If your project is set up for it, you can
GitHub user maskit opened a pull request:
https://github.com/apache/trafficserver/pull/278
TS-3846: Initialize priority with default values
The range of weight is between 1 and 256, and the the default weight is 16.
Therefore, a value in the code (or transferred) is one less
Github user maskit commented on the pull request:
https://github.com/apache/trafficserver/pull/263#issuecomment-129261728
It's in 7d63eae284d3bbc705d897639957b618fa5ce1b4
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user maskit closed the pull request at:
https://github.com/apache/trafficserver/pull/263
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user maskit commented on the pull request:
https://github.com/apache/trafficserver/pull/267#issuecomment-127662136
Rebased from current master to resolve conflict.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user maskit opened a pull request:
https://github.com/apache/trafficserver/pull/267
TS-3497: Define Http2Error to classify errors
HTTP/2 has two classes of error, connection error and stream error, defined
on the section 5.4.
Current implementation doesn't treat the
GitHub user maskit opened a pull request:
https://github.com/apache/trafficserver/pull/263
TS-3799: Fix handling of padding in DATA frames
Traffic Server doesn't handle padded DATA frames correctly, and returns
GOAWAY frame with PROTOCOL_ERROR.
https://issues.apache.org
GitHub user maskit opened a pull request:
https://github.com/apache/trafficserver/pull/81
Docs: fix literal blocks and broken links
I fixed literal blocks in docs such like below:
http://docs.trafficserver.apache.org/en/latest/sdk/http-hooks-and-transactions/http
Github user maskit closed the pull request at:
https://github.com/apache/trafficserver/pull/37
Github user maskit closed the pull request at:
https://github.com/apache/trafficserver/pull/36
GitHub user maskit opened a pull request:
https://github.com/apache/trafficserver/pull/37
DOC: fix broken links
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/maskit/trafficserver fixlinks
Alternatively you can review and
GitHub user maskit opened a pull request:
https://github.com/apache/trafficserver/pull/36
DOC: fix typos
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/maskit/trafficserver fixtypo
Alternatively you can review and apply these
Github user maskit closed the pull request at:
https://github.com/apache/trafficserver/pull/30
GitHub user maskit opened a pull request:
https://github.com/apache/trafficserver/pull/30
Doc: fix broken links and syntax errors
This fixes broken links and some syntax errors.
I didn't change the links to old API documents because many of those are
not yet documented in
Github user maskit closed the pull request at:
https://github.com/apache/trafficserver/pull/26
GitHub user maskit opened a pull request:
https://github.com/apache/trafficserver/pull/26
DOC: fix some syntax errors in documents
This fixes some of reST syntax errors in the documents.
You can merge this pull request into a Git repository by running:
$ git pull https
Github user maskit closed the pull request at:
https://github.com/apache/trafficserver/pull/13
1 - 100 of 101 matches
Mail list logo