Github user maskit commented on the pull request:

    https://github.com/apache/trafficserver/pull/570#issuecomment-210199731
  
    Reverting TS-4321 sounds reasonable if we can modify 
``stream->response_header`` without any side effects.
    
    The response headers in FetchSM must not be modified because FetchSM uses 
them internally to check if the response body is chunked. It seems 
``Http2Stream::response_initialize_data_handling`` does the similar thing.
    
    So all checks depend on response headers must be done before we modify 
headers here if we don't make the copy. If we cannot assure that, we still need 
the fix for TS-4321.
    
    Moreover, generating H2 headers from headers in Http2Stream sounds odd.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to