Github user maskit commented on a diff in the pull request:

    https://github.com/apache/trafficserver/pull/389#discussion_r48120169
  
    --- Diff: proxy/http2/HTTP2.cc ---
    @@ -665,11 +666,19 @@ http2_decode_header_blocks(HTTPHdr *hdr, const 
uint8_t *buf_start, const uint8_t
           }
         }
     
    +    // turn on that we have a trailer header
    +    char trailer_name[] = "trailer";
    +    if (name_len == (sizeof(trailer_name) - 1) && strncmp(name, 
trailer_name, sizeof(trailer_name) - 1) == 0) {
    +      trailing_header = true;
    --- End diff --
    
    `trailing_header` is for caller. It suggests existence of trailing header 
to outside of this function.
    `is_trailing_header` is for callee. It suggests that this block is trailing 
header to skip the pseudo header checks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to