Github user maskit commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/570#discussion_r59965426
--- Diff: proxy/ProxyClientSession.h ---
@@ -101,6 +106,75 @@ class ProxyClientSession : public VConnection
void do_api_callout(TSHttpHookID id);
static int64_t next_connection_id();
+ virtual int get_transact_count() const = 0;
+
+ // Override if your session protocol allows this
+ virtual bool
+ is_transparent_passthrough_allowed()
+ {
+ return false;
+ }
+
+ // Override if your session protocol cares
+ virtual void
+ set_half_close_flag(bool flag)
+ {
+ }
+ virtual bool
+ get_half_close_flag()
--- End diff --
This one should be const?
```
In file included from HttpSessionAccept.cc:26:
./Http1ClientSession.h:83:3: error:
'Http1ClientSession::get_half_close_flag' hides overloaded virtual function
[-Werror,-Woverloaded-virtual]
get_half_close_flag() const
^
../../proxy/ProxyClientSession.h:124:3: note: hidden overloaded virtual
function 'ProxyClientSession::get_half_close_flag' declared here: different
qualifiers (none vs const)
get_half_close_flag()
^
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
