Github user bgaff closed the pull request at:
https://github.com/apache/trafficserver/pull/245
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
I'd like to close the loop on this discussion. In general I believe there
is a consensus that perhaps ssl_multicert is not the place to deal with
ticket rotation and that if you're willing to have global session tickets
(meaning not tied to a specific domain) then the implementation that would
acco
GitHub user masaori335 opened a pull request:
https://github.com/apache/trafficserver/pull/276
TS-3752: Accept Large Header
Fix [TS-3752](https://issues.apache.org/jira/browse/TS-3752).
Approach: Collect all Header Block Fragments before decode with HPACK.
You can merge this pul
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/270#issuecomment-130127185
I should say, if there was a reasonable way to add functionality to
ip_allow.config via plugins, that would make a lot of sense. But, I don't think
there is.
---
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/270#issuecomment-130126864
That seems draconian to rule out these methods only because they are not in
the main HTTP RFCs. Since ATS is a general forward (and transparent) proxy, it
seems rea
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/270#issuecomment-130113092
I don't really see why ```ip_filter``` should not be able to deal with
webdav methods. It seems reasonable to me that you should be able to filter any
layered meth
Github user bgaff commented on the pull request:
https://github.com/apache/trafficserver/pull/270#issuecomment-130105002
I'm in agreement with @ushachar and @sudheerv on this one, I do not
believe webdav methods should land in the core.
---
If your project is set up for it, you can
Github user danobi commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36807553
--- Diff: iocore/net/test_certlookup.cc ---
@@ -206,7 +206,8 @@ SSLReleaseContext(SSL_CTX *ctx)
int
main(int argc, const char **argv)
{
Github user persiaAziz closed the pull request at:
https://github.com/apache/trafficserver/pull/259
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feat
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36800085
--- Diff: lib/ts/BaseLogFile.cc ---
@@ -0,0 +1,571 @@
+/** @file
+
+ Base class for log files implementation
+
+ @section
Github user sudheerv commented on the pull request:
https://github.com/apache/trafficserver/pull/270#issuecomment-130071743
@meeramn : I agree with the comments that this change seems like something
that can (and should?) be done in a plugin rather than in the core. It should
be fairl
Github user meeramn commented on the pull request:
https://github.com/apache/trafficserver/pull/270#issuecomment-130058487
ushachar: I made changes to support webdav methods in ip_allow.config. I
haven't implemented these methods - it just look for list of list of methods to
allow or
Github user danobi commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36794702
--- Diff: lib/ts/BaseLogFile.cc ---
@@ -0,0 +1,571 @@
+/** @file
+
+ Base class for log files implementation
+
+ @section license L
GitHub user shinrich opened a pull request:
https://github.com/apache/trafficserver/pull/275
TS-3797: Crashes due to cross-thread race conditions.
We have been testing a version of this in production on a few machines for
the past two weeks. We are expanding the testing to more mac
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36782875
--- Diff: lib/ts/BaseLogFile.cc ---
@@ -0,0 +1,571 @@
+/** @file
+
+ Base class for log files implementation
+
+ @section
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36781478
--- Diff: proxy/logging/LogFile.cc ---
@@ -754,115 +585,33 @@ LogFile::display(FILE *fd)
fprintf(fd, "Logfile: %s, %s\n", get_name(), (is
Github user danobi commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36781403
--- Diff: lib/ts/BaseLogFile.cc ---
@@ -0,0 +1,571 @@
+/** @file
+
+ Base class for log files implementation
+
+ @section license L
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36780749
--- Diff: cmd/traffic_crashlog/Makefile.am ---
@@ -20,6 +20,7 @@ bin_PROGRAMS = traffic_crashlog
AM_CPPFLAGS = \
$(iocore_include_di
Github user danobi commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36778052
--- Diff: lib/ts/BaseLogFile.cc ---
@@ -0,0 +1,571 @@
+/** @file
+
+ Base class for log files implementation
+
+ @section license L
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/274#issuecomment-129997435
jpeach;
I know this has been discussed quite a bit and I've always heard about
doing the rotation for `traffic.out` and `diags.log` (as in the ori
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36777148
--- Diff: proxy/logging/Makefile.am ---
@@ -27,7 +28,7 @@ AM_CPPFLAGS = \
-I$(top_srcdir)/proxy/hdrs \
-I$(top_srcdir)/proxy/share
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36777072
--- Diff: proxy/logging/LogFile.h ---
@@ -177,7 +92,12 @@ class LogFile : public LogBufferSink, public RefCountObj
off_t
get_size_
Github user danobi commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36776891
--- Diff: lib/ts/BaseLogFile.cc ---
@@ -0,0 +1,571 @@
+/** @file
+
+ Base class for log files implementation
+
+ @section license L
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36776865
--- Diff: proxy/logging/LogFile.h ---
@@ -168,8 +85,6 @@ class LogFile : public LogBufferSink, public RefCountObj
static int write_
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36776263
--- Diff: lib/ts/BaseLogFile.cc ---
@@ -0,0 +1,571 @@
+/** @file
+
+ Base class for log files implementation
+
+ @section
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36772493
--- Diff: lib/ts/BaseLogFile.cc ---
@@ -0,0 +1,571 @@
+/** @file
+
+ Base class for log files implementation
+
+ @section
Github user danobi commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36772358
--- Diff: cmd/traffic_cop/traffic_cop.cc ---
@@ -767,6 +767,26 @@ spawn_manager()
exit(1);
}
+ // Move any traffic.out that we
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36772290
--- Diff: lib/ts/BaseLogFile.cc ---
@@ -0,0 +1,571 @@
+/** @file
+
+ Base class for log files implementation
+
+ @section
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36772110
--- Diff: lib/ts/BaseLogFile.cc ---
@@ -0,0 +1,571 @@
+/** @file
+
+ Base class for log files implementation
+
+ @section
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36771917
--- Diff: cmd/traffic_manager/traffic_manager.cc ---
@@ -565,6 +612,25 @@ main(int argc, const char **argv)
lmgmt->proxy_options = tsAr
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36771572
--- Diff: lib/ts/BaseLogFile.cc ---
@@ -0,0 +1,571 @@
+/** @file
+
+ Base class for log files implementation
+
+ @section
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36771629
--- Diff: lib/ts/BaseLogFile.cc ---
@@ -0,0 +1,571 @@
+/** @file
+
+ Base class for log files implementation
+
+ @section
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36771496
--- Diff: lib/ts/BaseLogFile.cc ---
@@ -0,0 +1,571 @@
+/** @file
+
+ Base class for log files implementation
+
+ @section
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36770431
--- Diff: iocore/net/test_certlookup.cc ---
@@ -206,7 +206,8 @@ SSLReleaseContext(SSL_CTX *ctx)
int
main(int argc, const char **argv)
Github user danobi commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36770248
--- Diff: cmd/traffic_crashlog/Makefile.am ---
@@ -20,6 +20,7 @@ bin_PROGRAMS = traffic_crashlog
AM_CPPFLAGS = \
$(iocore_include_dirs) \
Github user danobi commented on the pull request:
https://github.com/apache/trafficserver/pull/274#issuecomment-129969889
There are a few reasons:
- It makes sense from the user perspective, since they can already control
rotation from records.config of the access & error logs
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36769922
--- Diff: iocore/eventsystem/test_Event.cc ---
@@ -91,23 +91,13 @@ reconfigure_diags()
static void
init_diags(const char *bdt, const c
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/274#issuecomment-129955776
Can you explain why we need this, rather than adding better support for
something like log rotate?
---
If your project is set up for it, you can reply to this ema
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36764670
--- Diff: cmd/traffic_crashlog/traffic_crashlog.cc ---
@@ -91,7 +92,8 @@ main(int /* argc ATS_UNUSED */, const char **argv)
crashlog_targ
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36765118
--- Diff: cmd/traffic_crashlog/Makefile.am ---
@@ -20,6 +20,7 @@ bin_PROGRAMS = traffic_crashlog
AM_CPPFLAGS = \
$(iocore_include_di
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36763807
--- Diff: cmd/traffic_cop/traffic_cop.cc ---
@@ -767,6 +767,26 @@ spawn_manager()
exit(1);
}
+ // Move any traffic.ou
> On Aug 9, 2015, at 8:08 PM, Brian Geffon wrote:
>
> All,
> We currently support strict and timed round robin for round robin DNS
> records and I'd like to propose adding consistent hashing based DNS
> selection. We're trying to replace our current ATS -> Haproxy setup with
> only ATS and that'
How is this different from the current (default) client IP hashing? Mainly that
you can select different source data for the hash?
On Monday, August 10, 2015 6:28 AM, Phil Sorber wrote:
On Sun, Aug 9, 2015 at 11:18 PM Brian Geffon wrote:
> It wouldn't really make sense to introdu
43 matches
Mail list logo
