Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36771917
--- Diff: cmd/traffic_manager/traffic_manager.cc ---
@@ -565,6 +612,25 @@ main(int argc, const char **argv)
lmgmt->proxy_options = tsArgs;
mgmt_log(stderr, "[main] Traffic Server Args: '%s'\n",
lmgmt->proxy_options);
}
+
+ // we must pass in bind_stdout and bind_stderr values to TS
+ // we do it so TS is able to create BaseLogFiles for each value
+ if (strcmp(bind_stdout, "") != 0) {
+ lmgmt->proxy_options =
+ (char *)ats_realloc(lmgmt->proxy_options,
strlen(lmgmt->proxy_options) + 1 /* space */
+ + strlen("--bind_stdout
") + strlen(bind_stdout) + 1 /* null term */);
+ strcat(lmgmt->proxy_options, " --bind_stdout ");
+ strcat(lmgmt->proxy_options, bind_stdout);
+ }
+
+ if (strcmp(bind_stderr, "") != 0) {
--- End diff --
Maybe `0 == *bind_stdout` instead of a function call?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
