Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36777072
--- Diff: proxy/logging/LogFile.h ---
@@ -177,7 +92,12 @@ class LogFile : public LogBufferSink, public RefCountObj
off_t
get_size_bytes() const
{
- return m_file_format != LOG_FILE_PIPE ? m_bytes_written : 0;
+ if (m_file_format == LOG_FILE_PIPE)
+ return 0;
+ else if (m_log)
+ return m_log->get_size_bytes();
+ else
+ return 0;
--- End diff --
`return m_file_format == LOG_PIPE_FILE ? 0 : m_log ?
m_log->get_size_bytes() : 0;`
Maybe. That's just my personal style.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
