Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36776865
--- Diff: proxy/logging/LogFile.h ---
@@ -168,8 +85,6 @@ class LogFile : public LogBufferSink, public RefCountObj
static int write_ascii_logbuffer(LogBufferHeader *buffer_header, int fd,
const char *path, const char *alt_format = NULL);
int write_ascii_logbuffer3(LogBufferHeader *buffer_header, const char
*alt_format = NULL);
- static bool rolled_logfile(char *file);
- static bool exists(const char *pathname);
--- End diff --
Is it worth taking these out? For client convenience it you could leave
them in and have them just forward to the `BaseLogFile` methods. Otherwise
you're forcing clients to be aware of the implementation details of `LogFile`
(e.g. that it uses `BaseLogFile`).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
