Github user danobi commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36807553
--- Diff: iocore/net/test_certlookup.cc ---
@@ -206,7 +206,8 @@ SSLReleaseContext(SSL_CTX *ctx)
int
main(int argc, const char **argv)
{
- diags = new Diags(NULL, NULL, stdout);
+ BaseLogFile *blf = new BaseLogFile("stdout");
+ diags = new Diags(NULL, NULL, blf);
--- End diff --
If the third parameter is changed into `const char *`, there will exist
constructor ambiguities when, for example, `NULL` is the third parameter. I'm
probably missing something here, but I think any changes (that I can currently
think of) made to the API to disambiguate the parameters would decrease the
overall understandability of the API.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
