upgrade_tests 7 FAIL when working directory has a "+" character

2013-09-04 Thread James McCoy
The basic_upgrade_1_0 test fails the svn_path_is_canonical(base, pool) assertion in svn_path_join: CMD: svnadmin create svn-test-work/repositories/upgrade_tests-7 --bdb-txn-nosync CMD: svnadmin dump svn-test-work/local_tmp/repos | svnadmin load svn-test-work/repositories/upgrade_tests-7 --ignore-

"svn diff -r N file" in 1.7.14 is broken if svn:mime-type is present

2014-01-04 Thread James McCoy
) The actual values reported vary among runs of "svn diff", sometimes writing garbage characters to the terminal. It appears to only occur with files that have the svn:mime-type property set. This works correctly with 1.7.13 and 1.8.5. Cheers, -- James GPG Key: 4096R/331BA3DB 2011-1

Invalid Makefile.PL generated if --enable-sqlite-compatibility-version specified

2014-01-16 Thread James McCoy
ecurity -pthread'?) syntax error at Makefile.PL line 55, near "'-DSVN_SQLITE_MIN_VERSION_NUMBER=3007012 -DSVN_SQLITE_MIN_VERSION='"3.7.12"" Execution of Makefile.PL aborted due to compilation errors.

Re: "svn diff -r N file" in 1.7.14 is broken if svn:mime-type is present

2014-01-24 Thread James McCoy
On Jan 4, 2014 5:10 PM, "Ben Reser" wrote: > What's really going on here for anyone that cares about the details is the > major rework of diff code we added for issues #4153 and #4421 incorrectly > assumes that the value of the property in the property hash is a C string when > in fact it is a svn

Re: Bugs in 1.8.5 libsvn_subr which make 32-bit threaded svnserve sometimes hang and eat 100% cpu

2014-02-13 Thread James McCoy
ve an obvious way of connecting the reference to "+=" to anything. How about casting size to apr_uint64_t instead? That allows using the previous += since the upcast happens on an operand instead of the result and is a bit more self-documenting. cache->data_used += (apr_uint64_t)size - entry->size; Cheers, -- James GPG Key: 4096R/331BA3DB 2011-12-05 James McCoy signature.asc Description: Digital signature

Ruby 2.0 support

2014-03-31 Thread James McCoy
'puts RbConfig::CONFIG["sitedir"]' /usr/local/lib/site_ruby Cheers, -- James GPG Key: 4096R/331BA3DB 2011-12-05 James McCoy Index: build/ac-macros/swig.m4 === --- build/ac-macros/swig.m4 (revision 1583233)

Re: Ruby 2.0 support

2014-04-01 Thread James McCoy
On Apr 1, 2014 2:57 AM, "Daniel Shahaf" wrote: > > James McCoy wrote on Mon, Mar 31, 2014 at 22:38:49 -0400: > > Index: configure.ac > > === > > --- configure.ac (revision 1583233) >

Re: Issues with bindings tests

2014-05-13 Thread James McCoy
e.in to set DYLD_LIBRARY_PATH in order to pick up the test libraries in preference to the system-wide libraries. This should probably be expanded to also happen when @SVN_APR_SHLIB_PATH_VARS@ is LD_LIBRARY_PATH. I had tried the below patch but ran into some other issues that I didn't have the time/experience to properly diagnose. Cheers, -- James GPG Key: 4096R/331BA3DB 2011-12-05 James McCoy signature.asc Description: Digital signature

Re: Issues with bindings tests

2014-05-14 Thread James McCoy
On Wed, May 14, 2014 at 03:35:50AM +, Daniel Shahaf wrote: > James McCoy wrote on Tue, May 13, 2014 at 22:00:55 -0400: > > I had tried the below patch but ran into some other issues that I didn't > > have the time/experience to properly diagnose. > > There wa

Re: Issues with bindings tests

2014-05-16 Thread James McCoy
On Wed, May 14, 2014 at 07:26:20AM -0400, James McCoy wrote: > On Wed, May 14, 2014 at 03:35:50AM +, Daniel Shahaf wrote: > > James McCoy wrote on Tue, May 13, 2014 at 22:00:55 -0400: > > > I had tried the below patch but ran into some other issues that I didn't > &g

Re: Ruby 2.0 support

2014-05-17 Thread James McCoy
On Tue, Apr 01, 2014 at 06:51:12AM -0400, James McCoy wrote: > > On Apr 1, 2014 2:57 AM, "Daniel Shahaf" wrote: > > > > James McCoy wrote on Mon, Mar 31, 2014 at 22:38:49 -040

Re: 1.9.4 up for signing/testing

2016-04-27 Thread James McCoy
tu's) packaging. I've been meaning to talk to some Ruby folks to answer Philip's questions. Cheers, -- James GPG Key: 4096R/331BA3DB 2011-12-05 James McCoy

Re: [PATCH/RFC] use-sasl=true in --without-sasl builds: make that a fatal error?

2016-04-29 Thread James McCoy
ble to me. Cheers, -- James GPG Key: 4096R/331BA3DB 2011-12-05 James McCoy

Re: svn commit: r1741742 - in /subversion/trunk: contrib/client-side/svn-merge-vendor.py contrib/server-side/fsfsverify.py tools/server-side/svn-backup-dumps.py

2016-04-30 Thread James McCoy
s.stderr.write("Please specify exactly one rev file.\n") For example, this would change to: [[[ from __future__ import print_function print('Please specify exactly one rev file.', file=sys.stderr) ]]] This also maintains the behavior of an automatic newline. Cheers, -- James GPG Key: 4096R/331BA3DB 2011-12-05 James McCoy

Re: svn commit: r1743550 - in /subversion/trunk: build/ contrib/server-side/ tools/client-side/ tools/dev/benchmarks/RepoPerf/ tools/dev/benchmarks/suite1/ tools/dist/

2016-05-12 Thread James McCoy
print_function”. Just because something looks the same visually doesn't mean it's the same syntax. Actually importing the same syntax avoids simple mistakes like this. Cheers, -- James GPG Key: 4096R/331BA3DB 2011-12-05 James McCoy

Re: ABI changes analysis

2016-06-26 Thread James McCoy
On Sun, Jun 26, 2016 at 09:26:27PM +0200, Stefan wrote: > I'm just wondering why the backward compatibility for 1.9.0 (and 1.8.0) > doesn't state 100% here [1]. > > Checking out the details on 1.9.0 [2] and there the details on > libsvn_subr [3] suggests 3 functions were removed: > - svn__apr_hash

Re: [PATCH] Conflict option labels

2016-10-12 Thread James McCoy
On Wed, Oct 12, 2016 at 04:44:10PM +0200, Ivan Zhakov wrote: > On 12 October 2016 at 15:38, Patrick Steinhardt > wrote: > > Hi, > > > > please find attached a patch pulling out the short descriptions > > of conflict resolution options from the client and puts them into > > libsvn_client. > > > > [

Re: [PATCH] Fix modification of nil value in Ruby test suite

2016-10-22 Thread James McCoy
On Tue, Nov 17, 2015 at 08:51:31AM -0500, James McCoy wrote: > On Nov 17, 2015 8:40 AM, "Philip Martin" wrote: > > > > James McCoy writes: > > > > > --- a/subversion/bindings/swig/ruby/libsvn_swig_ruby/swigutil_rb.c > > > +++ b/subversion/

Re: svn commit: r1764447 - in /subversion/trunk/subversion: libsvn_client/conflicts.c tests/libsvn_client/conflicts-test.c

2016-10-23 Thread James McCoy
On Wed, Oct 12, 2016 at 12:34:19PM -, s...@apache.org wrote: > Author: stsp > Date: Wed Oct 12 12:34:18 2016 > New Revision: 1764447 > > URL: http://svn.apache.org/viewvc?rev=1764447&view=rev > Log: > Don't flag an unnecessary tree conflict while resolving 'add vs add'. > > * subversion/libsv

Re: [PATCH] gpg-agent storage - add support for /run based sockets

2017-04-30 Thread James McCoy
On Fri, Apr 28, 2017 at 05:46:21PM +0200, Lukas Jirkovsky wrote: > Add support for sockets in /run used by recent gpg-agent Thanks for the patch! Aside from a few comments on the code, I wonder if it would be better to use "gpgconf --list-dir agent-socket" instead of reimplementing the various bi

Re: [PATCH] gpg-agent storage - add support for /run based sockets V2

2017-05-03 Thread James McCoy
On Wed, May 03, 2017 at 11:03:42PM +0200, Lukas Jirkovsky wrote: > On 3 May 2017 at 22:35, Stefan Sperling wrote: > > On Wed, May 03, 2017 at 10:05:01PM +0200, Lukas Jirkovsky wrote: > >> New version. Instead of reimplementing the gpg-agent logic, "gpgconf > >> --list-dir agent-socket" is used. If

Re: [PATCH] gpg-agent storage - add support for /run based sockets V4

2017-05-05 Thread James McCoy
On Fri, May 05, 2017 at 09:41:03AM +0200, Lukas Jirkovsky wrote: > On 4 May 2017 at 23:54, Lukas Jirkovsky wrote: > > Updated patch. It parses "gpgconf --list-dir" output to find gpg-agent > > socket. > > I just noticed I accidentally generated the patch from inside the > "subversion" subdirecto

Re: [PATCH] gpg-agent storage - add support for /run based sockets V4

2017-05-06 Thread James McCoy
On Fri, May 05, 2017 at 11:29:09PM -0400, James McCoy wrote: > On Fri, May 05, 2017 at 09:41:03AM +0200, Lukas Jirkovsky wrote: > > On 4 May 2017 at 23:54, Lukas Jirkovsky wrote: > > > Updated patch. It parses "gpgconf --list-dir" output to find gpg-agent > > &

Re: svn commit: r1794433 - /subversion/branches/1.9.x/STATUS

2017-05-09 Thread James McCoy
On Tue, May 09, 2017 at 01:00:00PM +0200, Bert Huijben wrote: > > -Original Message- > > From: Stefan Sperling [mailto:s...@elego.de] > > Sent: dinsdag 9 mei 2017 11:26 > > To: Bert Huijben > > Cc: dev@subversion.apache.org > > Subject: Re: svn commit: r1794433 - /subversion/branches/1.9.x

Re: svn commit: r1794433 - /subversion/branches/1.9.x/STATUS

2017-05-10 Thread James McCoy
On Tue, May 09, 2017 at 09:36:18AM -0400, Mark Phippard wrote: > On Tue, May 9, 2017 at 8:02 AM, James McCoy wrote: > > > Subversion is a library and we should be very careful about this. I > think > this code is by default left out on Windows, but there are tons of

Re: svn commit: r1794433 - /subversion/branches/1.9.x/STATUS

2017-05-13 Thread James McCoy
On Wed, May 10, 2017 at 08:34:59AM -0400, James McCoy wrote: > On Tue, May 09, 2017 at 09:36:18AM -0400, Mark Phippard wrote: > > I would expect a feature like this to at least require some kind of opt-in > > mechanism.  In this case, it should require some setting in config t

Re: svn commit: r1803722 - /subversion/branches/1.9.x/STATUS

2017-08-02 Thread James McCoy
On Wed, Aug 02, 2017 at 02:07:20PM +, Daniel Shahaf wrote: > james...@apache.org wrote on Wed, Aug 02, 2017 at 01:35:31 -: > > * r1802032 > > Install 'fsfs-stats' as a wrapper to 'svnfsfs', to which it was renamed > > in > > r1618848. > > Justification: > > Backwards co

Re: errorcode.inc in tarballs

2017-08-10 Thread James McCoy
On Aug 10, 2017 15:29, "Philip Martin" wrote: Branko Čibej writes: > Would be better to generate this header at build time ... but to do that > in a cross-platform manner, we'd have to write a C program to do that. Even that is hard, I know of no easy way for C code to convert an error number

Re: svn commit: r1803143 - in /subversion/trunk/subversion: include/ libsvn_delta/ libsvn_ra_serf/ mod_dav_svn/

2017-09-01 Thread James McCoy
On Fri, Sep 01, 2017 at 03:07:16AM +, Daniel Shahaf wrote: > Evgeny Kotkov wrote on Thu, 31 Aug 2017 19:05 +0300: > > Daniel Shahaf writes: > > > Is adding this function an ABI-compatible change? The docstring of > > > svn_delta_editor_t does say """ > > > > > > * @note Don't try to allocate

Re: svn commit: r1803143 - in /subversion/trunk/subversion: include/ libsvn_delta/ libsvn_ra_serf/ mod_dav_svn/

2017-09-02 Thread James McCoy
On Sat, Sep 02, 2017 at 08:18:00AM +, Daniel Shahaf wrote: > [replying to multiple] > > James McCoy wrote on Fri, Sep 01, 2017 at 08:15:05 -0400: > > On Fri, Sep 01, 2017 at 03:07:16AM +, Daniel Shahaf wrote: > > > I'm not sure I'm getting through he

Re: How to manage PR's (was: [GitHub] subversion pull request #6: VC should be 14.1 and not 15.0)

2017-10-10 Thread James McCoy
On Wed, Oct 11, 2017 at 12:51:34AM +, Daniel Shahaf wrote: > Stefan Sperling wrote on Tue, 10 Oct 2017 23:44 +0200: > > Couldn't some automated process mail PRs from github as (--git) diffs to > > dev@? > > Moreover, if the submitter's commits have a valid email address on them > (and the dom

Re: Python 3 Bindings Query

2017-10-16 Thread James McCoy
On Mon, Oct 16, 2017 at 08:36:51PM +, Daniel Shahaf wrote: > Troy Curtis Jr wrote on Mon, 16 Oct 2017 01:00 +: > > through Fedora's Python 3 porting status list [1] I saw the familiar > > Subversion project showed as not yet supporting Python 3. So I was > > wondering if you are interested

Re: svn commit: r1811786 - /subversion/trunk/subversion/bindings/swig/include/svn_types.swg

2017-10-24 Thread James McCoy
On Mon, Oct 23, 2017 at 12:28:01PM +0200, Bert Huijben wrote: > > -Original Message- > > From: james...@apache.org [mailto:james...@apache.org] > > Sent: woensdag 11 oktober 2017 05:08 > > To: comm...@subversion.apache.org > > Subject: svn commit: r1811786 - > > /subversion/trunk/subversion

Re: Reviewing 1.10 APIs & compatibility

2017-12-05 Thread James McCoy
On Dec 5, 2017 10:27, "Julian Foad" wrote: One task in the 1.10 release process is reviewing API changes. One way, that I use myself, is to take a library at a time and compare the 1.9 and 1.10 public headers, looking for procedural errors (e.g. how new and deprecated APIs are marked up, undocum

Re: library dependency information in status output (here: lz4)

2017-12-19 Thread James McCoy
On Tue, Dec 19, 2017 at 01:53:48PM +0100, Andreas Stieger wrote: > should we continue to add all linked dependencies (here: lz4) to the verbose > version output, as the attached patch would do? I don't see why not. +1 from me. Cheers, -- James GPG Key: 4096R/91BF BF4D 6956 BD5D F7B7 2D23 DFE6

Re: library dependency information in status output (here: lz4)

2017-12-19 Thread James McCoy
On Tue, Dec 19, 2017 at 04:46:18PM +0100, Andreas Stieger wrote: > > checking for lz4 library via pkg-config... yes > > > > and build says: > > > > subversion/libsvn_subr/compress_lz4.c:30:5: warning: "SVN_INTERNAL_LZ4" > > That is actually a side-effect of r1818662. Earlier versions of lz4 > d

Re: library dependency information in status output (here: lz4)

2017-12-19 Thread James McCoy
On Tue, Dec 19, 2017 at 04:46:18PM +0100, Andreas Stieger wrote: > > checking for lz4 library via pkg-config... yes > > > > and build says: > > > > subversion/libsvn_subr/compress_lz4.c:30:5: warning: "SVN_INTERNAL_LZ4" > > That is actually a side-effect of r1818662. Earlier versions of lz4 > d

shelve is (surprisingly) sensitive to working directory

2017-12-29 Thread James McCoy
While messing around with things recently, I decided to try out shelve to save some of my pending changes. This didn't work as well as I expected, since I wasn't in the root of my working copy. Simplified transcript below demonstrates the issue: [[[ jamessan@freya:~/src/apache.org/subversion/tru

Re: shelve is (surprisingly) sensitive to working directory

2018-01-03 Thread James McCoy
On Tue, Jan 02, 2018 at 12:06:47PM +, Julian Foad wrote: > James McCoy wrote: > Fixed in http://svn.apache.org/r1819804 > > Please could you check it. Much better, thanks. > The working directory still needs to be within the WC for all the shelving > commands. That seems

Re: Building Subversion on Debian stretch with serf support

2018-02-28 Thread James McCoy
On Wed, Feb 28, 2018 at 11:15:07AM +, Philip Martin wrote: > Paul Hammant writes: > > > Or is there an option to hand `apt-get` that really lassos in the serf > > binary for the same of making Subversion with client support for http(s) > > checkouts. > > Typically Debian installs libraries t

Re: Potential regression: high server-side memory consumption during import

2018-03-03 Thread James McCoy
On Sat, Mar 03, 2018 at 06:54:06PM +0100, Branko Čibej wrote: > P.S.: Running tests now with the patched 1.10.x, will vote on the > backport as soon as that's done. If it's approved, I believe we have to > move our expected release date from 28th March to 4th April? According to the flowchart post

libsvn_subr/utf-test failure due to unaligned memory access

2018-03-03 Thread James McCoy
This test has been failing for some time on Debian's alpha buildd[0]. One of the alpha porters looked into it and gave a thorough diagnosis[1] of the issue which basically boils down to: using a char* as apr_uint16_t*/apr_int32_t* is going to result in unaligned access. In a (much belated) reply[2

Re: svn commit: r1825787 - /subversion/trunk/subversion/tests/libsvn_subr/utf-test.c

2018-03-03 Thread James McCoy
On Sat, Mar 03, 2018 at 10:21:37PM +0100, Branko Čibej wrote: > On 03.03.2018 22:03, james...@apache.org wrote: > > Author: jamessan > > Date: Sat Mar 3 21:03:09 2018 > > New Revision: 1825787 > > > > URL: http://svn.apache.org/viewvc?rev=1825787&view=rev > > Log: > > * subversion/tests/libsvn_sub

Re: Warnings from the bindings

2018-03-30 Thread James McCoy
On Fri, Mar 30, 2018 at 09:29:47AM +0200, Branko Čibej wrote: > On 30.03.2018 00:27, Philip Martin wrote: > > Philip Martin writes: > > > >> +1 to release > > The swig-pl tests produce warnings for: > > > > Warning: unable to close filehandle $out_fh properly: Bad file descriptor > > at > > /h

Re: Strange libtool errors when try to build pyhton and ruby bindings (1.10.0)

2018-04-16 Thread James McCoy
On Mon, Apr 16, 2018 at 10:42:31AM +0200, Branko Čibej wrote: > [Moved from users@] > > On 16.04.2018 10:36, Branko Čibej wrote: > > The problem is that Swig has become a build-time dependency now. We > > don't configure the Swig bindings unless Swig is installed, even if the > > binding sources a

Re: Strange libtool errors when try to build pyhton and ruby bindings (1.10.0)

2018-04-16 Thread James McCoy
On Mon, Apr 16, 2018 at 03:30:24PM +0200, Branko Čibej wrote: > On 16.04.2018 14:29, James McCoy wrote: > > On Mon, Apr 16, 2018 at 10:42:31AM +0200, Branko Čibej wrote: > >> [Moved from users@] > >> > >> On 16.04.2018 10:36, Branko Čibej wrote: > >>

Re: JDK 10 removal of javah

2018-05-04 Thread James McCoy
On Sat, Dec 23, 2017 at 06:44:13PM +0100, Branko Čibej wrote: > On 23.12.2017 16:30, Andreas Stieger wrote: > > Hello, > > > > I was made aware by our Java package maintainer of the fact that JDK 10 > > is removing the javah tool, after the deprecation from JDK 8. Our javahl > > stuff no longer bui

Re: JDK 10 removal of javah

2018-05-17 Thread James McCoy
On Fri, May 04, 2018 at 08:12:29AM -0400, James McCoy wrote: > On Sat, Dec 23, 2017 at 06:44:13PM +0100, Branko Čibej wrote: > > On 23.12.2017 16:30, Andreas Stieger wrote: > > > Hello, > > > > > > I was made aware by our Java package maintainer of the fact tha

Minimum version of JDK for Subversion 1.10 (was Re: JDK 10 removal of javah)

2018-05-18 Thread James McCoy
On Fri, May 18, 2018 at 09:46:41AM +0200, Stefan Sperling wrote: > Elsewhere in this discussion thread it was suggested to raise the > minimum JDK version requirement to Java 1.8. > Your statement "please keep backward compatibility with older JDKs" > could mean anything between "please leave every

Re: JDK 10 removal of javah

2018-07-09 Thread James McCoy
On Thu, May 17, 2018 at 10:27:18PM -0400, James McCoy wrote: > The biggest wrinkle is that "javac -h" _only_ generates a header file if > there are native annotations, whereas "javah" would always generate a > header file. This found some places where we didn

Re: Feature freeze for 1.11

2018-09-08 Thread James McCoy
e working on or planning any other enhancements, features, or > > anything that needs to be 'frozen'? I could still use some help getting the Java 10 support finalized on Windows, if someone has cycles for that. Cheers, -- James GPG Key: 1024D/61326D40 2003-09-02 James McCoy

Re: svn commit: r1831895 - in /subversion/trunk: build/ac-macros/java.m4 build/generator/gen_win.py configure.ac subversion/bindings/javahl/README

2018-09-26 Thread James McCoy
On Tue, Sep 25, 2018 at 10:04:18AM +0200, Johan Corveleyn wrote: > On Sat, May 19, 2018 at 4:48 PM wrote: > > > > Author: jamessan > > Date: Sat May 19 14:48:35 2018 > > New Revision: 1831895 > > > > URL: http://svn.apache.org/viewvc?rev=1831895&view=rev > > Log: > > Bump minimum JDK version requi

Re: SVN-4530 describes a really nasty bug in our command-line parsing

2018-10-27 Thread James McCoy
On Sat, Oct 27, 2018 at 11:19:10PM +0200, Branko Čibej wrote: > First, read this: https://issues.apache.org/jira/browse/SVN-4530 > > Then watch this (hold my beer): > > $ svnadmin create repo > $ svn co file://$(pwd)/repo wc > Checked out revision 0. > $ svn mkdir wc/foo > A wc/foo > $ to

Re: [PATCH] svn/conflict-callbacks.c indentation fix

2018-11-02 Thread James McCoy
On Fri, Nov 02, 2018 at 11:08:10AM +0100, Stefan Sperling wrote: > On Fri, Nov 02, 2018 at 10:49:23AM +0100, Branko Čibej wrote: > > On 02.11.2018 10:44, Stefan Sperling wrote: > > > I confirm that your patch is correct. I mis-indented these blocks. > > > > Time to start using a real editor, I gue

Re: svn commit: r1849737 - in /subversion/trunk/subversion/bindings/cxx: include/svnxx.hpp include/svnxx/exception.hpp src/aprwrap/pool.hpp src/exception.cpp src/private/exception-private.hpp tests/te

2018-12-26 Thread James McCoy
On Thu, Dec 27, 2018 at 12:18:11AM +0100, Branko Čibej wrote: > On 26.12.2018 23:44, Daniel Shahaf wrote: > > Branko Čibej wrote on Wed, 26 Dec 2018 23:37 +0100: > >> On 26.12.2018 23:21, Daniel Shahaf wrote: > >>> Branko Čibej wrote on Wed, 26 Dec 2018 22:41 +0100: > On 26.12.2018 19:50, Dani

Re: Common header(s) for C and C++ API

2018-12-31 Thread James McCoy
On Mon, Dec 31, 2018 at 12:07:23AM +0100, Branko Čibej wrote: > Summary: I propose to create one or possibly several new public header > files that will be used by both the C and C++ public APIs. > > > I would like to completely hide the dependency on APR from the public > parts of the C++ API. I

Re: [PATCH] Re: SVN-4783 KWallet assumes KDE5 when Qt5 present

2019-01-28 Thread James McCoy
On Mon, Nov 19, 2018 at 02:19:12PM -0600, Satya Mishra wrote: > Hi, > > As requested in the bug report, here’s a patch that doesn’t hard-code the > path to kf5-config, but instead assumes it’s in the path. > > > The test for kwallet assumes KDE5 when Qt5 present, but that is not > > necessarily

Re: The run up to Subversion 1.13.0

2019-08-30 Thread James McCoy
On Fri, Aug 30, 2019 at 05:12:21PM +0100, Julian Foad wrote: > 2. As 1.13 is only weeks away, there is little point in making any further > 1.12.x patch releases from now on, so I will not plan to do so. > > Any other thoughts on anything we ought to include, or to do? Finishing(?) and merging th

Re: 1.13.x and swig-py3

2019-10-22 Thread James McCoy
On Mon, Oct 21, 2019 at 01:35:45PM +0200, Branko Čibej wrote: > On 21.10.2019 13:16, Julian Foad wrote: > > Johan Corveleyn wrote: > >> Nathan Hartman wrote: > >>     Branko Čibej  wrote: > >> > By the principle of least surprise, I think it > >> > would be better to merge to trunk, creat

Re: Supported SWIG version on swig-py3

2019-10-29 Thread James McCoy
On Tue, Oct 29, 2019 at 11:40:35AM +0100, Stefan Sperling wrote: > On Tue, Oct 29, 2019 at 11:37:17AM +0100, Branko Čibej wrote: > > Our .tar.bz2 and .tar.gz packages contain source files generated by > > Swig. A packager /can/ decide to regenerate them; I don't know why they > > would want to, but

Re: svn commit: r1869134 - /subversion/trunk/tools/dist/release.py

2019-10-29 Thread James McCoy
On Tue, Oct 29, 2019 at 11:21:04PM -, danie...@apache.org wrote: > Author: danielsh > Date: Tue Oct 29 23:21:04 2019 > New Revision: 1869134 > > URL: http://svn.apache.org/viewvc?rev=1869134&view=rev > Log: > * tools/dist/release.py > (write_news): Validate the argument to the --news-release

Re: Ruby 2.0 support

2014-05-27 Thread James McCoy
On Tue, May 27, 2014 at 01:51:25PM -0700, Ben Reser wrote: > On 3/31/14, 7:38 PM, James McCoy wrote: > > Ruby 2.0 has a few new RbConfig variables, {ruby,vendor,site}archhdrdir. > > At least rubyarchhdrdir needs to be used to correctly locate > > ruby/config.h, since it is

Re: [Patch] Fix for Issue 3046: document security requirement for hook script arguments

2014-06-19 Thread James McCoy
NL > > +#define HOOKS_QUOTE_ARGUMENTS_TEXT > \ > + "# CAUTION:" > NL \ > + "# For security reasions, you MUST always properly quote arguments when" > NL \ s/reasions/reasons/ Cheers, -- James GPG Key: 4096R/331BA3DB 2011-12-05 James McCoy

[PATCH] Search for libtoolize, not libtool

2014-09-23 Thread James McCoy
89#12 -- James GPG Key: 4096R/331BA3DB 2011-12-05 James McCoy Index: build/buildcheck.sh === --- build/buildcheck.sh (revision 1627191) +++ build/buildcheck.sh (working copy) @@ -97,14 +97,14 @@ esac fi -libtool=${LIBTOOL:-`./

Regression in dirent_walker with malformed DAV responses

2014-11-01 Thread James McCoy
ening pre-1.7 (albeit intentional this time rather than accidental), but at the very least better error reporting would be useful here. [1]: http://article.gmane.org/gmane.comp.version-control.git/258842 [2]: http://article.gmane.org/gmane.comp.version-control.git/258935 Cheers, -- James GPG K

[patch] Fix test failures with certain directory names (was: 1.9.0-beta1 up for testing/signing)

2015-03-07 Thread James McCoy
The attached patch fixes the issue for me. Cheers, -- James GPG Key: 4096R/331BA3DB 2011-12-05 James McCoy Fix test failures when running from a directory whose name contains characters which must be escaped in a URL. svn is more lenient about which characters need escaping, so use of urlli

Re: [patch] Fix test failures with certain directory names (was: 1.9.0-beta1 up for testing/signing)

2015-03-08 Thread 'James McCoy'
On Sun, Mar 08, 2015 at 03:32:35PM +0100, Bert Huijben wrote: > > -Original Message- > > From: James McCoy [mailto:james...@debian.org] > > Sent: zondag 8 maart 2015 05:22 > > To: dev@subversion.apache.org > > Subject: [patch] Fix test failures with certain di

Segfault in Perl bindings when commit touches a large number of files

2015-03-17 Thread James McCoy
tch("svn") called at /usr/lib/git-core/git-svn line 377 eval {...} called at /usr/lib/git-core/git-svn line 375 The 1.9 beta still crashes with a similar valgrind report, modulo line numbers and free'd block size. Cheers, -- James GPG Key: 4096R/331BA3DB 2011-12-05 James McC

Re: Segfault in Perl bindings when commit touches a large number of files

2015-03-20 Thread James McCoy
ving this resolves the crash and reduces the amount of (de)allocations. Cheers, -- James GPG Key: 4096R/331BA3DB 2011-12-05 James McCoy signature.asc Description: Digital signature

[patch] Resolve pod2man warnings

2015-03-21 Thread James McCoy
4096R/331BA3DB 2011-12-05 James McCoy signature.asc Description: Digital signature

Re: [PATCH] On the 'ra-git' branch: update to libgit2 v0.22

2015-03-30 Thread James McCoy
It's specified by POSIX[0]. [0]: http://pubs.opengroup.org/onlinepubs/009695399/utilities/xcu_chap02.html#tag_02_06_03 Cheers, -- James GPG Key: 4096R/331BA3DB 2011-12-05 James McCoy

Re: Segfault in Perl bindings when commit touches a large number of files

2015-05-19 Thread James McCoy
he crash in 1.9.0-rc1 unless I apply the original change I suggested to the generated subversion/bindings/swig/perl/native/svn_delta.c. I'm not sure how that specific part of the file is generated, so I'll just attach a diff of the generated file. Cheers, -- James GPG Key: 4096R/331BA3D

Re: Segfault in Perl bindings when commit touches a large number of files

2015-05-23 Thread James McCoy
On Fri, May 22, 2015 at 07:34:21PM +0200, Roderich Schupp wrote: > So back to your proposal, with the following patch svn-git has benn running > without crash for 15 minutes now. The patch is working for me as well. Cheers, -- James GPG Key: 4096R/331BA3DB 2011-12-05 James McCoy

[patch] Fix libsvn_auth_kwallet crash, use-after-free

2015-09-01 Thread James McCoy
password, but I haven't been able to reproduce that. [0]: https://bugs.launchpad.net/ubuntu/+source/subversion/+bug/563179 Cheers, -- James GPG Key: 4096R/331BA3DB 2011-12-05 James McCoy kwallet_terminate gets called, but then later on get_wallet goes back and looks in parameters for kwallet-w

Re: [patch] Fix libsvn_auth_kwallet crash, use-after-free

2015-09-02 Thread James McCoy
On Wed, Sep 02, 2015 at 11:16:29AM +0200, Bert Huijben wrote: > > -Original Message- > > From: James McCoy [mailto:james...@debian.org] > > Sent: woensdag 2 september 2015 06:00 > > To: dev@subversion.apache.org > > Subject: [patch] Fix libsvn_auth_kwallet cra

Re: Subversion 1.9.1 and SVNParentPath

2015-09-03 Thread James McCoy
.7 client and neon-debug-mask=130, we see[1] that the problem is the response from the CVE-patched httpd/mod_authz_svn doesn't send back the WWW-Authenticate headers, which prevents the client from trying to authenticate when the anonymous command fails. [1]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=797216#25 The last piece of information is that a small tweak to the authz file does allow “svn ls” work, but not “svn commit”: > Another thing I noticed: If I replace "* =" by "* = r" (which in my case > means "any valid user") as the last line in the SVN authz file, "svn ls" > works. I can't commit, though. Hope I was able to get some useful information. Feel free to follow up in the bug report, as Andreas seems to have easy access to testing server configurations and is responsive to requests for information. Cheers, -- James GPG Key: 4096R/331BA3DB 2011-12-05 James McCoy

[PATCH] Translation fixes

2015-10-18 Thread James McCoy
he rest of the po files which needed the same change. The other ("Committing transaction...") is due to the French translation being out of date, but the user provided a translation which I included in the patch. Cheers, -- James GPG Key: 4096R/331BA3DB 2011-12-05 James McCoy Index:

Crash performing diff in 1.9

2015-10-22 Thread James McCoy
0 0 1122 0 --:--:-- --:--:-- --:--:-- 1124 * Connection #0 to host example.ua left intact - Revision 113: / - Revision 113: / pom.xml src/ Powered by http://subversion.apache.org/";>Apache Subversion version 1.8.10 (r1615264). Cheers, -- James GPG Key: 4096R/331BA3DB 2011-12-05 James McCoy

Re: svn commit: r1690591 - /subversion/trunk/subversion/bindings/swig/include/proxy.swg

2015-10-31 Thread James McCoy
wig, but that's being considered for removal from Debian before the next stable release. Cheers, -- James GPG Key: 4096R/331BA3DB 2011-12-05 James McCoy

[PATCH] Convert Ruby tests from test-unit to minitest

2015-11-04 Thread James McCoy
Ruby 2.2 changed test/unit from an in-tree wrapper around minitest 4 to a bundled version of the externally maintained ruby-test-unit gem. Similarly, the in-tree minitest was removed and the externally maintained ruby-minitest gem (of the 5.x series) is bundled. These changes broke check-swig-rb,

Re: [PATCH] Convert Ruby tests from test-unit to minitest

2015-11-05 Thread James McCoy
On Thu, Nov 05, 2015 at 11:27:23AM +, Philip Martin wrote: > James McCoy writes: > > > Ruby 2.2 changed test/unit from an in-tree wrapper around minitest > > 4 to a bundled version of the externally maintained ruby-test-unit gem. > > Similarly, the in-tree mini

Re: [PATCH] Convert Ruby tests from test-unit to minitest

2015-11-06 Thread James McCoy
On Nov 5, 2015 6:27 AM, "Philip Martin" wrote: > > James McCoy writes: > > > Ruby 2.2 changed test/unit from an in-tree wrapper around minitest > > 4 to a bundled version of the externally maintained ruby-test-unit gem. > > Similarly, the in-tree mi

Re: [PATCH] Convert Ruby tests from test-unit to minitest

2015-11-07 Thread James McCoy
On Fri, Nov 06, 2015 at 10:56:49AM -0500, James McCoy wrote: > On Nov 5, 2015 6:27 AM, "Philip Martin" wrote: > > > > James McCoy writes: > > > > > Ruby 2.2 changed test/unit from an in-tree wrapper around minitest > > > 4 to a bundled versio

[PATCH] Fix modification of nil value in Ruby test suite

2015-11-08 Thread James McCoy
d. * subversion/bindings/swig/ruby/libsvn_swig_ruby/swigutil_rb.c: (svn_swig_rb_make_stream): Create a new Object if the given io is nil. Also call svn_swig_rb_get_pool in order to deduplicate some pool-handling code. ]]] Cheers, -- James GPG Key: 4096R/331BA3DB 2011-

Re: [PATCH] Convert Ruby tests from test-unit to minitest

2015-11-08 Thread James McCoy
On Sat, Nov 07, 2015 at 10:09:37PM -0500, James McCoy wrote: > The attached patch, however, at least gets the test suite working with > the test-unit gem, which is a pre-requisite for testing against Ruby > 2.2. Updated to fix a typo in Makefile.in. Cheers, -- James GPG Key: 4096R/331B

Re: [PATCH] Fix modification of nil value in Ruby test suite

2015-11-16 Thread James McCoy
On Sun, Nov 08, 2015 at 11:26:07PM -0500, James McCoy wrote: > The attached patch makes the Ruby 2.2 test suite failure I mentioned in > [0] go away, but this is all code I'm pretty unfamiliar with. > > https://mail-archives.apache.org/mod_mbox/subversion-dev/201511.mbox/ajax/

Re: [PATCH] Convert Ruby tests from test-unit to minitest

2015-11-16 Thread James McCoy
On Mon, Nov 09, 2015 at 12:15:51AM -0500, James McCoy wrote: > On Sat, Nov 07, 2015 at 10:09:37PM -0500, James McCoy wrote: > > The attached patch, however, at least gets the test suite working with > > the test-unit gem, which is a pre-requisite for testing against Ruby > >

Re: [PATCH] Convert Ruby tests from test-unit to minitest

2015-11-17 Thread James McCoy
On Nov 17, 2015 8:07 AM, "Philip Martin" wrote: > > Philip Martin writes: > > > James McCoy writes: > > > >> On Mon, Nov 09, 2015 at 12:15:51AM -0500, James McCoy wrote: > >>> On Sat, Nov 07, 2015 at 10:09:37PM -0500, James McCoy wrote: &g

Re: [PATCH] Fix modification of nil value in Ruby test suite

2015-11-17 Thread James McCoy
On Nov 17, 2015 8:40 AM, "Philip Martin" wrote: > > James McCoy writes: > > > --- a/subversion/bindings/swig/ruby/libsvn_swig_ruby/swigutil_rb.c > > +++ b/subversion/bindings/swig/ruby/libsvn_swig_ruby/swigutil_rb.c > > @@ -3230,14 +3230,16 @@ svn_swig_rb_ma

Re: Running SVN 1.9.x on ASF servers?

2015-11-28 Thread James McCoy
tu/subversion Cheers, -- James GPG Key: 4096R/331BA3DB 2011-12-05 James McCoy signature.asc Description: PGP signature

Swig 3.x support (was Re: svn commit: r1690591 - /subversion/trunk/subversion/bindings/swig/include/proxy.swg)

2015-12-21 Thread James McCoy
On Sun, Nov 01, 2015 at 01:17:56AM -0500, James McCoy wrote: > On Mon, Jul 13, 2015 at 11:00:17AM +0100, Joe Orton wrote: > > On Mon, Jul 13, 2015 at 11:41:23AM +0200, Branko Čibej wrote: > > > https://ci.apache.org/builders/svn-x64-ubuntu-gcc/builds/317 > > > > &g

Re: Swig 3.x support (was Re: svn commit: r1690591 - /subversion/trunk/subversion/bindings/swig/include/proxy.swg)

2015-12-22 Thread James McCoy
On Tue, Dec 22, 2015 at 02:45:03PM +0100, Branko Čibej wrote: > On 22.12.2015 04:26, James McCoy wrote: > > On Sun, Nov 01, 2015 at 01:17:56AM -0500, James McCoy wrote: > >> On Mon, Jul 13, 2015 at 11:00:17AM +0100, Joe Orton wrote: > >>> On Mon, Jul 13, 2015 at

Re: svn commit: r1723003 - /subversion/branches/1.9.x/STATUS

2016-01-05 Thread James McCoy
another addition and/or a backport branch. Yeah, I noticed the backport-conflicts failure. danielsh made some changes in trunk to fail if --with-swig is given but swig isn't found, which haven't been backported. I'll revisit that tonight. Cheers, -- James GPG Key: 4096R/331BA3DB 2011-12-05 James McCoy

Re: svn commit: r1727824 - /subversion/trunk/subversion/libsvn_fs/fs-loader.c

2016-01-31 Thread James McCoy
one either when Enumate -> Emulate Cheers, -- James GPG Key: 4096R/331BA3DB 2011-12-05 James McCoy

Re: SVN::Client::log() first argument Re: svn commit: r1729519 - /subversion/trunk/tools/client-side/svn-graph.pl

2016-02-14 Thread James McCoy
be a single $target (as defined above) or a reference to an array of them. Cheers, -- James GPG Key: 4096R/331BA3DB 2011-12-05 James McCoy

Re: SVN::Client::log() first argument Re: svn commit: r1729519 - /subversion/trunk/tools/client-side/svn-graph.pl

2016-02-15 Thread James McCoy
On Mon, Feb 15, 2016 at 11:54:39AM +0100, Bert Huijben wrote: > > -Original Message- > > From: James McCoy [mailto:vega.ja...@gmail.com] On Behalf Of James > > McCoy > > Sent: zondag 14 februari 2016 19:20 > > To: Daniel Shahaf > > Cc: dev@subver

Re: svn commit: r1731656 - /subversion/trunk/subversion/svnserve/serve.c

2016-02-22 Thread James McCoy
On Feb 22, 2016 10:10 AM, wrote: > > Author: stefan2 > Date: Mon Feb 22 15:06:40 2016 > New Revision: 1731656 > > URL: http://svn.apache.org/viewvc?rev=1731656&view=rev > Log: > Switch svnserve to using the streamy log API. > --- subversion/trunk/subversion/svnserve/serve.c (original) > +++ subve

Re: [PATCH] Trivial relnotes typo fix

2016-03-13 Thread James McCoy
On Mon, Mar 14, 2016 at 01:08:28AM +, Daniel Shahaf wrote: > Is someone able to commit this for me, please? Done in r1734874. Cheers, -- James GPG Key: 4096R/331BA3DB 2011-12-05 James McCoy

Escape filename for conflict merge

2019-12-10 Thread James McCoy
When a text conflict occurs during a merge, the user is given the option to resolve the conflict and we spawn their editor for them. In svn_cmdline__edit_file_externally, we explicitly use the shell to invoke the editor, so that $SVN_EDITOR can be a command with arguments rather than just a binary

Re: Escape filename for conflict merge

2019-12-26 Thread James McCoy
On Wed, Dec 11, 2019 at 03:12:56PM +, Julian Foad wrote: > Stefan Sperling wrote: > > My first question would be: Could anyone could test this on Windows? > > (Assuming you've been testing on Debian, as usual.) Yes, any testing from folks with Windows systems would be welcome. This recipe is

  1   2   >