Hi,

build/buildcheck.sh performs a search for a variant of libtool in order
to verify an acceptable version is available.  However, the similar
code in autogen.sh looks for and uses a variant of libtoolize.

Since libtoolize is the tool actually performing useful work between the
two, and buildcheck.sh fails the build if libtool isn't found, updating
buildcheck.sh to look for libtoolize seems appropriate.  This specific
build failure does occur[0] when trying to cross-build subversion with
Ubuntu's (and soon Debian's) Multi-Archified libtool packages[1].

The attached patch, proposed by Helmut Grohne[2], makes said change to
buildcheck.sh.

[0]: 
https://people.debian.org/~doko/logs/20140912/failed-libtool/subversion_1.8.10-1_unstable_jdk-libtool.log
[1]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=682045
[2]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=761789#12
-- 
James
GPG Key: 4096R/331BA3DB 2011-12-05 James McCoy <james...@debian.org>
Index: build/buildcheck.sh
===================================================================
--- build/buildcheck.sh	(revision 1627191)
+++ build/buildcheck.sh	(working copy)
@@ -97,14 +97,14 @@
   esac
 fi
 
-libtool=${LIBTOOL:-`./build/PrintPath glibtool libtool libtool15`}
+libtoolize=${LIBTOOLIZE:-`./build/PrintPath glibtoolize libtoolize libtoolize15`}
 # Extract the libtool version number: everything from the first number in
 # the version text until a hyphen or space.
-lt_pversion=`$libtool --version 2>/dev/null |
+lt_pversion=`$libtoolize --version 2>/dev/null |
   sed -e 's/^[^0-9]*//' -e 's/[- ].*//' -e '/^$/d' |
   sed -e 1q`
 if test -z "$lt_pversion"; then
-  echo "buildcheck: libtool not found."
+  echo "buildcheck: libtoolize not found."
   echo "            You need libtool version $LIBTOOL_WANTED_VERSION or newer installed"
   exit 1
 fi

Reply via email to