[patch] Fix libsvn_auth_kwallet crash, use-after-free

[James McCoy]

In Launchpad[0], it was reported that svn will crash when using the
Kwallet integration to store the password during a checkout.  Jens
Jorgensen provided the attached patch, which resolves the issue for me.

At the time, Jens mentioned that subsequent svn commands would still
prompt for the password, but I haven't been able to reproduce that.

[0]: https://bugs.launchpad.net/ubuntu/+source/subversion/+bug/563179

Cheers,
-- 
James
GPG Key: 4096R/331BA3DB 2011-12-05 James McCoy <james...@debian.org>

kwallet_terminate gets called, but then later on get_wallet goes back and looks
in parameters for kwallet-wallet, finds it, and proceeds to try to use the now-deleted
object. tsk-tsk

--- a/subversion/libsvn_auth_kwallet/kwallet.cpp	2010-08-12 12:38:09.397673392 +0800
+++ b/subversion/libsvn_auth_kwallet/kwallet.cpp	2010-08-12 14:47:38.937672867 +0800
@@ -176,6 +176,10 @@
       KWallet::Wallet *wallet = get_wallet(NULL, parameters);
       delete wallet;
       apr_hash_set(parameters,
+                   "kwallet-wallet",
+                   APR_HASH_KEY_STRING,
+                   NULL);
+      apr_hash_set(parameters,
                    "kwallet-initialized",
                    APR_HASH_KEY_STRING,
                    NULL);

signature.asc
Description: Digital signature