Re: two questions (and a proposed patch) regarding svn:ignore

2010-03-02 Thread C. Michael Pilato
Peter Samuelson wrote: > [C. Michael Pilato] >> Peter Samuelson wrote: >>> (Come to think of it, I bet a way to specify "all new directories" in >>> auto-props would be welcome too.) >> How about "any pattern ending a slash character" meaning "applies to >> directories"? > > Sure. Unix shell glob

Re: two questions (and a proposed patch) regarding svn:ignore

2010-02-26 Thread Peter Samuelson
[C. Michael Pilato] > Peter Samuelson wrote: > > (Come to think of it, I bet a way to specify "all new directories" in > > auto-props would be welcome too.) > > How about "any pattern ending a slash character" meaning "applies to > directories"? Sure. Unix shell globs behave exactly like this (

Re: two questions (and a proposed patch) regarding svn:ignore

2010-02-26 Thread C. Michael Pilato
Peter Samuelson wrote: > (Come to think of it, I bet a way to specify "all new directories" in > auto-props would be welcome too.) How about "any pattern ending a slash character" meaning "applies to directories"? -- C. Michael Pilato CollabNet <> www.collab.net <> Distributed Developme

Re: two questions (and a proposed patch) regarding svn:ignore

2010-02-25 Thread Peter Samuelson
Sorry to revive a thread from 3 weeks ago, but I had a thought. These things do not happen to me every day, you know! [Stefan Sperling] > When adding a recursive directory tree, we only heed the global ignores > list. Recall that the svn:ignore property is not inherited. > Subversion is adding th

Re: two questions (and a proposed patch) regarding svn:ignore

2010-02-03 Thread Julian Foad
Stefan Sperling wrote: > On Wed, Feb 03, 2010 at 12:52:25AM +, Julian Foad wrote: > > I think the rule is (not just for 'svn add', but for all svn commands > > that do this kind of ignoring): > > > > a file is ignored iff > > (it matches the svn:ignore property or the global-ignores sett

RE: two questions (and a proposed patch) regarding svn:ignore

2010-02-03 Thread Bert Huijben
> -Original Message- > From: Julian Foad [mailto:julian.f...@wandisco.com] > Sent: woensdag 3 februari 2010 12:30 > To: Bert Huijben > Cc: 'Stefan Sperling'; 'Bert Huijben'; 'Subversion Development' > Subject: RE: two questions (and

RE: two questions (and a proposed patch) regarding svn:ignore

2010-02-03 Thread Julian Foad
Bert Huijben wrote: > > -Original Message- > > From: Julian Foad [mailto:julianf...@btopenworld.com] > > While we're revving it, consider this API design point. We pass the list > > of global ignores in to the function through the CTX parameter. It seems > > stupid to have an additional par

RE: two questions (and a proposed patch) regarding svn:ignore

2010-02-03 Thread Bert Huijben
> -Original Message- > From: Julian Foad [mailto:julianf...@btopenworld.com] > Sent: woensdag 3 februari 2010 1:11 > To: 'Stefan Sperling' > Cc: Bert Huijben; 'Subversion Development' > Subject: Re: two questions (and a proposed patch) regard

Re: two questions (and a proposed patch) regarding svn:ignore

2010-02-03 Thread 'Stefan Sperling'
On Wed, Feb 03, 2010 at 12:11:09AM +, Julian Foad wrote: > On Tue, 2010-02-02, 'Stefan Sperling' wrote: > > On Tue, Feb 02, 2010 at 09:12:42PM +0100, Bert Huijben wrote: > > > In this libsvn_client_addX() case it would be adding an extra boolean to > > > pass to the new svn_client_addX() functi

Re: two questions (and a proposed patch) regarding svn:ignore

2010-02-03 Thread Stefan Sperling
On Wed, Feb 03, 2010 at 12:52:25AM +, Julian Foad wrote: > > > > > > Right now, the no_ignore parameter only disables global ignores, > > > and svn:ignore ignores are always ignored. > > > > No, that's not right. I just tried it with a trunk build. I set > > 'svn:ignore' to ignore the file na

Re: two questions (and a proposed patch) regarding svn:ignore

2010-02-02 Thread Julian Foad
I (Julian Foad) wrote: > On Tue, 2010-02-02 at 19:20 +0100, Stefan Sperling wrote: > > On Tue, Feb 02, 2010 at 06:46:46PM +0100, Bert Huijben wrote: > > > I like this change for my uses of 'svn' as '*' is handled by the > > > shell, but I don't think the new functionality is logical at the > > > sv

Re: two questions (and a proposed patch) regarding svn:ignore

2010-02-02 Thread Julian Foad
On Tue, 2010-02-02 at 19:20 +0100, Stefan Sperling wrote: > On Tue, Feb 02, 2010 at 06:46:46PM +0100, Bert Huijben wrote: > > I like this change for my uses of 'svn' as '*' is handled by the > > shell, but I don't think the new functionality is logical at the > > svn_client_add() layer. In most gui

Re: two questions (and a proposed patch) regarding svn:ignore

2010-02-02 Thread Julian Foad
On Tue, 2010-02-02, 'Stefan Sperling' wrote: > On Tue, Feb 02, 2010 at 09:12:42PM +0100, Bert Huijben wrote: > > In this libsvn_client_addX() case it would be adding an extra boolean to > > pass to the new svn_client_addX() function... And passing the right value > > from the wrapper in deprecated.

RE: two questions (and a proposed patch) regarding svn:ignore

2010-02-02 Thread Bert Huijben
> -Original Message- > From: 'Stefan Sperling' [mailto:s...@elego.de] > Sent: dinsdag 2 februari 2010 21:21 > To: Bert Huijben > Cc: 'Subversion Development' > Subject: Re: two questions (and a proposed patch) regarding svn:ignore > > On

Re: two questions (and a proposed patch) regarding svn:ignore

2010-02-02 Thread 'Stefan Sperling'
On Tue, Feb 02, 2010 at 09:12:42PM +0100, Bert Huijben wrote: > Yes.. > > It can also skip libsvn_client and use libsvn_wc or (for what it's worth) > edit the entries file directly, but that is not the point here.. Heh. > We have a > versioning policy on our api and hundreds of existing libsvn_

RE: two questions (and a proposed patch) regarding svn:ignore

2010-02-02 Thread Bert Huijben
> -Original Message- > From: Stefan Sperling [mailto:s...@elego.de] > Sent: dinsdag 2 februari 2010 19:21 > To: Bert Huijben > Cc: 'C. Michael Pilato'; dev@subversion.apache.org > Subject: Re: two questions (and a proposed patch) regarding svn:ignore >

Re: two questions (and a proposed patch) regarding svn:ignore

2010-02-02 Thread Stefan Sperling
On Tue, Feb 02, 2010 at 06:46:46PM +0100, Bert Huijben wrote: > I like this change for my uses of 'svn' as '*' is handled by the > shell, but I don't think the new functionality is logical at the > svn_client_add() layer. In most gui clients I use, I see some svn > status output containing the not

Re: two questions (and a proposed patch) regarding svn:ignore

2010-02-02 Thread 'Stefan Sperling'
On Tue, Feb 02, 2010 at 06:52:46PM +0100, Bert Huijben wrote: > -1 on applying this change without revving the apis and making the > compatibility wrappers 100% compatible with the original behavior. > (Maybe the change can be in an 1.7 version of the api if the api was already > converted). > T

RE: two questions (and a proposed patch) regarding svn:ignore

2010-02-02 Thread Bert Huijben
> -Original Message- > From: Stefan Sperling [mailto:s...@elego.de] > Sent: dinsdag 2 februari 2010 17:16 > To: dev@subversion.apache.org > Subject: two questions (and a proposed patch) regarding svn:ignore > > Hi, > > the book says: > > Subversion uses the ignore patterns —- both th

RE: two questions (and a proposed patch) regarding svn:ignore

2010-02-02 Thread Bert Huijben
> -Original Message- > From: C. Michael Pilato [mailto:cmpil...@collab.net] > Sent: dinsdag 2 februari 2010 17:37 > To: Stefan Sperling > Cc: dev@subversion.apache.org > Subject: Re: two questions (and a proposed patch) regarding svn:ignore > > Stefan Sperling wr

Re: two questions (and a proposed patch) regarding svn:ignore

2010-02-02 Thread Stefan Sperling
On Tue, Feb 02, 2010 at 11:36:44AM -0500, C. Michael Pilato wrote: > So maybe we could benefit from a pair of changes here: the one you > included, but also some notification for 'svn add' (and 'svn import') that > reports either explicitly-named or reached-through-recursion ignored items. > >

Re: two questions (and a proposed patch) regarding svn:ignore

2010-02-02 Thread C. Michael Pilato
Stefan Sperling wrote: > Hi, > > the book says: > > Subversion uses the ignore patterns —- both the global > and the per-directory lists -- > ^^^ > to determine which files should not be swept into the version > control system as part of a larger recursive additi