On Tue, Feb 02, 2010 at 06:52:46PM +0100, Bert Huijben wrote: > -1 on applying this change without revving the apis and making the > compatibility wrappers 100% compatible with the original behavior. > (Maybe the change can be in an 1.7 version of the api if the api was already > converted). >
The original behaviour isn't documented. We can keep it for backward compat if you like, but we've fixed API promises which aren't being help before without revving the function. > This patch by itself will break many third party subversion clients > and because the only way to see the change is the notification... it > will most likely not be caught by many unit tests. Right now, I'm trying to verify the rationale for the patch, not whether the tests pass with it. Before committing it I will run and adjust tests of course. > Changes of 'svn' specific client behavior should be coded in 'svn'... > not in libsvn_client. (or the apis must be revved following our > versioning guarantees) This is not specific to the 'svn' client. The docco for svn_client_add4() says: * If @a no_ignore is FALSE, don't add files or directories that match * ignore patterns. That promise isn't being held. Stefan
