Bert Huijben wrote: > > -----Original Message----- > > From: Julian Foad [mailto:julianf...@btopenworld.com] > > While we're revving it, consider this API design point. We pass the list > > of global ignores in to the function through the CTX parameter. It seems > > stupid to have an additional parameter that says whether to ignore the > > global ignores. Instead, the caller should set > > CTX->config['config:miscellany:global-ignores'] to empty before calling > > this function. > > > > Makes sense? > > >From 'svn' it makes sense to move the setting to the configuration as > 'svn' use a new 'svn_client_ctx_t' for every command. > > But, in several other clients the svn_client_ctx_t is a long living > object. (This is becoming more useful in WC-NG as it will keep the > handle to the wc.db instance open for you over multiple commands). > > This would require setting the setting before executing the command > and then resetting it later in the compatibility wrapper (and in other > libraries that don't want to change their api incompatible).
Yes, it would. I nearly wrote that out in my original email. Do you think that's so awkward that the API should continue to have a special flag for overriding that part of the config? - Julian
