On Wed, Feb 03, 2010 at 12:11:09AM +0000, Julian Foad wrote: > On Tue, 2010-02-02, 'Stefan Sperling' wrote: > > On Tue, Feb 02, 2010 at 09:12:42PM +0100, Bert Huijben wrote: > > > In this libsvn_client_addX() case it would be adding an extra boolean to > > > pass to the new svn_client_addX() function... And passing the right value > > > from the wrapper in deprecated.c. > > > > Right, no problem. So we add svn_client_add5, with boolean > > 'no_global_ignores' and 'no_svn_ignores' (better name anyone?). > > While we're revving it, consider this API design point. We pass the list > of global ignores in to the function through the CTX parameter. It seems > stupid to have an additional parameter that says whether to ignore the > global ignores. Instead, the caller should set > CTX->config['config:miscellany:global-ignores'] to empty before calling > this function. > > Makes sense?
Yes, it does, thanks for the suggestion. Stefan
